From 0eed87adc370af01d4061617360262ed1998294d Mon Sep 17 00:00:00 2001 From: Jesse Rosenthal Date: Thu, 30 Oct 2014 09:21:52 +2000 Subject: [PATCH] Re: [PATCH] Avoid empty thread names if possible. --- 44/2fce7452287f93c340ae6c18d82f5ba0af0233 | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 44/2fce7452287f93c340ae6c18d82f5ba0af0233 diff --git a/44/2fce7452287f93c340ae6c18d82f5ba0af0233 b/44/2fce7452287f93c340ae6c18d82f5ba0af0233 new file mode 100644 index 000000000..2bec92ad8 --- /dev/null +++ b/44/2fce7452287f93c340ae6c18d82f5ba0af0233 @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0E537431FC2 + for ; Wed, 29 Oct 2014 06:25:47 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id cF-EKlx50CqQ for ; + Wed, 29 Oct 2014 06:25:41 -0700 (PDT) +X-Greylist: delayed 1093 seconds by postgrey-1.32 at olra; + Wed, 29 Oct 2014 06:25:41 PDT +Received: from IPMTW1.johnshopkins.edu (ipmtw1.johnshopkins.edu + [128.220.229.140]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 571A1431FB6 + for ; Wed, 29 Oct 2014 06:25:40 -0700 (PDT) +X-IronPort-AV: E=Sophos;i="5.04,810,1406606400"; d="scan'208";a="15431611" +Received: from guppy.hwcampus.jhu.edu (HELO localhost) ([10.161.32.234]) + by IPMTW1.johnshopkins.edu with ESMTP/TLS/AES128-SHA; + 29 Oct 2014 09:21:53 -0400 +From: Jesse Rosenthal +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] Avoid empty thread names if possible. +In-Reply-To: +References: <87oatnakqy.fsf@jhu.edu> +User-Agent: Notmuch/0.18.2+155~gafa8535 (http://notmuchmail.org) Emacs/24.4.1 + (i686-pc-linux-gnu) +Date: Wed, 29 Oct 2014 09:21:52 -0400 +Message-ID: <87wq7j9fkf.fsf@jhu.edu> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 29 Oct 2014 13:25:49 -0000 + +Thanks for taking a look. + +Tomi Ollila writes: + +> IMO it is a bit silly to scan through the whole string and use the return +> value of 0 (vs != 0) to have effect. we should probably have something like +> #define EMPTY_STRING(s) ((s)[0] == '\0') +> and use that instead. + +Good point. Will put in the next version. + +> Also, to keep promise, mentioning 'patch' in commit message referring to +> the change introduced does IMO also look silly :D + +Ah. Yep, agreed. + -- 2.26.2