From 0dafb3a6bb936e40f26dbcc4f963fbb7b43c71c9 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 27 Mar 2012 09:45:47 +0300 Subject: [PATCH] Re: [PATCH 0/2] Escape message ID queries in Emacs --- 43/481591a6be819fe6deac2921eb86790ccb7ebb | 87 +++++++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 43/481591a6be819fe6deac2921eb86790ccb7ebb diff --git a/43/481591a6be819fe6deac2921eb86790ccb7ebb b/43/481591a6be819fe6deac2921eb86790ccb7ebb new file mode 100644 index 000000000..41db04621 --- /dev/null +++ b/43/481591a6be819fe6deac2921eb86790ccb7ebb @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 15EA7431FAF + for ; Mon, 26 Mar 2012 23:45:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id atTaoekv4Ewg for ; + Mon, 26 Mar 2012 23:45:49 -0700 (PDT) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 10EE8431FAE + for ; Mon, 26 Mar 2012 23:45:49 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 9DBF368055; Tue, 27 Mar 2012 09:45:47 +0300 (EEST) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/2] Escape message ID queries in Emacs +In-Reply-To: <1332812236-20387-1-git-send-email-amdragon@mit.edu> +References: <1332812236-20387-1-git-send-email-amdragon@mit.edu>User-Agent: + Notmuch/0.12+70~gce7ecf1 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 27 Mar 2012 06:45:50 -0000 + +On Tue, Mar 27 2012, Austin Clements wrote: + +> Currently, Emacs does not escape message ID queries and is +> inconsistent about quoting them. This patch centralizes this in one +> function that always produces a properly quoted and escaped message ID +> query. +> +> With this, Emacs no longer gets confused by Tomi's crazy message, +> id:"id:""1332281811-24710-2b-git-send-email-tomi.ollila@iki.fi""" + +LGTM. Things work! + + +One observation, though: + +In search bar the following queries return one match: + +id:id:"1332281811-24710-2b-git-send-email-tomi.ollila@iki.fi" +id:"id:""1332281811-24710-2b-git-send-email-tomi.ollila@iki.fi""" + +but + +id:"id:"1332281811-24710-2b-git-send-email-tomi.ollila@iki.fi"" + +return 0 matches. + +It looks like the (above) search strings goes verbatim to command line + +i.e. 'notmuch' 'search' '--sort=oldest-first' 'id:...' + +can be used to compare... so that would be CLI issue if there +is ever need to do do anything with it. + ++1 + +Thanks for fixing this. + +Tomi -- 2.26.2