From 0cf9577f22cea689948f11fe6df351563e6ae587 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 30 Mar 2014 11:30:21 +0300 Subject: [PATCH] Re: [Patch v2 2/3] util: add gzreadline --- 62/b87edd7c8b76377e5d9ab2eb554c46b560e951 | 194 ++++++++++++++++++++++ 1 file changed, 194 insertions(+) create mode 100644 62/b87edd7c8b76377e5d9ab2eb554c46b560e951 diff --git a/62/b87edd7c8b76377e5d9ab2eb554c46b560e951 b/62/b87edd7c8b76377e5d9ab2eb554c46b560e951 new file mode 100644 index 000000000..28f69e9b2 --- /dev/null +++ b/62/b87edd7c8b76377e5d9ab2eb554c46b560e951 @@ -0,0 +1,194 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2D3A2431FBD + for ; Sun, 30 Mar 2014 01:30:39 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Xepl+Ct6WO+A for ; + Sun, 30 Mar 2014 01:30:28 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id C3C0E431FBC + for ; Sun, 30 Mar 2014 01:30:27 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id CDC0E10005E; + Sun, 30 Mar 2014 11:30:21 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [Patch v2 2/3] util: add gzreadline +In-Reply-To: <1396116992-29640-3-git-send-email-david@tethera.net> +References: <1396100785-8744-1-git-send-email-david@tethera.net> + <1396116992-29640-1-git-send-email-david@tethera.net> + <1396116992-29640-3-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.17+171~g9a127b7 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 30 Mar 2014 08:30:39 -0000 + +On Sat, Mar 29 2014, David Bremner wrote: + +> The idea is to provide a more or less drop in replacement for readline +> to read from zlib/gzip streams. Take the opportunity to replace +> malloc with talloc. +> --- + +This series looks pretty good to me. I thought I found a place for real +improvement but I was wrong. Therefore I look in this for more detail ;D + +> util/Makefile.local | 2 +- +> util/zlib-extra.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++ +> util/zlib-extra.h | 10 +++++++++ +> 3 files changed, 70 insertions(+), 1 deletion(-) +> create mode 100644 util/zlib-extra.c +> create mode 100644 util/zlib-extra.h +> +> diff --git a/util/Makefile.local b/util/Makefile.local +> index 29c0ce6..e2a5b65 100644 +> --- a/util/Makefile.local +> +++ b/util/Makefile.local +> @@ -4,7 +4,7 @@ dir := util +> extra_cflags += -I$(srcdir)/$(dir) +> +> libutil_c_srcs := $(dir)/xutil.c $(dir)/error_util.c $(dir)/hex-escape.c \ +> - $(dir)/string-util.c $(dir)/talloc-extra.c +> + $(dir)/string-util.c $(dir)/talloc-extra.c $(dir)/zlib-extra.c +> +> libutil_modules := $(libutil_c_srcs:.c=.o) +> +> diff --git a/util/zlib-extra.c b/util/zlib-extra.c +> new file mode 100644 +> index 0000000..cda369f +> --- /dev/null +> +++ b/util/zlib-extra.c +> @@ -0,0 +1,59 @@ +> +/* zlib-extra.c - Extra or enhanced routines for compressed I/O. +> + * +> + * Copyright (c) 2014 David Bremner +> + * +> + * This program is free software: you can redistribute it and/or modify +> + * it under the terms of the GNU General Public License as published by +> + * the Free Software Foundation, either version 3 of the License, or +> + * (at your option) any later version. +> + * +> + * This program is distributed in the hope that it will be useful, +> + * but WITHOUT ANY WARRANTY; without even the implied warranty of +> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +> + * GNU General Public License for more details. +> + * +> + * You should have received a copy of the GNU General Public License +> + * along with this program. If not, see http://www.gnu.org/licenses/ . +> + * +> + * Author: David Bremner +> + */ +> + +> +#include "zlib-extra.h" +> +#include +> +#include +> +#include +> + +> +/* mimic POSIX/glibc getline, but on a zlib gzFile stream, and using talloc */ +> +ssize_t +> +gzgetline (void *ctx, char **lineptr, size_t *n, gzFile stream) { + +The naming space of this function looks like the gz*functions in general; +But this adds a special talloc usage. getline() > gzgetline() conversion +should be consistent w/ other gz*() functions. I'd suggest to make slight +change to the function name to sanction the talloc usage. Ah, the fine +art & pain in naming considerations... + +> + +> + size_t len=*n; + +spaces around '=' + +> + char *buf = *lineptr; +> + size_t offset = 0; +> + +> + if (len == 0 || buf == NULL) { +> + /* XXX arbitrary choice of initial size */ + +what does getline() use there.. could the 'XXX' just be dropped. + +> + len = BUFSIZ; +> + buf = talloc_size (ctx, len); +> + } +> + +> + while (1) { +> + +> + if (!gzgets (stream, buf + offset, len)) +> + return -1; +> + +> + /* XXX wasted effort re-counting length of whole line */ +> + offset = strlen (buf); + +offset += strlen (buf + offset); would drop the whole line recounting... +just would that ever happen (gzgets() just usually returns the whole line +with '\n').. so many alternatives there... + +...maybe just comment the usual case that full lines are returned. + + +Tomi + + +> + +> + if ( buf[offset-1] == '\n' ) +> + break; +> + +> + len *= 2; +> + buf = talloc_realloc (ctx, buf, char, len); +> + +> + } +> + +> + *lineptr = buf; +> + *n = len; +> + return offset; +> +} +> diff --git a/util/zlib-extra.h b/util/zlib-extra.h +> new file mode 100644 +> index 0000000..c18480f +> --- /dev/null +> +++ b/util/zlib-extra.h +> @@ -0,0 +1,10 @@ +> +#ifndef _ZLIB_EXTRA_H +> +#define _ZLIB_EXTRA_H +> + +> +#include +> + +> +/* Like getline, but read from a gzFile. Allocation is with talloc */ +> +ssize_t +> +gzgetline (void *ctx, char **lineptr, size_t *n, gzFile stream); +> + +> +#endif +> -- +> 1.9.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2