From 0cc547ad37c017bd5aca962b80acefeabb60bae2 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 10 May 2014 18:49:24 +0900 Subject: [PATCH] Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump. --- 5b/5412984e4a867cd8c1189f2c81a1c66db1c343 | 83 +++++++++++++++++++++++ 1 file changed, 83 insertions(+) create mode 100644 5b/5412984e4a867cd8c1189f2c81a1c66db1c343 diff --git a/5b/5412984e4a867cd8c1189f2c81a1c66db1c343 b/5b/5412984e4a867cd8c1189f2c81a1c66db1c343 new file mode 100644 index 000000000..a87454637 --- /dev/null +++ b/5b/5412984e4a867cd8c1189f2c81a1c66db1c343 @@ -0,0 +1,83 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2528C431FC0 + for ; Sat, 10 May 2014 02:51:07 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id NIjIA6qBd9bz for ; + Sat, 10 May 2014 02:51:00 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 12C0E431FBF + for ; Sat, 10 May 2014 02:51:00 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1Wj3uZ-0006pT-6S; Sat, 10 May 2014 09:49:43 +0000 +Received: (nullmailer pid 10909 invoked by uid 1000); Sat, 10 May 2014 + 09:49:24 -0000 +From: David Bremner +To: Charles Celerier , Notmuch Mail + +Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump. +In-Reply-To: +References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu> + <1399434615-28425-1-git-send-email-cceleri@cs.stanford.edu> + <1399434615-28425-2-git-send-email-cceleri@cs.stanford.edu> + <87d2fov2qj.fsf@maritornes.cs.unb.ca> + <87a9arvs9b.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 10 May 2014 18:49:24 +0900 +Message-ID: <87lhua3qvv.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 10 May 2014 09:51:07 -0000 + +Charles Celerier writes: + +> David Bremner writes: +> +> $ nm --version +> GNU nm (GNU Binutils) 2.24 +> Copyright 2013 Free Software Foundation, Inc. +> This program is free software; you may redistribute it under the terms of +> the GNU General Public License version 3 or (at your option) any later version. +> This program has absolutely no warranty. +> +> I'm not convinced the insertion of an underscore is nm's doing. + +OIC. right, nm is not the issue. + +> At this point, I'm not sure how to create a better version of this +> patch. Are we renaming functions in notmuch-private.h? Should we stick +> with objdump or switch to using nm? + +I'd go with renaming any functions that start with notmuch to start with +_notmuch. + +Since it seems neither nm nor objdump provides uniform output between +OS/X and Linux, there isn't an obvious advantage to switching to nm. Any +idea if objdump can be made to work (in this test) on OS/X ? + +d -- 2.26.2