From 0b51e62346e03dab058877ec318586bce3f46ca4 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 9 Jun 2013 13:33:41 +0300 Subject: [PATCH] Re: [PATCH v2] emacs: show: change emacs interactive pipe message. --- af/94b3977512694748946bd75898274c87ccb8c2 | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 af/94b3977512694748946bd75898274c87ccb8c2 diff --git a/af/94b3977512694748946bd75898274c87ccb8c2 b/af/94b3977512694748946bd75898274c87ccb8c2 new file mode 100644 index 000000000..d884491ef --- /dev/null +++ b/af/94b3977512694748946bd75898274c87ccb8c2 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A6FBB431FB6 + for ; Sun, 9 Jun 2013 03:33:53 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ke6D1T3TA8H4 for ; + Sun, 9 Jun 2013 03:33:44 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id BD741431FAE + for ; Sun, 9 Jun 2013 03:33:44 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 2DC0F100044; + Sun, 9 Jun 2013 13:33:42 +0300 (EEST) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: show: change emacs interactive pipe message. +In-Reply-To: <1370767308-1636-1-git-send-email-markwalters1009@gmail.com> +References: <1369944667-22705-1-git-send-email-markwalters1009@gmail.com> + <1370767308-1636-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.15.2+172~ge989640 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 09 Jun 2013 10:33:53 -0000 + +On Sun, Jun 09 2013, Mark Walters wrote: + +> Previously the query string for piping a message to a command was +> "Pipe message to command: " regardless of whether the function was +> called with a prefix argument (which pipes all open messages to the +> command). This patch modifies the `interactive' command to reflect +> this. +> --- +> This has the whitespace fix Tomi mentioned but is otherwise unchanged. + +LGTM, my review comments in id:m2wqqftvu3.fsf@guru.guru-group.fi apply. + +> Best wishes + +Tomi + + +> +> Mark +> +> +> emacs/notmuch-show.el | 5 ++++- +> 1 files changed, 4 insertions(+), 1 deletions(-) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 83bb9ad..d863f2b 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -1702,7 +1702,10 @@ to stdout or stderr will appear in the *notmuch-pipe* buffer. +> When invoked with a prefix argument, the command will receive all +> open messages in the current thread (formatted as an mbox) rather +> than only the current message." +> - (interactive "P\nsPipe message to command: ") +> + (interactive (let ((query-string (if current-prefix-arg +> + "Pipe all open messages to command: " +> + "Pipe message to command: "))) +> + (list current-prefix-arg (read-string query-string)))) +> (let (shell-command) +> (if entire-thread +> (setq shell-command +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2