From 0a81f4698b952995464690049b17114e6622349f Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 24 Nov 2015 08:46:04 +2000 Subject: [PATCH] Re: [PATCH] emacs: hello: fix accidental modification of widget-keymap --- 3d/6e81004e15b2da7fc84e855fd75dc09c047a41 | 65 +++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 3d/6e81004e15b2da7fc84e855fd75dc09c047a41 diff --git a/3d/6e81004e15b2da7fc84e855fd75dc09c047a41 b/3d/6e81004e15b2da7fc84e855fd75dc09c047a41 new file mode 100644 index 000000000..5680a8e9b --- /dev/null +++ b/3d/6e81004e15b2da7fc84e855fd75dc09c047a41 @@ -0,0 +1,65 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 6BAB66DE1378 + for ; Mon, 23 Nov 2015 05:02:47 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.306 +X-Spam-Level: +X-Spam-Status: No, score=-0.306 tagged_above=-999 required=5 tests=[AWL=0.245, + RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5Pjg2cbkq0yS for ; + Mon, 23 Nov 2015 05:02:42 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 6829E6DE0943 + for ; Mon, 23 Nov 2015 05:02:42 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1a0qVR-0000QR-4P; Mon, 23 Nov 2015 07:46:05 -0500 +Received: (nullmailer pid 30174 invoked by uid 1000); + Mon, 23 Nov 2015 12:46:04 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: hello: fix accidental modification of + widget-keymap +In-Reply-To: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com> +References: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 23 Nov 2015 08:46:04 -0400 +Message-ID: <87twoc51f7.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 23 Nov 2015 13:02:47 -0000 + +Mark Walters writes: + +> In emacs24 we use make-composed-keymap. It seems that if only a single +> map is specified then emacs just resuses it rather than creating a +> copy of it. Thus use make-sparse-keymap to force a copy. +> --- +> +> pseudomyne and the diredful author thamer found that we modify +> widget-keymap in notmuch. We clearly don't want to, and I think we +> tried not to, but emacs was being clever and reused the old keymap +> rather than creating a new one. + +applied to release and master. + +d -- 2.26.2