From 0a00a2f4e56cb695965bb30b60688e134d5305cd Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 22 Feb 2014 12:17:24 +0200 Subject: [PATCH] Re: [PATCH 4/4] emacs: Simplify and fix `notmuch-mua-prompt-for-sender' --- cf/325de34521818e78e0773065418e169ccdb9cd | 73 +++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 cf/325de34521818e78e0773065418e169ccdb9cd diff --git a/cf/325de34521818e78e0773065418e169ccdb9cd b/cf/325de34521818e78e0773065418e169ccdb9cd new file mode 100644 index 000000000..d7ac75f1e --- /dev/null +++ b/cf/325de34521818e78e0773065418e169ccdb9cd @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5CD6F431FBD + for ; Sat, 22 Feb 2014 02:17:37 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2w1GlIgtZV4S for ; + Sat, 22 Feb 2014 02:17:33 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 7B296431FB6 + for ; Sat, 22 Feb 2014 02:17:33 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 03EDF10005E; + Sat, 22 Feb 2014 12:17:25 +0200 (EET) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 4/4] emacs: Simplify and fix + `notmuch-mua-prompt-for-sender' +In-Reply-To: <1392923797-17045-5-git-send-email-amdragon@mit.edu> +References: <1392923797-17045-1-git-send-email-amdragon@mit.edu> + <1392923797-17045-5-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.17+94~g1b90823 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: bjonnh-nm@bjonnh.net +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 22 Feb 2014 10:17:37 -0000 + +On Thu, Feb 20 2014, Austin Clements wrote: + +This seris LGTM. I don't know about patch 4 as I have not used +the features (hand-edited From: always...) maybe I should... + +Tomi + + +> This patch rewrites `notmuch-mua-prompt-for-sender' to simply prompt +> for a full identity, where the list of identities is derived from +> either notmuch-identities or the user's Notmuch configuration. +> +> The original code also did several strange things, like using `eval' +> and specifying that this function was interactive. As a side-effect, +> this patch fixes these problems. And it adds a docstring. +> --- +> emacs/notmuch-mua.el | 33 +++++++++------------------------ +> 1 file changed, 9 insertions(+), 24 deletions(-) +> + -- 2.26.2