From 0869f9d4f91342044ae715f4579ced5ba8438a3e Mon Sep 17 00:00:00 2001
From: Robert Bradshaw <robertwb@math.washington.edu>
Date: Tue, 7 Oct 2008 11:05:58 -0700
Subject: [PATCH] more flexable declare

---
 Cython/Compiler/Nodes.py               | 25 +++++++++++++++++++++++--
 Cython/Compiler/ParseTreeTransforms.py |  4 ++--
 Cython/Shadow.py                       | 11 +++++++----
 3 files changed, 32 insertions(+), 8 deletions(-)

diff --git a/Cython/Compiler/Nodes.py b/Cython/Compiler/Nodes.py
index 136dbedf..80ccfe6e 100644
--- a/Cython/Compiler/Nodes.py
+++ b/Cython/Compiler/Nodes.py
@@ -2549,6 +2549,22 @@ class ExprStatNode(StatNode):
 
     child_attrs = ["expr"]
     
+    def analyse_declarations(self, env):
+        import ExprNodes
+        if isinstance(self.expr, ExprNodes.GeneralCallNode):
+            func = self.expr.function.as_cython_attribute()
+            if func == u'declare':
+                args, kwds = self.expr.explicit_args_kwds()
+                if len(args):
+                    error(self.expr.pos, "Variable names must be specified.")
+                for var, type_node in kwds.key_value_pairs:
+                    type = type_node.analyse_as_type(env)
+                    if type is None:
+                        error(type_node.pos, "Unknown type")
+                    else:
+                        env.declare_var(var.value, type, var.pos, is_cdef = True)
+                self.__class__ = PassStatNode
+    
     def analyse_expressions(self, env):
         self.expr.analyse_expressions(env)
         self.expr.release_temp(env)
@@ -2609,8 +2625,7 @@ class SingleAssignmentNode(AssignmentNode):
                 args, kwds = self.rhs.explicit_args_kwds()
                 
                 if func_name in ['declare', 'typedef']:
-                    self.declaration_only = True
-                    if len(args) != 1 or kwds is not None:
+                    if len(args) > 2 or kwds is not None:
                         error(rhs.pos, "Can only declare one type at a time.")
                         return
                     type = args[0].analyse_as_type(env)
@@ -2628,7 +2643,13 @@ class SingleAssignmentNode(AssignmentNode):
                             return
                         for var, pos in vars:
                             env.declare_var(var, type, pos, is_cdef = True)
+                        if len(args) == 2:
+                            # we have a value
+                            self.rhs = args[1]
+                        else:
+                            self.declaration_only = True
                     else:
+                        self.declaration_only = True
                         if not isinstance(lhs, ExprNodes.NameNode):
                             error(lhs.pos, "Invalid declaration.")
                         env.declare_typedef(lhs.name, type, self.pos, 'private')
diff --git a/Cython/Compiler/ParseTreeTransforms.py b/Cython/Compiler/ParseTreeTransforms.py
index d8d97f07..254a4218 100644
--- a/Cython/Compiler/ParseTreeTransforms.py
+++ b/Cython/Compiler/ParseTreeTransforms.py
@@ -719,12 +719,12 @@ class TransformBuiltinMethods(EnvTransform):
             if attribute == u'compiled':
                 node = BoolNode(node.pos, value=True)
             else:
-                error(node.pos, u"'%s' not a valid cython attribute" % attribute)
+                error(node.pos, u"'%s' not a valid cython attribute or is being used incorrectly" % attribute)
         return node
 
     def visit_SimpleCallNode(self, node):
 
-        # locals
+        # locals builtin
         if isinstance(node.function, ExprNodes.NameNode):
             if node.function.name == 'locals':
                 pos = node.pos
diff --git a/Cython/Shadow.py b/Cython/Shadow.py
index b0cba9e9..6e6c7508 100644
--- a/Cython/Shadow.py
+++ b/Cython/Shadow.py
@@ -21,11 +21,14 @@ def sizeof(arg):
 def address(arg):
     return pointer(type(arg))([arg])
     
-def declare(type):
-    if callable(type):
-        return type()
+def declare(type=None, value=None, **kwds):
+    if type and callable(type):
+        if value:
+            return type(value)
+        else:
+            return type()
     else:
-        return None
+        return value
 
 # Emulated types
 
-- 
2.26.2