From 08337a97a2756cd89ab611444f37d67250d3c05b Mon Sep 17 00:00:00 2001 From: Sam Ravnborg Date: Tue, 27 Dec 2005 09:19:05 +0100 Subject: [PATCH] copy_fd: close ifd on error In copy_fd when write fails we ought to close input file descriptor. Signed-off-by: Sam Ravnborg Signed-off-by: Junio C Hamano --- copy.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/copy.c b/copy.c index 7100eedbc..08a3d388a 100644 --- a/copy.c +++ b/copy.c @@ -22,11 +22,14 @@ int copy_fd(int ifd, int ofd) buf += written; len -= written; } - else if (!written) + else if (!written) { + close(ifd); return error("copy-fd: write returned 0"); - else + } else { + close(ifd); return error("copy-fd: write returned %s", strerror(errno)); + } } } close(ifd); -- 2.26.2