From 05e9fbf173248b9f13977135d3d0c14d6f385926 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 1 May 2014 22:43:10 +0300 Subject: [PATCH] RE: Final call for news for 0.18 --- 42/dd8003cdd224f33a437681f963b7bc9755cec0 | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 42/dd8003cdd224f33a437681f963b7bc9755cec0 diff --git a/42/dd8003cdd224f33a437681f963b7bc9755cec0 b/42/dd8003cdd224f33a437681f963b7bc9755cec0 new file mode 100644 index 000000000..7d05a8173 --- /dev/null +++ b/42/dd8003cdd224f33a437681f963b7bc9755cec0 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 585F3431FBF + for ; Thu, 1 May 2014 12:43:30 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id BP6GNXsmIQbI for ; + Thu, 1 May 2014 12:43:18 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id B0899431FAE + for ; Thu, 1 May 2014 12:43:18 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 295D0100064; + Thu, 1 May 2014 22:43:11 +0300 (EEST) +From: Tomi Ollila +To: Felipe Contreras , notmuch@notmuchmail.org +Subject: RE: Final call for news for 0.18 +In-Reply-To: <5361893877282_39b4d8330851@nysa.notmuch> +References: <1398899916-18352-1-git-send-email-david@tethera.net> + <5361893877282_39b4d8330851@nysa.notmuch> +User-Agent: Notmuch/0.18~rc0+7~g371733d (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 01 May 2014 19:43:30 -0000 + +On Thu, May 01 2014, Felipe Contreras wrote: + +> David Bremner wrote: +>> We've had a quiet freeze for a week or so, so I think we're probably +>> ready to release. Per Jani's suggestion, I made a "tl;dr" summary for +>> the NEWS. Barring last minute bugs, I'd like to release this weekend, +>> so please send me any NEWS comments ASAP. +> +> What about the vim changes? +> +> http://mid.gmane.org/1398289784-18203-1-git-send-email-felipe.contreras@g= +mail.com + +I was going to review these after 0.18 release as the freeze was announced +to be Apri 21th(*) and these patches in question was sent April 24th, witho= +ut +any request to consider these for 0.18... + +(*) This freeze was announced April 14th (see id:8761mcxjhc.fsf@zancas.loca= +lnet +or http://mid.gmane.org/8761mcxjhc.fsf@zancas.localnet ) + +In general these patches: + +id:1398289784-18203-2-git-send-email-felipe.contreras@gmail.com +id:1398289784-18203-3-git-send-email-felipe.contreras@gmail.com +id:1398289784-18203-4-git-send-email-felipe.contreras@gmail.com + +has something lacking in the commit messages; none of these indicate that +these are vim patches in the subject line. For 1/3 I'd have liked to see +some potentially understandable explanation why the change was done instead +of "Seems it never really worked." -- the change looks a bit strange +(probably due to only the context seen). Commit message for 2/3 might be +tolerable if it were prefixed with vim: -- and the same applies to 3/3 +(in 3/3 I don't understand the change and I don't use vim so I don't know +how to test so It would be nice to get someone else (or two) to report +their experience with these patches applied in their notmuch-vim environmen= +t) + +Also NEWS for these changes are missing. + +I personally don't see these patches being important enough to hinder +0.18 release timeline -- these patches should just have come earlier... +... but if you had a good case, fix these things (quickly!) and had +strong backing from some other notmuch-vim users I could see a small +chance of these being part of the next release... + + +Tomi + + +PS: does vim frontend lack id:message-id feature -- the above http link +to gmane was just useless to me, which meant I had to use extra steps +to reach the emails (which sometimes if not often leads me just to drop +the issue there...). If it is lacking and SomeOne(=E2=84=A2) proposes id:ms= +gid +handling to notmuch-wim I promise to review that right away :D + + +> --=20 +> Felipe Contreras -- 2.26.2