From 045f2fa74b97cfaa6c3e263e8e706c07fe103499 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 7 May 2014 00:00:23 +0300 Subject: [PATCH] Re: [PATCH v2 00/10] add insert --must-index option --- 48/57b8a7364616591e50d7ccd9d8c368c786aa38 | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 48/57b8a7364616591e50d7ccd9d8c368c786aa38 diff --git a/48/57b8a7364616591e50d7ccd9d8c368c786aa38 b/48/57b8a7364616591e50d7ccd9d8c368c786aa38 new file mode 100644 index 000000000..cb383c053 --- /dev/null +++ b/48/57b8a7364616591e50d7ccd9d8c368c786aa38 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 08B6A431FC2 + for ; Tue, 6 May 2014 14:00:36 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xq+4SiQWoePJ for ; + Tue, 6 May 2014 14:00:28 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 1F7D7431FAF + for ; Tue, 6 May 2014 14:00:28 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id B5A761000E5; + Wed, 7 May 2014 00:00:23 +0300 (EEST) +From: Tomi Ollila +To: Peter Wang , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 00/10] add insert --must-index option +In-Reply-To: <1397653165-15620-1-git-send-email-novalazy@gmail.com> +References: <1397653165-15620-1-git-send-email-novalazy@gmail.com> +User-Agent: Notmuch/0.18+12~gbfbd199 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 06 May 2014 21:00:36 -0000 + +On Wed, Apr 16 2014, Peter Wang wrote: + +> Follow up to id:1374365254-13227-1-git-send-email-novalazy@gmail.com +> The main changes are to take into account failures during +> tagging and flushing of the database. +> +> I took Jani's patch id:1390152046-6509-1-git-send-email-jani@nikula.org +> without modification. +> +> The soname bump is included in case it is required. + +I guess it is -- then changing in that file is not enough, lib/notmuch.h +needs to have the same change. + +But, would a MINOR value update work -- anyone who needs only 3.1.0 +could also work with 3.2.0... + +If MINOR update were sufficient then we would not need to add +api changes that supports logging (etc.) to this conversation... + +... but anyone interested these changes should also take a look +of the actual changes... :D + +Tomi + +> The python/go/ruby changes are untested. + + + +> +> +> Jani Nikula (1): +> lib: add return status to database close and destroy +> +> Peter Wang (9): +> lib: bump soname +> python: handle return status of database close and destroy +> go: add return status to database close method +> ruby: handle return status of database close +> cli: refactor insert +> cli: indicate insert failure mode in exit status +> cli: add insert --must-index option +> test: test insert --must-index +> man: update insert documentation +> +> bindings/go/src/notmuch/notmuch.go | 4 +- +> bindings/python/notmuch/database.py | 12 ++-- +> bindings/ruby/database.c | 4 +- +> doc/man1/notmuch-insert.rst | 24 +++++-- +> lib/Makefile.local | 2 +- +> lib/database.cc | 30 ++++++-- +> lib/notmuch.h | 15 +++- +> notmuch-insert.c | 134 +++++++++++++++++++++--------------- +> test/T070-insert.sh | 32 +++++++-- +> 9 files changed, 176 insertions(+), 81 deletions(-) +> +> -- +> 1.8.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2