From 003bcc227a6c2ef3bc3ac2b582da7e721083f4ac Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 7 Apr 2014 15:42:06 +2100 Subject: [PATCH] Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it --- 87/4570ad4a69111cdd1bd488d2fbbc278bd696dd | 73 +++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 87/4570ad4a69111cdd1bd488d2fbbc278bd696dd diff --git a/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd b/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd new file mode 100644 index 000000000..f91534aa0 --- /dev/null +++ b/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1CD6B431FBC + for ; Sun, 6 Apr 2014 11:43:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Lq+zPDc+FiBt for ; + Sun, 6 Apr 2014 11:43:23 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 93333431FB6 + for ; Sun, 6 Apr 2014 11:43:23 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1WWs1N-0004eg-FW; Sun, 06 Apr 2014 18:42:21 +0000 +Received: (nullmailer pid 10092 invoked by uid 1000); Sun, 06 Apr 2014 + 18:42:06 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create + notmuch-version.el from it +In-Reply-To: <1395261431-24668-2-git-send-email-tomi.ollila@iki.fi> +References: <1395261431-24668-1-git-send-email-tomi.ollila@iki.fi> + <1395261431-24668-2-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.17+170~gf516b7c (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 06 Apr 2014 15:42:06 -0300 +Message-ID: <87a9by47wh.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 06 Apr 2014 18:43:32 -0000 + +Tomi Ollila writes: + +> +;; You should have received a copy of the GNU General Public License +> +;; along with Notmuch. If not, see . + +Do you think we need a copyright header in a generated file? + +> + +> +(defconst notmuch-emacs-version %VERSION% +> + "Version string of this version of Notmuch Emacs MUA.") +> + + +At the risk of being very picky, how about less copies of Version, maybe +"Version of Notmuch Emacs MUA" + +Other than that, the series looks OK, and works on Debian now. + +d + -- 2.26.2