Zac Medico [Sun, 1 Apr 2012 16:38:27 +0000 (09:38 -0700)]
dispatch_conf: don't pass bytes for Popen cmd
This will fix bug #410417.
Zac Medico [Sat, 31 Mar 2012 23:19:04 +0000 (16:19 -0700)]
varexpand: optimize access to current char
Zac Medico [Sat, 31 Mar 2012 21:17:23 +0000 (14:17 -0700)]
getconfig: show error message for varexpand fail
Zac Medico [Sat, 31 Mar 2012 20:27:11 +0000 (13:27 -0700)]
varexpand: use frozenset for word characters
Zac Medico [Sat, 31 Mar 2012 19:48:44 +0000 (12:48 -0700)]
varexpand: use list for efficient append
Zac Medico [Sat, 31 Mar 2012 17:22:13 +0000 (10:22 -0700)]
dispatch_conf: emulate getstatusoutput with Popen
This will fix bug #410315.
Zac Medico [Fri, 30 Mar 2012 00:17:06 +0000 (17:17 -0700)]
portage.5: note more bashrc caveats, bug #409627
Zac Medico [Thu, 29 Mar 2012 22:25:23 +0000 (15:25 -0700)]
fowners: return success for prefix if EUID != 0
This is based on a patch by Jeremy Olexa from bug #409893.
Jeremy Olexa [Thu, 29 Mar 2012 22:02:56 +0000 (15:02 -0700)]
dosym: add $EPREFIX to absolute target
Mike Frysinger [Tue, 27 Mar 2012 20:38:18 +0000 (16:38 -0400)]
xpak: clean up style
A few spaces here and there go a long way to making this readable.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Zac Medico [Wed, 28 Mar 2012 01:49:59 +0000 (18:49 -0700)]
varexpand: don't cache results
Caching wasn't really necessary here, and it didn't properly account
for input differences in the 'mydict' parameter.
Zac Medico [Wed, 28 Mar 2012 00:35:59 +0000 (17:35 -0700)]
locks.py: fix _close_fds docstring
Zac Medico [Wed, 28 Mar 2012 00:26:17 +0000 (17:26 -0700)]
LockNonblockTestCase: close_fds tweak
Make consistent with commit
144c23efbb4e9565debad03c13c5bcab833a8336.
Zac Medico [Tue, 27 Mar 2012 18:56:32 +0000 (11:56 -0700)]
emerge: suggest dispatch-conf for bug #398843
Zac Medico [Tue, 27 Mar 2012 18:28:12 +0000 (11:28 -0700)]
Close fewer file descriptors for fork / no exec.
This will fix bug #374335.
Zac Medico [Tue, 27 Mar 2012 17:35:44 +0000 (10:35 -0700)]
etc-update: handle emacs diff cmd, bug #409849
Zac Medico [Tue, 27 Mar 2012 17:06:05 +0000 (10:06 -0700)]
etc-update: remove duplicate using_editor
Zac Medico [Tue, 27 Mar 2012 16:28:01 +0000 (09:28 -0700)]
movefile: use writemsg for unicode safety
Zac Medico [Tue, 27 Mar 2012 15:52:35 +0000 (08:52 -0700)]
Replace @returns with @return.
Greg Turner [Tue, 27 Mar 2012 15:40:18 +0000 (08:40 -0700)]
grabdict: remove incorrect docstring, bug #409839
Greg Turner [Tue, 27 Mar 2012 15:32:56 +0000 (08:32 -0700)]
Localize config update messages, bug #409835.
Zac Medico [Tue, 27 Mar 2012 14:39:57 +0000 (07:39 -0700)]
emerge-webrsync: use portageq from same prefix
Zac Medico [Mon, 26 Mar 2012 03:49:47 +0000 (20:49 -0700)]
unmerge: fix return code for bug #409647
Zac Medico [Sun, 25 Mar 2012 23:20:19 +0000 (16:20 -0700)]
Exit status 128 + SIGINT for --ask 'no' answer.
This will fix bug #409647.
Zac Medico [Sun, 25 Mar 2012 21:48:25 +0000 (14:48 -0700)]
emerge --sync: use yellow for portage update msg
Zac Medico [Fri, 23 Mar 2012 19:57:47 +0000 (12:57 -0700)]
movefile: import print_function
This fixes printing of tuples under python-2.x, as shown in
bug #402323.
Zac Medico [Fri, 23 Mar 2012 18:22:23 +0000 (11:22 -0700)]
movefile: clarify message for xattr copy error
This will fix bug #402323.
Zac Medico [Fri, 23 Mar 2012 18:05:36 +0000 (11:05 -0700)]
movefile: refactor selinux conditional code
Zac Medico [Fri, 23 Mar 2012 17:28:21 +0000 (10:28 -0700)]
Clarify symlink/dir collision for bug #409359.
Zac Medico [Fri, 23 Mar 2012 05:37:39 +0000 (22:37 -0700)]
repoman: disable dependency.unknown for blockers
This will fix bug #382407.
Zac Medico [Fri, 23 Mar 2012 01:38:14 +0000 (18:38 -0700)]
mtimedb: fix hexversion for python issue 5729
Zac Medico [Thu, 22 Mar 2012 21:36:36 +0000 (14:36 -0700)]
mtimedb: enable JSON write support
JSON read support has been available since portage-2.1.10.49.
Zac Medico [Thu, 22 Mar 2012 19:00:39 +0000 (12:00 -0700)]
emerge --changelog: show some log entries above
This will fix bug #373009.
Zac Medico [Thu, 22 Mar 2012 17:15:10 +0000 (10:15 -0700)]
emerge --changelog: fix split ChangeLog bugs
This should fix possible missing content when displaying split
ChangeLogs (bug #389611), and also normalizes blank lines.
Zac Medico [Thu, 22 Mar 2012 15:23:51 +0000 (08:23 -0700)]
PreservedLibsRegistry: try to parse as JSON first
Zac Medico [Wed, 21 Mar 2012 21:24:15 +0000 (14:24 -0700)]
PreservedLibsRegistry: enable JSON write support
JSON read support has been available since portage-2.2.0_alpha89.
Zac Medico [Wed, 21 Mar 2012 19:25:55 +0000 (12:25 -0700)]
getmaskingreason: use remember_source_file
This will fix bug #409179.
Zac Medico [Wed, 21 Mar 2012 07:40:21 +0000 (00:40 -0700)]
Bug #361759: QA check for /etc/udev/rules.d
Zac Medico [Wed, 21 Mar 2012 07:16:54 +0000 (00:16 -0700)]
Map emerge --buildpkg=n to FEATURES=-buildpkg.
This will fix bug #409085.
Zac Medico [Mon, 19 Mar 2012 18:33:28 +0000 (11:33 -0700)]
doebuild_environment: comment on bug #408817
Zac Medico [Mon, 19 Mar 2012 18:12:32 +0000 (11:12 -0700)]
spawn_nofetch: clone locked config, bug #408817
It's unsafe to pass in an unlocked config instance, since that can
trigger issues like bug #408817 due to fragile assumptions involving
the config state inside doebuild_environment().
Zac Medico [Mon, 19 Mar 2012 17:06:41 +0000 (10:06 -0700)]
Revert "depgraph: reset pkgsettings after setcpv"
This reverts commit
884993c7f4b9e7e9ede690f5fab81742915fc942.
Calling reset is expensive and is not really needed since commit
3ca5f0cc08d233a3e229e78b573c7aab7d46cb9c.
Zac Medico [Mon, 19 Mar 2012 17:00:38 +0000 (10:00 -0700)]
doebuild_environment: sanity check for bug 408817
Ensure that CATEGORY is determined correctly, and raise AssertionError
if it can't be determined.
Zac Medico [Mon, 19 Mar 2012 16:29:29 +0000 (09:29 -0700)]
depgraph: reset pkgsettings after setcpv
This should prevent doebuild_environment from incorrectly using the
CATEGORY from the previous setcpv call, as reported in bug #408817.
Zac Medico [Sun, 18 Mar 2012 22:39:40 +0000 (15:39 -0700)]
unmerge: remove unused preserve-libs
This fixes a case were one or more packages are unmerged without being
replaced, and some preserved libraries need to be removed because
they all consumers have just been unmerged.
Zac Medico [Sun, 18 Mar 2012 17:07:09 +0000 (10:07 -0700)]
dispatch_conf: fix broken diffstatusoutput_len
Zac Medico [Sat, 17 Mar 2012 23:28:54 +0000 (16:28 -0700)]
etc-update: quote ${file}
Zac Medico [Sat, 17 Mar 2012 22:56:33 +0000 (15:56 -0700)]
etc-update: ignore non-existent CONFIG_PROTECT
Zac Medico [Sat, 17 Mar 2012 22:11:47 +0000 (15:11 -0700)]
Omit EPREFIX from paths in unicode QA Notice.
Zac Medico [Sat, 17 Mar 2012 21:56:37 +0000 (14:56 -0700)]
Use eqawarn for install of non UTF-8 file names.
This will fix bug #406749.
Zac Medico [Sat, 17 Mar 2012 21:31:55 +0000 (14:31 -0700)]
repoman: add --digest=<y|n> option, bug #406875
Zac Medico [Sat, 17 Mar 2012 19:48:30 +0000 (12:48 -0700)]
repoman: ignore temp files, bug #406877
If the file isn't in the VCS new or changed set, then assume that
it's an irrelevant temporary file. This relies on commit
2dac56fa282645031eb29860abc403e983a04b2d to guarantee that Manifest
entries are not generated for file names containing prohibited
characters.
Zac Medico [Sat, 17 Mar 2012 16:44:03 +0000 (09:44 -0700)]
Manifest: filter file names with repoman's regex
This makes Manifest generation consistent with repoman, which is
necessary if repoman is going to ignore irrelevant files as requested
in bug #406877.
Zac Medico [Sat, 17 Mar 2012 00:08:59 +0000 (17:08 -0700)]
Add a Makefile derived from the portage ebuild.
This will fix bug #335320.
Martin von Gagern [Tue, 13 Mar 2012 17:15:26 +0000 (10:15 -0700)]
Display: spawn pkg_nofetch when appropriate
Signed-off-by: Zac Medico <zmedico@gentoo.org>
Mike Frysinger [Mon, 12 Mar 2012 05:29:32 +0000 (01:29 -0400)]
QA: detect pkg-config files that bleed LDFLAGS
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Mon, 12 Mar 2012 04:40:12 +0000 (00:40 -0400)]
etc-update: ignore changes in whitespace (-b) for automerge
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Sun, 11 Mar 2012 04:15:31 +0000 (23:15 -0500)]
portageq: add "colormap" helper
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Sun, 11 Mar 2012 19:39:50 +0000 (15:39 -0400)]
etc-update: fix logic bug with protected files
The rewrite introduced a slight bug with protected files. Fix that,
and rework the code slightly to make it obvious that we want a diff
set of options for files and dirs.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Sun, 11 Mar 2012 03:57:43 +0000 (22:57 -0500)]
etc-update: handle symlinked files
If the config file is symlinked somewhere, then update the target rather
then discarding the symlink and replacing it with a real file.
URL: http://bugs.gentoo.org/330221
Reported-by: Jack Byer <ftn768@gmail.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Sun, 11 Mar 2012 03:23:25 +0000 (22:23 -0500)]
etc-update: fix default "enter" behavior
Adding support for -[3579] command line flags inadvertently broke the
default behavior of hitting "enter" to automatically select the next
file. Make this work again.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Sun, 11 Mar 2012 02:54:59 +0000 (21:54 -0500)]
etc-update: add a --preen flag
Add a flag to merge just trivial updates and then quit.
URL: http://bugs.gentoo.org/159080
Reported-by: Iván Pérez Domínguez <iperez@babel.ls.fi.upm.es>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Sun, 11 Mar 2012 02:43:30 +0000 (21:43 -0500)]
etc-update: support scan paths on the command line
URL: http://bugs.gentoo.org/59235
Reported-by: Cory Visi <merlin@gentoo.org>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Thu, 8 Mar 2012 21:47:16 +0000 (16:47 -0500)]
dispatch-conf: do regex matching ourselves
This avoids having to pipe through multiple greps, as well as running
diff multiple times on the same set of files.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Zac Medico [Sat, 10 Mar 2012 15:22:46 +0000 (07:22 -0800)]
ebuild.sh: skip EBUILD_HOOK_DIR for depend phase
Zac Medico [Fri, 9 Mar 2012 06:35:43 +0000 (22:35 -0800)]
install-info: avoid unnecessary shell
Zac Medico [Fri, 9 Mar 2012 05:08:40 +0000 (21:08 -0800)]
Exit after killed while waiting on prefetch.
Zac Medico [Fri, 9 Mar 2012 02:54:02 +0000 (18:54 -0800)]
Use Popen to avoid unnecessary shell.
Zac Medico [Thu, 8 Mar 2012 23:55:39 +0000 (15:55 -0800)]
Disable 'illegally inherited' check for nofetch.
It's disabled for nofetch, since that can be called by repoman and
that triggers bug #407449 due to repoman not exporting non-essential
variables such as INHERITED.
Mike Frysinger [Thu, 8 Mar 2012 20:19:55 +0000 (15:19 -0500)]
dispatch-conf: add --help/--version flags
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Thu, 8 Mar 2012 20:13:05 +0000 (15:13 -0500)]
etc-update(1): flesh out a bit more
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Thu, 8 Mar 2012 18:45:29 +0000 (13:45 -0500)]
etc-update: turn -[3579] flags into command line option
This lets people do `etc-update --automode -3` rather than having
to do something like `echo "-3" | etc-update`.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger [Thu, 8 Mar 2012 05:11:56 +0000 (00:11 -0500)]
etc-update: rewrite significantly
This tool is very inefficient, especially in the case of auto-merging
with -3/-5 and such. Rewrite the code to kill off dead paths, compress
multiple greps into a single sed, cache more calculated results, and
use bash code where possible rather than execing external tools. There
are also style updates here, many of which fix quoting issues and other
such things.
The next rewrite should probably be in python, but this version is
fast enough for me now even on my slow machines.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Zac Medico [Mon, 5 Mar 2012 09:55:39 +0000 (01:55 -0800)]
whirlpool.py: fix WhirlpoolAdd for bug #406407
This file is a python port of Whirlpool.c the reference implementation:
http://www.larc.usp.br/~pbarreto/whirlpool.zip
Comparison of both implementations reveals a difference in loop logic
at the very beginning of the WhirlpoolAdd function, which is fixed now.
Zac Medico [Mon, 5 Mar 2012 07:30:28 +0000 (23:30 -0800)]
pruneNonExisting: handle eselect-opengl symlinks
Only count symlinks as preserved if they still point to a hardink
in the same directory, in order to handle cases where a tool such
as eselect-opengl has updated the symlink to point to a hardlink
in a different directory (see bug #406837). The unused hardlink is
automatically found by _find_unused_preserved_libs, since the soname
symlink no longer points to it. After the hardlink is removed by
_remove_preserved_libs, it calls pruneNonExisting which eliminates
the irrelevant symlink from the registry here.
Zac Medico [Mon, 5 Mar 2012 00:48:41 +0000 (16:48 -0800)]
repoman: say Git >=1.7.9 needed for signed commit
Zac Medico [Mon, 5 Mar 2012 00:01:29 +0000 (16:01 -0800)]
repoman: support overlays without repo_name
Zac Medico [Wed, 29 Feb 2012 15:49:25 +0000 (07:49 -0800)]
action_build: return 1 for "no" --ask answer
Zac Medico [Tue, 28 Feb 2012 04:57:35 +0000 (20:57 -0800)]
cvstree.getentries: handle "ignored" files in cvs
It's possible for files to be under version control even though they
match our ignore filter, so don't ignore them if they are listed in the
"Entries" file. Thanks to Mike Gilbert <floppym@gentoo.org> for
reporting in this blog post:
http://floppym.blogspot.com/2012/02/cvs-status-display-cvs-checkout-in-svn.html
Sebastian Luther [Sun, 26 Feb 2012 09:34:31 +0000 (10:34 +0100)]
autounmask: Avoid unmasking live versions if possible
Before this patch the allowed changes were:
1. USE
2. USE + ~arch + license
3. USE + ~arch + license + missing keywords + masks
With this patch:
1. USE
2. USE + ~arch + license
3. USE + ~arch + license + missing keywords
4. USE + ~arch + license + masks
5. USE + ~arch + license + missing keywords + masks
This avoids unmasking live versions, which are typically masked
and have missing keywords to be avoided if there is a regular
masked version available.
Sebastian Luther [Sun, 26 Feb 2012 08:49:13 +0000 (09:49 +0100)]
Reorganize how autounmask allows changes to be made
This patch does not change emerge's behaviour.
Sebastian Luther [Fri, 24 Feb 2012 21:13:52 +0000 (22:13 +0100)]
autounmask: Fix USE change messages to display the correct parent
Fixes bug 399863.
Zac Medico [Thu, 23 Feb 2012 05:30:19 +0000 (21:30 -0800)]
Unmerge orphan directory symlinks for bug 384397.
Zac Medico [Thu, 23 Feb 2012 03:07:11 +0000 (19:07 -0800)]
dblink: split out _unmerge_dirs method
This code will need to be called twice when safely unmerging symlinks
to directories (bug #384397).
Zac Medico [Wed, 22 Feb 2012 20:50:48 +0000 (12:50 -0800)]
ecompressdir: handle abs symlink, bug #405327
Zac Medico [Mon, 20 Feb 2012 11:01:12 +0000 (03:01 -0800)]
Scheduler: hang in _schedule_tasks, bug 404995
This is triggered whenever emerge bails out while parallel-fetch is
running in the background.
Zac Medico [Sat, 18 Feb 2012 04:03:41 +0000 (20:03 -0800)]
_eventloop: use explicit relative imports
Zac Medico [Sat, 18 Feb 2012 03:40:03 +0000 (19:40 -0800)]
MtimeDB: add JSON read/write
Support serialization as JSON instead of pickle, so that
/var/cache/edb/mtimedb is human readable/writable, for those rare
cases where it may be useful. Currently, pickle is still used for
writes. The plan is to migrate to JSON after JSON read has been
supported for some time.
Zac Medico [Sat, 18 Feb 2012 02:41:27 +0000 (18:41 -0800)]
MtimeDB._load: explicitly close file
Zac Medico [Sat, 18 Feb 2012 02:01:27 +0000 (18:01 -0800)]
PreservedLibsRegistry: add JSON read/write
Support serialization as JSON instead of pickle, so that
/var/lib/portage/preserved_libs_registry is human readable/writable,
for those rare cases where it may be useful. Currently, pickle is still
used for writes. The plan is to migrate to JSON after JSON read has
been supported for some time.
Zac Medico [Fri, 17 Feb 2012 23:56:56 +0000 (15:56 -0800)]
repoman: make virtual.oldstyle an error
Also, add "allow-provide-virtuals = true" setting for
metadata/layout.conf which reduces it to a warning.
Zac Medico [Fri, 17 Feb 2012 23:33:35 +0000 (15:33 -0800)]
portage.5: layout.conf manifest-hashes example
Zac Medico [Fri, 17 Feb 2012 23:23:39 +0000 (15:23 -0800)]
PollSelectAdapter: don't inherit PollConstants
Zac Medico [Fri, 17 Feb 2012 22:56:21 +0000 (14:56 -0800)]
Move Poll{Constants,SelectAdapter} to _eventloop.
Zac Medico [Fri, 17 Feb 2012 22:49:36 +0000 (14:49 -0800)]
Move _emerge.SlotObject to portage.util.
Zac Medico [Fri, 17 Feb 2012 22:31:37 +0000 (14:31 -0800)]
SlotObject: validate __slots__ and keyword args
Zac Medico [Fri, 17 Feb 2012 22:18:05 +0000 (14:18 -0800)]
Remove redundant inherited __slots__ values.
Zac Medico [Fri, 17 Feb 2012 22:16:59 +0000 (14:16 -0800)]
EventLoop: fix _io_handler_class "f" attribute
Arfrever Frehtes Taifersar Arahesis [Fri, 17 Feb 2012 21:33:13 +0000 (22:33 +0100)]
portage.package.ebuild.fetch.fetch(): Fix ResourceWarning with Python 3.2.
Zac Medico [Fri, 17 Feb 2012 10:20:35 +0000 (02:20 -0800)]
EventLoop.iteration: run timeouts last
Run timeouts last, in order to minimize latency in termination of
iteration loops that they may control.