git.git
17 years agoindex-pack: write-or-die instead of unchecked write-in-full.
Junio C Hamano [Thu, 11 Jan 2007 21:15:51 +0000 (13:15 -0800)]
index-pack: write-or-die instead of unchecked write-in-full.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agowrite_in_full: really write in full or return error on disk full.
Linus Torvalds [Thu, 11 Jan 2007 21:04:11 +0000 (13:04 -0800)]
write_in_full: really write in full or return error on disk full.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDocument git-init
Junio C Hamano [Thu, 11 Jan 2007 20:58:10 +0000 (12:58 -0800)]
Document git-init

These days, the command does a lot more than just initialise the
object database (such as setting default config-variables,
installing template hooks...), and "git init" is actually a more
sensible name nowadays.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agowrite-cache: do not leak the serialized cache-tree data.
Linus Torvalds [Thu, 11 Jan 2007 20:25:16 +0000 (12:25 -0800)]
write-cache: do not leak the serialized cache-tree data.

It is not used after getting written, and just is leaking every time
we write the index out.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoProvide better feedback for the untracked only case in status output
Jürgen Rühle [Wed, 10 Jan 2007 22:25:03 +0000 (23:25 +0100)]
Provide better feedback for the untracked only case in status output

Since 98bf8a47c296f51ea9722fef4bb81dbfb70cd4bb status would claim that
git-commit could be useful even if there are no changes except untracked files.

Since wt-status is already computing all the information needed go the whole
way and actually track the (non-)emptiness of all three sections separately,
unify the code, and provide useful messages for each individual case.

Thanks to Junio and Michael Loeffler for suggestions.

Signed-off-by: Jürgen Rühle <j-r@online.de>
17 years agoMerge branch 'js/reflog'
Junio C Hamano [Wed, 10 Jan 2007 22:16:16 +0000 (14:16 -0800)]
Merge branch 'js/reflog'

* js/reflog:
  Sanitize for_each_reflog_ent()

17 years agoMakefile: remove $foo when $foo.exe is built/installed.
Junio C Hamano [Wed, 10 Jan 2007 20:24:54 +0000 (12:24 -0800)]
Makefile: remove $foo when $foo.exe is built/installed.

On Cygwin, newly builtins are not recognized, because there exist both
the executable binaries (with .exe extension) _and_ the now-obsolete
scripts (without extension), but the script is executed.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agosend-email: work around double encoding of in-body From field.
Jürgen Rühle [Wed, 10 Jan 2007 21:36:39 +0000 (13:36 -0800)]
send-email: work around double encoding of in-body From field.

git-send-email sends out the message taken from format-patch
output without quoting nor encoding.  When copying the From:
line to form in-body From: field, it should not copy it
verbatim, because the From: for the header is quoted according
to RFC 2047 when not ASCII.

The original came from Jürgen Rühle, but I moved the
string munging into a separate function so that later other
people can tweak it more easily.  Bugs introduced during the
translation are mine.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoAdd git-init documentation.
Nicolas Pitre [Wed, 10 Jan 2007 17:56:41 +0000 (12:56 -0500)]
Add git-init documentation.

Oops. Commit 515377ea9ec6192f82a2fa5c5b5b7651d9d6cf6c missed one
file, git-init documentation.

Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoFix t1410 for core.filemode==false
Johannes Schindelin [Wed, 10 Jan 2007 12:22:50 +0000 (13:22 +0100)]
Fix t1410 for core.filemode==false

Since c869753e, core.filemode is hardwired to false on Cygwin.
So this test had no chance to succeed, since an early commit
(changing just the filemode) failed, and therefore all subsequent
tests.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoMake git-describe a builtin.
Shawn O. Pearce [Wed, 10 Jan 2007 11:36:36 +0000 (06:36 -0500)]
Make git-describe a builtin.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDon't save the commit buffer in git-describe.
Shawn O. Pearce [Wed, 10 Jan 2007 11:36:29 +0000 (06:36 -0500)]
Don't save the commit buffer in git-describe.

The commit buffer (message of the commit) is not actually
used by the git-describe process.  We can save some memory
by not keeping it around.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoFix warnings in sha1_file.c - use C99 printf format if available
Pavel Roskin [Wed, 10 Jan 2007 04:07:11 +0000 (23:07 -0500)]
Fix warnings in sha1_file.c - use C99 printf format if available

Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years ago-u is now default for 'git-mailinfo'.
Junio C Hamano [Wed, 10 Jan 2007 05:31:36 +0000 (21:31 -0800)]
-u is now default for 'git-mailinfo'.

Originally from David Woodhouse, but also adjusts the callers of
mailinfo to the new default.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years ago-u is now default for 'git-applymbox'
Junio C Hamano [Wed, 10 Jan 2007 05:20:01 +0000 (21:20 -0800)]
-u is now default for 'git-applymbox'

It has '-n' to disable it just in case, but do not even bother
documenting it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-am: should work when "--no-utf8 --utf8" is given
Junio C Hamano [Wed, 10 Jan 2007 05:16:45 +0000 (21:16 -0800)]
git-am: should work when "--no-utf8 --utf8" is given

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDon't die in git-http-fetch when fetching packs.
Shawn O. Pearce [Wed, 10 Jan 2007 01:04:52 +0000 (20:04 -0500)]
Don't die in git-http-fetch when fetching packs.

My sp/mmap changes to pack-check.c modified the function such that
it expects packed_git.pack_size to be populated with the total
bytecount of the packfile by the caller.

But that isn't the case for packs obtained by git-http-fetch as
pack_size was not initialized before being accessed.  This caused
verify_pack to think it had 2^32-21 bytes available when the
downloaded pack perhaps was only 305 bytes in length.  The use_pack
function then later dies with "offset beyond end of packfile"
when computing the overall file checksum.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoUpdate git-svn manpage to remove the implication that SVN::* is optional.
Steven Grimm [Wed, 10 Jan 2007 00:20:17 +0000 (16:20 -0800)]
Update git-svn manpage to remove the implication that SVN::* is optional.

Now that git-svn requires the SVN::* Perl library, the manpage doesn't need
to describe what happens when you don't have it.

Signed-off-by: Steven Grimm <koreth@midwinter.com>
Acked-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoReplacing the system call pread() with lseek()/xread()/lseek() sequence.
Stefan-W. Hahn [Tue, 9 Jan 2007 21:04:12 +0000 (22:04 +0100)]
Replacing the system call pread() with lseek()/xread()/lseek() sequence.

Using cygwin with cygwin.dll before 1.5.22 the system call pread() is buggy.
This patch introduces NO_PREAD. If NO_PREAD is set git uses a sequence of
lseek()/xread()/lseek() to emulate pread.

Signed-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogitweb: Fix git_patchset_body not closing <div class="patch">
Jakub Narebski [Tue, 9 Jan 2007 23:07:43 +0000 (00:07 +0100)]
gitweb: Fix git_patchset_body not closing <div class="patch">

Fix case when git_patchset_body didn't close <div class="patch">,
for patchsets with last patch empty.

This patch also removes some commented out code in git_patchset_body.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Acked-by: Luben Tuikov <ltuikov@yahoo.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit.el: Define the propertize function if needed, for XEmacs compatibility.
Alexandre Julliard [Tue, 9 Jan 2007 20:27:40 +0000 (21:27 +0100)]
git.el: Define the propertize function if needed, for XEmacs compatibility.

Also use `concat' instead of `format' in the pretty-printer since
format doesn't preserve properties under XEmacs.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-clone: Make sure the master branch exists before running cat on it.
Alexandre Julliard [Tue, 9 Jan 2007 20:26:52 +0000 (21:26 +0100)]
git-clone: Make sure the master branch exists before running cat on it.

Otherwise we get an error like this on stderr:

  cat: [...]/.git/refs/remotes/origin/master: No such file or directory

which makes it look like git-clone failed.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-apply: Remove directories that have become empty after deleting a file.
Alexandre Julliard [Tue, 9 Jan 2007 20:25:46 +0000 (21:25 +0100)]
git-apply: Remove directories that have become empty after deleting a file.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoget_tree_entry: map blank requested entry to tree root
Jeff King [Tue, 9 Jan 2007 16:11:47 +0000 (11:11 -0500)]
get_tree_entry: map blank requested entry to tree root

This means that
  git show HEAD:
will now return HEAD^{tree}, which is logically consistent with
  git show HEAD:Documentation

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agobuiltin-archive: do not free a tree held by the object layer.
Junio C Hamano [Tue, 9 Jan 2007 22:07:59 +0000 (14:07 -0800)]
builtin-archive: do not free a tree held by the object layer.

Found by running "git archive --format=tar HEAD" in Documentation/
directory.

It's surprising that nobody has noticed this from the beginning...

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoMerge branch 'maint'
Junio C Hamano [Tue, 9 Jan 2007 20:04:30 +0000 (12:04 -0800)]
Merge branch 'maint'

* maint:
  Fix "Do not ignore a detected patchfile brokenness."
  Do not ignore a detected patchfile brokenness.

17 years agoFix "Do not ignore a detected patchfile brokenness."
Junio C Hamano [Tue, 9 Jan 2007 19:50:53 +0000 (11:50 -0800)]
Fix "Do not ignore a detected patchfile brokenness."

Returning negative value from there does not stop the caller from using
the earlier part.

Noticed by Linus.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoSanitize for_each_reflog_ent()
Johannes Schindelin [Mon, 8 Jan 2007 00:59:54 +0000 (01:59 +0100)]
Sanitize for_each_reflog_ent()

It used to ignore the return value of the helper function; now, it
expects it to return 0, and stops iteration upon non-zero return
values; this value is then passed on as the return value of
for_each_reflog_ent().

Further, it makes no sense to force the parsing upon the helper
functions; for_each_reflog_ent() now calls the helper function with
old and new sha1, the email, the timestamp & timezone, and the message.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDo not ignore a detected patchfile brokenness.
Junio C Hamano [Tue, 9 Jan 2007 10:52:31 +0000 (02:52 -0800)]
Do not ignore a detected patchfile brokenness.

find_header() function is used to read and parse the patchfile
and it detects errors in the patch, but one place ignored the
error and went ahead, which was quite bad.

Noticed by Jeff Garzik.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agomerge-base: do not leak commit list
Junio C Hamano [Tue, 9 Jan 2007 07:10:49 +0000 (23:10 -0800)]
merge-base: do not leak commit list

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoAuto-quote config values in config.c:store_write_pair()
Brian Gernhardt [Tue, 9 Jan 2007 05:27:41 +0000 (00:27 -0500)]
Auto-quote config values in config.c:store_write_pair()

Suggested by Jakub Narebski <jnareb@gmail.com> on the list.

When we send a value to store_write_pair(), make sure that the value
that gets read out matches the one passed in.  This means that for any
value that contains leading or trailing whitespace or any comment
character (# and ;), we need to surround it in quotes.

Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoIgnore git-init and git-remote
Brian Gernhardt [Tue, 9 Jan 2007 05:27:33 +0000 (00:27 -0500)]
Ignore git-init and git-remote

These new commands weren't added to .gitignore.  Add them so we don't
end up with copies of them in the repo.

Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agorm git-rerere.perl -- it is now a built-in.
Junio C Hamano [Tue, 9 Jan 2007 05:52:38 +0000 (21:52 -0800)]
rm git-rerere.perl -- it is now a built-in.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agocvsserver: fix revision number during file adds
Martin Langhoff [Tue, 9 Jan 2007 02:10:41 +0000 (15:10 +1300)]
cvsserver: fix revision number during file adds

With this patch, cvs add / cvs commit echoes back to the client
the correct file version (1.1) so that the file in the checkout
is recognised as up-to-date.

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agocvsserver: detect early of we are up to date and avoid costly rev-list
Martin Langhoff [Tue, 9 Jan 2007 02:10:32 +0000 (15:10 +1300)]
cvsserver: detect early of we are up to date and avoid costly rev-list

if the SHA1 of our head matches the last SHA1 seen in the DB, avoid further
processing.

[jc: an "Oops, please amend" patch rolled in]

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDocumentation: add git-remote man page
J. Bruce Fields [Tue, 9 Jan 2007 04:28:51 +0000 (23:28 -0500)]
Documentation: add git-remote man page

Add a preliminary man page for git-remote.

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoMerge branch 'jc/reflog'
Junio C Hamano [Mon, 8 Jan 2007 23:56:51 +0000 (15:56 -0800)]
Merge branch 'jc/reflog'

* jc/reflog:
  reflog --fix-stale: do not check the same trees and commits repeatedly.
  reflog expire --fix-stale
  Move traversal of reachable objects into a separate library.
  builtin-prune: separate ref walking from reflog walking.
  builtin-prune: make file-scope static struct to an argument.

17 years agoshort i/o: fix config updates to use write_in_full
Andy Whitcroft [Mon, 8 Jan 2007 15:58:38 +0000 (15:58 +0000)]
short i/o: fix config updates to use write_in_full

We need to check that the writes we perform during the update of
the users configuration work.  Convert to using write_in_full().

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoshort i/o: fix calls to write to use xwrite or write_in_full
Andy Whitcroft [Mon, 8 Jan 2007 15:58:23 +0000 (15:58 +0000)]
short i/o: fix calls to write to use xwrite or write_in_full

We have a number of badly checked write() calls.  Often we are
expecting write() to write exactly the size we requested or fail,
this fails to handle interrupts or short writes.  Switch to using
the new write_in_full().  Otherwise we at a minimum need to check
for EINTR and EAGAIN, where this is appropriate use xwrite().

Note, the changes to config handling are much larger and handled
in the next patch in the sequence.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoshort i/o: fix calls to read to use xread or read_in_full
Andy Whitcroft [Mon, 8 Jan 2007 15:58:08 +0000 (15:58 +0000)]
short i/o: fix calls to read to use xread or read_in_full

We have a number of badly checked read() calls.  Often we are
expecting read() to read exactly the size we requested or fail, this
fails to handle interrupts or short reads.  Add a read_in_full()
providing those semantics.  Otherwise we at a minimum need to check
for EINTR and EAGAIN, where this is appropriate use xread().

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoshort i/o: clean up the naming for the write_{in,or}_xxx family
Andy Whitcroft [Mon, 8 Jan 2007 15:57:52 +0000 (15:57 +0000)]
short i/o: clean up the naming for the write_{in,or}_xxx family

We recently introduced a write_in_full() which would either write
the specified object or emit an error message and fail.  In order
to fix the read side we now want to introduce a read_in_full()
but without an error emit.  This patch cleans up the naming
of this family of calls:

1) convert the existing write_or_whine() to write_or_whine_pipe()
   to better indicate its pipe specific nature,
2) convert the existing write_in_full() calls to write_or_whine()
   to better indicate its nature,
3) introduce a write_in_full() providing a write or fail semantic,
   and
4) convert write_or_whine() and write_or_whine_pipe() to use
   write_in_full().

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years ago--prune is now default for 'pack-refs'
Junio C Hamano [Mon, 8 Jan 2007 22:40:33 +0000 (14:40 -0800)]
--prune is now default for 'pack-refs'

There is no reason not to, really.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years ago--utf8 is now default for 'git-am'
Junio C Hamano [Mon, 8 Jan 2007 21:59:15 +0000 (13:59 -0800)]
--utf8 is now default for 'git-am'

Since we are talking about allowing potentially incompatible UI
changes in v1.5.0 iff the change improves the general situation,
I would say why not.

There is --no-utf8 flag to avoid re-coding from botching the log
message just in case, but we may not even need it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-commit: do not fail to print the diffstat even if there is a file named HEAD
Michael Loeffler [Mon, 8 Jan 2007 19:23:13 +0000 (20:23 +0100)]
git-commit: do not fail to print the diffstat even if there is a file named HEAD

Signed-off-by: Michael Loeffler <zvpunry@zvpunry.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agossh-upload: prevent buffer overrun
Andy Whitcroft [Mon, 8 Jan 2007 11:45:44 +0000 (11:45 +0000)]
ssh-upload: prevent buffer overrun

Prevent a client from overrunning the on stack ref buffer.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agocvsimport: cleanup temporary cvsps file
Martin Langhoff [Mon, 8 Jan 2007 08:08:46 +0000 (21:08 +1300)]
cvsimport: cleanup temporary cvsps file

It is bad manners to leave these sizable files
around when we are done with them.

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agocvsimport: document -S and -L options
Martin Langhoff [Mon, 8 Jan 2007 06:53:03 +0000 (19:53 +1300)]
cvsimport: document -S and -L options

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agocvsimport: skip commits that are too recent (option and documentation)
Martin Langhoff [Mon, 8 Jan 2007 06:43:39 +0000 (19:43 +1300)]
cvsimport: skip commits that are too recent (option and documentation)

This makes the earlier "wait for 10 minutes before importing" safety
overridable with "-a(ll)" flag, and adds necessary documentation.

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svn: pass an unambiguous ref to rev-list when grafting-branches
Eric Wong [Mon, 8 Jan 2007 03:35:41 +0000 (19:35 -0800)]
git-svn: pass an unambiguous ref to rev-list when grafting-branches

Some users apparently create local heads with the same basename
as the remote branch they're tracking.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svn: add --prefix= option to multi-init
Eric Wong [Mon, 8 Jan 2007 03:35:40 +0000 (19:35 -0800)]
git-svn: add --prefix= option to multi-init

Also, document --{trunk,branches,tags} options while we're
documenting multi-init options.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDocumentation: clarify definition of "reachable"
J. Bruce Fields [Mon, 8 Jan 2007 00:25:35 +0000 (19:25 -0500)]
Documentation: clarify definition of "reachable"

Clarify definition of "reachable" (what chain?)

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svnimport: fix edge revisions double importing
Sasha Khapyorsky [Mon, 8 Jan 2007 02:22:42 +0000 (04:22 +0200)]
git-svnimport: fix edge revisions double importing

This fixes newly introduced bug when the incremental cycle edge revisions
are imported twice.

Signed-off-by: Sasha Khapyorsky <sashak@voltaire.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agocvsimport: skip commits that are too recent
Martin Langhoff [Mon, 8 Jan 2007 01:11:23 +0000 (14:11 +1300)]
cvsimport: skip commits that are too recent

With this patch, cvsimport will skip commits made
in the last 10 minutes. The recent-ness test is of
5 minutes + cvsps fuzz window (5 minutes default).

When working with a CVS repository that is in use,
importing commits that are too recent can lead to
partially incorrect trees. This is mainly due to

 - Commits that are within the cvsps fuzz window may later
   be found to have affected more files.

 - When performing incremental imports, clock drift between
   the systems may lead to skipped commits.

This commit helps keep incremental imports of in-use
CVS repositories sane.

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogitweb: Remove superfluous "|" in "commit" view
Jakub Narebski [Mon, 8 Jan 2007 01:10:42 +0000 (02:10 +0100)]
gitweb: Remove superfluous "|" in "commit" view

Remove superfluous trailing "|" separator from difftree part of "commit"
view for new files (created in given commit).

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoRemove unnecessary git-rm --cached reference from status output
Jürgen Rühle [Sun, 7 Jan 2007 19:18:26 +0000 (20:18 +0100)]
Remove unnecessary git-rm --cached reference from status output

Since git-reset has learned restoring the absence of paths git-rm --cached is
no longer necessary. Therefore remove it from the cached content header hint.

Also remove the unfortunate wording 'Cached' from the header itself.

Signed-off-by: Jürgen Rühle <j-r@online.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years ago"init-db" can really be just "init"
Nicolas Pitre [Sun, 7 Jan 2007 17:31:29 +0000 (12:31 -0500)]
"init-db" can really be just "init"

Make "init" the equivalent of "init-db". This should make first GIT
impression a little more friendly.

Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoMerge branch 'sp/mmap'
Junio C Hamano [Sun, 7 Jan 2007 08:12:47 +0000 (00:12 -0800)]
Merge branch 'sp/mmap'

* sp/mmap: (27 commits)
  Spell default packedgitlimit slightly differently
  Increase packedGit{Limit,WindowSize} on 64 bit systems.
  Update packedGit config option documentation.
  mmap: set FD_CLOEXEC for file descriptors we keep open for mmap()
  pack-objects: fix use of use_pack().
  Fix random segfaults in pack-objects.
  Cleanup read_cache_from error handling.
  Replace mmap with xmmap, better handling MAP_FAILED.
  Release pack windows before reporting out of memory.
  Default core.packdGitWindowSize to 1 MiB if NO_MMAP.
  Test suite for sliding window mmap implementation.
  Create pack_report() as a debugging aid.
  Support unmapping windows on 'temporary' packfiles.
  Improve error message when packfile mmap fails.
  Ensure core.packedGitWindowSize cannot be less than 2 pages.
  Load core configuration in git-verify-pack.
  Fully activate the sliding window pack access.
  Unmap individual windows rather than entire files.
  Document why header parsing won't exceed a window.
  Loop over pack_windows when inflating/accessing data.
  ...

Conflicts:

cache.h
pack-check.c

17 years agoSpell default packedgitlimit slightly differently
Junio C Hamano [Sun, 7 Jan 2007 08:11:11 +0000 (00:11 -0800)]
Spell default packedgitlimit slightly differently

This is shorter and easier to read, and also makes sure the
constant expression does not overflow integer range.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoMerge branch 'jr/status'
Junio C Hamano [Sun, 7 Jan 2007 07:49:24 +0000 (23:49 -0800)]
Merge branch 'jr/status'

* jr/status:
  Improve cached content header of status output
  Support --amend on initial commit in status output
  Improve "nothing to commit" part of status output
  Clarify syntax and role of git-add in status output

17 years agoMerge branch 'jc/remote'
Junio C Hamano [Sun, 7 Jan 2007 07:49:16 +0000 (23:49 -0800)]
Merge branch 'jc/remote'

* jc/remote:
  git-remote

17 years agogit-reset <tree> -- <path> restores absense of <path> in <tree>
Junio C Hamano [Fri, 5 Jan 2007 09:38:56 +0000 (01:38 -0800)]
git-reset <tree> -- <path> restores absense of <path> in <tree>

When <path> exists in the index (either merged or unmerged), and
<tree> does not have it, git-reset should be usable to restore
the absense of it from the tree.  This implements it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agodiff-index --cached --raw: show tree entry on the LHS for unmerged entries.
Junio C Hamano [Fri, 5 Jan 2007 09:25:18 +0000 (01:25 -0800)]
diff-index --cached --raw: show tree entry on the LHS for unmerged entries.

This updates the way diffcore represents an unmerged pair
somewhat.  It used to be that entries with mode=0 on both sides
were used to represent an unmerged pair, but now it has an
explicit flag.  This is to allow diff-index --cached to report
the entry from the tree when the path is unmerged in the index.

This is used in updating "git reset <tree> -- <path>" to restore
absense of the path in the index from the tree.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoreflog --fix-stale: do not check the same trees and commits repeatedly.
Junio C Hamano [Sun, 7 Jan 2007 06:32:41 +0000 (22:32 -0800)]
reflog --fix-stale: do not check the same trees and commits repeatedly.

Since we use the reachability tracking machinery now, we should
keep the already checked trees and commits whose completeness is
known, to avoid checking the same thing over and over again.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoreflog expire --fix-stale
Junio C Hamano [Sat, 6 Jan 2007 10:16:19 +0000 (02:16 -0800)]
reflog expire --fix-stale

The logic in an earlier round to detect reflog entries that
point at a broken commit was not sufficient.  Just like we do
not trust presense of a commit during pack transfer (we trust
only our refs), we should not trust a commit's presense, even if
the tree of that commit is complete.

A repository that had reflog enabled on some of the refs that
was rewound and then run git-repack or git-prune from older
versions of git can have reflog entries that point at a commit
that still exist but lack commits (or trees and blobs needed for
that commit) between it and some commit that is reachable from
one of the refs.

This revamps the logic -- the definition of "broken commit"
becomes: a commit that is not reachable from any of the refs and
there is a missing object among the commit, tree, or blob
objects reachable from it that is not reachable from any of the
refs.  Entries in the reflog that refer to such a commit are
expired.

Since this computation involves traversing all the reachable
objects, i.e. it has the same cost as 'git prune', it is enabled
only when a new option --fix-stale.  Fortunately, once this is
run, we should not have to ever worry about missing objects,
because the current prune and pack-objects know about reflogs
and protect objects referred by them.

Unfortunately, this will be absolutely necessary to help people
migrate to the newer prune and repack.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoMove traversal of reachable objects into a separate library.
Junio C Hamano [Sat, 6 Jan 2007 10:16:17 +0000 (02:16 -0800)]
Move traversal of reachable objects into a separate library.

This moves major part of builtin-prune into a separate file,
reachable.c.  It is used to mark the objects that are reachable
from refs, and optionally from reflogs.

The patch looks very large, but if you look at it with diff -C,
which this message is formatted in, most of them are copied
lines and there are very little additions.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agobuiltin-prune: separate ref walking from reflog walking.
Junio C Hamano [Sat, 6 Jan 2007 10:16:14 +0000 (02:16 -0800)]
builtin-prune: separate ref walking from reflog walking.

This is necessary for the next step, because the reason I am
making the connectivity walker into a library is because I want
to use it for cleaning up stale reflog entries.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agobuiltin-prune: make file-scope static struct to an argument.
Junio C Hamano [Sat, 6 Jan 2007 10:16:10 +0000 (02:16 -0800)]
builtin-prune: make file-scope static struct to an argument.

I want to make the first part of 'git prune' that marks the
reachable objects callable as a library, so this starts the
first step toward the goal by making the callchain to pass
rev_info structure as an argument.

No functionality change should be in this step.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogitweb: Fix split patches output (e.g. file to symlink)
Jakub Narebski [Sun, 7 Jan 2007 01:52:27 +0000 (02:52 +0100)]
gitweb: Fix split patches output (e.g. file to symlink)

Do not replace /dev/null in two-line from-file/to-file diff header for
split patches ("split" patch mean more than one patch per one
diff-tree raw line) by a/file or b/file link.

Split patches differ from pair of deletion/creation patch in git diff
header: both a/file and b/file are hyperlinks, in all patches in a
split.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoRevert "gitweb: There can be empty patches (in git_patchset_body)"
Jakub Narebski [Sun, 7 Jan 2007 01:52:26 +0000 (02:52 +0100)]
Revert "gitweb: There can be empty patches (in git_patchset_body)"

This reverts commit 1ebb948f656c03a5bdaab4de1a113b9ffcb98bea,
as that patch quieted warning but was not proper solution.
The previous commit was.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogitweb: Fix errors in git_patchset_body for empty patches
Jakub Narebski [Sun, 7 Jan 2007 01:52:25 +0000 (02:52 +0100)]
gitweb: Fix errors in git_patchset_body for empty patches

We now do not skip over empty patches in git_patchset_body (where
empty means that they consist only of git diff header, and of extended
diff header, for example "pure rename" patch).  This means that after
extended diff header there can be next patch (i.e. /^diff /) or end of
patchset, and not necessary patch body (i.e. /^--- /).

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogitweb: Fix error in "rename to"/"copy to" git diff header output
Jakub Narebski [Sun, 7 Jan 2007 01:52:24 +0000 (02:52 +0100)]
gitweb: Fix error in "rename to"/"copy to" git diff header output

Fix error in git_patchset_body subroutine, which caused "rename to"/"copy
to" line in extended diff header to be displayed incorrectly.

While at it, fix align.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogitweb: Fix error in git_patchest_body for file creation/deletion patch
Jakub Narebski [Sun, 7 Jan 2007 01:52:23 +0000 (02:52 +0100)]
gitweb: Fix error in git_patchest_body for file creation/deletion patch

$from_id, $to_id variables should be local per PATCH.

Fix error in git_patchset_body for file creation (deletion) patches,
where instead of /dev/null as from-file (to-file) diff header line, it
had link to previous file with current file name.  This error occured
only if there was another patch before file creation (deletion) patch.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svn: fix show-ignore
Eric Wong [Sun, 7 Jan 2007 06:25:55 +0000 (22:25 -0800)]
git-svn: fix show-ignore

Looks like I broke it in 747fa12cef73b6ca04fffaddaad7326cf546cdea
but never noticed.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDocumentation: tutorial editing
J. Bruce Fields [Sun, 7 Jan 2007 03:38:38 +0000 (22:38 -0500)]
Documentation: tutorial editing

Edit for conciseness.

Add a "Making changes" section header.

When possible, make sure that stuff in text boxes could be entered literally.
(Don't use "..." unless we want a user to type that.)

Move 'commit -a' example into a literal code section, clarify that it finds
modified files automatically.

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDocumentation/git-svn: clarify dcommit, rebase vs pull/merge
Eric Wong [Sun, 7 Jan 2007 01:53:40 +0000 (17:53 -0800)]
Documentation/git-svn: clarify dcommit, rebase vs pull/merge

Clarify that dcommit creates a revision in SVN for every commit
in git.  Also, add 'merge' to the rebase vs pull section because
git-merge is now a first-class UI.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svnimport: clean svn path when accessing SVN repo
Sasha Khapyorsky [Sun, 7 Jan 2007 00:22:10 +0000 (02:22 +0200)]
git-svnimport: clean svn path when accessing SVN repo

Clean svn path from leading '/' when accessing SVN repo.

Signed-off-by: Sasha Khapyorsky <sashak@voltaire.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svnimport: support for incremental import
Sasha Khapyorsky [Sun, 7 Jan 2007 00:17:19 +0000 (02:17 +0200)]
git-svnimport: support for incremental import

This adds ability to do import "in chunks" (default 1000 revisions),
after each chunk git repo will be repacked. The option -R is used to
change default value of chunk size (or how often repository will
repacked).

Signed-off-by: Sasha Khapyorsky <sashak@voltaire.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit.el: Avoid setting font lock keywords before entering log-edit mode.
Alexandre Julliard [Sat, 6 Jan 2007 13:46:47 +0000 (14:46 +0100)]
git.el: Avoid setting font lock keywords before entering log-edit mode.

Instead, reinitialize the keywords after the fact. This avoids
conflicts with other users of log-edit mode, like pcl-cvs.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoinstaweb: Nicer error message when the http daemon isn't found
Fredrik Kuivinen [Sat, 6 Jan 2007 10:40:06 +0000 (11:40 +0100)]
instaweb: Nicer error message when the http daemon isn't found

Signed-off-by: Fredrik Kuivinen <frekui@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit.el: Don't use --info-only when resolving a file.
Alexandre Julliard [Sat, 6 Jan 2007 10:20:57 +0000 (11:20 +0100)]
git.el: Don't use --info-only when resolving a file.

It doesn't make a difference for git.el, but it helps when interacting
with git-rebase and friends.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-clean: Fix the -q option.
Alexandre Julliard [Sat, 6 Jan 2007 10:19:44 +0000 (11:19 +0100)]
git-clean: Fix the -q option.

The 'quiet' flag is set by -q, but it's not used anywhere.
Remove it and set the 'echo1' variable instead.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoPrint a more accurate error message when we fail to create a lock file.
Steven Grimm [Sat, 6 Jan 2007 03:14:04 +0000 (19:14 -0800)]
Print a more accurate error message when we fail to create a lock file.

Signed-off-by: Steven Grimm <koreth@midwinter.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoDescribe git-clone's actual behavior in the summary
Steven Grimm [Sat, 6 Jan 2007 01:52:20 +0000 (17:52 -0800)]
Describe git-clone's actual behavior in the summary

If a branch other than "master" is checked out in the origin repository,
git-clone makes a local copy of that branch rather than the origin's
"master"
branch. This patch describes the actual behavior.

Signed-off-by: Steven Grimm <koreth@midwinter.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoSet default "tar" umask to 002 and owner.group to root.root
René Scharfe [Fri, 5 Jan 2007 22:30:22 +0000 (23:30 +0100)]
Set default "tar" umask to 002 and owner.group to root.root

In order to make the generated tar files more friendly to users who
extract them as root using GNU tar and its implied -p option, change
the default umask to 002 and change the owner name and group name to
root.  This ensures that a) the extracted files and directories are
not world-writable and b) that they belong to user and group root.

Before they would have been assigned to a user and/or group named
git if it existed.  This also answers the question in the removed
comment: uid=0, gid=0, uname=root, gname=root is exactly what we
want.

Normal users who let tar apply their umask while extracting are
only affected if their umask allowed the world to change their
files (e.g. a umask of zero).  This case is so unlikely and strange
that we don't need to support it.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoIncrease packedGit{Limit,WindowSize} on 64 bit systems.
Shawn O. Pearce [Fri, 5 Jan 2007 03:28:08 +0000 (22:28 -0500)]
Increase packedGit{Limit,WindowSize} on 64 bit systems.

If we have a 64 bit address space we can easily afford to commit
a larger amount of virtual address space to pack file access.
So on these platforms we should increase the default settings of
core.packedGit{Limit,WindowSize} to something that will better
handle very large projects.

Thanks to Andy Whitcroft for pointing out that we can safely
increase these defaults on such systems.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoFix timestamp for test-tick
Junio C Hamano [Sat, 6 Jan 2007 10:16:07 +0000 (02:16 -0800)]
Fix timestamp for test-tick

The earlier test timestamp was too old; I forgot that the bare
unixtime integer had to be after Jan 1, 2000.  This changes
test_tick to use the git-epoch timestamp.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agobuiltin-prune: memory diet.
Junio C Hamano [Fri, 5 Jan 2007 21:31:43 +0000 (13:31 -0800)]
builtin-prune: memory diet.

Somehow we forgot to turn save_commit_buffer off while walking
the reachable objects.  Releasing the memory for commit object
data that we do not use matters for large projects (for example,
about 90MB is saved while traversing linux-2.6 history).

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-remote
Junio C Hamano [Wed, 3 Jan 2007 20:13:04 +0000 (12:13 -0800)]
git-remote

It might be handy to have a single command that helps you manage
your configuration that relates to downloading from remote
repositories.  This currently does only about 20% of what I want
it to do.

$ git remote

shows the list of 'remotes' you have defined somewhere, and

$ git remote origin

shows the details about the named remote (in this case
"origin").  How the branches are tracked, if you have a
tracking branch that is stale, etc.

$ git add another git://git.kernel.org/pub/...

defines the default remote.another.url and remote.another.fetch
entries just like a clone does; you can say "git fetch another"
afterwards.

For it to be useful, I think it should be enhanced to:

 - check overlaps of tracking branches and warn;

 - offer to remove stale tracking branches in one go;

 - offer ways to remove or rename remote;

 - offer ways to update an existing remote, perhaps have an
   interactive mode;

Other enhancements might be also possible, but I do not think of
anything that is absolutely necessary other than the above right
now.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoBlame "linenr" link jumps to previous state at "orig_lineno"
Luben Tuikov [Fri, 5 Jan 2007 02:37:45 +0000 (18:37 -0800)]
Blame "linenr" link jumps to previous state at "orig_lineno"

Blame currently displays the commit id which introduced a
block of one or more lines, the line numbers wrt the current
listing of the file and the file's line contents.

The commit id displayed is hyperlinked to the commit.

Currently the linenr links are hyperlinked to the same
commit id displayed to the left, which is _no_ different
than the block of lines displayed, since it is the _same
commit_ that is hyperlinked.  And thus clicking on it leads
to the same state of the file for that chunk of
lines. I.e. data mining is not currently possible with
gitweb given a chunk of lines introduced by a commit.

This patch makes such data mining possible.

The line numbers are now hyperlinked to the parent of the
commit id of the block of lines.  Furthermore they are
linked to the line where that block was introduced.

Thus clicking on a linenr link will show you the file's
line(s) state prior to the commit id you were viewing.

So clicking continually on a linenr link shows you how this
line and its line number changed over time, leading to the
initial commit where it was first introduced.

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogitweb: Fix "Use of uninitialized value" warning in git_tags_body
Jakub Narebski [Wed, 3 Jan 2007 21:54:29 +0000 (22:54 +0100)]
gitweb: Fix "Use of uninitialized value" warning in git_tags_body

Fix "Use of uninitialized value" warning in git_tags_body generated
for lightweight tags of tree and blob object; those don't have age
($tag{'age'}) defined.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svn: make --repack work consistently between fetch and multi-fetch
Eric Wong [Fri, 5 Jan 2007 02:09:56 +0000 (18:09 -0800)]
git-svn: make --repack work consistently between fetch and multi-fetch

Since fetch reforks itself at most every 1000 revisions, we
need to update the counter in the parent process to have a
working count if we set our repack interval to be > ~1000
revisions.  multi-fetch has always done this correctly
because of an extra process; now fetch uses the extra process;
as well.

While we're at it, only compile the $sha1 regex that checks for
repacking once.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svn: update documentation for multi-{init|fetch}
Eric Wong [Fri, 5 Jan 2007 02:04:06 +0000 (18:04 -0800)]
git-svn: update documentation for multi-{init|fetch}

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-svn: make multi-init less confusing
Eric Wong [Fri, 5 Jan 2007 02:02:00 +0000 (18:02 -0800)]
git-svn: make multi-init less confusing

It now requires at least one of the (trunk|branch|tags) arguments
(either from the command-line or in .git/config).  Also we make
sure that anything that is passed as a URL ('help') in David's
case is actually a URL.

Thanks to David Kågedal for reporting this issue.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoRemove shadowing variable from traverse_trees()
René Scharfe [Thu, 4 Jan 2007 18:33:36 +0000 (19:33 +0100)]
Remove shadowing variable from traverse_trees()

The variable named entry is allocated using malloc() and then
forgotten, it being shadowed by an automatic variable of the
same name.  Fixing the array size at 3 worked so far because
the only caller of traverse_trees() needed only as much
entries.  Simply remove the shadowing varaible and we're able
to traverse more than three trees and save stack space at the
same time!

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoMake check target depend on common-cmds.h
René Scharfe [Thu, 4 Jan 2007 18:33:48 +0000 (19:33 +0100)]
Make check target depend on common-cmds.h

This fixes sparse complaining about a missing include file
if 'make check' is run on clean sources.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agorerere: Fix removal of already resolved path.
Junio C Hamano [Thu, 4 Jan 2007 08:06:50 +0000 (00:06 -0800)]
rerere: Fix removal of already resolved path.

There was an obvious thinko in memmove() to remove an entry that
was resolved from the in-core data structure.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agoMerge branch 'maint'
Junio C Hamano [Fri, 5 Jan 2007 06:28:21 +0000 (22:28 -0800)]
Merge branch 'maint'

* maint:
  pack-check.c::verify_packfile(): don't run SHA-1 update on huge data
  Fix infinite loop when deleting multiple packed refs.

17 years agopack-check.c::verify_packfile(): don't run SHA-1 update on huge data v1.4.4.4
Junio C Hamano [Thu, 4 Jan 2007 07:09:08 +0000 (23:09 -0800)]
pack-check.c::verify_packfile(): don't run SHA-1 update on huge data

Running the SHA1_Update() on the whole packfile in a single call
revealed an overflow problem we had in the SHA-1 implementation
on POWER architecture some time ago, which was fixed with commit
b47f509b (June 19, 2006).  Other SHA-1 implementations may have
a similar problem.

The sliding mmap() series already makes chunked calls to
SHA1_Update(), so this patch itself will become moot when it
graduates to "master", but in the meantime, run the hash
function in smaller chunks to prevent possible future problems.

Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogitweb: Fix shortlog only showing HEAD revision.
Robert Fitzsimons [Wed, 3 Jan 2007 20:25:55 +0000 (20:25 +0000)]
gitweb: Fix shortlog only showing HEAD revision.

My change in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6 had a small bug
found by Michael Krufky which caused the passed in hash value to be
ignored, so shortlog would only show the HEAD revision.

Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
17 years agogit-verify-tag: make sure we remove temporary file.
Junio C Hamano [Wed, 3 Jan 2007 20:34:20 +0000 (12:34 -0800)]
git-verify-tag: make sure we remove temporary file.

Signed-off-by: Junio C Hamano <junkio@cox.net>