Simon McVittie [Sun, 21 Dec 2008 10:17:45 +0000 (10:17 +0000)]
Merge commit 'origin/comments' into comments-joey
Simon McVittie [Sun, 21 Dec 2008 10:16:58 +0000 (10:16 +0000)]
todo/comments: Properly escape inline HTML
Simon McVittie [Sun, 21 Dec 2008 10:11:48 +0000 (10:11 +0000)]
todo/comments: reorganise by status
Simon McVittie [Sun, 21 Dec 2008 10:08:53 +0000 (10:08 +0000)]
comments: note fixed things and recommend merging origin/comments
http://smcv.pseudorandom.co.uk/ [Sun, 21 Dec 2008 09:31:49 +0000 (04:31 -0500)]
fix markdown
Joey Hess [Sun, 21 Dec 2008 06:52:08 +0000 (01:52 -0500)]
meta: Process meta date during scan pass so that the date will always affect sorting in inlines.
Joey Hess [Sun, 21 Dec 2008 06:41:00 +0000 (01:41 -0500)]
analysis
Joey Hess [Sun, 21 Dec 2008 06:04:19 +0000 (01:04 -0500)]
comment layout change
I saw a layout similar to this on blogger, and I sorta like it
The dash avoids parens sitting next to each other in some cases.
Joey Hess [Sun, 21 Dec 2008 06:04:03 +0000 (01:04 -0500)]
Merge branch 'master' into comments
http://dtrt.org/ [Sun, 21 Dec 2008 03:28:20 +0000 (22:28 -0500)]
Response; added shell code and html formating to reproduction steps
Joey Hess [Sun, 21 Dec 2008 01:55:38 +0000 (20:55 -0500)]
avoid storing transient state in pagestate
None of the comment state needs to be stored through the a later run of
ikiwiki, so move it all from pagestate to a more transient storage.
This is assuming that we'll never want to add pagespecs to search against
the comment state. Pagespecs like author() are why the meta plugin does
store its meta data in pagestate -- the data can be needed later to match
against.
Joey Hess [Sun, 21 Dec 2008 01:27:42 +0000 (20:27 -0500)]
response
http://dtrt.org/ [Sun, 21 Dec 2008 00:36:15 +0000 (19:36 -0500)]
Sort paramater not a problem; Revised steps to reprodce
Joey Hess [Sat, 20 Dec 2008 23:51:09 +0000 (18:51 -0500)]
alternate idea
Joey Hess [Sat, 20 Dec 2008 23:46:56 +0000 (18:46 -0500)]
remove signin icons, use title
Joey Hess [Sat, 20 Dec 2008 23:36:16 +0000 (18:36 -0500)]
tweak author display
Put the icon after the name, mostly because it scans better on
non-graphical browsers where the alt text is displayed. And because the
name is really the more important part.
Joey Hess [Sat, 20 Dec 2008 23:30:14 +0000 (18:30 -0500)]
my try at improving comment styling
Makes it look more like a blog, but not enough to be confusing, and with
nothing as large as in a blog. Removal of the vertical line under the
subject imho makes it easier to scan through comments as each box is a new
one. Bolding the subject seems to make it stand out enough, especially as
its a link now. (Also considered increasing its font size to 110%.)
Joey Hess [Sat, 20 Dec 2008 23:18:19 +0000 (18:18 -0500)]
note new bug
Joey Hess [Sat, 20 Dec 2008 23:14:49 +0000 (18:14 -0500)]
response
Joey Hess [Sat, 20 Dec 2008 23:07:45 +0000 (18:07 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
http://dtrt.org/ [Sat, 20 Dec 2008 23:06:21 +0000 (18:06 -0500)]
Workaround and possible cause
Joey Hess [Sat, 20 Dec 2008 22:58:56 +0000 (17:58 -0500)]
Merge commit 'smcv/comments'
Joey Hess [Sat, 20 Dec 2008 22:58:01 +0000 (17:58 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
http://smcv.pseudorandom.co.uk/ [Sat, 20 Dec 2008 18:03:44 +0000 (13:03 -0500)]
Simon McVittie [Sat, 20 Dec 2008 17:39:55 +0000 (17:39 +0000)]
comment.tmpl: make anon/OpenID/signed-in icons independent of smileys
Simon McVittie [Thu, 18 Dec 2008 20:28:41 +0000 (20:28 +0000)]
comments_display: display (?) for anon users, {x} for OpenIDs and {*} for local logins
This is a mockup of Joey's idea; to do it properly, the icons should
move to the basewiki or to a comments underlay, and {x} should be
replaced with an OpenID logo (if one with clear licensing even exists).
Simon McVittie [Thu, 18 Dec 2008 20:01:08 +0000 (20:01 +0000)]
comments: Rename COMMENTURL to ADDCOMMENTURL to avoid confusion with COMMENTAUTHORURL
Also refactor page.tmpl to use if/else rather than unless/if.
Simon McVittie [Thu, 18 Dec 2008 19:57:25 +0000 (19:57 +0000)]
comments: pass COMMENTOPENID to templates
Simon McVittie [Thu, 18 Dec 2008 19:57:03 +0000 (19:57 +0000)]
comments: remove linkuser(), it's been integrated into preprocess() now
Simon McVittie [Thu, 18 Dec 2008 19:56:36 +0000 (19:56 +0000)]
_comment directive: if the user looks like an OpenID, store that
Joey Hess [Sat, 20 Dec 2008 16:30:48 +0000 (11:30 -0500)]
haskell
Joey Hess [Sat, 20 Dec 2008 16:04:45 +0000 (11:04 -0500)]
note
brush [Sat, 20 Dec 2008 10:58:00 +0000 (05:58 -0500)]
minor edits
brush [Sat, 20 Dec 2008 10:56:04 +0000 (05:56 -0500)]
added details on cgi wrapper creation
http://weakish.int.eu.org/ [Sat, 20 Dec 2008 09:20:58 +0000 (04:20 -0500)]
initial page
http://weakish.int.eu.org/ [Sat, 20 Dec 2008 09:18:56 +0000 (04:18 -0500)]
vimperator can do this, too.
Joey Hess [Fri, 19 Dec 2008 22:57:09 +0000 (17:57 -0500)]
avoid uninitialized value
This can happen when a new field,
such as the new lasttry, is added.
Joey Hess [Fri, 19 Dec 2008 22:33:40 +0000 (17:33 -0500)]
fix comment permalink to always point to comment parent page
Joey Hess [Fri, 19 Dec 2008 22:26:41 +0000 (17:26 -0500)]
update
Joey Hess [Fri, 19 Dec 2008 22:07:54 +0000 (17:07 -0500)]
typos
Joey Hess [Fri, 19 Dec 2008 19:29:54 +0000 (14:29 -0500)]
simplify and compact the comment edit form
Mostly to make it more visually similar to the page edit form.
I'm a bit uncertian about the placement of the page type selector,
and about removing the "Page type". May rethink that.
Joey Hess [Fri, 19 Dec 2008 19:21:48 +0000 (14:21 -0500)]
remove 'signed in as foo'
I think users should know who they're signed in as; the edit pages don't
say so there's no reason to here. Also, the user id was not displayed
pretty.
Joey Hess [Fri, 19 Dec 2008 19:20:07 +0000 (14:20 -0500)]
add link from comment subject to its permalink
Joey Hess [Fri, 19 Dec 2008 19:14:20 +0000 (14:14 -0500)]
fiddle with comment css classes
Joey Hess [Fri, 19 Dec 2008 19:09:39 +0000 (14:09 -0500)]
remove cruft
wtf does it do? absolutely nothing
Joey Hess [Fri, 19 Dec 2008 19:07:22 +0000 (14:07 -0500)]
rename comments_form to editcomment
Joey Hess [Fri, 19 Dec 2008 19:03:26 +0000 (14:03 -0500)]
rename comments_display to comment
Joey Hess [Fri, 19 Dec 2008 18:55:41 +0000 (13:55 -0500)]
replace discussion links on pages with comments link
The thinking here is that having both a Discussion page and comments for
the same page is redundant, and certianly not what you want if you enable
comments for a page. At first I considered making configurable via pagespec
what pages got discussion links. But that would mean testing a new pagespec
for every page, and a redundant config setting to keep in sync. So intead,
take a lead from my previous change to make inlined pages have a comments
link, and change the discussion link at the top of regular pages to link to
their comments.
(Implementation is a bit optimised to avoid redundant pagespec checking.)
Víctor Moral [Fri, 19 Dec 2008 07:32:01 +0000 (08:32 +0100)]
updated spanish translation
Joey Hess [Fri, 19 Dec 2008 01:58:16 +0000 (20:58 -0500)]
jump to comment after posting
Jumping to the just posted comment was the imputus, but I killed a number
of birds here.
Added a INLINEPAGE template variable, which can be used to add anchors to
any inline template.
To keep that sufficiently general, it is the full page name, so the
comment anchors and links changed form.
Got rid of the FIXMEd hardcoded html anchor div.
More importantly, the anchor is now to the very top of the comment, not the
text below. So you can see the title, and how it attributes you.
Avoid changing the permalink of pages that are not really comments, but
happen to contain the _comment directive. I think that behavior was a bug,
though not a likely one to occur since _comment should only really be used
on comment pages.
Joey Hess [Fri, 19 Dec 2008 01:20:42 +0000 (20:20 -0500)]
document how to make a global comments feed
Joey Hess [Fri, 19 Dec 2008 01:10:42 +0000 (20:10 -0500)]
responses
Joey Hess [Thu, 18 Dec 2008 23:00:03 +0000 (18:00 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
smcv@ [Thu, 18 Dec 2008 21:08:33 +0000 (21:08 +0000)]
Update todo/comments with today's fixes, and thoughts about the remaining items
Joey Hess [Thu, 18 Dec 2008 19:49:24 +0000 (14:49 -0500)]
clarify
justin [Thu, 18 Dec 2008 19:20:59 +0000 (14:20 -0500)]
Joey Hess [Thu, 18 Dec 2008 17:53:47 +0000 (12:53 -0500)]
pagespec thoughts
Joey Hess [Thu, 18 Dec 2008 17:32:23 +0000 (12:32 -0500)]
note about comments feed
Joey Hess [Thu, 18 Dec 2008 02:27:28 +0000 (21:27 -0500)]
aggregate: If a feed fails to be downloaded, try again immediatly next time aggregation is run, even if the usual time has not passed. Closes: #508622 (Michael Gold)
Joey Hess [Thu, 18 Dec 2008 02:17:42 +0000 (21:17 -0500)]
close
Joey Hess [Thu, 18 Dec 2008 01:40:46 +0000 (20:40 -0500)]
deletion
Joey Hess [Thu, 18 Dec 2008 01:29:55 +0000 (20:29 -0500)]
jump to comments anchor after post
Not ideal, it would be nicer to jump to the actual comment posted, but no
anchor is available.
Joey Hess [Thu, 18 Dec 2008 01:22:42 +0000 (20:22 -0500)]
typo
Joey Hess [Thu, 18 Dec 2008 01:19:12 +0000 (20:19 -0500)]
fix
Joey Hess [Thu, 18 Dec 2008 01:10:22 +0000 (20:10 -0500)]
simplify pagespec
Joey Hess [Thu, 18 Dec 2008 00:47:54 +0000 (19:47 -0500)]
two comments ui suggestions
Joey Hess [Thu, 18 Dec 2008 00:38:02 +0000 (19:38 -0500)]
add Comments link when displaying a page inline
This link will supplant the usual Discussion link for pages
that have comments enabled.
Joey Hess [Thu, 18 Dec 2008 00:06:29 +0000 (19:06 -0500)]
fix test when comments_closed_pagespec is empty
Joey Hess [Wed, 17 Dec 2008 23:56:32 +0000 (18:56 -0500)]
don't rely on $@
A malformed pagespec will cause $@ to be set when translated, but if
it is used a second time, the memoization will defeat that check. Better to
check for the result not being defined.
Joey Hess [Wed, 17 Dec 2008 23:50:04 +0000 (18:50 -0500)]
change around comments pagespecs
I think it is clearer to have one pagespec that controls all pages with
comments, and a separate pagespec that can be used to close new comments on
a subset of those pages.
Joey Hess [Wed, 17 Dec 2008 22:05:49 +0000 (17:05 -0500)]
fix default values for config settings
defaults cannot be set in getsetup, do it in checkconfig to avoid
uninitialized value warnings.
Joey Hess [Wed, 17 Dec 2008 20:29:22 +0000 (15:29 -0500)]
clarification
Joey Hess [Wed, 17 Dec 2008 20:22:16 +0000 (15:22 -0500)]
Coding style change: Remove explcit vim folding markers.
Joey Hess [Wed, 17 Dec 2008 19:26:08 +0000 (14:26 -0500)]
checksessionexpiry: rework
This function as factored out was a bit confusing, I think this makes more
sense.
Joey Hess [Wed, 17 Dec 2008 19:15:52 +0000 (14:15 -0500)]
more comments doc updates
Moved todo items to a todo page, mark the old todo item about comments as
done, etc.
Joey Hess [Wed, 17 Dec 2008 19:06:57 +0000 (14:06 -0500)]
Merge branch 'master' into comments
Joey Hess [Wed, 17 Dec 2008 18:59:12 +0000 (13:59 -0500)]
monotone: When getting the log, tell monotone how many entries we want, rather than closing the pipe, which it dislikes. (thm)
Joey Hess [Wed, 17 Dec 2008 18:56:10 +0000 (13:56 -0500)]
rename: Fix double-escaping of page name in edit box.
titlepage normally escapes, but so does formbuilder.
http://thm.id.fedoraproject.org/ [Wed, 17 Dec 2008 10:54:16 +0000 (05:54 -0500)]
rename bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38____35__34__59_____40__patch__41__.mdwn to bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34_____40__patch__41__.mdwn
http://thm.id.fedoraproject.org/ [Wed, 17 Dec 2008 10:52:10 +0000 (05:52 -0500)]
rename bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34__.mdwn to bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38____35__34__59_____40__patch__41__.mdwn
http://thm.id.fedoraproject.org/ [Tue, 16 Dec 2008 11:56:19 +0000 (06:56 -0500)]
http://thm.id.fedoraproject.org/ [Tue, 16 Dec 2008 11:54:55 +0000 (06:54 -0500)]
Jon Dowland [Mon, 15 Dec 2008 16:09:26 +0000 (16:09 +0000)]
add a meta title
Jon Dowland [Mon, 15 Dec 2008 15:39:07 +0000 (15:39 +0000)]
not putting cgi in destdir
Joey Hess [Fri, 12 Dec 2008 20:38:23 +0000 (15:38 -0500)]
elide unnecessary variables
Joey Hess [Fri, 12 Dec 2008 20:25:12 +0000 (15:25 -0500)]
remove fixme
sessioncgi hooks are always called with the wiki locked
Joey Hess [Fri, 12 Dec 2008 20:22:43 +0000 (15:22 -0500)]
fix redefinition of $author
Joey Hess [Fri, 12 Dec 2008 20:19:01 +0000 (15:19 -0500)]
move related code together
Joey Hess [Fri, 12 Dec 2008 20:13:07 +0000 (15:13 -0500)]
whitespace
Joey Hess [Fri, 12 Dec 2008 20:10:17 +0000 (15:10 -0500)]
don't explicitly use inline
loadplugin("inline") should take care of that
Joey Hess [Fri, 12 Dec 2008 20:08:06 +0000 (15:08 -0500)]
avoid unnecessary variable
Joey Hess [Fri, 12 Dec 2008 20:05:26 +0000 (15:05 -0500)]
get rid of the [postcomment] hack
I think that using a flag variable is sorta cleaner.
(This is untested.)
Joey Hess [Fri, 12 Dec 2008 20:02:40 +0000 (15:02 -0500)]
improve documentation of postcomment
Joey Hess [Fri, 12 Dec 2008 19:59:23 +0000 (14:59 -0500)]
move getsetup to usual place
Joey Hess [Fri, 12 Dec 2008 19:52:05 +0000 (14:52 -0500)]
first pass through comments documentation
Moved documentation out of contrib.
Mostly tweaked some wording. Moved documentation of various bits to other
pages (pagespec, etc), and linked to those.
Documented the new templates in wikitemplates.
Small quantities of documentation were removed. Particularly the list of
template variables, which I think is fairly obvious when editing the
template.
Joey Hess [Fri, 12 Dec 2008 19:29:42 +0000 (14:29 -0500)]
update changelog
Joey Hess [Fri, 12 Dec 2008 19:27:56 +0000 (14:27 -0500)]
update copyright
Joey Hess [Fri, 12 Dec 2008 19:24:35 +0000 (14:24 -0500)]
Merge branch 'master' into comments
Joey Hess [Fri, 12 Dec 2008 19:23:33 +0000 (14:23 -0500)]
add log entry
Simon McVittie [Tue, 18 Nov 2008 11:25:13 +0000 (11:25 +0000)]
htmlbalance: don't compact whitespace, and set misc other options
Not compacting whitespace is the most important one: now that we run
sanitize hooks on individual posted comments in the comments plugin,
whitespace that is significant to Markdown (but not HTML) is lost.
(cherry picked from commit
cb5aaa3cee8b35d6fc6e88a7449a9477a6587c7a)