ikiwiki.git
14 years agoMerge remote branch 'upstream/master' into prv/po
intrigeri [Fri, 25 Jun 2010 12:38:37 +0000 (14:38 +0200)]
Merge remote branch 'upstream/master' into prv/po

Conflicts:
IkiWiki/Plugin/po.pm

14 years agosidebars defined by pagespec perhaps?
http://kerravonsen.dreamwidth.org/ [Fri, 25 Jun 2010 02:40:25 +0000 (02:40 +0000)]
sidebars defined by pagespec perhaps?

14 years agocommenting on the link-text-from-title idea
http://kerravonsen.dreamwidth.org/ [Fri, 25 Jun 2010 01:58:02 +0000 (01:58 +0000)]
commenting on the link-text-from-title idea

14 years agochdir to srcdir in rcs_getctime
Joey Hess [Thu, 24 Jun 2010 01:29:47 +0000 (21:29 -0400)]
chdir to srcdir in rcs_getctime

14 years agotest from google openid
https://www.google.com/accounts/o8/id?id=AItOawm0mAKbBvoYTeRz4lDv83cTfXsAns5CmDQ [Thu, 24 Jun 2010 00:45:59 +0000 (00:45 +0000)]
test from google openid

14 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Thu, 24 Jun 2010 00:30:47 +0000 (20:30 -0400)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

14 years agobugfix
Joey Hess [Thu, 24 Jun 2010 00:26:09 +0000 (20:26 -0400)]
bugfix

14 years agoopenid nickname support finished; closing
Joey Hess [Thu, 24 Jun 2010 00:21:44 +0000 (20:21 -0400)]
openid nickname support finished; closing

14 years agoupdate
Joey Hess [Thu, 24 Jun 2010 00:16:55 +0000 (20:16 -0400)]
update

14 years agofinializing openid nickname support
Joey Hess [Thu, 24 Jun 2010 00:12:26 +0000 (20:12 -0400)]
finializing openid nickname support

Renamed usershort => nickname.

Note that this means existing user login sessions will not have the nickname
recorded, and so it won't be used for those.

14 years agogit: Record the username from openid in the git author email. (This avoids display...
Joey Hess [Wed, 23 Jun 2010 23:44:41 +0000 (19:44 -0400)]
git: Record the username from openid in the git author email. (This avoids display of ugly google openids.)

14 years agotake username from email address as fallback
Joey Hess [Wed, 23 Jun 2010 23:36:23 +0000 (19:36 -0400)]
take username from email address as fallback

14 years agorcs_getctime and rcs_getmtime take relative filenames
Joey Hess [Wed, 23 Jun 2010 23:32:53 +0000 (19:32 -0400)]
rcs_getctime and rcs_getmtime take relative filenames

There was some confusion about whether the filename was
relative to srcdir or not. Some test cases, and the bzr
plugin assumed it was relative to the srcdir. Most everything else
assumed it was absolute.

Changed it to relative, for consistency with the rest
of the rcs_ functions.

14 years agorcs_commit and rcs_commit_staged api changes
Joey Hess [Wed, 23 Jun 2010 21:35:21 +0000 (17:35 -0400)]
rcs_commit and rcs_commit_staged api changes

Using named parameters for these is overdue. Passing the session in a
parameter instead of passing username and IP separately will later allow
storing other session info, like username or part of the email.

Note that these functions are not part of the exported API,
and the prototype change will catch (most) skew, so I am not changing
API versions. Any third-party plugins that call them will need updated
though.

14 years agoupdate for new rcs_commit_staged API
Joey Hess [Wed, 23 Jun 2010 20:56:50 +0000 (16:56 -0400)]
update for new rcs_commit_staged API

In the process, lost the commits from special usernames
when committing changed po files. Instead of trying to dummy up a session
object for the special username, I just don't pass one, and the commit will
appear to be from whatever user ikiwiki runs as.

14 years agostop using REMOTE_ADDR
Joey Hess [Wed, 23 Jun 2010 20:32:20 +0000 (16:32 -0400)]
stop using REMOTE_ADDR

Everywhere that REMOTE_ADDR was used, a session object is available, so
instead use its remote_addr method.

In IkiWiki::Receive, stop setting a dummy REMOTE_ADDR.

Note that it's possible for a session cookie to be obtained using one IP
address, and then used from another IP. In this case, the first IP will now
be used. I think that should be ok.

14 years agoAPI: rcs_commit and rcs_commit_staged are passed a new parameter
Joey Hess [Wed, 23 Jun 2010 20:05:49 +0000 (16:05 -0400)]
API: rcs_commit and rcs_commit_staged are passed a new parameter
that may contain the username component of the email address of
the user making the commit.

14 years agoAdd new optional field usershort to rcs_recentchanges.
Joey Hess [Wed, 23 Jun 2010 19:32:27 +0000 (15:32 -0400)]
Add new optional field usershort to rcs_recentchanges.

Now the git plugin supports commits with author fields that look like:
Author: http://my.openid/ <me@web>

Then in recentchanges, the short username will be displayed, linking
to the openid.

Particularly useful for the horrible google openids, of course.

14 years agowhitespace
Joey Hess [Wed, 23 Jun 2010 19:23:13 +0000 (15:23 -0400)]
whitespace

14 years agoIt is possible to use google-sitemapgen to create google sitemaps for ikiwiki.
BerndZeimetz [Wed, 23 Jun 2010 18:44:52 +0000 (18:44 +0000)]
It is possible to use google-sitemapgen to create google sitemaps for ikiwiki.

14 years agoadd news item for ikiwiki 3.20100623
Joey Hess [Wed, 23 Jun 2010 18:23:51 +0000 (14:23 -0400)]
add news item for ikiwiki 3.20100623

14 years agoreleasing version 3.20100623 3.20100623
Joey Hess [Wed, 23 Jun 2010 18:23:09 +0000 (14:23 -0400)]
releasing version 3.20100623

14 years agobugfix: record email-like links as page links
Joey Hess [Wed, 23 Jun 2010 18:05:57 +0000 (14:05 -0400)]
bugfix: record email-like links as page links

This way, an email-like link will be a mailto until a matching page
is created, then it will link to the page. And removing the page will
convert it back to a mailto.

14 years agosimplify anchor handling
Joey Hess [Wed, 23 Jun 2010 17:57:27 +0000 (13:57 -0400)]
simplify anchor handling

At least two bugfixes in here. First, an old bug;
\[[foo#0]] was displayed as [[foo]], losing the anchor
as the anchor text was false. Secondly, a new bug;
an email like foo#bar@baz should not check bestlink("foo@baz").

14 years agoavoid needing full email regexp
Joey Hess [Wed, 23 Jun 2010 17:40:10 +0000 (13:40 -0400)]
avoid needing full email regexp

Fully validating the email address is not necessary,
all that matters is not matching an url like http://foo@bar/
as an email address.

14 years agodocument external links
Joey Hess [Wed, 23 Jun 2010 17:35:31 +0000 (13:35 -0400)]
document external links

14 years agoadd changelog for externalink
Joey Hess [Wed, 23 Jun 2010 17:33:14 +0000 (13:33 -0400)]
add changelog for externalink

remove debian.org linkspam ;)

14 years agoMerge remote branch 'remotes/bzed/extendedlink'
Joey Hess [Wed, 23 Jun 2010 17:30:14 +0000 (13:30 -0400)]
Merge remote branch 'remotes/bzed/extendedlink'

14 years agoresponse
Joey Hess [Wed, 23 Jun 2010 17:29:46 +0000 (13:29 -0400)]
response

14 years agoone slash is enough to escape
Joey Hess [Wed, 23 Jun 2010 17:17:33 +0000 (13:17 -0400)]
one slash is enough to escape

14 years agoRevert "don't need to escape the inline tag if its in pre tag"
Joey Hess [Wed, 23 Jun 2010 17:16:31 +0000 (13:16 -0400)]
Revert "don't need to escape the inline tag if its in pre tag"

This reverts commit 4833f486b6ca759e1bcd8acc19e13ef4a0a6063f.

Being in a pre does not stop an inline directive from working.

14 years agoclarify indexdb is cached info, rebuildable
Joey Hess [Wed, 23 Jun 2010 17:15:10 +0000 (13:15 -0400)]
clarify indexdb is cached info, rebuildable

14 years agothoughts
Joey Hess [Wed, 23 Jun 2010 17:12:43 +0000 (13:12 -0400)]
thoughts

14 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Wed, 23 Jun 2010 17:05:02 +0000 (13:05 -0400)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

14 years agoresponse
Joey Hess [Wed, 23 Jun 2010 17:04:56 +0000 (13:04 -0400)]
response

14 years agoAdded a comment: do parameter missing
http://joey.kitenet.net/ [Wed, 23 Jun 2010 17:03:12 +0000 (17:03 +0000)]
Added a comment: do parameter missing

14 years agodespam
Joey Hess [Wed, 23 Jun 2010 16:53:01 +0000 (12:53 -0400)]
despam

"ikiwikiweb" is banned

14 years agoresponse
Joey Hess [Wed, 23 Jun 2010 16:51:50 +0000 (12:51 -0400)]
response

14 years ago(no commit message)
ikiwikiweb [Tue, 22 Jun 2010 20:46:57 +0000 (20:46 +0000)]

14 years agotesting
ikiwikiweb [Tue, 22 Jun 2010 20:45:40 +0000 (20:45 +0000)]
testing

14 years agoping
privat [Tue, 22 Jun 2010 15:10:59 +0000 (15:10 +0000)]
ping

14 years ago(no commit message)
privat [Tue, 22 Jun 2010 13:30:50 +0000 (13:30 +0000)]

14 years agoAdded a comment
jeanm [Sat, 19 Jun 2010 13:35:37 +0000 (13:35 +0000)]
Added a comment

14 years agoWhat license for themes for distribution in ikiwiki?
PaulePanter [Sat, 19 Jun 2010 10:47:30 +0000 (10:47 +0000)]
What license for themes for distribution in ikiwiki?

14 years agoMatch start page `/index` does not work.
PaulePanter [Sat, 19 Jun 2010 10:35:32 +0000 (10:35 +0000)]
Match start page `/index` does not work.

14 years agoTest PageSpec with root page `/index.mdwn`.
PaulePanter [Sat, 19 Jun 2010 10:27:28 +0000 (10:27 +0000)]
Test PageSpec with root page `/index.mdwn`.

14 years agoEnhance the link plugin to handle external links.
Bernd Zeimetz [Sun, 13 Jun 2010 23:18:33 +0000 (01:18 +0200)]
Enhance the link plugin to handle external links.

The following ways to create a link are supported now:
[[url]]
[[text|url]]
url can be one of the following:
- an internal wikilink: will be handled as before
- any other kind of URL, including mailto: proper links will be created:
  <a href="url">url</a>
  <a href="url">text</a>
- an email address:
  <a href="mailto:url">url</a>
  <a href="mailto:url">text</a>

14 years agoforgotten signature
bhobbit [Sat, 19 Jun 2010 00:20:50 +0000 (00:20 +0000)]
forgotten signature

14 years agoreply to Joey
bhobbit [Sat, 19 Jun 2010 00:20:01 +0000 (00:20 +0000)]
reply to Joey

14 years agoless tight positioning
Joey Hess [Fri, 18 Jun 2010 22:19:12 +0000 (18:19 -0400)]
less tight positioning

the descenders in the tabs were cut off before

14 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Fri, 18 Jun 2010 22:07:40 +0000 (18:07 -0400)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

14 years agosidebar styling and fix actions for inlined pages
Joey Hess [Fri, 18 Jun 2010 22:06:29 +0000 (18:06 -0400)]
sidebar styling and fix actions for inlined pages

Styling the actions for inlined pages as tabs did not work well.
That still needs some work; for now just don't style the actions for
inlined pages.

14 years agoupdate to newer version from svend's blog
Joey Hess [Fri, 18 Jun 2010 22:03:19 +0000 (18:03 -0400)]
update to newer version from svend's blog

14 years agodon't need to escape the inline tag if its in pre tag
http://www.openid.albertlash.com/openid/ [Fri, 18 Jun 2010 20:48:10 +0000 (20:48 +0000)]
don't need to escape the inline tag if its in pre tag

14 years ago(no commit message)
http://www.openid.albertlash.com/openid/ [Fri, 18 Jun 2010 20:47:31 +0000 (20:47 +0000)]

14 years agostore state to avoid needing to rebuild when changing theme
Joey Hess [Fri, 18 Jun 2010 20:40:47 +0000 (16:40 -0400)]
store state to avoid needing to rebuild when changing theme

14 years agoneedsbuild hook is passed an array ref
Joey Hess [Fri, 18 Jun 2010 20:15:57 +0000 (16:15 -0400)]
needsbuild hook is passed an array ref

14 years agotypo
Joey Hess [Fri, 18 Jun 2010 19:06:15 +0000 (15:06 -0400)]
typo

14 years agomention added themes
Joey Hess [Fri, 18 Jun 2010 18:59:45 +0000 (14:59 -0400)]
mention added themes

14 years agorename bzed theme to "blueview"
Joey Hess [Fri, 18 Jun 2010 18:58:36 +0000 (14:58 -0400)]
rename bzed theme to "blueview"

14 years agoalso a problem for theme plugin
Joey Hess [Fri, 18 Jun 2010 18:39:08 +0000 (14:39 -0400)]
also a problem for theme plugin

14 years agoresponse
Joey Hess [Fri, 18 Jun 2010 18:31:24 +0000 (14:31 -0400)]
response

14 years agoresponse
Joey Hess [Fri, 18 Jun 2010 18:24:39 +0000 (14:24 -0400)]
response

14 years agoavoid showing subpages of contrib plugins
Joey Hess [Fri, 18 Jun 2010 16:59:03 +0000 (12:59 -0400)]
avoid showing subpages of contrib plugins

14 years agofix filename
Joey Hess [Fri, 18 Jun 2010 16:57:20 +0000 (12:57 -0400)]
fix filename

14 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Fri, 18 Jun 2010 16:56:57 +0000 (12:56 -0400)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

14 years agobugnum
Joey Hess [Fri, 18 Jun 2010 16:52:26 +0000 (12:52 -0400)]
bugnum

14 years agoavoid shelling
Joey Hess [Fri, 18 Jun 2010 16:50:31 +0000 (12:50 -0400)]
avoid shelling

14 years agomercurial: Fix buggy getctime code.
Joey Hess [Fri, 18 Jun 2010 16:48:05 +0000 (12:48 -0400)]
mercurial: Fix buggy getctime code.

The file passed to rcs_getctime is already absolute, and it was
trying to stick the srcdir on the front.

Also, eliminated potentially unsafe shelling.

14 years ago`themes.pm` instead of `themes.mdwn`
PaulePanter [Fri, 18 Jun 2010 09:08:28 +0000 (09:08 +0000)]
`themes.pm` instead of `themes.mdwn`

14 years agoavoid dying if cannot chdir to an underlaydir
Joey Hess [Thu, 17 Jun 2010 20:54:03 +0000 (16:54 -0400)]
avoid dying if cannot chdir to an underlaydir

14 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Thu, 17 Jun 2010 20:52:33 +0000 (16:52 -0400)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

14 years agoyeay ! \\o \o/ o//
demo [Thu, 17 Jun 2010 15:00:59 +0000 (15:00 +0000)]
yeay ! \\o \o/ o//

14 years ago(no commit message)
jhagg [Thu, 17 Jun 2010 08:30:38 +0000 (08:30 +0000)]

14 years ago(no commit message)
jeanm [Thu, 17 Jun 2010 06:22:19 +0000 (06:22 +0000)]

14 years agolink to theme plugin
Joey Hess [Wed, 16 Jun 2010 23:23:08 +0000 (19:23 -0400)]
link to theme plugin

14 years agoMerge branch 'themes'
Joey Hess [Wed, 16 Jun 2010 23:17:18 +0000 (19:17 -0400)]
Merge branch 'themes'

14 years agoadd background image, kindly gpl'd by bzed
Joey Hess [Wed, 16 Jun 2010 23:15:57 +0000 (19:15 -0400)]
add background image, kindly gpl'd by bzed

14 years agoforce list context
Joey Hess [Wed, 16 Jun 2010 20:07:41 +0000 (16:07 -0400)]
force list context

run_or_die returns a status code in scalar context

14 years agopreserve timestamps for directive and theme underlays
Joey Hess [Wed, 16 Jun 2010 19:48:50 +0000 (15:48 -0400)]
preserve timestamps for directive and theme underlays

14 years agoforce rebuild for theme change
Joey Hess [Wed, 16 Jun 2010 19:44:21 +0000 (15:44 -0400)]
force rebuild for theme change

For now, a rebuild is the only way to ensure the changed theme is used.
Ikiwiki normally will not realize style.css has changed, since themes
tend to have the same timestamp for the file.

14 years agoadd theme plugin
Joey Hess [Wed, 16 Jun 2010 19:43:42 +0000 (15:43 -0400)]
add theme plugin

14 years agoEncode not used
Joey Hess [Wed, 16 Jun 2010 19:30:33 +0000 (15:30 -0400)]
Encode not used

14 years agocomments
Joey Hess [Wed, 16 Jun 2010 19:03:38 +0000 (15:03 -0400)]
comments

14 years agonot local.css here
Joey Hess [Wed, 16 Jun 2010 19:02:42 +0000 (15:02 -0400)]
not local.css here

14 years agocopy from actiontabs.css in css_market
Joey Hess [Wed, 16 Jun 2010 19:02:14 +0000 (15:02 -0400)]
copy from actiontabs.css in css_market

fixed a few indents

14 years agocopy from bzed
Joey Hess [Wed, 16 Jun 2010 19:00:26 +0000 (15:00 -0400)]
copy from bzed

14 years agotweak bzed's theme
Joey Hess [Wed, 16 Jun 2010 18:55:44 +0000 (14:55 -0400)]
tweak bzed's theme

* move dotted border from bottom inlinecontent to top inlinefooter,
  and allow inlinefooter to clear floating content. This way, floating
  images do not hang down through the dotted border
* don't reset inputs and textareas, it makes buttons in forms
  all squash up together
* don't eliminate fieldsets, it makes the web setup page a
  mess
* only force the size of the search box. ikiwiki generally picks
  form field sizes with a reasonable good reason
* remove some custom css classes not used
* remove some trailing whitespace

14 years agoadd copy of local.css from bzed.de
Joey Hess [Wed, 16 Jun 2010 18:53:47 +0000 (14:53 -0400)]
add copy of local.css from bzed.de

bzed says this is not quite ready, but I'm an impatient guy. Guess
I'll have to track his updates.

14 years agoattachment: Support Windows paths when taking basename of client-supplied file name.
Joey Hess [Wed, 16 Jun 2010 17:23:32 +0000 (13:23 -0400)]
attachment: Support Windows paths when taking basename of client-supplied file name.

14 years ago(no commit message)
jhagg [Wed, 16 Jun 2010 13:40:29 +0000 (13:40 +0000)]

14 years agogit: Gix --gettime to properly support utf8 filenames.
Joey Hess [Wed, 16 Jun 2010 03:21:55 +0000 (23:21 -0400)]
git: Gix --gettime to properly support utf8 filenames.

In passing, fixed a bug where the srcdir was in a subdir of a repository
named "0".

14 years agoMake --gettime be honored after initial setup.
Joey Hess [Wed, 16 Jun 2010 02:56:06 +0000 (22:56 -0400)]
Make --gettime be honored after initial setup.

Bugfix in passing: New files not treated as such when no rcs is used.

14 years agobugnum
Joey Hess [Tue, 15 Jun 2010 23:35:17 +0000 (19:35 -0400)]
bugnum

14 years agofix other cases of unicode mixing issue
Joey Hess [Tue, 15 Jun 2010 21:41:26 +0000 (17:41 -0400)]
fix other cases of unicode mixing issue

and fix underlaydir override attack guard when srcdir is non-absolute

14 years agoFix issues with combining unicode srcdirs and source files.
Joey Hess [Tue, 15 Jun 2010 20:40:37 +0000 (16:40 -0400)]
Fix issues with combining unicode srcdirs and source files.

A short story:

  Once there was a unicode string, let's call him Srcdir.

  Along came a crufy old File::Find, who went through a tree and pasted each
  of the leaves in turn onto Srcdir. But this 90's relic didn't decode the
  leaves -- despite some of them using unicode! Poor Srcdir, with these
  leaves stuck on him, tainted them with his nice unicode-ness. They didn't
  look like leaves at all, but instead garbage.

(In other words, perl's unicode support sucks mightily, and drives
us all to drink and bad storytelling. But we knew that..)

So, srcdir is not normally flagged as unicode, because typically it's pure
ascii. And in that case, things work ok; File::Find finds filenames, which
are not yet decoded to unicode, and appends them to the srcdir, and then
decode_utf8 happily converts the whole thing.

But, if the srcdir does contain utf8 characters, that breaks. Or, if a Yaml
setup file is used, Yaml::Syck's implicitunicode sets the unicode flag of
*all* strings, even those containing only ascii. In either case, srcdir
has the unicode flag set; a non-decoded filename is appended, and the flag
remains set; and decode_utf8 sees the flag and does *nothing*. The result
is that the filename is not decoded, so looks valid and gets skipped.

File::Find only sticks the directory and filenames together in no_chdir
mode .. but we need that mode for security. In order to retain the
security, and avoid the problem, I made it not pass srcdir to File::Find.
Instead, chdir to the srcdir, and pass ".". Since "." is ascii, the problem
is avoided.

Note that chdir srcdir is safe because we check for symlinks in the srcdir
path.

Note that it takes care to chdir back to the starting location. Because
the user may have specified relative paths and so staying in the srcdir
might break. A relative path could even be specifed for an underlay dir, so
it chdirs back after each.

14 years agoFix issues with combining unicode srcdirs and source files.
Joey Hess [Tue, 15 Jun 2010 20:40:37 +0000 (16:40 -0400)]
Fix issues with combining unicode srcdirs and source files.

A short story:

  Once there was a unicode string, let's call him Srcdir.

  Along came a crufy old File::Find, who went through a tree and pasted each
  of the leaves in turn onto Srcdir. But this 90's relic didn't decode the
  leaves -- despite some of them using unicode! Poor Srcdir, with these
  leaves stuck on him, tainted them with his nice unicode-ness. They didn't
  look like leaves at all, but instead garbage.

In other words, perl's unicode support sucks mightily, and drives
us all to drink and bad storytelling. But we knew that..

So, srcdir is not normally flagged as unicode, because typically it's pure
ascii. And in that case, things work ok; File::Find finds filenames, which
are not yet decoded to unicode, and appends them to the srcdir, and then
decode_utf8 happily converts the whole thing.

But, if the srcdir does contain utf8 characters, that breaks. Or, if a Yaml
setup file is used, Yaml::Syck's implicitunicode sets the unicode flag of
*all* strings, even those containing only ascii. In either case, srcdir
has the unicode flag set; a non-decoded filename is appended, and
decode_utf8 sees the flag and does *nothing*. The result is that the
filename is not decoded, so looks valid and gets skipped.

File::Find only sticks the directory and filenames together in no_chdir
mode .. but we need that mode for security. In order to retain the
security, and avoid the problem, I made it not pass srcdir to File::Find.
Instead, chdir to the srcdir, and pass ".". Since "." is ascii, the problem
is avoided.

Note that it takes care to chdir back to the starting location. Because
the user may have specified relative paths and so staying in the srcdir
might break. A relative path could even be specifed for an underlay dir, so
it chdirs back after each.

14 years agonote
Joey Hess [Tue, 15 Jun 2010 19:15:39 +0000 (15:15 -0400)]
note

14 years agomatch only pages in calendar
Joey Hess [Tue, 15 Jun 2010 18:17:23 +0000 (14:17 -0400)]
match only pages in calendar

14 years agoclear floats before comments begin
Joey Hess [Tue, 15 Jun 2010 17:44:42 +0000 (13:44 -0400)]
clear floats before comments begin