W. Trevor King [Sat, 5 Dec 2009 22:17:21 +0000 (17:17 -0500)]
Added missing author entries to some comments + cleanups.
W. Trevor King [Sat, 5 Dec 2009 21:50:34 +0000 (16:50 -0500)]
Fix libbe.diff.Diff._changed_bugs() to handle subscriptions by bug shortname.
W. Trevor King [Sat, 5 Dec 2009 13:31:04 +0000 (08:31 -0500)]
Cleanup Dir in becommands/init.py doctest.
W. Trevor King [Sat, 5 Dec 2009 13:16:27 +0000 (08:16 -0500)]
Merged be.diff-subscribe
Highlights:
* changes to `be diff`
* exits with an error if required revision control is not possible.
Previously it printed a message, but exitted with status 0.
* removed options --new, --removed, --modified, --all
* added options --uuids, --subscribe
* New method diff.Diff.full_report() allows fast generation of
similar report_tree()s via diff.DiffTree.masked.
* New method diff.subscriptions_from_string() for consistent
subscription string parsing.
* clean up be-handle-mail.Message.subscriber_emails() with
diff.Diff.report_tree(subscriptions)
* hardcoded 'DIR' replaced with diff.BUGDIR_ID
* assorted cleanups and bugfixes
W. Trevor King [Sat, 5 Dec 2009 13:15:52 +0000 (08:15 -0500)]
Updated NEWS
W. Trevor King [Sat, 5 Dec 2009 13:08:09 +0000 (08:08 -0500)]
Adjust libbe.diff.DiffTree to fix failed doctest.
======================================================================
FAIL: Doctest: libbe.diff.DiffTree
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.5/doctest.py", line 2128, in runTest
raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for libbe.diff.DiffTree
File "/home/wking/src/fun/be/be.diff-subscribe/libbe/diff.py", line 136, in DiffTree
----------------------------------------------------------------------
File "/home/wking/src/fun/be/be.diff-subscribe/libbe/diff.py", line 172, in libbe.diff.DiffTree
Failed example:
print bugdir.report_string()
Exception raised:
Traceback (most recent call last):
File "/usr/lib/python2.5/doctest.py", line 1228, in __run
compileflags, 1) in test.globs
File "<doctest libbe.diff.DiffTree[18]>", line 1, in <module>
print bugdir.report_string()
File "/home/wking/src/fun/be/be.diff-subscribe/libbe/diff.py", line 213, in report_string
return "\n".join(self.report())
TypeError
W. Trevor King [Sat, 5 Dec 2009 12:41:50 +0000 (07:41 -0500)]
Use new libbe.diff.Diff.report_tree(subscriptions) in be-handle-mail.
This makes Message.subscriber_emails() much cleaner.
Also fix libbe.diff.Diff._sub_report() to handle missing
'bugdir/settings'.
Added libbe.diff.SubscriptionType.__cmp__ so that
SubscriptionType('all') == SubscriptionType('all')
This is important when comparing the types returned by
becommands.subscribe.get_bugdir_subscribers()
with the libbe.diff.*_TYPE_* types.
W. Trevor King [Sat, 5 Dec 2009 10:38:48 +0000 (05:38 -0500)]
Added libbe.diff.Diff.full_report() for speed with several subscription lists.
Now report_tree() returns an appropriately .masked version of the
cached full report, which is much faster than recomputing a new diff
tree from scratch.
Also fixed bug in libbe.diff.DiffTree.report() where
.requires_children=True was exposing nodes with children, when it
should (and now does) only expose nodes with _unmasked_ children.
W. Trevor King [Sat, 5 Dec 2009 09:21:04 +0000 (04:21 -0500)]
More 'DIR'->diff.BUGDIR_ID updates
W. Trevor King [Sat, 5 Dec 2009 09:11:39 +0000 (04:11 -0500)]
Created diff.subscriptions_from_string()
W. Trevor King [Sat, 5 Dec 2009 08:55:55 +0000 (03:55 -0500)]
Added --subscribe option to `be diff`
W. Trevor King [Sat, 5 Dec 2009 08:53:26 +0000 (03:53 -0500)]
Added BUGDIR_TYPE_MOD and BUGDIR_TYPE_REM to libbe.diff.
Now you can subscribe to only hear about modified bugs or only about
removed bugs. Kindof odd for a general subscription, but possibly
useful as an argument to the upcoming `be diff --subscribe`, e.g.
be diff --subscribe DIR:mod
which would replace the old
be diff --modified
W. Trevor King [Sat, 5 Dec 2009 08:32:06 +0000 (03:32 -0500)]
Adjusted diff.Subscription.__init__() to guess type_root if required.
W. Trevor King [Sat, 5 Dec 2009 08:22:25 +0000 (03:22 -0500)]
Added subscriptions option to diff.Diff.report_tree().
Also added diff.BUGDIR_ID to avoid lots of magic 'DIR' definitions,
and added diff.Subscription class to make the old (id, type) tuples a
bit more elegant.
W. Trevor King [Sat, 5 Dec 2009 06:58:41 +0000 (01:58 -0500)]
Moved subscription types from becommands/subscribe.py to libbe/diff.py.
W. Trevor King [Sat, 5 Dec 2009 06:30:30 +0000 (01:30 -0500)]
Replaced `be diff` options --new, --removed, --modified, and --all with --uuids.
We'll be adding a --subscribe option which will select the
bugs/changes we're interested in, which deprecates the selection
portion of the old options. The new --uuids just selects the "bug
uuid" output over the default "change summary" output.
W. Trevor King [Sat, 5 Dec 2009 06:10:01 +0000 (01:10 -0500)]
Set boolean options default to False in becommands/list.py
Otherwise they default to None. It doesn't matter at the moment,
since all the comparisons seem to be
if options.XYZ == True:
but this protects against confusion in the future if someone tries
if options.XYZ == False:
W. Trevor King [Sat, 5 Dec 2009 06:00:35 +0000 (01:00 -0500)]
`be diff` raises UsageError if required revision control not possible.
It had previously printed an message and exitted without error.
W. Trevor King [Sat, 5 Dec 2009 05:57:43 +0000 (00:57 -0500)]
Fix cmdutil.help() calls in be to use args not sys.argv.
sys.argv won't work if there are any options in the be call, e.g.
be -d DIR diff
W. Trevor King [Sat, 5 Dec 2009 05:21:35 +0000 (00:21 -0500)]
Add __eq__ and __ne__ methods to Tree.
This fixes a bug introduced by
revision-id: wking@drexel.edu-
20091205034412-8apqxq8zqim48tf7
committer: W. Trevor King <wking@drexel.edu>
timestamp: Fri 2009-12-04 22:44:12 -0500
message:
Use __cmp__ instead of __eq__ for Tree comparison.
When I made that commit, I'd forgotten that Tree inherits an __eq__
method from list, so it won't fall back to the __cmp__ method to
determine equality. The new __eq__ and __ne__ methods use __cmp__
internally, so further subclasses (e.g. Comment) only need to override
__cmp__. Of course, list also defines __ge__, __gt__, __le__, __lt__,
... which I don't bother with, so stay away from TreeA > TreeB and the
like.
W. Trevor King [Sat, 5 Dec 2009 04:55:11 +0000 (23:55 -0500)]
Merged `be diff --dir DIR` functionality
W. Trevor King [Sat, 5 Dec 2009 04:53:27 +0000 (23:53 -0500)]
Updated NEWS
W. Trevor King [Sat, 5 Dec 2009 04:39:15 +0000 (23:39 -0500)]
Updated NEWS
W. Trevor King [Sat, 5 Dec 2009 04:33:25 +0000 (23:33 -0500)]
Added --dir option to `be diff'.
Now you can compare two repositories:
be -d branchA diff -d branchB
or
branchA$ be diff -d ../branchB
which is helpful for VCSs like bzr that lack cross-branch revid
visibility. Git users can still use
branchA$ be diff REVID
where REVID is a commit from any branch in the repo.
This new functionality acts like a BE counterpart to `bzr missing DIR'.
W. Trevor King [Sat, 5 Dec 2009 04:30:32 +0000 (23:30 -0500)]
Fixed removed comment listing in libbe/diff.py.
Previous implementation guaranteed to raise KeyErrors, because new bug
doesn't contain the uuid.
W. Trevor King [Sat, 5 Dec 2009 03:44:12 +0000 (22:44 -0500)]
Use __cmp__ instead of __eq__ for Tree comparison.
This ensures that __ne__ will also work, and makes it easier to
subclass Tree. For example, in the previous implementation you could
have
>>> commA == commB
False
>>> cmp(commA, commB)
0
if the comments had different ids, but equivalent content.
At the user-interface level, this removes some false "modified
comments" from `be diff`.
W. Trevor King [Fri, 4 Dec 2009 03:05:23 +0000 (22:05 -0500)]
Don't necessarily initialize a new VCS in BugDir.load_settings().
We may already have the right type, in which case, don't mess with it.
This speeds up bugdir loading a bit more:
$ time be list > /dev/null
real 0m1.245s
user 0m1.116s
sys 0m0.124s
W. Trevor King [Fri, 4 Dec 2009 02:37:29 +0000 (21:37 -0500)]
Don't get VCS version in VCS.__init__().
Often, this just causes a slow subprocess.Popen() call to
get information we woln't even look at.
Old benchmark:
$ time be list > /dev/null
real 0m2.369s
user 0m1.980s
sys 0m0.388s
New benchmark:
$ time be list > /dev/null
real 0m1.472s
user 0m1.304s
sys 0m0.164s
W. Trevor King [Fri, 4 Dec 2009 02:19:54 +0000 (21:19 -0500)]
Added libbe.TESTING (defaults to False).
This flag allows us to skip unittest and testsuite declaration if we
woln't need them. It speeds up simple be calls a suprising amount.
With Testing=True (the old behavior):
wking@thor:be.wtk$ time ./be > /dev/null
real 0m0.393s
user 0m0.340s
sys 0m0.048s
With TESTING=False (the new behavior):
be.wtk$ time ./be > /dev/null
real 0m0.216s
user 0m0.152s
sys 0m0.064s
This adjustment was inspired by Jakub Wilk's Debian bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559295
W. Trevor King [Fri, 4 Dec 2009 01:38:58 +0000 (20:38 -0500)]
Added copyright blurbs to __init__.py files.
W. Trevor King [Fri, 4 Dec 2009 01:16:56 +0000 (20:16 -0500)]
Remove _test() functions from plugin.py and cmdutil.py.
Testing should be handled through test.py, not by calling per-module
_test() functions.
W. Trevor King [Mon, 30 Nov 2009 11:29:48 +0000 (06:29 -0500)]
Merged completed be.email-bugs branch.
Highlights:
* import-xml now works as advertized in its longhelp string
* new methods Bug.merge() and Comment.merge()
* comment.list_to_root() is now Bug.add_comments()
* BugDir.list_uuids() is now BugDir.uuids()
* Bug.from_xml() now imports comments :p
* test.py uses unittest.TestSuite 'suite' in becommands, if present.
W. Trevor King [Mon, 30 Nov 2009 11:29:04 +0000 (06:29 -0500)]
Mark bug 565 as fixed: be email-bugs for bug submission from bzr-less users
W. Trevor King [Mon, 30 Nov 2009 11:28:01 +0000 (06:28 -0500)]
be-handle-mail uses more conservative --add-only for be-bugs:xml
W. Trevor King [Mon, 30 Nov 2009 11:26:09 +0000 (06:26 -0500)]
Generalized doctest string in subproc.py
W. Trevor King [Mon, 30 Nov 2009 11:36:38 +0000 (06:36 -0500)]
Added some thoughts on import_xml merge algorithms
W. Trevor King [Mon, 30 Nov 2009 11:35:29 +0000 (06:35 -0500)]
Fixed import_xml.py to live up to its longhelp description.
Also added LonghelpTestCase to prove it.
W. Trevor King [Mon, 30 Nov 2009 11:26:49 +0000 (06:26 -0500)]
Avoid redundant Comment.alt_ids
W. Trevor King [Mon, 30 Nov 2009 11:05:03 +0000 (06:05 -0500)]
Changed Bug and Comment.merge() kwargs.
The old allow_changes and allow_new_comments didn't have separate
handling for extra_strings, like import_xml will need. It also didn't
have a way to specify what to do if an illegal change occurs.
Sometimes you'll want to raise an exception, but sometimes you'll want
to ?silently? ignore the change.
W. Trevor King [Mon, 30 Nov 2009 10:05:49 +0000 (05:05 -0500)]
Minor BugDir docstring typo correction.
W. Trevor King [Sun, 29 Nov 2009 08:19:30 +0000 (03:19 -0500)]
Moved comment.list_to_root() to Bug.add_comments() with some cleanups.
This makes Bug.add_comment simpler. Also makes Bug.from_xml() more
robust, since it no longer depends on the order in which the XML file
lists the comments. The previous Bug.from_xml() would have choked on
<be-xml>
<bug>
<comment>
<uuid>B</uuid>
<in-reply-to>A</in-reply-to>
</comment>
<comment>
<uuid>A</uuid>
</comment>
</bug>
</be-xml>
because when B was being added, the referenced A hadn't yet been
noticed.
W. Trevor King [Sun, 29 Nov 2009 03:07:16 +0000 (22:07 -0500)]
Added comment import to Bug.from_xml().
This is a pretty critical feature, dunno how I missed it before.
I also added a little check to both Bug and Comment.from_xml() so that
xml_string can take an ElementTree Element as well as the usual raw
string/unicode. This avoids repeated string <-> Element conversions.
Added Bug.add_comment() which handles the addition of a Comment
instance, matching .in_reply_to, checking .uuid uniqueness, etc.
W. Trevor King [Sun, 29 Nov 2009 01:27:53 +0000 (20:27 -0500)]
test.py now uses unittest.TestSuite 'suite' in becommands if present.
Such 'suite' instances have been required for libbe submodules. This
will allow becommands to test themselves more thoroughly than they
could with only doctests.
W. Trevor King [Sun, 29 Nov 2009 01:24:19 +0000 (20:24 -0500)]
BugDir.list_uuids() -> BugDir.uuids()
W. Trevor King [Sat, 28 Nov 2009 12:41:13 +0000 (07:41 -0500)]
Added Bug.merge() and Comment.merge().
Added *.explicit_attrs list creation to Bug and Comment.from_xml().
Added match_alt_id keyword argumennt to .comment_from_uuid().
Removed extra enline following '</extra-string>' tag in Bug and
Comment.xml().
W. Trevor King [Sat, 21 Nov 2009 20:18:02 +0000 (15:18 -0500)]
Added restrict_file_access to becommands' execute() args.
+ associated adjustments in other files.
See cmdutil.restrict_file_access.__doc__ for an explanation of the
security hole this closes.
W. Trevor King [Sat, 21 Nov 2009 20:06:10 +0000 (15:06 -0500)]
Merged mostly completed `be email-bugs'.
Highlights:
* new be commands 'email-bugs' and 'import-xml'
* standardized <be-xml> format for XML files.
* new be-handle-mail interface '[be-bug:xml]'
* restrict_file_access security patch
* new subprocess handling submodule libbe.subproc
* test.py adjusted to use an installed VCS for most tests.
* assorted bugfixes
Altered interfaces to the following be commands:
* comment --xml tag gone, use import-xml.
* show --xml xml format updated to <be-xml> format.
Also adjusted be-mbox-to-xml and be-xml-to-mbox to handle new <be-xml>
format and provide better handling of *.extra_strings.
W. Trevor King [Sat, 21 Nov 2009 19:54:11 +0000 (14:54 -0500)]
Fix libbe.vcs.VCS.get_file_contents(allow_no_vcs=True,binary=True).
In it's previous form it had ignored the binary option if
self._use_vcs() returned False.
Also added a few more details to the docstring, explaining the
arguments.
W. Trevor King [Sat, 21 Nov 2009 19:03:00 +0000 (14:03 -0500)]
Updated interfaces/email/interactive/README for [be-bug:xml] interface
W. Trevor King [Sat, 21 Nov 2009 18:53:09 +0000 (13:53 -0500)]
Added [be-tag:xml] processing to be-handle-mail.
Now it will automatically apply and commit emails from
be email-bugs ...
W. Trevor King [Sat, 21 Nov 2009 18:49:32 +0000 (13:49 -0500)]
Adjusted `be import-xml` to properly handle croot_bug==None.
If there aren't any root comments, then the user needn't specify
--comment-root, in which case croot_bug will be None and we want to
skip all the croot processing.
W. Trevor King [Sat, 21 Nov 2009 18:18:54 +0000 (13:18 -0500)]
Fixed bug in be-handle-mail.Message.parse_comment() for emails w/o Message-id.
You used to get:
Uncaught exception:
'NoneType' object has no attribute 'decode'
File "./be-handle-mail", line 857, in main
m.run()
File "./be-handle-mail", line 591, in run
command.run()
File "./be-handle-mail", line 244, in run
manipulate_encodings=False)
File "/tmp/be.email-bugs/interfaces/email/interactive/libbe/cmdutil.py", line 82, in execute
ret = cmd.execute([a.decode(enc) for a in args],
A `print args' in Message.parse_comment() revealed
[..., u'--alt-id', None,...]
W. Trevor King [Sat, 21 Nov 2009 18:08:05 +0000 (13:08 -0500)]
Added interfaces/email/interactive/examples/email_bugs
For testing the new [be-bug:xml] interface we're about to write.
W. Trevor King [Sat, 21 Nov 2009 17:52:37 +0000 (12:52 -0500)]
`be email-bugs` now uses `be show` internals to produce consistent XML.
Broke the bulk of show.py out into new function show.output(), which
is used by both show.py and email_bugs.py to reduce duplication of
effort and increase consistency of the XML.
Also a few relevant help string updates.
W. Trevor King [Sat, 21 Nov 2009 17:23:47 +0000 (12:23 -0500)]
Upgraded `be show --xml` to new <be-xml> format.
W. Trevor King [Sat, 21 Nov 2009 15:53:04 +0000 (10:53 -0500)]
Broke `be comment --xml` out and extended into `be import-xml`.
It should currently do everything that `be comment --xml` did, but it
still has a way to go before it lives up to it's longhelp string,
mostly figuring out bug/comment merging.
The allowed XML format also changed a bit, becoming a bit more
structured.
cmdutil.bug_from_shortname() renamed to cmdutil.bug_from_id().
New functions cmdutil.parse_id() and cmdutil.bug_comment_from_id().
Additional doctests in libbe.comment.Comment.comment_shortnames() to
show example output if bug_shortname==None.
Brought be-xml-to-mbox and be-mbox-to-xml up to speed on the current
<be-xml>-rooted format.
* Added <extra-string> handling to their comment handling.
* Moved extra strings from email bodies to X-Extra-String headers
(some comment bodies are not text, and we should keep the estr
location consistent between bugs and comments.)
W. Trevor King [Fri, 20 Nov 2009 22:09:08 +0000 (17:09 -0500)]
Added Bug.from_xml() + some .from_xml() fixups.
Moved comment.InvalidXML to utility.InvalidXML, so that bug and
comment can share it. Added docstring explaining the __init__
arguments.
Added indent and shortname options to Bug.xml() to match
Comment.xml().
Added .extra_strings export to Comment.xml().
Converted Bug.xml() from string addition to list joining, which avoids
a bunch of memory allocation/deallocation.
Assorted " -> ' replacements.
Elaborated doctests to check UTF-8, extra_strings, ...
Added new comparison cmp_extra_strings for both bug. and
comment.DEFAULT_CMP_FULL_CMP_LIST.
W. Trevor King [Fri, 20 Nov 2009 22:07:57 +0000 (17:07 -0500)]
Import os in libbe.subproc if _POSIX == True
W. Trevor King [Fri, 20 Nov 2009 21:48:07 +0000 (16:48 -0500)]
Fixed bug
529c290e-b1cf-4800-be7e-
68f1ecb9565c (howto version BE).
Also appended some of the recent discussion about releases to the
comment list.
W. Trevor King [Fri, 20 Nov 2009 20:10:59 +0000 (15:10 -0500)]
Fix typo in becommands.init's doctest
W. Trevor King [Fri, 20 Nov 2009 20:09:42 +0000 (15:09 -0500)]
Import select in libbe.subproc if _POSIX == True
W. Trevor King [Fri, 20 Nov 2009 19:29:01 +0000 (14:29 -0500)]
Adjusted test.py to use an installed vcs by default.
Protects agaist the off chance that the user doesn't have Arch (tla)
installed ;).
Changed Arch.name from "Arch" to "arch" so that each VCSs .name
matches the module name. This allows us to use vcs.VCS_ORDER (a list
of module names) to set up the allowed values of BugDir.vcs_name.
W. Trevor King [Fri, 20 Nov 2009 18:25:08 +0000 (13:25 -0500)]
Added becommands/email_bugs.py
This send a list of bugs in a single email off to be processed by
be-handle-mail. Of course, be-handle-mail doesn't yet handle the
[be-bug:xml] format that email_bugs.py creates. On to that now...
W. Trevor King [Fri, 20 Nov 2009 15:48:36 +0000 (10:48 -0500)]
Broke subprocess handling out into its own submodule libbe.subproc.
W. Trevor King [Fri, 20 Nov 2009 14:41:44 +0000 (09:41 -0500)]
Removed superfluous 'import time' from becommands/commit.py doctest.
W. Trevor King [Fri, 20 Nov 2009 13:33:40 +0000 (08:33 -0500)]
Created bug
56506b73-36cc-4e32-a578-
258a219edba8 describing problem
W. Trevor King [Fri, 20 Nov 2009 12:57:17 +0000 (07:57 -0500)]
Have release.py update copyrights as well.
W. Trevor King [Fri, 20 Nov 2009 12:28:20 +0000 (07:28 -0500)]
Added release.py script automating release process
W. Trevor King [Thu, 19 Nov 2009 21:45:53 +0000 (16:45 -0500)]
Merged updated READMEs and new update_copyright.py (and its results).
W. Trevor King [Thu, 19 Nov 2009 22:00:02 +0000 (17:00 -0500)]
Ran the new update_copyright.py
W. Trevor King [Thu, 19 Nov 2009 21:59:06 +0000 (16:59 -0500)]
Translated update_copyright.sh to Python update_copyright.py
W. Trevor King [Thu, 19 Nov 2009 05:39:31 +0000 (00:39 -0500)]
Updated README and Bugs-Everywhere-Web/README.
W. Trevor King [Wed, 18 Nov 2009 00:55:42 +0000 (19:55 -0500)]
Updated NEWS file
W. Trevor King [Tue, 17 Nov 2009 14:51:18 +0000 (09:51 -0500)]
Fixed bug with unicode handling reported by Nicolas Alvarez.
Date: Mon, 16 Nov 2009 20:34:50 -0300
From: Nicolas Alvarez <nicolas.alvarez@gmail.com>
Subject: [Be-devel] Mercurial + BE + Unicode doesn't work
My username in ~/.hgrc contains a Unicode character. When I run "be new" on
a Mercurial repository, I get an unhandled Python exception:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 13:
ordinal not in range(128)
The following shell script should reproduce the error:
#!/bin/sh
repo=/tmp/`mktemp -d bug-repro.XXXX`
hg init $repo
cd $repo
/usr/bin/printf "[ui]\nusername = Nicol\u00e1s\n" > $repo/.hg/hgrc
be set-root $repo
be new "Testing"
rm -rf /tmp/$repo
[WTK:
Note that the
be set-root
usage is out of date, it is now
be init
]
W. Trevor King [Tue, 17 Nov 2009 14:47:44 +0000 (09:47 -0500)]
Use unicode_output=False in some Darcs._u_invoke_client() calls.
This avoids the following error:
======================================================================
ERROR: Should get file contents as committed to specified revision.
----------------------------------------------------------------------
Traceback (most recent call last):
File ".../libbe/vcs.py", line 860, in test_revision_file_contents_as_committed
full_path, revision)
File ".../libbe/vcs.py", line 339, in get_file_contents
contents = self._vcs_get_file_contents(relpath,revision,binary=binary)
File ".../libbe/darcs.py", line 122, in _vcs_get_file_contents
status,output,error = self._u_invoke(args, stdin=major_patch)
File ".../libbe/vcs.py", line 488, in _u_invoke
raise CommandError(args, status, stdout, stderr)
CommandError: Command failed (2):
patch: **** Only garbage was found in the patch input.
while executing
['patch', '--reverse', 'a/text']
After adding the unicode_output=False lines, I adjusted the
VCS._u_invoke_client() definition to pass all it's kwargs
automatically through to VCS._u_invoke(). To make this simpler and
more consistent, I renamed the "directory" option to "cwd", and
adjusted *._u_invoke() calls appropriately in several VCS backends.
W. Trevor King [Tue, 17 Nov 2009 14:04:37 +0000 (09:04 -0500)]
Cleanup temp. dir. in libbe.vcs tests.
W. Trevor King [Tue, 17 Nov 2009 13:48:14 +0000 (08:48 -0500)]
"CommandStderr" -> "CommandError" in VCS._u_invoke()
Corrects a mistake from using string replace to move output,error ->
stdout,stderr a few commits ago.
W. Trevor King [Tue, 17 Nov 2009 13:43:44 +0000 (08:43 -0500)]
Don't attempt to convert unicode objects to strings in *._setting_attr_string()
W. Trevor King [Tue, 17 Nov 2009 13:36:22 +0000 (08:36 -0500)]
Set binary=True for mapfile file handling
The YAML library produces Python string encodings of unicode objects.
There's no reason to try and convert them back into Python unicode
objects just to save them with binary=False, because the files are
only read in to be passed into the YAML parser, which can handle the
unicode characters correctly.
W. Trevor King [Tue, 17 Nov 2009 13:25:15 +0000 (08:25 -0500)]
Added unicode_output option to VCS._u_invoke()
W. Trevor King [Tue, 17 Nov 2009 13:21:56 +0000 (08:21 -0500)]
rename "output","error" -> "stdout","stderr" in VCS._u_invoke()
W. Trevor King [Sat, 24 Oct 2009 11:21:07 +0000 (07:21 -0400)]
Merged Gianluca's nested directory fix.
Gianluca Montecchi [Thu, 22 Oct 2009 20:20:19 +0000 (22:20 +0200)]
- Merged Trevor branch
- Reapplied the fix for subdirs
Gianluca Montecchi [Wed, 21 Oct 2009 21:34:05 +0000 (23:34 +0200)]
Fixed a typo in the --export-dir-template options
Gianluca Montecchi [Wed, 21 Oct 2009 21:30:35 +0000 (23:30 +0200)]
Fixed a problem with the creation of nested directory
(i.e.: be html -o dir1/dir2 failed to create dir2 if dir1 does not exists)
W. Trevor King [Wed, 21 Oct 2009 15:03:50 +0000 (11:03 -0400)]
Merged Gianluca's recent `be html` work.
* Added --export-template and --export-template-dir
* Fixed index page row colors.
* Fixed --index-header
Also a bit of tightening on my own:
* Inspired by ._write_file, wrote ._read_file and .make_dir.
* Wrapped some lines to stay under 80 characters,
* Stripped trailing whitespace.
gian [Wed, 21 Oct 2009 12:51:06 +0000 (14:51 +0200)]
test for bzr merge
Gianluca Montecchi [Tue, 20 Oct 2009 23:18:40 +0000 (01:18 +0200)]
Finished merge with Trevor branch
Gianluca Montecchi [Tue, 20 Oct 2009 23:14:10 +0000 (01:14 +0200)]
added the --export-template and --export-dir_template
to export the default template
Gianluca Montecchi [Tue, 20 Oct 2009 22:37:18 +0000 (00:37 +0200)]
The (ugly) colors are back
Gianluca Montecchi [Tue, 20 Oct 2009 21:15:27 +0000 (23:15 +0200)]
Fixed the wrong index_header values
Gianluca Montecchi [Tue, 20 Oct 2009 21:08:57 +0000 (23:08 +0200)]
merged with Trevor branch
W. Trevor King [Tue, 20 Oct 2009 13:38:17 +0000 (09:38 -0400)]
Merged my cleanup of Gianluca's HTML branch.
This fixes a bug in binary comments (non-"text/" content-types), where
the content-type wasn't being set until _after_ the save was
attempted. This led to errors for non-ascii bodies (e.g. images with
null characters).
Note that text/html comments are included as is, so make sure they are
formatted appropriately to fit into your tempate without creating
invalid code. This issue could be a real pain in the neck, especially
when including text/html email bodies, which might contain <body>
tags, etc.. Stupid email clients that don't send a text/plain
alternative...
W. Trevor King [Tue, 20 Oct 2009 13:37:22 +0000 (09:37 -0400)]
Save non-text/ comments as separate files. Inline images.
W. Trevor King [Tue, 20 Oct 2009 13:30:42 +0000 (09:30 -0400)]
Pass content_type to Comment.new_reply() to fix error adding non-text/ comments
W. Trevor King [Tue, 20 Oct 2009 12:28:35 +0000 (08:28 -0400)]
Restructured becommands/html to make templating more flexible + general cleanups.
W. Trevor King [Tue, 20 Oct 2009 01:36:25 +0000 (21:36 -0400)]
General cleanup of becommands/html.py
W. Trevor King [Mon, 19 Oct 2009 23:52:14 +0000 (19:52 -0400)]
Merged Gianluca's html becommand with templates.
W. Trevor King [Mon, 19 Oct 2009 19:51:34 +0000 (15:51 -0400)]
Non-event merge with trunk, just to pull in that bit of history
Gianluca Montecchi [Thu, 8 Oct 2009 20:18:50 +0000 (22:18 +0200)]
Reworked the html command template system