Carl Worth [Wed, 21 Apr 2010 21:16:20 +0000 (14:16 -0700)]
emacs: Fix notmuch-search-authors-width declaration.
Our defcustom call was missing the 'notmuch group, which emacs was
nice enough to warn about during compilation.
David Edmondson [Mon, 12 Apr 2010 07:51:30 +0000 (08:51 +0100)]
emacs: Support for customizing search result display
This patch helps in customizing search result display similar to
mutt's index_format. The customization is done by defining an alist as
below:
(setq notmuch-search-result-format '(("date" . "%s ")
("authors" . "%-40s ")
("subject" . "%s ")))
The supported keywords are date, count, authors, subject and tags.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>
Signed-off-by: David Edmondson <dme@dme.org>
Carl Worth [Wed, 21 Apr 2010 20:19:19 +0000 (13:19 -0700)]
emacs/notmuch-show.el: Part headers are real buttons that save the part
Convert the part headers into buttons that save the part when
activated.
David Edmondson [Thu, 1 Apr 2010 17:33:46 +0000 (18:33 +0100)]
emacs: Display all body parts using `notmuch part --part=<n>'
Use the `notmuch part' command to access body parts not currently
included in the JSON output and display those body parts
appropriately.
David Edmondson [Tue, 23 Mar 2010 11:54:05 +0000 (11:54 +0000)]
emacs: Use mailcap.el to guess the type of application/octet-stream parts
Use the mailcap functionality to guess a MIME type for attachments of
type application/octet-stream and, presuming successful, feed the
attachment back into the display code with the determine type.
This is mostly useless at the moment, as the JSON output from notmuch
does not include the content of application/octet-stream parts, so
they cannot be displayed even if the guess is a good one.
David Edmondson [Tue, 23 Mar 2010 11:54:05 +0000 (11:54 +0000)]
emacs: Use `mm-display-part' when possible
For parts that the mm-decode/mm-view functions can inline and we have
the content, use `mm-display-part' to insert the part in the
buffer.
David Edmondson [Tue, 23 Mar 2010 10:06:00 +0000 (10:06 +0000)]
emacs/notmuch-show.el: Improved part labelling
If a text/plain part is not the first part in a message, add a label
in order that a user can see that multiple parts are present.
If a part has a 'filename' attribute, include it in any label
describing the part.
David Edmondson [Mon, 22 Mar 2010 16:49:16 +0000 (16:49 +0000)]
emacs: Move body markup to a separate file
Move the citation and signature markup for text/plain parts to a new
file (notmuch-wash.el) and call it using a hook mechanism rather than
directly.
Carl Worth [Wed, 21 Apr 2010 19:50:10 +0000 (12:50 -0700)]
emacs: Rename body-invis-spec to message-invis-spec
This is more consistent with the related names (toggle-message,
:message-visible, etc.)
Carl Worth [Wed, 21 Apr 2010 19:32:29 +0000 (12:32 -0700)]
emacs: Remove the notmuch-show-toggle-body command (with "b" binding)
In the recent switch to a JSON-based emacs interface, RET now toggles
message visibility anywhere in the message, (rather than only on the
summary line). So we no longer need this separate "b" binding for this.
Additionally, the body toggle was implemented independently from RET,
so after hiding a message with "b" one could not make it visible with
RET. This confusing state is now no longer possible, (since the
:body-visible property is removed entirely).
David Edmondson [Sun, 11 Apr 2010 07:58:43 +0000 (08:58 +0100)]
emacs: JSON based implementation
Re-implement notmuch-show.el using the JSON output format of the
notmuch command. Most functionality is retained - HTML display is
noticeably missing.
Anthony [Tue, 20 Apr 2010 15:55:31 +0000 (08:55 -0700)]
json_quote_chararray: Always return a newly talloced array
The special case for len==0 was wrong---the normal code path is to
talloc to get a newly allocated, editable string, that might be
talloc_free'd later. It makes more sense just to let the len==0
behaviour fall through into the normal case code.
Reviewed-by: Carl Worth <cworth@cworth.org>
This results in the same value being returned, but with the proper
memory handling.
David Edmondson [Tue, 6 Apr 2010 07:24:00 +0000 (08:24 +0100)]
json: Avoid calling strlen(NULL)
MIME parts may have no filename, which previously resulted in calling
strlen(NULL).
David Edmondson [Wed, 24 Mar 2010 15:50:11 +0000 (15:50 +0000)]
emacs/notmuch.el: Enable `hl-line-mode' in `notmuch-search-mode'
David Edmondson [Mon, 22 Mar 2010 14:50:20 +0000 (14:50 +0000)]
emacs/notmuch-show.el: Avoid passing unintended format strings to `message'
If the text being stashed included %, `message' was unhappy and
complained.
Carl Worth [Mon, 19 Apr 2010 17:13:29 +0000 (10:13 -0700)]
debian: Make git ignore several intermediate files.
The "make release" target doesn't cause these to be left around, but
manually doing something like ./debian/rules/build can.
Carl Worth [Fri, 16 Apr 2010 20:13:12 +0000 (13:13 -0700)]
make release: Add Debian package building and upload
Finally, a single button to push to do all the uploading.
Carl Worth [Fri, 16 Apr 2010 20:02:03 +0000 (13:02 -0700)]
Increment version to 0.2.
Only minor features added this time--nothing that merits a 1.0.
Carl Worth [Fri, 16 Apr 2010 20:00:35 +0000 (13:00 -0700)]
make release: Add a check that version and debian/changelog are consistent
Eventually I'd like to automate this so that one or the other of these
files is canonical and the other is generated from it. Until then, add
this check to the release process to avoid a skewed release being
shipped.
Carl Worth [Fri, 16 Apr 2010 19:10:23 +0000 (12:10 -0700)]
Makefile: Avoid complaining about .first-build-message not existing
This cleans up a few spurious warnings from the build.
Carl Worth [Fri, 16 Apr 2010 18:51:56 +0000 (11:51 -0700)]
Fix final link of notmuch binary to use C compiler if possible.
On Linux, a C program that depends on a C library which in turn
depends on a C++ can be linked with the C compiler, (avoiding a direct
link from the program to the C++ runtime libraries).
Other platforms with less fancy linkers need to use the C++ compiler
for this linking.
Carl Worth [Fri, 16 Apr 2010 18:35:33 +0000 (11:35 -0700)]
debian: Remove watch file.
We're switching to a native package, where we build the upstream and
debian releases simultaneously, so there's no need for a watch file.
Carl Worth [Fri, 16 Apr 2010 18:32:41 +0000 (11:32 -0700)]
debian: Switch to "3.0 (native)" source format.
To keep lintian happy.
Carl Worth [Fri, 16 Apr 2010 18:24:43 +0000 (11:24 -0700)]
Makefile: Fix conditionals to avoid calling git when no .git is present
Otherwise, building from a tar-file snapshot or release caused a bunch
of error messages from unnecessary git invocations.
Carl Worth [Fri, 16 Apr 2010 18:08:56 +0000 (11:08 -0700)]
Makefile: Add a top-level "make snapshot" target.
Useful for verifying that our tar-file creation works. The tar-file
name can't easily be used as a target directly since it depends on the
current git revision.
Carl Worth [Fri, 16 Apr 2010 18:03:25 +0000 (11:03 -0700)]
Makefile: Rework the version checks slightly.
Theese were previously pointing to "make VERSION=X.Y release", but
we've recently changed to an alternate scheme involving the updated
version in a file named "version".
Carl Worth [Fri, 16 Apr 2010 17:58:53 +0000 (10:58 -0700)]
RELEASING: Add a step to upgrade the version in the "version" file.
It is annoying to have an extra step here, but it does at least mean
that we are back to just "make release" rather than "make VERSION=X.Y
release".
Carl Worth [Fri, 16 Apr 2010 17:37:32 +0000 (10:37 -0700)]
Makefile: Add an explicit version file to the repository.
We do this so that "git archive" produces a usable tar file without us
having to post-modify it, (since tools like git-buildpackage might not
give us an easy way to hook into the tar-file-creation step).
To support this we also have to change our preference to prefer the
git-described-based version (if available) and only if not available
do we fallback to using what's in the "version" file. Finally, we also
ovverride this preference when releasing, (where what's in the
"version" file wins).
Note that using our Makefile's rule to create a tar file still will
insert the git-based version into the tar file. This is useful for
creating snapshots which will correctly report the git version from
which they were created.
Carl Worth [Fri, 16 Apr 2010 17:24:38 +0000 (10:24 -0700)]
debian/changelog: Create an entry for the 0.2 release.
A (very slightly filtered) version of what already appears in NEWS.
Carl Worth [Fri, 16 Apr 2010 17:23:50 +0000 (10:23 -0700)]
RELEASING: Add a (manual!) step to create a debian/changelog entry
I'd like to have this be fully automated in the future, but for now,
it's an extra step.
Carl Worth [Fri, 16 Apr 2010 17:00:11 +0000 (10:00 -0700)]
debian: Don't auto-generate debian/changelog.
David Bremner informs me that shoving everything from the notmuch "git
log" into the debian/changelog is a bit excessive. Instead, we'll
start manually updating this file, (which feels a bit redundant with
NEWS, but perhaps makes us a better Debian-comunity member).
Carl Worth [Fri, 16 Apr 2010 15:49:09 +0000 (08:49 -0700)]
debian: Add a gbp.conf to start using git-buildpackage
On Bdale Garbee's recommendation I'm switching from gitpkg, (which
constructed a source tree but still required me to go run debuild), to
git-buildpackage. I hadn't originally used git-buildpackage because it
didn't seem to work without a configuration file, (where gitpkg was
fine).
Bdale was kind enough to point me to his fw/altos source at
git.gag.com where I found an example gpb.conf file as well as a target
in debian/rules to automatically update debian/changelog with the new
version number.
Carl Worth [Fri, 16 Apr 2010 15:33:31 +0000 (08:33 -0700)]
make release: Don't print the release message on stdout.
It's just too long for copy/paste, so just let the user know the name
of the file containing the message instead.
Carl Worth [Fri, 16 Apr 2010 15:31:46 +0000 (08:31 -0700)]
Makefile: Fix "make release" to print the current release announcement.
This was accidentally hard-coded to always print the 0.1 NEWS blurb.
Carl Worth [Fri, 16 Apr 2010 15:28:05 +0000 (08:28 -0700)]
NEWS: Add release notes for the 0.2 release.
Carl Worth [Fri, 16 Apr 2010 14:53:10 +0000 (07:53 -0700)]
Revert "notmuch.el: 'F' in search mode takes us to a list of folders."
This reverts commit
fbec989fe3272d6eff038369587be076347b96f0.
I only pushed this accidentally. See message
id:871ver6u9r.fsf@yoom.home.cworth.org for the various reasons I
didn't like this patch, (mostly I think the association of 'F' is
wrong).
Sebastian Spaeth [Fri, 16 Apr 2010 07:06:02 +0000 (09:06 +0200)]
notmuch.c: Shorten version string
We previously output "notmuch version 0.1" as response to notmuch --version.
Shorten this to "notmuch 0.1" as we know that we will receive a version
number when we explicitely ask for it.
Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
Carl Worth [Fri, 16 Apr 2010 04:22:57 +0000 (21:22 -0700)]
emacs: Fix search filtering of a global search ("*")
With the recent addition of "*" being a special case for a search
matching all messages, we have to take care when doing a filter
operation. In this case it's not legal to simply append and get:
* and <some-new-search-terms>
Instead we carefully construct a new search string of only:
<some-new-search-terms>
This could all be avoided if we had a parser that could understand
"*" with the meaning we want.
Carl Worth [Fri, 16 Apr 2010 03:52:27 +0000 (20:52 -0700)]
TODO: Add two tasks that both have to do with auditing the library API
It was noted today in IRC that libnotmuch is not yet careful about
wrapping all Xapian calls with try/catch blocks to print nicer error
messages. It seems it would be natural to audit that at the same time
as doing the symbol-hiding work.
Carl Worth [Fri, 16 Apr 2010 03:50:46 +0000 (20:50 -0700)]
RELEASING: Change wording of libnotmuch version instruction
We actually want this version to be incremented by the commits that
extend the interface. So the release process really is not to just
verify two things (NEWS and libnotmuch version), then run "make
VERSION=x.y release", and send the mail. Quite nice.
Carl Worth [Fri, 16 Apr 2010 03:03:30 +0000 (20:03 -0700)]
make release: Enforce a clean source tree before release.
Where by clean, we check that no files are known to git to be
modified.
Carl Worth [Fri, 16 Apr 2010 02:55:11 +0000 (19:55 -0700)]
RELEASING: Remove a meaningless step from the release process.
The entire "make sure the code you want is in place" thing is part of
a larger release process that we don't document here at all. Instead,
we just focus here on the mechanics of pushing things out once the
larger process has determined the code is ready.
And the fewer steps there are, the better, (for making the
release-process as painless as possible and for avoiding any
mistakes).
Gregor Hoffleit [Thu, 15 Apr 2010 09:51:47 +0000 (11:51 +0200)]
configure: Fix syntax error (spaces in assignment).
Before and after the assignment operator, no spaces are allowed.
I don't know if there are any /bin/sh which allow spaces, but at least
in bash, csh and zsh, the former code was no valid assigment.
Ben Gamari [Sun, 24 Jan 2010 21:23:34 +0000 (16:23 -0500)]
Fix typo in message
Carl Worth [Fri, 16 Apr 2010 01:40:08 +0000 (18:40 -0700)]
make release: Provide a kinder message when VERSION is forgotten.
I'm unlikely to always remember to pass VERSION=X.Y so it's nice for
make release to remind me.
Carl Worth [Thu, 15 Apr 2010 23:28:13 +0000 (16:28 -0700)]
Makefile: Re-order the commands in "make release" slightly.
We put verify-version as a dependency, not a recursive action to keep
its output clean, (I know that I will always type "make release"
instead of "make VERSION=X.Y release" so I want a nice, neat
reminder).
Also, put the various ssh-based commands together, and after the
build, (so that it doesn't ask for a password/passphrase both before
and after building).
Carl Worth [Thu, 15 Apr 2010 23:23:57 +0000 (16:23 -0700)]
Makefile: Simplify the release targets.
Previously, we had a separate release-upload target that a user might
mistake as something useful to call directly, (which would have the
undesired effect or uploading a new package, but without first making
all the checks that we want).
So we eliminate that target, (folding its actions into "make
release"), and we also rename the several release-verify-foo targets
to simply verify-foo. This leaves as the only targets with "release"
in the name as "release" and "release-message". Both of these are
intended for the user to call directly.
Carl Worth [Thu, 15 Apr 2010 23:17:32 +0000 (16:17 -0700)]
Makefile.local: Fix typo in comment.
Just an extra word that clearly didn't belong.
Carl Worth [Thu, 15 Apr 2010 23:09:43 +0000 (16:09 -0700)]
RELEASING: Remove obsolete step about updating micro version number.
We've now changed to using "git describe" to automatically report a
version number that changes with every git commit. So we no longer
need to manually update anything in the Makefile during the release
process.
Carl Worth [Thu, 15 Apr 2010 23:08:37 +0000 (16:08 -0700)]
Makefile: Make "make release" run the test suite.
This drops one manual step from our release process, (helping
to ensure we don't forget anything during the release).
Carl Worth [Thu, 15 Apr 2010 22:18:30 +0000 (15:18 -0700)]
make test: Actually count and report on failures.
Hurrah---no more manual verification of that PASS column.
This means that "make test" can actually be a useful part of the
release process now, (since it will exit with non-zero status if there
are any failures).
Carl Worth [Thu, 15 Apr 2010 22:09:21 +0000 (15:09 -0700)]
test: Unify all tests to use the pass_if_equal function.
Previously some tests (dump/restore) were doing ad-hoc verification of
values and their own printing of PASS/FAIL, etc. This made it
impossible to count test pass/fail rates in a single place.
The only reason these tests were written that way was because the old
execute_expecting function only worked if one could directly test the
stdout output of a notmuch command. The recent switch to pass_if_equal
means that all tests can use it.
Carl Worth [Thu, 15 Apr 2010 22:06:00 +0000 (15:06 -0700)]
test: Align the PASS/FAIL column.
Just to make things a little more pleasant to look at.
Carl Worth [Thu, 15 Apr 2010 21:56:21 +0000 (14:56 -0700)]
Makefile: Add a "make test" target.
I just wasted far too much time looking for a bug that wasn't actually
there only because I hadn't recompiled before running the test
suite. Now we can take advantage of actual dependency information to
force a rebuild for "make test".
Carl Worth [Thu, 15 Apr 2010 16:15:10 +0000 (09:15 -0700)]
lib: search_threads: Fix nested search to handle original search of "*"
When constructing a thread, we usually run a nested query to find all
messages in the thread that match the original search string. However,
we need to have special-case handling of an original search string of
"*" now that that is a supported means of specifying all messages.
The special-case ends up bein quite simple---we do less work, (just
skipping the nested search since we know that all messages must
match). I had been wanting to write this identical code to more
efficiently handle "notmuch search thread:<foo>" which was previously
running two identical searches. So that case is now more efficient as
well.
Carl Worth [Thu, 15 Apr 2010 21:06:10 +0000 (14:06 -0700)]
test: Add a test for "notmuch search '*'"
This feature was added recently and should have gotten a new test at
the time.
As this test demonstrates, the code is broken, ("notmuch search '*'
returns bogus dates of the Unix epoch for any threads where the
term "and" does not appear in any messages).
Carl Worth [Thu, 15 Apr 2010 21:09:07 +0000 (14:09 -0700)]
test: Use an older date for the generated messages.
Using a date in the current year makes the test suite fragile since
the search output will include a date of "January 05" for now, but
will start doing "2010-01-05" in the future.
Carl Worth [Thu, 15 Apr 2010 21:01:54 +0000 (14:01 -0700)]
test: Remove test-message filenames from generated messages
The filenames aren't predictable (including the current directory) nor
stable from one run to the next (including the PID). This makes it
hard to predict the output from a search command that returns such a
message (such as "*").
The original goal was simply to ensure that each generated message was
distinguishable somehow. So just use the message counter instead.
Carl Worth [Thu, 15 Apr 2010 20:44:00 +0000 (13:44 -0700)]
test: Disentangle execution of notmuch from the examination of the results.
The old execute_expecting function was doing far too much for its own
good. One of the worst aspects of this was that it introduced
shell-quoting challengers where the caller could not easily control
the precise invocation of the command to be executed.
I personally couldn't find a way to test "notmuch search '*'" without
the shell expanding * against files in the current directory, or
having bogus quotation marks appearing in the search string,
(defeating the recognition of "*" as a special search term).
Hopefully this aspect of the test suite will be much easier to maintain now.
Carl Worth [Thu, 15 Apr 2010 20:19:19 +0000 (13:19 -0700)]
TODO: Add some ideas for improving the emacs interface.
One of these is a bad bug I noticed this morning, (archiving messages I had
never read when going through a search of "tag:inbox and tag:to-me" and
hitting space bar).
The other ideas came from recent conversations with Dirk and Eric.
Carl Worth [Thu, 15 Apr 2010 20:15:27 +0000 (13:15 -0700)]
TODO: Add some ideas about better search syntax
Recent coding around the "*" feature suggests some improvements that
we could make, (some of which might push us into writing a custom
query parser rather than using the one that exists in Xapian).
Carl Worth [Thu, 15 Apr 2010 00:19:42 +0000 (17:19 -0700)]
Merge bugfix for test-suite correctness.
The test suite was recently broken, and subsequently fixed (at the
commit that introduced the breakage). This merges that fixup commit:
f1776f8b51013bb66eb21e64c8084ddfe73c3a5c
Carl Worth [Thu, 15 Apr 2010 00:17:50 +0000 (17:17 -0700)]
test: Fix reply tests to track insignificant change in output.
The recent fix to properly decode encoded headers made the expected
output of "notmuch reply" differ by a single space, (previously, there
were two spaces before the References: value and now there is just
one).
Fix the test suite so that these are all noted as correct results
again.
Carl Worth [Wed, 14 Apr 2010 23:29:50 +0000 (16:29 -0700)]
Makefile: Fix final linking of notmuch binary for OS X.
Apparently the OS X linker can't resolve symbols when linking a
program (notmuch) against a library (libnotmuch) when the library
depends on another library (libgmime) that the program doesn't depend
on directly.
For this case, we need to link the program directly against both
libraries, but we don't want to do this on Linux, where the linker can
do this on its own and the explicit, unneeded link would cause
problems.
Carl Worth [Wed, 14 Apr 2010 23:18:19 +0000 (16:18 -0700)]
Makefile: Add library version information on OS X.
This encodes the library version into the library, where the linking
binary can pick it up, and the linker can even enforce mismatches in
the minor release, (such as linking a binary against version 1.2 and
then attempting to run it against version 1.1).
Carl Worth [Wed, 14 Apr 2010 23:16:05 +0000 (16:16 -0700)]
Makefile: Fix library linking command for OS X
I'm not sure which system Aaron used, but on the machine I have access
to, (Darwin 8.11.0), the -shared and -dylib_install_name options are
not recognized. Instead I use -dynamic_lib and -install_name as
documented here:
http://www.finkproject.org/doc/porting/shared.php
Aaron Ecay [Sun, 11 Apr 2010 23:44:53 +0000 (19:44 -0400)]
Add infrastructure for building shared library on OS X.
This patch adds a configure check for OS X (actually Darwin),
and sets up the Makefiles to build a proper shared library on
that platform.
Signed-off-by: Aaron Ecay <aaronecay@gmail.com>
Carl Worth [Wed, 14 Apr 2010 23:03:18 +0000 (16:03 -0700)]
Makefile: Move compat sources from the client code to the library.
Since the library code needs these as well.
Dirk Hohndel [Tue, 13 Apr 2010 16:47:48 +0000 (09:47 -0700)]
Add simplistic reimplementation of strcasestr to compat library
While all systems that I have access to support strcasestr, it is
in fact not part of POSIX. So here's a fallback reimplementation
based on POSIX functions.
Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Tested-by: Tomas Carnecky <tom@dbservice.com> (on OpenSolaris snv_134)
Carl Worth [Wed, 14 Apr 2010 18:32:26 +0000 (11:32 -0700)]
Makefile: Move include of Makefile.config up from Makefile.local
The recent change to include sub-directory Makefile.local files
before the top-level Makefile.local means that we need to include
the Makefile.config before those. So move it up from Makefile.local
to Makefile.
Aaron Ecay [Sun, 11 Apr 2010 23:44:52 +0000 (19:44 -0400)]
Fix up Makefile for build.
Must set extra_c(xx)flags before including subdir Makefile.local's,
so that there is a blank slate that the subdirs can add on to.
Must include subdir Makefile.local's before global one, otherwise
the compat sources are not added to the list of those to be
compiled.
Signed-off-by: Aaron Ecay <aaronecay@gmail.com>
Aaron Ecay [Sun, 11 Apr 2010 23:44:51 +0000 (19:44 -0400)]
Use C++ compiler to link notmuch binaries
Since the binaries contain C++ code, it is necessary to use the C++
linker, or errors result on some platforms (OS X).
Signed-off-by: Aaron Ecay <aaronecay@gmail.com>
Jesse Rosenthal [Tue, 13 Apr 2010 18:47:19 +0000 (14:47 -0400)]
Clean up code duplication in adding or removing tag by region.
Clean up code duplication, as per Carl's suggestion, by making
notmuch-search-{add/remove}-tag-thread a special case of the -region
commands, where the region in question is between (point) and (point).
Jesse Rosenthal [Tue, 13 Apr 2010 18:47:19 +0000 (14:47 -0400)]
Fix bug in adding or removing tag by region.
There was a bug in notmuch-search-{add,remove}-tag-region, which would
not behave correctly if the region went beyond the last message. Now,
instead of simply iterating to the last line of the region, these
functions will iterate to the minimum of the last line of the region
and the last possible line, i.e.
(- (line-number-at-pos (point-max)) 2)
Tested-by: Carl Worth <cworth@cworth.org> Note that the old, buggy
behavior included infinite loops of emacs lisp code, so the new
behavior is significantly better than that.
Carl Worth [Tue, 13 Apr 2010 17:10:37 +0000 (10:10 -0700)]
TODO: Capture some recent ideas expressed on the mailing list.
There's a potential simplification of notmuch-reply.c and some emacs
improvements that might require extending message-mode to a
notmuch-message-mode.
Michal Sojka [Wed, 3 Mar 2010 07:50:56 +0000 (08:50 +0100)]
Decode headers in reply
When headers contain non-ASCII characters, they are encoded according
to rfc2047. Nomtuch reply command emits the headers in the encoded
form, which makes them hard to read by humans who compose the reply.
For example instead of "Subject: Re: Rozlučka" one currently sees
"Subject: Re: =?iso-8859-2?q?Rozlu=E8ka?=".
This patch adds a new GMime filter which is used to decode headers to
UTF-8 and uses this filter when notmuch reply outputs headers.
Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
Jesse Rosenthal [Sun, 24 Jan 2010 20:22:33 +0000 (15:22 -0500)]
notmuch.el: quote args in notmuch-show to facilitate remote use
Put single-quotes around the argument of the `show --entire-thread' command
in notmuch-show. This change should have no effect on normal usage.
However, it allows us to use the notmuch.el client with a remote notmuch
binary and database over ssh (by, e.g., setting `notmuch-command' to a
simple shell script). Without the quotes, ssh will not send the command
properly.
One very simple example script is as follows. (Note that it requires
keypair login to the ssh server.)
#!/bin/sh
SSH_BIN="/path/to/local/ssh"
NOTMUCH_HOST="my.remote.server"
NOTMUCH_REMOTE_PATH="/path/to/remote/notmuch"
$SSH_BIN $NOTMUCH_HOST $NOTMUCH_REMOTE_PATH $@
Carl Worth [Tue, 13 Apr 2010 15:50:44 +0000 (08:50 -0700)]
TODO: Note GMime bug that needs to be tested and upstreamed.
This bug was recently noted in a commit message, so we should hold
onto it until we've passed it along to the GMime project.
martin f. krafft [Tue, 2 Mar 2010 15:31:28 +0000 (16:31 +0100)]
Do not segfault on empty mime parts
notmuch previously unconditionally checked mime parts for various
properties, but not for NULL, which is the case if libgmime encounters
an empty mime part.
Upon encounter of an empty mime part, the following is printed to
stderr (the second line due to my patch):
(process:17197): gmime-CRITICAL **: g_mime_message_get_mime_part: assertion `GMIME_IS_MESSAGE (message)' failed
Warning: Not indexing empty mime part.
This is probably a bug that should get addressed in libgmime, but for
not, my patch is an acceptable workaround.
Signed-off-by: martin f. krafft <madduck@madduck.net>
Michal Sojka [Tue, 30 Mar 2010 08:23:23 +0000 (10:23 +0200)]
Prevent data loss caused by SIGINT during notmuch new
When Ctrl-C is pressed in a wrong time during notmuch new, it can lead
to removal of messages from the database even if the files were not
removed.
It happened at least once to me.
Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
Michael Forney [Fri, 26 Mar 2010 18:39:17 +0000 (18:39 +0000)]
Fix typo in notmuch.h documentation regarding database open modes
Reviewed-by: Carl Worth <cworth@cworth.org>:
The original proposal for having different open modes used the name
WRITABLE. I didn't like that name, (easy to misspell as WRITEABLE even
for native English speakers). So we renamed it to READ_WRITE
immediately, but apparently some of the documentation held the old
name for a while.
Carl Worth [Tue, 13 Apr 2010 15:33:58 +0000 (08:33 -0700)]
TODO: Make an explicit note that we need to start testing --format=json
The recent fix to handle utf8 in the JSON output is the kind of bug
I'd never like to see again, (so that I'd like the test suite to be
helping us track that).
Gregor Hoffleit [Thu, 4 Mar 2010 10:40:03 +0000 (11:40 +0100)]
Fix json_quote_str to handle non-ASCII characters
The current code in json_quote_str() only accepts strict printable ASCII
code points (i.e. 32-127), all other code points are dropped from the
JSON output. The code is attempting to drop only non-printable ASCII
characters, but doing a signed comparison of the byte value is also
dropping characters with values >= 128.
This patch uses an unsigned comparison to accept code points 32-255.
Reviewed-by: Carl Worth <cworth@cworth.org> (with some additional
details for commit message).
Carl Worth [Tue, 13 Apr 2010 15:09:12 +0000 (08:09 -0700)]
TODO: Note several changes we want to make to the database schema.
Since database upgrades can be fairly painful, we'll want to do all of
these within a single release.
Carl Worth [Mon, 12 Apr 2010 22:54:03 +0000 (15:54 -0700)]
lib: Remove condition regarding a NULL parent_thread_id.
A recent change guaranteed that a message ID can never be resolved
to a NULL thread ID, so we don't need this extra case.
Carl Worth [Mon, 12 Apr 2010 22:45:40 +0000 (15:45 -0700)]
lib: Always add reference terms to the database.
Previously, we were only adding the reference terms for cases where
the referenced message did not yet exist in the database. For thread
presentation, it's useful to have the connection information provided
by the references, even when the messages are present. So add this
term unconditionally.
Carl Worth [Mon, 12 Apr 2010 22:15:14 +0000 (15:15 -0700)]
lib: Document the metadata stored within the Xapian database.
We are currently storing "version", "last_thread_id", and
"thread_id_*" values so document how each of these are used.
Carl Worth [Mon, 12 Apr 2010 21:41:34 +0000 (14:41 -0700)]
lib: Fix line-wrapping in _notmuch_database_link_message.
This function had some excessively long lines due to nested
expressions. It's simple enough to un-nest these and have readable
line lengths.
Carl Worth [Mon, 12 Apr 2010 21:35:25 +0000 (14:35 -0700)]
lib: Fix internal documentation of _notmuch_database_link_message
This function was recently modified, (to include a metadata lookup for
a message's thread ID before looking for parent/child thread IDs), but
the documentation wasn't updated. Fix that.
Carl Worth [Mon, 12 Apr 2010 21:29:36 +0000 (14:29 -0700)]
lib: Simplify code flow in _resolve_message_id_to_thread_id
There are two primary cases in this function, (the message exists in
the database or it does not). Previously the code for these two cases
was split and intermingled with goto-spaghetti connections.
Carl Worth [Mon, 12 Apr 2010 21:19:15 +0000 (14:19 -0700)]
lib: Fix internal documentation of _resolve_message_id_to_thread_id
We no longer return NULL, but instead generate a new thread ID for
messages that we haven't seen yet.
James Westby [Sat, 13 Mar 2010 21:27:57 +0000 (16:27 -0500)]
Store thread ids for messages that we haven't seen yet
This allows us to thread messages even when we receive them out of
order, or never receive the root.
The thread ids for messages that aren't present but are referred to are
stored as metadata in the database and then retrieved if we ever get
that message.
When determining the thread id for a message we also check for this
metadata so that we can thread descendants of a message together before
we receive it.
Edited by Carl Worth <cworth@cworth.org>: Split this portion of the
commit from the earlier-applied portion adding test cases.
James Westby [Sat, 13 Mar 2010 21:27:57 +0000 (16:27 -0500)]
test: Add new tests for out-of-order messages.
These new tests demonstrate a bug as follows:
Multiple messages are added to the database
All of these message references a common parent
The parent message does not exist in the databas
In this scenario, the messages will not be recognized as belonging to
the same thread. We consider this a bug, and the new tests treat this
as a failure.
Edited by Carl Worth <cworth@cworth.org>: Split these tests into their
own commit (before the fix of the bug). This lets me see the actual
failure in the test suite, before the fix is applied. Also fix the
alignment of new messages from test suite, (so that the PASS portions
all line up---which is important while we're still manually verifying
test-suite results).
Carl Worth [Sat, 10 Apr 2010 02:12:36 +0000 (19:12 -0700)]
RELEASING: Update instructions for new version technique.
We pass this in on the "make release" command-line rather than editing
the Makefile.
Michal Sojka [Thu, 8 Apr 2010 11:49:22 +0000 (13:49 +0200)]
Derive version numbers from git
I often have several versions of notmuch compiled and it would be very
helpful to be able to distinguish between them. Git has a very nice
feature to make intermediate numbering automatic and unambiguous so
let's use it here.
For tagged versions, the version is the name of the tag, for
intermediate versions, the unique ID of the commit is appended to the
tag name.
When notmuch is compiled from a release tarball, there is no git
repository and therefore the tarball contains a special file 'version',
which contains the version of release tarball.
To create a new release one has to run 'make release VERSION=X.Y'.
Carl Worth [Fri, 9 Apr 2010 23:57:07 +0000 (16:57 -0700)]
nomtuch.1: Add documentation for "notmuch count"
Somehow this has been missing from our manual. Add it now.
Carl Worth [Fri, 9 Apr 2010 23:56:34 +0000 (16:56 -0700)]
notmuch count: Remove unneeded paragraph from documentation.
This paragraph acts like it's introducing an example, but then no
example is given. Just drop this.
Carl Worth [Fri, 9 Apr 2010 23:49:58 +0000 (16:49 -0700)]
notmuch count: Remove special handling of "*".
From both the implementation and from the documentation. This is
handled generically in the library for all search-based commands,
so count doesn't need special treatment.
Carl Worth [Fri, 9 Apr 2010 23:49:20 +0000 (16:49 -0700)]
notmuch: Document the new special-case syntax of "*".
This functionality came through a recent addition to the library.
Carl Worth [Fri, 9 Apr 2010 23:40:31 +0000 (16:40 -0700)]
lib: Handle "*" as a query string to match all messages.
This seems like a generally useful thing to support, (but the previous
support through an empty string was not convenient for some users,
(such as the command-line client).