git.git
18 years agoA better-scheduled PPC SHA-1 implementation.
Unknown [Sat, 24 Jun 2006 09:31:20 +0000 (02:31 -0700)]
A better-scheduled PPC SHA-1 implementation.

This is about 15% faster that the current sha1ppc.S on a G4, and
5% faster on a G5 when hashing 10 million bytes, unaligned.
(The G5 ratio seems to get better as the sizes fall.)

It's also somewhat smaller, due to using load-multiple instructions.

No copyright is claimed on the changes to Paul Mackerras' work below.

18 years agotest-sha1: test hashing large buffer
Junio C Hamano [Sat, 24 Jun 2006 09:59:20 +0000 (02:59 -0700)]
test-sha1: test hashing large buffer

test to hash a large buffer in one go is more important than
hashing large amount of data in small fixed chunks.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMakefile: add framework to verify and bench sha1 implementations.
Junio C Hamano [Sat, 24 Jun 2006 07:59:49 +0000 (00:59 -0700)]
Makefile: add framework to verify and bench sha1 implementations.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-pull: abort when fmt-merge-msg fails.
Junio C Hamano [Sat, 24 Jun 2006 08:10:27 +0000 (01:10 -0700)]
git-pull: abort when fmt-merge-msg fails.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'pb/error'
Junio C Hamano [Sat, 24 Jun 2006 08:06:51 +0000 (01:06 -0700)]
Merge branch 'pb/error'

* pb/error:
  usage: minimum type fix.
  Customizable error handlers
  git-merge: Don't use -p when outputting summary
  git-commit: allow -e option anywhere on command line
  patch-id: take "commit" prefix as well as "diff-tree" prefix

18 years agousage: minimum type fix.
Junio C Hamano [Sat, 24 Jun 2006 05:44:33 +0000 (22:44 -0700)]
usage: minimum type fix.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoCustomizable error handlers
Petr Baudis [Sat, 24 Jun 2006 02:34:38 +0000 (04:34 +0200)]
Customizable error handlers

This patch makes the usage(), die() and error() handlers customizable.
Nothing in the git code itself uses that but many other libgit users
(like Git.pm) will.

This is implemented using the mutator functions primarily because you
cannot directly modifying global variables of libgit from a program that
dlopen()ed it, apparently. But having functions for that is a better API
anyway.

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-merge: Don't use -p when outputting summary
Timo Hirvonen [Fri, 23 Jun 2006 21:45:40 +0000 (00:45 +0300)]
git-merge: Don't use -p when outputting summary

-p is not needed and we only want diffstat and summary.

Signed-off-by: Timo Hirvonen <tihirvon@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-commit: allow -e option anywhere on command line
Jeff King [Fri, 23 Jun 2006 13:43:38 +0000 (09:43 -0400)]
git-commit: allow -e option anywhere on command line

Previously, the command 'git-commit -e -m foo' would ignore the '-e' option
because the '-m' option overwrites the no_edit flag during sequential
option parsing. Now we cause -e to reset the no_edit flag after all
options are parsed.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agopatch-id: take "commit" prefix as well as "diff-tree" prefix
Johannes Schindelin [Fri, 23 Jun 2006 15:36:21 +0000 (17:36 +0200)]
patch-id: take "commit" prefix as well as "diff-tree" prefix

Some time ago we changed git-log in a massive way, and one consequence is
that the keyword changed. Adjust patch-id for that.

[jc: as Linus suggests, allowing both old and new prefix.]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMakefile: do not recompile main programs when libraries have changed.
Junio C Hamano [Thu, 22 Jun 2006 22:43:47 +0000 (15:43 -0700)]
Makefile: do not recompile main programs when libraries have changed.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoadd GIT-CFLAGS to .gitignore
Matthias Kestenholz [Thu, 22 Jun 2006 21:06:39 +0000 (23:06 +0200)]
add GIT-CFLAGS to .gitignore

Signed-off-by: Matthias Kestenholz <matthias@spinlock.ch>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoTweak diff colors
Linus Torvalds [Thu, 22 Jun 2006 20:53:31 +0000 (13:53 -0700)]
Tweak diff colors

This patch does:

 - always reset the color _before_ printing out the newline.

   This is actually important. You (and Johannes) didn't see it, because
   it only matters if you set the background, but if you don't do this,
   you get some random and funky behaviour if you pick a color with a
   non-default background (which still potentially has problems with tabs
   etc, but less so).

 - allow people to have a different color for the "file headers"
   (DIFF_METAINFO) and for the "fragment header" (DIFF_FRAGINFO). Also,
   make a difference between "normal color" and "reset colors"

 - default to red/green for old/new lines. That's the norm, I'd think.

 - instead of that eye-popping (and eye-ball-with-a-fondue-fork-popping)
   purple color for metadata, use bold-face for file headers, and cyan for
   the frag headers. I actually prefer the "gray background" for that, but
   it only works well in xterms, so COLOR_CYAN it is..

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into next v1.4.1-rc1
Junio C Hamano [Thu, 22 Jun 2006 17:36:26 +0000 (10:36 -0700)]
Merge branch 'master' into next

* master:
  git-svn: fix commit --edit flag when using SVN:: libraries
  Makefile: do not force unneeded recompilation upon GIT_VERSION changes
  Check and document the options to prevent mistakes.
  Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.

18 years agoMerge branch 'js/lsfix'
Junio C Hamano [Thu, 22 Jun 2006 17:35:13 +0000 (10:35 -0700)]
Merge branch 'js/lsfix'

* js/lsfix:
  Initialize lock_file struct to all zero.
  Make git-update-ref a builtin
  Make git-update-index a builtin
  Make git-stripspace a builtin
  Make git-mailinfo a builtin
  Make git-mailsplit a builtin
  Make git-write-tree a builtin

18 years agoMerge branch 'ew/rebase'
Junio C Hamano [Thu, 22 Jun 2006 17:34:02 +0000 (10:34 -0700)]
Merge branch 'ew/rebase'

* ew/rebase:
  rebase --merge: fix for rebasing more than 7 commits.
  rebase: error out for NO_PYTHON if they use recursive merge
  Add renaming-rebase test.
  rebase: Allow merge strategies to be used when rebasing

18 years agoMerge branch 'jn/web'
Junio C Hamano [Thu, 22 Jun 2006 17:33:34 +0000 (10:33 -0700)]
Merge branch 'jn/web'

* jn/web:
  gitweb: whitespace cleanup around '='
  gitweb: Use $hash_base as $search_hash if possible
  gitweb: Make use of $PATH_INFO for project parameter
  Move $gitbin earlier in gitweb.cgi
  Add git version to gitweb output
  gitweb: whitespace cleanup
  gitweb: style done with stylesheet
  gitweb: A couple of page title tweaking
  Fix: Support for the standard mime.types map in gitweb
  gitweb: add type="text/css" to stylesheet link
  Make CSS file gitweb/gitweb.css more readable
  Fix gitweb stylesheet
  Support for the standard mime.types map in gitweb
  gitweb: text files for 'blob_plain' action without charset by default
  gitweb: safely output binary files for 'blob_plain' action
  Move gitweb style to gitweb.css

18 years agoMerge early parts of branch 'js/diff'
Junio C Hamano [Thu, 22 Jun 2006 17:32:58 +0000 (10:32 -0700)]
Merge early parts of branch 'js/diff'

18 years agoMerge branch 'jc/upload-corrupt'
Junio C Hamano [Thu, 22 Jun 2006 17:25:51 +0000 (10:25 -0700)]
Merge branch 'jc/upload-corrupt'

* jc/upload-corrupt:
  daemon: send stderr to /dev/null instead of closing.
  upload-pack/fetch-pack: support side-band communication
  Retire git-clone-pack
  upload-pack: prepare for sideband message support.
  upload-pack: avoid sending an incomplete pack upon failure

18 years agoMerge branch 'ew/rebase' into next
Junio C Hamano [Thu, 22 Jun 2006 09:29:58 +0000 (02:29 -0700)]
Merge branch 'ew/rebase' into next

* ew/rebase:
  rebase --merge: fix for rebasing more than 7 commits.

18 years agoMerge branch 'jn/web' into next
Junio C Hamano [Thu, 22 Jun 2006 09:29:50 +0000 (02:29 -0700)]
Merge branch 'jn/web' into next

* jn/web:
  gitweb: whitespace cleanup around '='
  gitweb: Use $hash_base as $search_hash if possible

18 years agogitweb: whitespace cleanup around '='
Jakub Narebski [Thu, 22 Jun 2006 06:52:57 +0000 (08:52 +0200)]
gitweb: whitespace cleanup around '='

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogitweb: Use $hash_base as $search_hash if possible
Timo Hirvonen [Tue, 20 Jun 2006 13:41:05 +0000 (16:41 +0300)]
gitweb: Use $hash_base as $search_hash if possible

$hash (h parameter) does not always point to a commit. Use $hash_base as
$search_hash when it is defined.

Signed-off-by: Timo Hirvonen <tihirvon@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/waitpid'
Junio C Hamano [Thu, 22 Jun 2006 09:19:08 +0000 (02:19 -0700)]
Merge branch 'jc/waitpid'

* jc/waitpid:
  Restore SIGCHLD to SIG_DFL where we care about waitpid().

18 years agoMerge branch 'ff/c99'
Junio C Hamano [Thu, 22 Jun 2006 09:18:51 +0000 (02:18 -0700)]
Merge branch 'ff/c99'

* ff/c99:
  Remove all void-pointer arithmetic.
  Change types used in bitfields to be `int's.
  Don't use empty structure initializers.
  Cast pointers to `void *' when used in a format.
  Don't instantiate structures with FAMs.
  Initialize FAMs using `FLEX_ARRAY'.
  Remove ranges from switch statements.

18 years agoMerge branch 'pb/config'
Junio C Hamano [Thu, 22 Jun 2006 09:15:45 +0000 (02:15 -0700)]
Merge branch 'pb/config'

* pb/config:
  git_config: access() returns 0 on success, not > 0
  repo-config: Fix late-night bug
  Read configuration also from $HOME/.gitconfig
  Fix setting config variables with an alternative GIT_CONFIG
  Support for extracting configuration from different files

18 years agoMerge branch 'lt/objlist'
Junio C Hamano [Thu, 22 Jun 2006 09:15:22 +0000 (02:15 -0700)]
Merge branch 'lt/objlist'

* lt/objlist:
  Add "named object array" concept

18 years agogit-svn: fix commit --edit flag when using SVN:: libraries
Eric Wong [Thu, 22 Jun 2006 08:22:46 +0000 (01:22 -0700)]
git-svn: fix commit --edit flag when using SVN:: libraries

Trying to open an interactive editor in the console while stdout is
being piped to the parent process doesn't work out very well.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMakefile: do not force unneeded recompilation upon GIT_VERSION changes
Junio C Hamano [Thu, 22 Jun 2006 09:04:27 +0000 (02:04 -0700)]
Makefile: do not force unneeded recompilation upon GIT_VERSION changes

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agorebase --merge: fix for rebasing more than 7 commits.
Junio C Hamano [Thu, 22 Jun 2006 08:44:54 +0000 (01:44 -0700)]
rebase --merge: fix for rebasing more than 7 commits.

Instead of using 4-digit numbers to name commits being rebased,
just use "cmt.$msgnum" string, with $msgnum as a decimal number
without leading zero padding.  This makes it possible to rebase
more than 9999 commits, but of more practical importance is that
the earlier code used "printf" to format already formatted
$msgnum and barfed when it counted up to 0008.  In other words,
the old code was incapable of rebasing more than 7 commits, and
this fixes that problem.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoCheck and document the options to prevent mistakes.
Eric W. Biederman [Wed, 21 Jun 2006 13:17:31 +0000 (07:17 -0600)]
Check and document the options to prevent mistakes.

When multiple recipients are given to git-send-email on the same
--cc line the code does not properly handle it.

Full and proper parsing of the email addresses so I can detect
which commas mean a new email address is more than I care to implement.

In particular this email address: "bibo,mao" <bibo.mao@intel.com>
must not be treated as two email addresses.

So this patch simply treats all commas in recipient lists as
an error and fails if one is given.

At the same time it documents that git-send-email wants multiple
instances of --cc specified on the command line if you want to
cc multiple recipients.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoPass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.
Yakov Lerner [Thu, 22 Jun 2006 01:47:00 +0000 (04:47 +0300)]
Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.

Before this patch, -DDEFAULT_GIT_TEMPLATE_DIR was passed on compilation
command line to all and every .c file compiled. In fact the macro
is used by only one .c file, and unused by all other .c files.
Remove -DDEFAULT_GIT_TEMPLATE_DIR where unused. Follow the example of
exec_cmd.o. Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.

Signed-off-by: Yakov Lerner <iler.ml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into next
Junio C Hamano [Thu, 22 Jun 2006 01:37:31 +0000 (18:37 -0700)]
Merge branch 'master' into next

* master:
  Fix grow_refs_hash()

18 years agoMerge branch 'jc/upload-corrupt' into next
Junio C Hamano [Wed, 21 Jun 2006 23:38:11 +0000 (16:38 -0700)]
Merge branch 'jc/upload-corrupt' into next

* jc/upload-corrupt:
  daemon: send stderr to /dev/null instead of closing.

18 years agoMerge branch 'jn/web' into next
Junio C Hamano [Wed, 21 Jun 2006 23:38:05 +0000 (16:38 -0700)]
Merge branch 'jn/web' into next

* jn/web:
  gitweb: Make use of $PATH_INFO for project parameter

18 years agodaemon: send stderr to /dev/null instead of closing.
Junio C Hamano [Wed, 21 Jun 2006 23:37:48 +0000 (16:37 -0700)]
daemon: send stderr to /dev/null instead of closing.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogitweb: Make use of $PATH_INFO for project parameter
Jakub Narebski [Wed, 21 Jun 2006 15:06:39 +0000 (17:06 +0200)]
gitweb: Make use of $PATH_INFO for project parameter

Allow to have project name in the path part of URL, just after the name of
script. For example instead of gitweb.cgi?p=git.git you can write
gitweb.cgi/git.git or gitweb.cgi/git.git/

Not used in URLs inside gitweb; it means that the above alternate syntax
must be generated by hand, at least for now.

Side effect: project name parameter is now stripped of leading and
trailing slash before validation.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix grow_refs_hash()
Linus Torvalds [Wed, 21 Jun 2006 18:01:12 +0000 (11:01 -0700)]
Fix grow_refs_hash()

Earlier commit 3e4339e6f96e8c4f38a9c6607b98d3e96a2ed783 had a
thinko that did not check for collisions while repopulating the
objects in the new hash table.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'ew/rebase' into next
Junio C Hamano [Wed, 21 Jun 2006 10:56:41 +0000 (03:56 -0700)]
Merge branch 'ew/rebase' into next

* ew/rebase:
  rebase: error out for NO_PYTHON if they use recursive merge
  Add renaming-rebase test.
  rebase: Allow merge strategies to be used when rebasing
  object-refs: avoid division by zero

18 years agorebase: error out for NO_PYTHON if they use recursive merge
Eric Wong [Wed, 21 Jun 2006 10:04:42 +0000 (03:04 -0700)]
rebase: error out for NO_PYTHON if they use recursive merge

recursive merge relies on Python, and we can't perform
rename-aware merges without the recursive merge.  So bail out
before trying it.

The test won't work w/o recursive merge, either, so skip that,
too.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAdd renaming-rebase test.
Junio C Hamano [Sun, 18 Jun 2006 10:33:12 +0000 (03:33 -0700)]
Add renaming-rebase test.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agorebase: Allow merge strategies to be used when rebasing
Eric Wong [Wed, 21 Jun 2006 10:04:41 +0000 (03:04 -0700)]
rebase: Allow merge strategies to be used when rebasing

This solves the problem of rebasing local commits against an
upstream that has renamed files.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoobject-refs: avoid division by zero
Andre Noll [Wed, 21 Jun 2006 02:46:05 +0000 (04:46 +0200)]
object-refs: avoid division by zero

Currently, we don't check refs_hash_size size and happily call
lookup_object_refs() even if refs_hash_size is zero which leads to
a division by zero in hash_obj().

Signed-off-by: Andre Noll <maan@systemlinux.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'ff/c99' into next
Junio C Hamano [Wed, 21 Jun 2006 10:51:59 +0000 (03:51 -0700)]
Merge branch 'ff/c99' into next

* ff/c99:
  Remove all void-pointer arithmetic.

18 years agoMerge branch 'jc/upload-corrupt' into next
Junio C Hamano [Wed, 21 Jun 2006 09:50:59 +0000 (02:50 -0700)]
Merge branch 'jc/upload-corrupt' into next

* jc/upload-corrupt:
  upload-pack/fetch-pack: support side-band communication
  Retire git-clone-pack
  upload-pack: prepare for sideband message support.
  upload-pack: avoid sending an incomplete pack upon failure
  Fix possible out-of-bounds array access

18 years agoupload-pack/fetch-pack: support side-band communication
Junio C Hamano [Wed, 21 Jun 2006 07:30:21 +0000 (00:30 -0700)]
upload-pack/fetch-pack: support side-band communication

This implements a protocol extension between fetch-pack and
upload-pack to allow stderr stream from upload-pack (primarily
used for the progress bar display) to be passed back.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoRetire git-clone-pack
Junio C Hamano [Wed, 21 Jun 2006 06:54:26 +0000 (23:54 -0700)]
Retire git-clone-pack

The program is not used by git-clone since git-fetch-pack was extended
to allow its caller do what git-clone-pack alone did, and git-clone was
updated to use it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoupload-pack: prepare for sideband message support.
Junio C Hamano [Wed, 21 Jun 2006 05:48:23 +0000 (22:48 -0700)]
upload-pack: prepare for sideband message support.

This does not implement sideband for propagating the status to
the downloader yet, but add code to capture the standard error
output from the pack-objects process in preparation for sending
it off to the client when the protocol extension allows us to do
so.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoupload-pack: avoid sending an incomplete pack upon failure
Junio C Hamano [Wed, 21 Jun 2006 01:26:34 +0000 (18:26 -0700)]
upload-pack: avoid sending an incomplete pack upon failure

When the repository on the remote side is corrupted, rev-list
spawned from upload-pack would die with error, but pack-objects
that reads from the rev-list happily created a packfile that can
be unpacked by the downloader.  When this happens, the resulting
packfile is not corrupted and unpacks cleanly, but the list of
the objects contained in it is not what the protocol exchange
computed.

This update makes upload-pack to monitor its subprocesses, and
when either of them dies with error, sends an incomplete pack
data to the downloader to cause it to fail.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jn/web' into next
Junio C Hamano [Wed, 21 Jun 2006 09:33:43 +0000 (02:33 -0700)]
Merge branch 'jn/web' into next

* jn/web:
  Move $gitbin earlier in gitweb.cgi
  Add git version to gitweb output
  gitweb: whitespace cleanup

18 years agoFix possible out-of-bounds array access
Uwe Zeisberger [Wed, 21 Jun 2006 09:04:12 +0000 (11:04 +0200)]
Fix possible out-of-bounds array access

If match is "", match[-1] is accessed.  Let pathspec_matches return 1 in that
case indicating that "" matches everything.

Incidently this fixes git-grep'ing in ".".

Signed-off-by: Uwe Zeisberger <Uwe_Zeisberger@digi.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMove $gitbin earlier in gitweb.cgi
Jakub Narebski [Wed, 21 Jun 2006 07:48:04 +0000 (09:48 +0200)]
Move $gitbin earlier in gitweb.cgi

(cherry picked from 9dca843086356b964f27d8fabe1e3c48074a9f02 commit)

Signed-off-by: Jakub Narebski <jnareb.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAdd git version to gitweb output
Jakub Narebski [Wed, 21 Jun 2006 07:48:03 +0000 (09:48 +0200)]
Add git version to gitweb output

Add git-core binaries used version as the comment at the beginning of HTML
output, just below the comment with version of git web interface version.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogitweb: whitespace cleanup
Jakub Narebski [Wed, 21 Jun 2006 07:48:02 +0000 (09:48 +0200)]
gitweb: whitespace cleanup

Do not use tabs to align variable initialization (actually use
tabs only at the beginning of line, for code indent).  Remove trailing
whitespace.  Make whitespace usage more consistent.

Signed-off-by: Jakub Narebski <jnareb.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into next
Junio C Hamano [Wed, 21 Jun 2006 08:24:45 +0000 (01:24 -0700)]
Merge branch 'master' into next

* master:
  checkout -f: do not leave untracked working tree files.
  Log peer address when git-daemon called from inetd

18 years agocheckout -f: do not leave untracked working tree files.
Junio C Hamano [Tue, 20 Jun 2006 09:47:14 +0000 (02:47 -0700)]
checkout -f: do not leave untracked working tree files.

Earlier we did not consider untracked working tree files
"precious", but we have always considered them fair game to
clobber.  These days, branch switching by read-tree is more
careful and tries to protect untracked working tree files.  This
caused the following workflow to stop working:

git checkout one-branch-with-file-F
git checkout -f another-without-file-F
git pull . one-branch-with-file-F

Because the second checkout leaves F from the previous state as
untracked file in the working tree, the merge would fail, trying
to protect F from being clobbered.

This changes "git checkout -f" to remove working tree files that
are known to git in the switched-from state but do not exist in
the switched-to state, borrowing the same logic from "reset --hard".

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoLog peer address when git-daemon called from inetd
David Woodhouse [Tue, 20 Jun 2006 14:38:13 +0000 (15:38 +0100)]
Log peer address when git-daemon called from inetd

When we run git-daemon from inetd, even with the --verbose option, it
doesn't log the peer address. That logic was only in the standalone
daemon code -- move it to the execute() function instead. Tested with
both IPv6 and Legacy IP clients, in both inetd and daemon mode.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Jon Loeliger <jdl@jdl.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jn/web' into next
Junio C Hamano [Tue, 20 Jun 2006 21:06:32 +0000 (14:06 -0700)]
Merge branch 'jn/web' into next

* jn/web:
  gitweb: style done with stylesheet
  gitweb: A couple of page title tweaking

18 years agogitweb: style done with stylesheet
Jakub Narebski [Tue, 20 Jun 2006 14:58:12 +0000 (14:58 +0000)]
gitweb: style done with stylesheet

Replace (almost) all 'style' attributes with 'class' attribute
and adding rule to CSS file. Some tables use CSS for styling
instead of legacy styling attributes.

[jc: too many rejects -- hand fixed and reindented]

18 years agogitweb: A couple of page title tweaking
Jakub Narebski [Tue, 20 Jun 2006 06:17:03 +0000 (06:17 +0000)]
gitweb: A couple of page title tweaking

[jc: the e-mailed patch did not apply, so I had to guess but I think
 I got the result right.]

18 years agoMerge branch 'jn/web' into next
Junio C Hamano [Tue, 20 Jun 2006 10:00:13 +0000 (03:00 -0700)]
Merge branch 'jn/web' into next

18 years agoFix: Support for the standard mime.types map in gitweb
Jakub Narebski [Tue, 20 Jun 2006 06:19:31 +0000 (06:19 +0000)]
Fix: Support for the standard mime.types map in gitweb

Temporary fix: commented out offending line in mimetype_guess.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'master' into next
Junio C Hamano [Tue, 20 Jun 2006 09:51:23 +0000 (02:51 -0700)]
Merge branch 'master' into next

18 years agoMerge branch 'jn/web' into next
Junio C Hamano [Tue, 20 Jun 2006 09:39:53 +0000 (02:39 -0700)]
Merge branch 'jn/web' into next

18 years agoMerge branch 'pb/config' into next
Junio C Hamano [Tue, 20 Jun 2006 09:39:48 +0000 (02:39 -0700)]
Merge branch 'pb/config' into next

18 years agoRemove all void-pointer arithmetic.
Florian Forster [Sun, 18 Jun 2006 15:18:09 +0000 (17:18 +0200)]
Remove all void-pointer arithmetic.

ANSI C99 doesn't allow void-pointer arithmetic. This patch fixes this in
various ways. Usually the strategy that required the least changes was used.

Signed-off-by: Florian Forster <octo@verplant.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit-svn: fix --rmdir when using SVN:: libraries
Eric Wong [Tue, 20 Jun 2006 00:59:35 +0000 (17:59 -0700)]
git-svn: fix --rmdir when using SVN:: libraries

When tracking directories with nearly all of its files at
the most nested levels, --rmdir would accidentally go too
far when deleting.

Of course, we'll add a test for this condition, too.

Makefile: automatically run new tests as they appear in t/

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogit_config: access() returns 0 on success, not > 0
Johannes Schindelin [Tue, 20 Jun 2006 07:51:09 +0000 (09:51 +0200)]
git_config: access() returns 0 on success, not > 0

Another late-night bug. Sorry again.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agorepo-config: Fix late-night bug
Johannes Schindelin [Tue, 20 Jun 2006 07:45:53 +0000 (09:45 +0200)]
repo-config: Fix late-night bug

This bug was hidden by the "future-proofing" of the test. Sigh.

When neither GIT_CONFIG nor GIT_CONFIG_LOCAL is set, do not use NULL,
but $GIT_DIR/config. Instead of using $GIT_DIR/config when only
GIT_CONFIG_LOCAL is set. Sorry.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogitweb: add type="text/css" to stylesheet link
Jakub Narebski [Tue, 20 Jun 2006 04:11:32 +0000 (04:11 +0000)]
gitweb: add type="text/css" to stylesheet link

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jc/waitpid' into next
Junio C Hamano [Tue, 20 Jun 2006 01:47:51 +0000 (18:47 -0700)]
Merge branch 'jc/waitpid' into next

* jc/waitpid:
  Restore SIGCHLD to SIG_DFL where we care about waitpid().

18 years agoMerge branch 'lt/objlist' into next
Junio C Hamano [Tue, 20 Jun 2006 01:47:29 +0000 (18:47 -0700)]
Merge branch 'lt/objlist' into next

* lt/objlist:
  Add "named object array" concept
  xdiff: minor changes to match libxdiff-0.21
  fix rfc2047 formatter.
  Fix t8001-annotate and t8002-blame for ActiveState Perl
  Add specialized object allocator

18 years agoMerge branches 'js/lsfix', 'pb/config' and 'jn/web' into next
Junio C Hamano [Tue, 20 Jun 2006 01:46:56 +0000 (18:46 -0700)]
Merge branches 'js/lsfix', 'pb/config' and 'jn/web' into next

* js/lsfix:
  Initialize lock_file struct to all zero.

* pb/config:
  Read configuration also from $HOME/.gitconfig
  Fix setting config variables with an alternative GIT_CONFIG

* jn/web:
  Make CSS file gitweb/gitweb.css more readable

18 years agoAdd "named object array" concept
Linus Torvalds [Tue, 20 Jun 2006 00:42:35 +0000 (17:42 -0700)]
Add "named object array" concept

We've had this notion of a "object_list" for a long time, which eventually
grew a "name" member because some users (notably git-rev-list) wanted to
name each object as it is generated.

That object_list is great for some things, but it isn't all that wonderful
for others, and the "name" member is generally not used by everybody.

This patch splits the users of the object_list array up into two: the
traditional list users, who want the list-like format, and who don't
actually use or want the name. And another class of users that really used
the list as an extensible array, and generally wanted to name the objects.

The patch is fairly straightforward, but it's also biggish. Most of it
really just cleans things up: switching the revision parsing and listing
over to the array makes things like the builtin-diff usage much simpler
(we now see exactly how many members the array has, and we don't get the
objects reversed from the order they were on the command line).

One of the main reasons for doing this at all is that the malloc overhead
of the simple object list was actually pretty high, and the array is just
a lot denser. So this patch brings down memory usage by git-rev-list by
just under 3% (on top of all the other memory use optimizations) on the
mozilla archive.

It does add more lines than it removes, and more importantly, it adds a
whole new infrastructure for maintaining lists of objects, but on the
other hand, the new dynamic array code is pretty obvious. The change to
builtin-diff-tree.c shows a fairly good example of why an array interface
is sometimes more natural, and just much simpler for everybody.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoRestore SIGCHLD to SIG_DFL where we care about waitpid().
Junio C Hamano [Tue, 20 Jun 2006 01:25:21 +0000 (18:25 -0700)]
Restore SIGCHLD to SIG_DFL where we care about waitpid().

It was reported that under one implementation of socks client
"git clone" fails with "error: waitpid failed (No child processes)",
because "git" is spawned after setting SIGCHLD to SIG_IGN.

Arguably it may be a broken setting, but we should protect
ourselves so that we can get reliable results from waitpid() for
the children we care about.

This patch resets SIGCHLD to SIG_DFL in three places:

 - connect.c::git_connect() - initiators of git native
   protocol transfer are covered with this.

 - daemon.c::main() - obviously.

 - merge-index.c::main() - obviously.

There are other programs that do fork() but do not waitpid():
http-push, imap-send.  upload-pack does not either, but in the
case of that program, each of the forked halves runs exec()
another program, so this change would not have much effect
there.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoxdiff: minor changes to match libxdiff-0.21
Junio C Hamano [Tue, 20 Jun 2006 00:01:35 +0000 (17:01 -0700)]
xdiff: minor changes to match libxdiff-0.21

This reformats the change 621c53cc082299eaf69e9f2dc0274547c7d87fb0
introduced to match what upstream author implemented in libxdiff-0.21
without changing any logic (hopefully ;-).  This is to help keep
us in sync with the upstream.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agofix rfc2047 formatter.
Junio C Hamano [Mon, 19 Jun 2006 22:00:17 +0000 (15:00 -0700)]
fix rfc2047 formatter.

Running git-format-patch on patches from Lukas destroyed
the From: line.  This fixes it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix t8001-annotate and t8002-blame for ActiveState Perl
Dennis Stosberg [Mon, 19 Jun 2006 19:40:37 +0000 (21:40 +0200)]
Fix t8001-annotate and t8002-blame for ActiveState Perl

There seems to be at least one implementation of Perl which requires the
user to specify an extension for backup files.

Reported by Alex Riesen.

Signed-off-by: Dennis Stosberg <dennis@stosberg.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoAdd specialized object allocator
Linus Torvalds [Mon, 19 Jun 2006 17:44:15 +0000 (10:44 -0700)]
Add specialized object allocator

This creates a simple specialized object allocator for basic
objects.

This avoids wasting space with malloc overhead (metadata and
extra alignment), since the specialized allocator knows the
alignment, and that objects, once allocated, are never freed.

It also allows us to track some basic statistics about object
allocations. For example, for the mozilla import, it shows
object usage as follows:

     blobs:   627629 (14710 kB)
     trees:  1119035 (34969 kB)
   commits:   196423  (8440 kB)
      tags:     1336    (46 kB)

and the simpler allocator shaves off about 2.5% off the memory
footprint off a "git-rev-list --all --objects", and is a bit
faster too.

[ Side note: this concludes the series of "save memory in object storage".
  The thing is, there simply isn't much more to be saved on the objects.

  Doing "git-rev-list --all --objects" on the mozilla archive has a final
  total RSS of 131498 pages for me: that's about 513MB. Of that, the
  object overhead is now just 56MB, the rest is going somewhere else (put
  another way: the fact that this patch shaves off 2.5% of the total
  memory overhead, considering that objects are now not much more than 10%
  of the total shows how big the wasted space really was: this makes
  object allocations much more memory- and time-efficient).

  I haven't looked at where the rest is, but I suspect the bulk of it is
  just the pack-file loading. It may be that we should pack the tree
  objects separately from the blob objects: for git-rev-list --objects, we
  don't actually ever need to even look at the blobs, but since trees and
  blobs are interspersed in the pack-file, we end up not being dense in
  the tree accesses, so we end up looking at more pages than we strictly
  need to.

  So with a 535MB pack-file, it's entirely possible - even likely - that
  most of the remaining RSS is just the mmap of the pack-file itself. We
  don't need to map in _all_ of it, but we do end up mapping a fair
  amount. ]

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoRead configuration also from $HOME/.gitconfig
Johannes Schindelin [Mon, 19 Jun 2006 23:48:03 +0000 (01:48 +0200)]
Read configuration also from $HOME/.gitconfig

This patch is based on Pasky's, with three notable differences:

- I did not yet update the documentation
- I named it .gitconfig, not .gitrc
- git-repo-config does not barf when a unique key is overridden locally

The last means that if you have something like

[alias]
l = log --stat -M

in ~/.gitconfig, and

[alias]
l = log --stat -M next..

in $GIT_DIR/config, then

git-repo-config alias.l

returns only one value, namely the value from $GIT_DIR/config.

If you set the environment variable GIT_CONFIG, $HOME/.gitconfig is not
read, and neither $GIT_DIR/config, but $GIT_CONFIG instead.

If you set GIT_CONFIG_LOCAL instead, it is interpreted instead of
$GIT_DIR/config, but $HOME/.gitconfig is still read.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoFix setting config variables with an alternative GIT_CONFIG
Johannes Schindelin [Mon, 19 Jun 2006 22:51:58 +0000 (00:51 +0200)]
Fix setting config variables with an alternative GIT_CONFIG

When setting a config variable, git_config_set() ignored the variables
GIT_CONFIG and GIT_CONFIG_LOCAL. Now, when GIT_CONFIG_LOCAL is set, it
will write to that file. If not, GIT_CONFIG is checked, and only as a
fallback, the change is written to $GIT_DIR/config.

Add a test for it, and also future-proof the test for the upcoming
$HOME/.gitconfig support.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoInitialize lock_file struct to all zero.
Johannes Schindelin [Mon, 19 Jun 2006 22:55:20 +0000 (00:55 +0200)]
Initialize lock_file struct to all zero.

hold_lock_file_for_update() relies on that.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMake CSS file gitweb/gitweb.css more readable
Jakub Narebski [Mon, 19 Jun 2006 18:27:59 +0000 (20:27 +0200)]
Make CSS file gitweb/gitweb.css more readable

Taken from git://git.xmms.se/xmms2/gitweb-xmms2.git
commit  561262030d58a6325f500b36d836dbe02a5abc68
"Make CSS readable" by Daniel Svensson, with extra
parts removed and consistent whitespace usage.

[jc: tabified the results to cleaning things up, and removed an
 added item that was commented out. ]

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge early parts of branch 'ff/c99'
Junio C Hamano [Mon, 19 Jun 2006 05:13:54 +0000 (22:13 -0700)]
Merge early parts of branch 'ff/c99'

18 years agoMerge early parts of branch 'ls/am'
Junio C Hamano [Mon, 19 Jun 2006 05:13:11 +0000 (22:13 -0700)]
Merge early parts of branch 'ls/am'

18 years agoMake git-update-ref a builtin
Lukas Sandström [Tue, 13 Jun 2006 20:22:00 +0000 (22:22 +0200)]
Make git-update-ref a builtin

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMake git-update-index a builtin
Lukas Sandström [Tue, 13 Jun 2006 20:21:57 +0000 (22:21 +0200)]
Make git-update-index a builtin

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMake git-stripspace a builtin
Lukas Sandström [Tue, 13 Jun 2006 20:21:53 +0000 (22:21 +0200)]
Make git-stripspace a builtin

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMake git-mailinfo a builtin
Lukas Sandström [Tue, 13 Jun 2006 20:21:50 +0000 (22:21 +0200)]
Make git-mailinfo a builtin

[jc: with a bit of constness tightening]

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMake git-mailsplit a builtin
Lukas Sandström [Tue, 13 Jun 2006 20:21:46 +0000 (22:21 +0200)]
Make git-mailsplit a builtin

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMake git-write-tree a builtin
Lukas Sandström [Tue, 13 Jun 2006 20:21:42 +0000 (22:21 +0200)]
Make git-write-tree a builtin

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMerge branch 'jn/web' into next
Junio C Hamano [Mon, 19 Jun 2006 04:50:19 +0000 (21:50 -0700)]
Merge branch 'jn/web' into next

* jn/web:
  Fix gitweb stylesheet
  Support for the standard mime.types map in gitweb
  gitweb: text files for 'blob_plain' action without charset by default
  gitweb: safely output binary files for 'blob_plain' action
  Move gitweb style to gitweb.css

18 years agoMerge branch 'pb/config' into next
Junio C Hamano [Mon, 19 Jun 2006 04:48:32 +0000 (21:48 -0700)]
Merge branch 'pb/config' into next

* pb/config:
  Support for extracting configuration from different files
  Fix PPC SHA1 routine for large input buffers
  Make t8001-annotate and t8002-blame more portable
  Remove "refs" field from "struct object"
  Make release tarballs friendlier to older tar versions

18 years agoFix gitweb stylesheet
Jakub Narebski [Sun, 18 Jun 2006 06:45:03 +0000 (23:45 -0700)]
Fix gitweb stylesheet

An earlier commit forgot to move some piece from the CGI script
to the external stylesheet.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoSupport for the standard mime.types map in gitweb
Petr Baudis [Sat, 17 Jun 2006 22:01:06 +0000 (00:01 +0200)]
Support for the standard mime.types map in gitweb

gitweb will try to look up the filename mimetype in /etc/mime.types
and optionally a user-configured mime.types map as well.

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogitweb: text files for 'blob_plain' action without charset by default
Jakub Narebski [Sat, 17 Jun 2006 16:07:24 +0000 (18:07 +0200)]
gitweb: text files for 'blob_plain' action without charset by default

$default_text_plain_charset is undefined (no specified charset) by
default. Additionally ':raw' layer for binmode is used for outputting file
content.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agogitweb: safely output binary files for 'blob_plain' action
Jakub Narebski [Sat, 17 Jun 2006 11:32:15 +0000 (13:32 +0200)]
gitweb: safely output binary files for 'blob_plain' action

gitweb tries now to output correct Content-Type header for
'blob_plain' action; for now text/plain for text files,
appropriate image MIME type for *.png, *.gif and *.jpg/*.jpeg files,
and application/octet-stream for other binary files.

Introduced new configuration variables: $default_blob_plain_mimetype
and $default_text_plain_charset (only 'utf-8' is guaranteed to work
for the latter).

binmode changed to ':raw' in git_blob_plain for output of non-text files.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoMove gitweb style to gitweb.css
Jakub Narebski [Sat, 17 Jun 2006 09:23:56 +0000 (11:23 +0200)]
Move gitweb style to gitweb.css

Move gitweb style from embedded <style> element in gitweb/gitweb.cgi
to external CSS file gitweb/gitweb.css.

Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoChange types used in bitfields to be `int's.
Florian Forster [Sun, 18 Jun 2006 15:18:08 +0000 (17:18 +0200)]
Change types used in bitfields to be `int's.

According to ANSI C99 bitfields are only defined for `signed int' and `unsigned
int'. This patch corrects the bitfield in the `msg_data_t' type from
`imap-send.c'.

Signed-off-by: Florian Forster <octo@verplant.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
18 years agoDon't use empty structure initializers.
Florian Forster [Sun, 18 Jun 2006 15:18:07 +0000 (17:18 +0200)]
Don't use empty structure initializers.

Empty initializers for structures are not allowed in ANSI C99. This patch
removes such an initializer from `builtin-read-tree.c'. Since the struct was
static (and is therefore implicitely initialized to zero anyway) it wasn't
actually needed.

Signed-off-by: Florian Forster <octo@verplant.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>