be.git
14 years agoMerged Anton Batenev's report of Nicolas Alvarez' unicode-in-be-new bug
W. Trevor King [Fri, 19 Mar 2010 11:18:13 +0000 (07:18 -0400)]
Merged Anton Batenev's report of Nicolas Alvarez' unicode-in-be-new bug

14 years agoReported bug with utf-8 strings
Anton Batenev [Tue, 16 Mar 2010 12:54:22 +0000 (15:54 +0300)]
Reported bug with utf-8 strings

14 years agoFix relative links from bug pages in `be html`.
W. Trevor King [Mon, 22 Feb 2010 22:22:34 +0000 (17:22 -0500)]
Fix relative links from bug pages in `be html`.

Introduced by bugs/XXX.html -> bugs/XXX/index.html in
  wking@drexel.edu-20100220181238-j5ecst02y0k9ioo9

14 years agoUse truncated_id in `be html` comment <div id="">
W. Trevor King [Mon, 22 Feb 2010 14:39:21 +0000 (09:39 -0500)]
Use truncated_id in `be html` comment <div id="">

14 years agoFix len(char) assertion typo in libbe.util.utility.underlined()
W. Trevor King [Sat, 20 Feb 2010 18:28:34 +0000 (13:28 -0500)]
Fix len(char) assertion typo in libbe.util.utility.underlined()

14 years agoAdded `be html --min-id-length INT` option
W. Trevor King [Sat, 20 Feb 2010 18:21:25 +0000 (13:21 -0500)]
Added `be html --min-id-length INT` option

14 years agoMerged Gianluca's truncated-IDs in `be html` output patch.
W. Trevor King [Sat, 20 Feb 2010 18:12:38 +0000 (13:12 -0500)]
Merged Gianluca's truncated-IDs in `be html` output patch.

Or at least merged the general idea.  Changes in the implementation
listed in #bea/01e/2f9#.

14 years agoVariable lenght of the file name in the be html command.
Gianluca Montecchi [Thu, 11 Feb 2010 22:47:20 +0000 (23:47 +0100)]
Variable lenght of the file name in the be html command.

14 years agoFixed a bug in the be html command.
gian [Wed, 10 Feb 2010 13:28:49 +0000 (14:28 +0100)]
Fixed a bug in the be html command.

  File "/usr/lib/python2.5/site-packages/libbe/command/html.py", line 371, in _escape
    return xml.sax.saxutils.escape(char)
NameError: global name 'char' is not defined

14 years agoMerged Gianluca's fix of my version of Eric's patch ;)
W. Trevor King [Wed, 10 Feb 2010 09:50:20 +0000 (04:50 -0500)]
Merged Gianluca's fix of my version of Eric's patch ;)

14 years agoMerged Trevor's tree
Gianluca Montecchi [Tue, 9 Feb 2010 23:03:38 +0000 (00:03 +0100)]
Merged Trevor's tree

14 years agoMerged Eric Kow's HTML escaping patch
W. Trevor King [Tue, 9 Feb 2010 15:27:03 +0000 (10:27 -0500)]
Merged Eric Kow's HTML escaping patch

14 years agoMerged initial Sphinx documentation structure.
W. Trevor King [Mon, 8 Feb 2010 22:05:12 +0000 (17:05 -0500)]
Merged initial Sphinx documentation structure.

There's still a long way to go in this direction, but the basic
framework is now in place.  Toss in numpydoc-style docstrings
  http://projects.scipy.org/numpy/wiki/CodingStyleGuidelines
when you have time, and things will gradually improve over time.

I also punted our user ID creation/parsing in libbe.ui.util.user to
the email module.  This way IDs are handled in an RFC-compliant way
(less suprising for users) and by someone else (less work for us :).

14 years agoConsolidated Makefile and doc/man/module.mk. Incorperated doc/Makefile.
W. Trevor King [Mon, 8 Feb 2010 22:02:56 +0000 (17:02 -0500)]
Consolidated Makefile and doc/man/module.mk.  Incorperated doc/Makefile.

Now
  make sphinx
builds the Sphinx HTML documentation (in doc/.build/html), and
  make clean
cleans up everything.

Having a separate module.mk was just making things confusing, so I
took it out ;).

14 years agoFixed docstrings so only Sphinx errors are "autosummary" and "missing attribute"
W. Trevor King [Sun, 7 Feb 2010 22:53:53 +0000 (17:53 -0500)]
Fixed docstrings so only Sphinx errors are "autosummary" and "missing attribute"

14 years agoUse email.utils.formataddr/parseaddr to generate/parse user IDs
W. Trevor King [Sun, 7 Feb 2010 18:37:37 +0000 (13:37 -0500)]
Use email.utils.formataddr/parseaddr to generate/parse user IDs

14 years agoUse numpydoc and generate-libbe-txt.py to autogenerate API documentation
W. Trevor King [Sat, 6 Feb 2010 21:53:57 +0000 (16:53 -0500)]
Use numpydoc and generate-libbe-txt.py to autogenerate API documentation

14 years agoAdded bugdir and comment modules to Sphinx docs
W. Trevor King [Sat, 6 Feb 2010 18:44:05 +0000 (13:44 -0500)]
Added bugdir and comment modules to Sphinx docs

14 years agoAdded libbe.bug to the Sphinx documentation
W. Trevor King [Sat, 6 Feb 2010 18:09:24 +0000 (13:09 -0500)]
Added libbe.bug to the Sphinx documentation

14 years agoBroke out install.txt + reStructuredText markup fixes
W. Trevor King [Sat, 6 Feb 2010 16:06:32 +0000 (11:06 -0500)]
Broke out install.txt + reStructuredText markup fixes

14 years agoAdded page titles to the documentation & adjusted section levels.
W. Trevor King [Sat, 6 Feb 2010 14:47:20 +0000 (09:47 -0500)]
Added page titles to the documentation & adjusted section levels.

14 years agoSphynx now gets version string automatically.
W. Trevor King [Sat, 6 Feb 2010 01:09:58 +0000 (20:09 -0500)]
Sphynx now gets version string automatically.

14 years agoMoved manpage source doc/src to doc/man
W. Trevor King [Sat, 6 Feb 2010 01:08:22 +0000 (20:08 -0500)]
Moved manpage source doc/src to doc/man

14 years agoCreated Sphinx framework with sphinx-quickstart and added .txt extensiosns
W. Trevor King [Sat, 6 Feb 2010 01:06:02 +0000 (20:06 -0500)]
Created Sphinx framework with sphinx-quickstart and added .txt extensiosns

14 years agoAvoid double-escaping in 'be html'.
Eric Kow [Fri, 5 Feb 2010 14:30:21 +0000 (14:30 +0000)]
Avoid double-escaping in 'be html'.

14 years agoUse ${HOME}/.local as default prefix.
Eric Kow [Fri, 5 Feb 2010 11:48:28 +0000 (11:48 +0000)]
Use ${HOME}/.local as default prefix.
This is apparently a new standard.

14 years agoSort comments in `be html`.
W. Trevor King [Tue, 2 Feb 2010 19:11:14 +0000 (14:11 -0500)]
Sort comments in `be html`.

14 years agoFix be-xml-to-mbox handling of non-text/* content types
W. Trevor King [Tue, 2 Feb 2010 17:37:32 +0000 (12:37 -0500)]
Fix be-xml-to-mbox handling of non-text/* content types

14 years agoRestore "content_type" kwarg to Comment.new_reply().
W. Trevor King [Tue, 2 Feb 2010 17:32:53 +0000 (12:32 -0500)]
Restore "content_type" kwarg to Comment.new_reply().

It had been removed in
    revno: 473.1.43
    committer: W. Trevor King <wking@drexel.edu>
    branch nick: be.restructure
    timestamp: Mon 2009-12-14 07:37:51 -0500
    message:
      Transitioned comment to Command format
when we pushed unicode encoding/decoding back to the Storage backend.

However, with the addition of libbe.util.id.short_to_long_text(),
we need it again.

Also add a Doctest showing a non-text/* comment, so utilities dealing
with them can see what they'll be working with.

14 years agoMade Bzr/Darcs.version_cmp() more robust in response to Chris' email.
W. Trevor King [Mon, 1 Feb 2010 17:31:53 +0000 (12:31 -0500)]
Made Bzr/Darcs.version_cmp() more robust in response to Chris' email.

From: Chris Ball <cjb@laptop.org>
Subject: Test suite status

...
I ran the wking@drexel.edu-20100130162439-pmh5tg6kuq92x3l5 testsuite
on Fedora 13/Rawhide.  Had to downgrade Mercurial (bzr-hg doesn't
support 1.4.2 yet) and bzr (my Fedora package contained a "b4" in the
version string, which breaks libbe/storage/vcs/bzr.py:version_cmp()).
...

14 years agoFixed Chris' "zero name length for Mercurial w/o ~/.hgrc" bug.
W. Trevor King [Mon, 1 Feb 2010 17:02:11 +0000 (12:02 -0500)]
Fixed Chris' "zero name length for Mercurial w/o ~/.hgrc" bug.

From: Chris Ball <cjb@laptop.org>
Subject: Test suite status
Date: Mon, 01 Feb 2010 11:27:53 -0500
Message-id: <m38wbcor92.fsf@pullcord.laptop.org>

...

I hit the "assert len(name) > 0" in libbe/ui/util/libbe.py, coming from
hg.py when running with no ~/.hgrc.  Fixed by the following patch:

=== modified file 'libbe/storage/vcs/hg.py'
--- libbe/storage/vcs/hg.py     2010-01-21 17:45:49 +0000
+++ libbe/storage/vcs/hg.py     2010-02-01 16:17:03 +0000
@@ -87,7 +87,14 @@
         return tmp_stdout.getvalue().rstrip('\n')

     def _vcs_get_user_id(self):
-        return self._u_invoke_client('showconfig', 'ui.username')
+        output = self._u_invoke_client('showconfig', 'ui.username')
+        if output != "":
+            return output.rstrip('\n')
+        else:
+            # guess missing info
+            name = libbe.ui.util.user.get_fallback_username()
+            email = libbe.ui.util.user.get_fallback_email()
+            return libbe.ui.util.user.create_user_id(name, email)

     def _vcs_detect(self, path):
         """Detect whether a directory is revision-controlled using Mercurial"""

14 years agoFix command name output of `be --complete`.
W. Trevor King [Mon, 1 Feb 2010 16:36:21 +0000 (11:36 -0500)]
Fix command name output of `be --complete`.

By adding command_names option to libbe.command.commands.  Previous
versions of `be --complete` printed "import_xml", not "import-xml".

Also fixed libbe.command.base's doctests, so test.py can run them.

14 years agoClearer UnicodeDecodeError message in command_line.dispatch().
W. Trevor King [Mon, 1 Feb 2010 15:59:52 +0000 (10:59 -0500)]
Clearer UnicodeDecodeError message in command_line.dispatch().

See #bea/e30# ("Where should the vcs-name and encoding configuration
options live?")  for details.

14 years agolibbe.command.html.HTMLGen._long_to_linked_user() handles failed conversion.
W. Trevor King [Sat, 30 Jan 2010 16:24:39 +0000 (11:24 -0500)]
libbe.command.html.HTMLGen._long_to_linked_user() handles failed conversion.

Before, anything matching libbe.util.id.REGEXP was convert-or-die.
Now it's convert-or-no-op.  Much safer ;).  The new
_long_to_linked_user doctest would have failed with the old
implementation.

14 years agoAlways load settings when initializing BugDir from storage.
W. Trevor King [Sat, 30 Jan 2010 15:29:22 +0000 (10:29 -0500)]
Always load settings when initializing BugDir from storage.

Avoids problems like:

$ be html
Traceback (most recent call last):
  File "be", line 21, in <module>
    sys.exit(libbe.ui.command_line.main())
  File ".../libbe/ui/command_line.py", line 327, in main
    ret = dispatch(ui, command, args)
  File ".../libbe/ui/command_line.py", line 267, in dispatch
    ret = ui.run(command, options, args)
  File ".../libbe/command/base.py", line 504, in run
    return command.run(options, args)
  File ".../libbe/command/base.py", line 233, in run
    self.status = self._run(**params)
  File ".../libbe/command/html.py", line 111, in _run
    html_gen.run(params['output'])
  File ".../libbe/command/html.py", line 154, in run
    bugs.sort()
  File ".../libbe/bug.py", line 261, in __cmp__
    return cmp_full(self, other)
  File ".../libbe/bug.py", line 818, in __call__
    val = comparison(bug_1, bug_2)
  File ".../libbe/bug.py", line 750, in cmp_status
    return cmp(status_index[bug_1.status], status_index[bug_2.status])
  File ".../libbe/storage/util/properties.py", line 223,
in _fget
    raise ValueCheckError(name, value, value_allowed_fn)
libbe.storage.util.properties.ValueCheckError: open-feature not allowed by <function <lambda> at 0x84b610c> for status

14 years agoFix `be show` handling for no IDs
W. Trevor King [Fri, 29 Jan 2010 19:32:27 +0000 (14:32 -0500)]
Fix `be show` handling for no IDs

14 years agoAdd version information to test.py stderr for easier error reproduction
W. Trevor King [Fri, 29 Jan 2010 12:52:21 +0000 (07:52 -0500)]
Add version information to test.py stderr for easier error reproduction

14 years agoFix editor spawning on null-string EDITOR and VISUAL.
W. Trevor King [Fri, 29 Jan 2010 12:32:41 +0000 (07:32 -0500)]
Fix editor spawning on null-string EDITOR and VISUAL.

  $ EDITOR= VISUAL= python -c 'import os; import sys; print os.environ'
  {..., 'EDITOR': '', ..., 'VISUAL': '', ...}

14 years agoMerged some new bugs and be-xml-to-mbox extra_strings fix
W. Trevor King [Fri, 29 Jan 2010 11:59:49 +0000 (06:59 -0500)]
Merged some new bugs and be-xml-to-mbox extra_strings fix

14 years agoAdded #bea/169# : Generating per-bugdir/bug/comment change logs
W. Trevor King [Fri, 29 Jan 2010 01:19:32 +0000 (20:19 -0500)]
Added #bea/169# : Generating per-bugdir/bug/comment change logs

14 years agoRemoved taglines other cruft from #bea/d99# comments
W. Trevor King [Thu, 28 Jan 2010 23:06:40 +0000 (18:06 -0500)]
Removed taglines other cruft from #bea/d99# comments

14 years agoFix "extra_strings" -> "extra-strings" typos in be-xml-to-mbox
W. Trevor King [Thu, 28 Jan 2010 22:50:17 +0000 (17:50 -0500)]
Fix "extra_strings" -> "extra-strings" typos in be-xml-to-mbox

14 years agoAdd some workarounds for older bzrlibs. Tested on 1.3.1
W. Trevor King [Thu, 28 Jan 2010 18:17:42 +0000 (13:17 -0500)]
Add some workarounds for older bzrlibs.  Tested on 1.3.1

14 years agoWork around "bzr ls --non-recursive PATH : no list" bug in old bzrlib.
W. Trevor King [Thu, 28 Jan 2010 18:06:06 +0000 (13:06 -0500)]
Work around "bzr ls --non-recursive PATH : no list" bug in old bzrlib.

See: https://bugs.launchpad.net/bzr/+bug/158690

Bug affected versions:
  0.90.0 (reported)
  1.3.1  (my test suite hit it)
Doesn't affect versions:
  2.0+   (non_recursive -> recursive)
But I haven't isolated the source more specifically.

Working around it for everything < 2.0 should be safe, but the cutoff
could be fine-tuned if someone wants to dig through the bzr.dev
history...

14 years agoFix bzrlib.builtins.cmd_cat() output for pre 1.6.0 bzrlibs.
W. Trevor King [Thu, 28 Jan 2010 17:46:18 +0000 (12:46 -0500)]
Fix bzrlib.builtins.cmd_cat() output for pre 1.6.0 bzrlibs.

Fixed in bzr.dev
  revno: 3341.2.1
  revision-id: bialix@ukr.net-20080407074826-5lwuyv4dn1qlijg4
  parent: pqm@pqm.ubuntu.com-20080407044456-s1a9orh0kssphdh9
  committer: Alexander Belchenko <bialix@ukr.net>
  branch nick: cmd-cat
  timestamp: Mon 2008-04-07 10:48:26 +0300
  message: `bzr cat` no more internally used Tree.print_file().
Merged into bzr.dev's trunk
  revno: 3512 [merge]
  revision-id: pqm@pqm.ubuntu.com-20080626004245-dnw85so4xqg8r9hy
  parent: pqm@pqm.ubuntu.com-20080625230724-lyux37pu8nx8tq34
  parent: aaron@aaronbentley.com-20080626001706-wo3w74fwgliy12s4
  committer: Canonical.com Patch Queue Manager <pqm@pqm.ubuntu.com>
  branch nick: +trunk
  timestamp: Thu 2008-06-26 01:42:45 +0100
  message: (bialix) Deprectate (Branch|Repository).print_file, fix cmd_cat

Before bzr branch 1.6
  bzr.dev$ bzr tags
  ...
  bzr-1.5rc1           3418.6.3
  bzr-1.6              3606.5.9
  ...

Fixes:

python test.py -q libbe.storage.vcs.bzr
...............................FSome value:1E..
======================================================================
ERROR: Get should be able to return the previous version.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/wking/src/fun/be/be.wtk/libbe/storage/base.py", line 976, in test_
get_previous_version
    ret = self.s.get(self.id, revision=revs[i])
  File "/home/wking/src/fun/be/be.wtk/libbe/storage/base.py", line 335, in get
    value = self._get(*args, **kwargs)
  File "/home/wking/src/fun/be/be.wtk/libbe/storage/vcs/base.py", line 849, in _
get
    raise InvalidID(id, revision)
InvalidID: unlikely id in revision 1
...

14 years agoFix bzrlib.builtins.cmd_ls() recursion argument for pre 2.0 bzrlibs.
W. Trevor King [Thu, 28 Jan 2010 16:47:59 +0000 (11:47 -0500)]
Fix bzrlib.builtins.cmd_ls() recursion argument for pre 2.0 bzrlibs.

$ python test.py libbe.storage.vcs.bzr
...
======================================================================
ERROR: Children list should be revision dependent.
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../libbe/storage/base.py", line 997, in test_
get_previous_children
    ret = sorted(self.s.children('parent', revision=revs[i]))
  File ".../libbe/storage/base.py", line 314, in child
ren
    return self._children(*args, **kwargs)
  File ".../libbe/storage/vcs/base.py", line 811, in _
children
    path = self.path(id, revision, relpath=False)
  File ".../libbe/storage/vcs/base.py", line 716, in p
ath
    path = self._vcs_path(id, revision)
  File ".../libbe/storage/vcs/bzr.py", line 145, in _v
cs_path
    self.repo, revision=revision, recursive=True)
  File ".../libbe/storage/vcs/bzr.py", line 163, in _v
cs_listdir
    cmd.run(revision=revision, path=path, recursive=recursive)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 800, in ignor
e_pipe
    result = func(*args, **kwargs)
TypeError: run() got an unexpected keyword argument 'recursive'
...

The change is due to (in bzr.dev):

revno: 4206.2.1
revision-id: ian.clatworthy@canonical.com-20090326133831-orvicmmc6w29mpfp
parent: pqm@pqm.ubuntu.com-20090326063330-evutyvml3067dpsz
committer: Ian Clatworthy <ian.clatworthy@canonical.com>
branch nick: bzr.ls-recursive-off
timestamp: Thu 2009-03-26 23:38:31 +1000
message: ls should be non-recursive by default

Which occured between bzr-1.9rc1 and 2.0rc1.:

bzr.dev$ bzr tags
2.0rc1               4634.9.1
...
bzr-1.9rc1           3815.3.1
bzr-2.0.1            4634.73.2
...

14 years agoMerged with be.wtk trunk
W. Trevor King [Thu, 28 Jan 2010 16:00:27 +0000 (11:00 -0500)]
Merged with be.wtk trunk

14 years agoOops, fix Comment doctest EDITOR cleanup
W. Trevor King [Thu, 28 Jan 2010 15:56:44 +0000 (10:56 -0500)]
Oops, fix Comment doctest EDITOR cleanup

14 years agoAdd #bea/9c2# : Can comment punt functionality to email.Message?
W. Trevor King [Thu, 28 Jan 2010 15:42:32 +0000 (10:42 -0500)]
Add #bea/9c2# : Can comment punt functionality to email.Message?

14 years agoDon't accidentally spawn VISUAL in Comment doctests.
W. Trevor King [Thu, 28 Jan 2010 12:33:51 +0000 (07:33 -0500)]
Don't accidentally spawn VISUAL in Comment doctests.

14 years agoImplement Arch._vcs_path()
W. Trevor King [Wed, 27 Jan 2010 21:50:34 +0000 (16:50 -0500)]
Implement Arch._vcs_path()

Fixes VersionedStorage_commit_TestCase.test_get_previous_children.
Should have fixed
  VersionedStorage_commit_TestCase.test_get_previous_version
too, but 'tla file-find' is buggy:
  https://bugs.launchpad.net/ubuntu/+source/tla/+bug/513472

Also:
  * sort children in test_get_previous_children, since we shouldn't
    require a particular child order
  * unescape filenames in Arch._diff()
  * remove debugging prints from Arch._parse_diff()
  * remove silly blank line in git.py I'd stumbled across ;).

14 years agoImplement Arch._vcs_changed().
W. Trevor King [Wed, 27 Jan 2010 17:47:37 +0000 (12:47 -0500)]
Implement Arch._vcs_changed().

Fixes VersionedStorage_changed_TestCase.test_changed failure.

14 years agoFix StorageTestCase.classname -> ._classname()
W. Trevor King [Wed, 27 Jan 2010 17:41:18 +0000 (12:41 -0500)]
Fix StorageTestCase.classname -> ._classname()

Introduced in
  wking@drexel.edu-20100127152727-nu58o4g6jea5or7w

14 years ago`be html` links (<a href="...) #-delimited references in text/* bodies.
W. Trevor King [Wed, 27 Jan 2010 17:06:53 +0000 (12:06 -0500)]
`be html` links (<a href="...) #-delimited references in text/* bodies.

14 years agoMerged clarifications requested by Ben Finney
W. Trevor King [Wed, 27 Jan 2010 15:29:40 +0000 (10:29 -0500)]
Merged clarifications requested by Ben Finney

14 years agoMake VCS error messages and Storage test failures more descriptive
W. Trevor King [Wed, 27 Jan 2010 15:27:27 +0000 (10:27 -0500)]
Make VCS error messages and Storage test failures more descriptive

14 years agoMerged be.auth, adding "--auth" to `be serve`
W. Trevor King [Wed, 27 Jan 2010 13:50:48 +0000 (08:50 -0500)]
Merged be.auth, adding "--auth" to `be serve`

14 years agoAdd --help, --quiet options to test.py.
W. Trevor King [Wed, 27 Jan 2010 13:39:00 +0000 (08:39 -0500)]
Add --help, --quiet options to test.py.

Fixes Ben's "unintuitive test.py interface" bug:

Date: Wed, 27 Jan 2010 14:09:14 +1100
From: Ben Finney
Subject: [Be-devel] Re: Test suite on Trevor's development branch
...
> $ python ./test.py -q
>
> ----------------------------------------------------------------------
> Ran 0 tests in 0.000s
>
> OK

Running a Python unittest-capable test suite with "-q" should run it in
"quiet" mode, where progress is indicated by single characters along a
lone, and only failures and errors are reported.
...

14 years agoEncourage a run of `make` to build auto-generated files.
W. Trevor King [Wed, 27 Jan 2010 13:22:22 +0000 (08:22 -0500)]
Encourage a run of `make` to build auto-generated files.

Fixes Ben's "unintuitive test procedure" bug:

Date: Wed, 27 Jan 2010 14:09:14 +1100
From: Ben Finney
Subject: [Be-devel] Re: Test suite on Trevor's development branch
...
> $ python ./test.py
> Traceback (most recent call last):
[...]
> ImportError: No module named _version

So it's not possible to simply get a copy of the branch and try running
the test suite.
...

14 years agoStreamlined libbe.command.serve, adding --auth option, #/bea/c1b#, and testing.
W. Trevor King [Wed, 27 Jan 2010 13:07:31 +0000 (08:07 -0500)]
Streamlined libbe.command.serve, adding --auth option, #/bea/c1b#, and testing.

14 years agoAdded --ssl to `be serve` using cherrypy.wsgiserver.
W. Trevor King [Mon, 25 Jan 2010 21:49:00 +0000 (16:49 -0500)]
Added --ssl to `be serve` using cherrypy.wsgiserver.

14 years agoConvert libbe.command.serve to WSGI for increased flexibility.
W. Trevor King [Mon, 25 Jan 2010 17:15:57 +0000 (12:15 -0500)]
Convert libbe.command.serve to WSGI for increased flexibility.

The Python Web Server Gateway Interface (WSGI) is a simple and
universal interface between web servers and web applications or
frameworks.  See PEP 333 for details.
  http://www.python.org/dev/peps/pep-0333/

14 years agoRework fix for #bea/8fc# : be crashes on outdated id-cache
W. Trevor King [Mon, 25 Jan 2010 12:54:37 +0000 (07:54 -0500)]
Rework fix for #bea/8fc# : be crashes on outdated id-cache

Now we re-run CachedPathID.init in an 'append' mode, rather than
starting over from scratch.  This avoids problems like

  ======================================================================
  ERROR: Should not be able to add children to non-directories.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File ".../be.wtk/libbe/storage/base.py", line 680, in test_add_invalid_directory
      self.s.add('child', 'parent', directory=False)
    File ".../be.wtk/libbe/storage/base.py", line 248, in add
      self._add(id, *args, **kwargs)
    File ".../be.wtk/libbe/storage/vcs/base.py", line 737, in _add
      path = self._cached_path_id.add_id(id, parent)
    File ".../be.wtk/libbe/storage/vcs/base.py", line 267, in add_id
      parent_path = self.path(parent, relpath=True)
    File ".../be.wtk/libbe/storage/vcs/base.py", line 246, in path
      raise InvalidID(uuid)
  InvalidID: parent in revision None

and similar.

14 years agoDon't print 'Multiple paths' message on cache regen
W. Trevor King [Mon, 25 Jan 2010 12:31:57 +0000 (07:31 -0500)]
Don't print 'Multiple paths' message on cache regen

14 years agoFixed #bea/8fc# : be crashes on outdated id-cache
W. Trevor King [Mon, 25 Jan 2010 01:39:00 +0000 (20:39 -0500)]
Fixed #bea/8fc# : be crashes on outdated id-cache

Also explicitly avoid loading or saving settings for root comments.

14 years agoAdded bug #bea/8fc# : be crashes on outdated id-cache
W. Trevor King [Mon, 25 Jan 2010 00:51:17 +0000 (19:51 -0500)]
Added bug #bea/8fc# : be crashes on outdated id-cache

14 years agoMerged be.doc documentation rewrite + bugfixes + new bugs
W. Trevor King [Sun, 24 Jan 2010 16:22:53 +0000 (11:22 -0500)]
Merged be.doc documentation rewrite + bugfixes + new bugs

Highlights:
  * Fix broken Diff.comment_body_change_string implementation.
  * Fix List --severity handling, added --important
  * Fix `be target --help`
  * Fix non-text/plain `be comment` code and added 'Created
    comment...' output

14 years agoRewrote documentation
W. Trevor King [Sun, 24 Jan 2010 16:20:47 +0000 (11:20 -0500)]
Rewrote documentation

14 years agoAdded some bugs (and fixed typo) noticed while rewriting documentation
W. Trevor King [Sun, 24 Jan 2010 16:00:09 +0000 (11:00 -0500)]
Added some bugs (and fixed typo) noticed while rewriting documentation

14 years agoFix Diff.comment_body_change_string's difflib.unified_diff call
W. Trevor King [Sun, 24 Jan 2010 15:59:20 +0000 (10:59 -0500)]
Fix Diff.comment_body_change_string's difflib.unified_diff call

14 years agoFixed List --severity handling, added --important
W. Trevor King [Sun, 24 Jan 2010 00:28:57 +0000 (19:28 -0500)]
Fixed List --severity handling, added --important

14 years agoFix vars call for `be target --help`
W. Trevor King [Sat, 23 Jan 2010 23:51:57 +0000 (18:51 -0500)]
Fix vars call for `be target --help`

14 years agoUpdate --subscriber option help string for Subscribe
W. Trevor King [Sat, 23 Jan 2010 23:49:13 +0000 (18:49 -0500)]
Update --subscriber option help string for Subscribe

14 years agoModern ID format in `be list` _long_help
W. Trevor King [Sat, 23 Jan 2010 21:49:46 +0000 (16:49 -0500)]
Modern ID format in `be list` _long_help

14 years agoFix broken handling of non-text/plain comments
W. Trevor King [Sat, 23 Jan 2010 21:44:55 +0000 (16:44 -0500)]
Fix broken handling of non-text/plain comments

14 years agoAdded "Created comment..." output to `be comment`
W. Trevor King [Sat, 23 Jan 2010 20:56:14 +0000 (15:56 -0500)]
Added "Created comment..." output to `be comment`

14 years agoReorganized documentation to clean doc/ for user-readable files
W. Trevor King [Sat, 23 Jan 2010 16:40:11 +0000 (11:40 -0500)]
Reorganized documentation to clean doc/ for user-readable files

14 years agoFixed some bugs in settings_object handling and got test_usage.sh working.
W. Trevor King [Sat, 23 Jan 2010 16:16:42 +0000 (11:16 -0500)]
Fixed some bugs in settings_object handling and got test_usage.sh working.

Highlights:
  * clarified settings_object handling and improved unittests
  * added `be list --mine`
  * fixed some bugs in List, Import_XML, Init
  * added Storage.exists() (haven't implemented it in all VCS backends though).
  * added VCS.path()

14 years agoUpdate test_usage.sh
W. Trevor King [Sat, 23 Jan 2010 16:11:04 +0000 (11:11 -0500)]
Update test_usage.sh

14 years agoFix typos in untested parts of List and Import_XML for test_usage.py
W. Trevor King [Sat, 23 Jan 2010 16:10:45 +0000 (11:10 -0500)]
Fix typos in untested parts of List and Import_XML for test_usage.py

14 years agoAdded `be list --mine`
W. Trevor King [Sat, 23 Jan 2010 15:05:07 +0000 (10:05 -0500)]
Added `be list --mine`

14 years agoInit should tell the UI about its connected storage and bugdir.
W. Trevor King [Sat, 23 Jan 2010 15:05:00 +0000 (10:05 -0500)]
Init should tell the UI about its connected storage and bugdir.

14 years agoMove BugDir, Bug, and Comment to new _setup_saved_settings
W. Trevor King [Sat, 23 Jan 2010 01:38:57 +0000 (20:38 -0500)]
Move BugDir, Bug, and Comment to new _setup_saved_settings

14 years agoAdded testSimplePropertySetStorageSave and relavant rewrites to settings_object
W. Trevor King [Sat, 23 Jan 2010 01:35:23 +0000 (20:35 -0500)]
Added testSimplePropertySetStorageSave and relavant rewrites to settings_object

It hadn't been handling the "attach storage after initializing"
technique that BugDir, Bug, and Comment use when from_memory==True.
Now it does, by refusing to overwrite self.settings with the
newly-loaded settings.

14 years agoAdd Bzr._vcs_exists() anyway :p
W. Trevor King [Fri, 22 Jan 2010 19:14:03 +0000 (14:14 -0500)]
Add Bzr._vcs_exists() anyway :p

14 years agoWe don't need VCS._vcs_exists yet, with exists only used in _add
W. Trevor King [Fri, 22 Jan 2010 19:13:08 +0000 (14:13 -0500)]
We don't need VCS._vcs_exists yet, with exists only used in _add

14 years agoMinor cleanups + remove debuging line in Init doctest
W. Trevor King [Fri, 22 Jan 2010 19:05:01 +0000 (14:05 -0500)]
Minor cleanups + remove debuging line in Init doctest

14 years agoAdd VCS._exists(), VCS.path(). Fix default handling in VCS._get().
W. Trevor King [Fri, 22 Jan 2010 18:54:53 +0000 (13:54 -0500)]
Add VCS._exists(), VCS.path().  Fix default handling in VCS._get().

VCS.path() consolidates a bunch of distributed code.

The VCS backend cannot distinguish between _EMPTY and '' entry values,
so it assumes
  len(contents) == 0
means _EMPTY.  However, it had been returing None then, not default
like its supposed to.

14 years agoAdded _EMPTY and Storage.exists() to libbe.storage.base.
W. Trevor King [Fri, 22 Jan 2010 18:28:01 +0000 (13:28 -0500)]
Added _EMPTY and Storage.exists() to libbe.storage.base.

There seem to be problems distinguishing between "added but unset" IDs
and "added and set to ''" IDs.  Now _EMPTY lets us mark "added but unset",
and Storage.exists() handles "already added?" more clearly than the old
hack "does .get() succeed?".

14 years agoReworked settings_object module, but command.init tests still fail:
W. Trevor King [Fri, 22 Jan 2010 16:30:26 +0000 (11:30 -0500)]
Reworked settings_object module, but command.init tests still fail:

$ python test.py libbe.command.init
Doctest: libbe.command.init.Init ... FAIL
...
-----------------------
File ".../libbe/command/init.py", line 47, in libbe.command.init.Init
Failed example:
    ui.run(cmd)
Exception raised:
    Traceback (most recent call last):
      ...
      File "/tmp/be.wtk/libbe/command/init.py", line 97, in _run
        bd = libbe.bugdir.BugDir(storage, from_storage=False)
      File "/tmp/be.wtk/libbe/bugdir.py", line 185, in __init__
        self.save()
      File "/tmp/be.wtk/libbe/bugdir.py", line 228, in save
        self.save_settings()
      File "/tmp/be.wtk/libbe/bugdir.py", line 204, in save_settings
        mf = mapfile.generate(self._get_saved_settings())
      File "/tmp/be.wtk/libbe/storage/util/settings_object.py", line 230, in _get_saved_settings
        self, self._setting_name_to_attr_name(k))
      File "/tmp/be.wtk/libbe/storage/util/properties.py", line 194, in _fget
        value = fget(self)
      File "/tmp/be.wtk/libbe/storage/util/properties.py", line 329, in _fget
        primer(self)
      File "/tmp/be.wtk/libbe/storage/util/settings_object.py", line 69, in prop_load_settings
        self.load_settings()
      File "/tmp/be.wtk/libbe/bugdir.py", line 194, in load_settings
        self.settings = mapfile.parse(settings_mapfile)
      File "/tmp/be.wtk/libbe/storage/util/mapfile.py", line 123, in parse
        c = yaml.load(contents)
      ...
      File "/usr/lib/python2.6/site-packages/yaml/reader.py", line 213, in update_raw
        data = self.stream.read(size)
    AttributeError: 'NoneType' object has no attribute 'read'
...

14 years agoAdded unprimableVal option to primed_property.
W. Trevor King [Fri, 22 Jan 2010 14:17:08 +0000 (09:17 -0500)]
Added unprimableVal option to primed_property.

For clearer handling of the "Tried to load but failed" case.

14 years agoAdded tests to Init to check for empty settings file
W. Trevor King [Fri, 22 Jan 2010 14:15:36 +0000 (09:15 -0500)]
Added tests to Init to check for empty settings file

14 years agoBugfix merge: better Comment.xml() & libbe.util.id.parse_user()
W. Trevor King [Fri, 22 Jan 2010 11:40:23 +0000 (06:40 -0500)]
Bugfix merge: better Comment.xml() & libbe.util.id.parse_user()

Highlights:
  * new Comment.safe_in_reply_to to improve comment xml output.
  * don't raise MultipleIDMatches if one of the matches is exact.

14 years agoAdd Comment.safe_in_reply_to to improve comment xml output.
W. Trevor King [Fri, 22 Jan 2010 01:54:00 +0000 (20:54 -0500)]
Add Comment.safe_in_reply_to to improve comment xml output.

Now
  be show --xml ID | be-xml-to-mbox | catmutt
shows appropriate linking regardless of missing references or
references to alt-ids in the original comments.  On the other hand,
  be show --xml ID | be import-xml
could alter alt-ids.  If that's a problem we could turn off
save_in_reply_to usage via an option to the xml methods in the future.

14 years agoDon't raise MultipleIDMatches if one of the matches is exact.
W. Trevor King [Thu, 21 Jan 2010 22:25:05 +0000 (17:25 -0500)]
Don't raise MultipleIDMatches if one of the matches is exact.

14 years agoMerge assorted bugfixes and optimizations.
W. Trevor King [Thu, 21 Jan 2010 18:14:08 +0000 (13:14 -0500)]
Merge assorted bugfixes and optimizations.

Highlights:
  * `be new` adds creator field like its supposed to (oops :p).
  * `be list --xml` uses <be-xml> format (was <bugs>).
  * `be import-xml` handles root comments appropriately.
  * `be` raises an appropriate help message.
  * `be help` works.
  * `be html` prints Comment.id.user() information.
  * better SavedSettingsObject._get_saved_settings() avoids data loss.
  * be-mbox-to-xml -> be-mail-to-xml and adds assorted format support.
  * be-xml-to-mbox and be-handle-mail work with new libbe layout.
  * BugDir.uuids() now caches on-disk uuids for speed.
  * Mercurial detection works for mercurial <= 1.1.2 _and_ >= 1.2
  * Fix bugs in VCS._children() relative/absolute path handling.

14 years agoFix be-handle-mail's notification creation for new libbe structure
W. Trevor King [Thu, 21 Jan 2010 18:07:05 +0000 (13:07 -0500)]
Fix be-handle-mail's notification creation for new libbe structure

14 years agoAjdust Target tests for cached BugDir.uuids() implementation
W. Trevor King [Thu, 21 Jan 2010 17:52:24 +0000 (12:52 -0500)]
Ajdust Target tests for cached BugDir.uuids() implementation

14 years agoFix _uuids_cache reset in BugDir._clear_bugs
W. Trevor King [Thu, 21 Jan 2010 17:48:07 +0000 (12:48 -0500)]
Fix _uuids_cache reset in BugDir._clear_bugs

14 years agoUpdate libbe.storage.util.settings_object tests for new ._get_saved_settings
W. Trevor King [Thu, 21 Jan 2010 17:47:38 +0000 (12:47 -0500)]
Update libbe.storage.util.settings_object tests for new ._get_saved_settings