be.git
15 years agoAdded libbe/upgrade.py to handle upgrading on-disk bugdirs.
W. Trevor King [Mon, 31 Aug 2009 16:32:05 +0000 (12:32 -0400)]
Added libbe/upgrade.py to handle upgrading on-disk bugdirs.

15 years agoMade get_path() definitions consistent between bugdirs, bugs, and comments.
W. Trevor King [Mon, 31 Aug 2009 15:50:28 +0000 (11:50 -0400)]
Made get_path() definitions consistent between bugdirs, bugs, and comments.

15 years agoBug 22b (target-bugs) blocked by 519 (on-disk upgrade) and assigned to Trevor
W. Trevor King [Mon, 31 Aug 2009 13:54:55 +0000 (09:54 -0400)]
Bug 22b (target-bugs) blocked by 519 (on-disk upgrade) and assigned to Trevor

15 years agoVCS vs. RCS terminology blocked by on-disk upgrade path.
W. Trevor King [Mon, 31 Aug 2009 06:31:21 +0000 (02:31 -0400)]
VCS vs. RCS terminology blocked by on-disk upgrade path.

15 years agoAdded comment 22b:7 about representing targets with Bug() instances.
W. Trevor King [Mon, 31 Aug 2009 06:26:19 +0000 (02:26 -0400)]
Added comment 22b:7 about representing targets with Bug() instances.

15 years agoBroke up be-handle-mail.parse() into parse_new(), _comment(), and _control().
W. Trevor King [Sun, 16 Aug 2009 20:02:18 +0000 (16:02 -0400)]
Broke up be-handle-mail.parse() into parse_new(), _comment(), and _control().

Also fleshed out the be-handle-mail docstring.

15 years agoAdded on-disk representation upgrade bug
W. Trevor King [Sun, 16 Aug 2009 19:09:21 +0000 (15:09 -0400)]
Added on-disk representation upgrade bug

15 years agoHandle BugDir.list_uuids() in the case of missing ".be/bugs/".
W. Trevor King [Tue, 11 Aug 2009 18:46:26 +0000 (14:46 -0400)]
Handle BugDir.list_uuids() in the case of missing ".be/bugs/".

Previously:
  $ be init
  $ be list
  ...
    File ".../libbe/bugdir.py", line 537, in list_uuids
      for uuid in os.listdir(self.get_path("bugs")):
  OSError: [Errno 2] No such file or directory: '.../.be/bugs'

15 years ago"be html" fixes bug 2f0
W. Trevor King [Sat, 8 Aug 2009 14:24:33 +0000 (10:24 -0400)]
"be html" fixes bug 2f0

15 years agoOops, update comment.From->author and .time_string->.date in becommands/html.py
W. Trevor King [Sat, 8 Aug 2009 14:23:23 +0000 (10:23 -0400)]
Oops, update comment.From->author and .time_string->.date in becommands/html.py

15 years agoUpdated AUTHORS and copyright info for becommands/html.py.
W. Trevor King [Fri, 7 Aug 2009 18:29:16 +0000 (14:29 -0400)]
Updated AUTHORS and copyright info for becommands/html.py.

Also adjusted update_copyright.sh to ignore Gianluca's temporary use
of
  gianluca <gian@galactica>
since he's now using
  Gianluca Montecchi <gian@grys.it>
on becommands/html.py.

15 years agoMerged Gianluca's html output branch.
W. Trevor King [Fri, 7 Aug 2009 18:19:30 +0000 (14:19 -0400)]
Merged Gianluca's html output branch.

Changes to merge with my branch:

  * Added some reference to "be html" or "becommands/html.py" in his
    new bugs' summaries.  Bug titles should make clear to which aspect
    of our growing repository they refer.
  * Fixed unittests in becommands/html.py.
  * execute() kwarg "test"->!"manipulate_encodings
  * bugdir.simple_bug_dir() -> bugdir.SimpleBugDir()
  * bd.cleanup() at end of unittests

15 years agoSort bugs in HTML output.
W. Trevor King [Fri, 7 Aug 2009 17:53:26 +0000 (13:53 -0400)]
Sort bugs in HTML output.

15 years agoXHTML attribute values should be strings, and cellspacing not allowed in tr.
W. Trevor King [Fri, 7 Aug 2009 17:49:47 +0000 (13:49 -0400)]
XHTML attribute values should be strings, and cellspacing not allowed in tr.

15 years agoEscape HTML entities (e.g. & and @) in HTML output
W. Trevor King [Fri, 7 Aug 2009 17:45:19 +0000 (13:45 -0400)]
Escape HTML entities (e.g. & and @) in HTML output

15 years agoXHTML tags must be closed (e.g. <br />, not <br>)
W. Trevor King [Fri, 7 Aug 2009 17:23:00 +0000 (13:23 -0400)]
XHTML tags must be closed (e.g. <br />, not <br>)

15 years agoXHTML attribute values should be strings.
W. Trevor King [Fri, 7 Aug 2009 17:21:47 +0000 (13:21 -0400)]
XHTML attribute values should be strings.

15 years agoProtect bug html from libbe.settings_object.EMPTY
W. Trevor King [Fri, 7 Aug 2009 17:19:58 +0000 (13:19 -0400)]
Protect bug html from libbe.settings_object.EMPTY

15 years agoAdded DOCTYPE to detail html as well
W. Trevor King [Fri, 7 Aug 2009 17:15:19 +0000 (13:15 -0400)]
Added DOCTYPE to detail html as well

15 years agoRespect bugdir's encoding in html generation
W. Trevor King [Fri, 7 Aug 2009 17:12:08 +0000 (13:12 -0400)]
Respect bugdir's encoding in html generation

15 years agoAdded DOCTYPE and post-</div> endlines
W. Trevor King [Fri, 7 Aug 2009 17:09:15 +0000 (13:09 -0400)]
Added DOCTYPE and post-</div> endlines

15 years agoImproved threaded comment handling.
W. Trevor King [Fri, 7 Aug 2009 17:04:46 +0000 (13:04 -0400)]
Improved threaded comment handling.

The previous method only grabbed first line of a comment.  The new
approach replaces the messy Comment->string->parse->html with
Comment->html.

Also replaced all open()s with codecs.open to allow for non-ASCII
output.  Alphabetized the non libbe imports while I was adding codecs.

15 years agoAdjusted help/doc strings in becommands/html.py
W. Trevor King [Fri, 7 Aug 2009 15:52:39 +0000 (11:52 -0400)]
Adjusted help/doc strings in becommands/html.py

15 years ago- closed bugs f77, 2b8 d8d
Gianluca Montecchi [Tue, 4 Aug 2009 21:31:33 +0000 (23:31 +0200)]
- closed bugs f77, 2b8 d8d
- some changes to the css and to the html layout

15 years agoMerged bugfix branch be.missing-git-config
W. Trevor King [Tue, 4 Aug 2009 19:43:33 +0000 (15:43 -0400)]
Merged bugfix branch be.missing-git-config

15 years agoNow libbe.git.Git handles missing name/email and guesses instead.
W. Trevor King [Tue, 4 Aug 2009 19:42:49 +0000 (15:42 -0400)]
Now libbe.git.Git handles missing name/email and guesses instead.

15 years agoMerged Gianluca's missing-git-config bug report
W. Trevor King [Tue, 4 Aug 2009 19:34:19 +0000 (15:34 -0400)]
Merged Gianluca's missing-git-config bug report

15 years agoImported Ben's VCS vs. RCS bug report from the mailing list.
W. Trevor King [Mon, 3 Aug 2009 23:28:34 +0000 (19:28 -0400)]
Imported Ben's VCS vs. RCS bug report from the mailing list.

15 years agoSsupport for UTF-8 in "be comment" calls to EDITOR/VISUAL.
W. Trevor King [Mon, 3 Aug 2009 23:27:00 +0000 (19:27 -0400)]
Ssupport for UTF-8 in "be comment" calls to EDITOR/VISUAL.

15 years agoFixed width and index
Gianluca Montecchi [Mon, 3 Aug 2009 19:29:21 +0000 (21:29 +0200)]
Fixed width and index

15 years agoMerged dependency tree branch.
W. Trevor King [Sat, 1 Aug 2009 18:21:08 +0000 (14:21 -0400)]
Merged dependency tree branch.

Also exposes dependency manipulation functions/classes for use by
other modules.

15 years agoAdded dependency tree display with "be depend -t DEPTH BUG-ID".
W. Trevor King [Sat, 1 Aug 2009 18:16:09 +0000 (14:16 -0400)]
Added dependency tree display with "be depend -t DEPTH BUG-ID".

Should probably be a directed graph, since people might not make
tree-like dependency graphs.  Cyclic graphs seem unlikely, though,
so a tree only risks redundant bug entries.

15 years agoAdded one-way-link repair.
W. Trevor King [Sat, 1 Aug 2009 11:52:51 +0000 (07:52 -0400)]
Added one-way-link repair.

15 years agoAdded two-way dependency links.
W. Trevor King [Sat, 1 Aug 2009 11:12:46 +0000 (07:12 -0400)]
Added two-way dependency links.

Still need to implement and test one-way-link repair.

15 years agoClosed bug f77, minox fix to layout
Gianluca Montecchi [Fri, 31 Jul 2009 21:54:05 +0000 (23:54 +0200)]
Closed bug f77, minox fix to layout

15 years agoNow becommands.new's unittest cleans up after itself.
W. Trevor King [Fri, 31 Jul 2009 19:05:19 +0000 (15:05 -0400)]
Now becommands.new's unittest cleans up after itself.

15 years agoImproved unittest cleanup by adding BugDir.cleanup().
W. Trevor King [Fri, 31 Jul 2009 18:59:06 +0000 (14:59 -0400)]
Improved unittest cleanup by adding BugDir.cleanup().

Also simple_bug_dir -> SimpleBugDir class, which allows me to add
utility.Dir cleanup to SimpleBugDir.cleanup().

Still having a bit of trouble with the becommand.new tests due to
bugdir loading though...

15 years agoReturn to original directory after libbe.bugdir.SimpleBugDirTestCase().
W. Trevor King [Fri, 31 Jul 2009 09:24:05 +0000 (05:24 -0400)]
Return to original directory after libbe.bugdir.SimpleBugDirTestCase().

This was causing strange "RCS not found" errors in the bzr and hg
unittests.  For example, the bzr tests all passed:
  wking@thor:be.wtk-rr$ python test.py bzr
  ...
  Ran 12 tests in 24.143s

  OK
Except when run after the bugdir tests:
  wking@thor:be.wtk-rr$ python test.py bugdir bzr
  ...
  Ran 19 tests in 1.862s

  FAILED (errors=12)
Where the failures were all
  AssertionError: bzr RCS not found

Fixed by returning to intial directory after SimpleBugDirTestCase
execution.  Problem is due to Python issues with unlinked directories
though, so bzr/hg will _still_ not work from unlinked directories.
This is for Python 2.5.4 on Ubuntu 8.04.3, but probably effects other
pythons too.

Details:

Isolated problem to unlinked directories:
  mkdir /tmp/a
  cd /tmp/a
  rmdir /tmp/a
  python /home/wking/src/fun/be/be.wtk-rr/test.py bzr
which fails with the same "RCS not found" errors because bzr fails:
  wking@thor:/$ mkdir /tmp/a; cd /tmp/a; rmdir /tmp/a; bzr --help; cd /;
  rmdir: removing directory, /tmp/a
  'import site' failed; use -v for traceback
  bzr: ERROR: Couldn't import bzrlib and dependencies.
  Please check bzrlib is on your PYTHONPATH.

  Traceback (most recent call last):
    File "/usr/bin/bzr", line 64, in <module>
      import bzrlib
  ImportError: No module named bzrlib
which fails becase 'import site' fails:
  wking@thor:/$ mkdir /tmp/a; cd /tmp/a; rmdir /tmp/a; python -c 'import site'; cd /;
  rmdir: removing directory, /tmp/a
  'import site' failed; use -v for traceback
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/home/wking/lib/python/site.py", line 73, in <module>
      __boot()
    File "/home/wking/lib/python/site.py", line 33, in __boot
      imp.load_module('site',stream,path,descr)
    File "/usr/lib/python2.5/site.py", line 408, in <module>
      main()
    File "/usr/lib/python2.5/site.py", line 392, in main
      paths_in_sys = removeduppaths()
    File "/usr/lib/python2.5/site.py", line 96, in removeduppaths
      dir, dircase = makepath(dir)
    File "/usr/lib/python2.5/site.py", line 72, in makepath
      dir = os.path.abspath(os.path.join(*paths))
    File "/usr/lib/python2.5/posixpath.py", line 403, in abspath
      path = join(os.getcwd(), path)
  OSError: [Errno 2] No such file or directory
which fails because our cwd doesn't exist.  That makes sense ;).
Still I think Python should be able to handle it, so I reported it
  http://bugs.python.org/issue6612

15 years agoRemoved libbe.bzr.Bzr's automerge on post-commit.
W. Trevor King [Fri, 31 Jul 2009 08:57:32 +0000 (04:57 -0400)]
Removed libbe.bzr.Bzr's automerge on post-commit.

I'd done this already in
  wking@drexel.edu-20090723154304-swmkxpfagdzff9ai
but for some reason the merge with the email branch brought it back.

15 years agoFixed libbe.bugdir.BugDirTestCase.testComments(sync_with_disk=False).
W. Trevor King [Fri, 31 Jul 2009 08:25:21 +0000 (04:25 -0400)]
Fixed libbe.bugdir.BugDirTestCase.testComments(sync_with_disk=False).

15 years agoFixed comment.cmp_attr unittest because "o" > "a" so cmp("o", "a") == 1.
W. Trevor King [Fri, 31 Jul 2009 08:17:05 +0000 (04:17 -0400)]
Fixed comment.cmp_attr unittest because "o" > "a" so cmp("o", "a") == 1.

15 years agoFixed indent spacing in libbe.diff.report().
W. Trevor King [Fri, 31 Jul 2009 08:13:33 +0000 (04:13 -0400)]
Fixed indent spacing in libbe.diff.report().

Only increment depth if data_part != None.

15 years agoMerged interactive email interface
W. Trevor King [Wed, 29 Jul 2009 19:56:10 +0000 (15:56 -0400)]
Merged interactive email interface

15 years agoCorrected some problems with revision_id() before an initial commit.
W. Trevor King [Wed, 29 Jul 2009 19:49:45 +0000 (15:49 -0400)]
Corrected some problems with revision_id() before an initial commit.

15 years agoAdded clean messages on bug_from_shortname failure.
W. Trevor King [Wed, 29 Jul 2009 19:46:37 +0000 (15:46 -0400)]
Added clean messages on bug_from_shortname failure.

So user's don't get confused.

15 years agoMoved all the implementation into the html.py file
Gianluca Montecchi [Mon, 27 Jul 2009 21:59:40 +0000 (23:59 +0200)]
Moved all the implementation into the html.py file
Implemented the creation of the index for active and inactive bugs, with detail for earch of them

15 years agobe-handle-mail no longer sends blank subscriber emails when no change occurs.
W. Trevor King [Mon, 27 Jul 2009 21:04:42 +0000 (17:04 -0400)]
be-handle-mail no longer sends blank subscriber emails when no change occurs.

It had been mailing out the empty MIMEMultipart root returned by
diff_tree.report().

15 years agoFixed _procmailrc rules.
W. Trevor King [Mon, 27 Jul 2009 20:38:30 +0000 (16:38 -0400)]
Fixed _procmailrc rules.

"[" is a special character.

Also a few minor cleanups in be-handle-mail.

15 years agoRestored Makefile to /home/wking installation
W. Trevor King [Mon, 27 Jul 2009 19:05:55 +0000 (15:05 -0400)]
Restored Makefile to /home/wking installation

15 years agoCleaned up be-handle-mail's subscriber notification emails (fewer attachments).
W. Trevor King [Mon, 27 Jul 2009 18:42:17 +0000 (14:42 -0400)]
Cleaned up be-handle-mail's subscriber notification emails (fewer attachments).

Previously, every node in the DiffTree created it's own attachment.
Now they're consolidated into a single attachment per bug.  higher
level nodes are still one attachment per node.

Also:
  * added send_pgp_mime.append_text()
  * pulled guess_encoding() out of send_pgp_mime.encodedMIMEText().
  * renamed data_string -> data_part in libbe.diff, since it needn't be a string.

15 years agoAllow "subscribe" command via the email interface.
W. Trevor King [Mon, 27 Jul 2009 13:24:46 +0000 (09:24 -0400)]
Allow "subscribe" command via the email interface.

15 years agoTweaked the output text for modified bugs in libbe.diff and be-handle-mail.
W. Trevor King [Mon, 27 Jul 2009 13:06:27 +0000 (09:06 -0400)]
Tweaked the output text for modified bugs in libbe.diff and be-handle-mail.

15 years agoAdded "be-handle-mail --notify-since REVISION".
W. Trevor King [Mon, 27 Jul 2009 13:01:04 +0000 (09:01 -0400)]
Added "be-handle-mail --notify-since REVISION".

15 years agoAdded an additional format check to be-handle-mail's pseudoheader parsing.
W. Trevor King [Mon, 27 Jul 2009 12:38:33 +0000 (08:38 -0400)]
Added an additional format check to be-handle-mail's pseudoheader parsing.

Marked outstanding email interface bugs as fixed.

15 years agoMerged "be subscribe" and be-handle-mail subscription support.
W. Trevor King [Mon, 27 Jul 2009 12:12:16 +0000 (08:12 -0400)]
Merged "be subscribe" and be-handle-mail subscription support.

Also assorted other changes and fixes in the be.subscribe branch.
Highlights:
  * Much more powerful libbe.diff with subclassable report generators.
  * "be diff" compares working copy with last commit by default.
  * comment reference text shown in "be comment" EDITOR footer
  * .revision_id() for all VCSs
  * meaningful comment comparison and stricter bug comparison
  * stricter .sync_with_disk interpretation.  See BugDir.__doc__.
  * Comment.From and .time_string -> .author and .date, for better
    conformance with settings_object.setting_name_to_attr_name().

15 years agoSubscribing myself to all changes.
W. Trevor King [Mon, 27 Jul 2009 12:11:11 +0000 (08:11 -0400)]
Subscribing myself to all changes.

15 years agoMoved be-handle-mail over to new libbe.diff classes.
W. Trevor King [Mon, 27 Jul 2009 12:09:20 +0000 (08:09 -0400)]
Moved be-handle-mail over to new libbe.diff classes.

15 years agoRemoved debugging exception from libbe/comment.py.
W. Trevor King [Mon, 27 Jul 2009 11:59:38 +0000 (07:59 -0400)]
Removed debugging exception from libbe/comment.py.

15 years agoComment.remove() now ignores .sync_with_disk when removing the root comment.
W. Trevor King [Mon, 27 Jul 2009 11:56:17 +0000 (07:56 -0400)]
Comment.remove() now ignores .sync_with_disk when removing the root comment.

15 years agoAdded default to settings_object.versioned_property's change_hook_property.
W. Trevor King [Mon, 27 Jul 2009 11:47:35 +0000 (07:47 -0400)]
Added default to settings_object.versioned_property's change_hook_property.

Now change_hook properties handle defaults, which allows them to avoid
an initial
  None -> default
save hook trigger.

Removed the now-redundant read-only mode business in
becommands/diff.py.

15 years agoPut bd into read-only mode in becommands/diff.py.
W. Trevor King [Mon, 27 Jul 2009 11:22:01 +0000 (07:22 -0400)]
Put bd into read-only mode in becommands/diff.py.

Otherwise comment comparison reads were triggering notice of the
  None -> EMPTY
transition in comment.extra_strings, which was causing a write to
disk.  This trigger is probably occuring in Bug and BugDir too.
Perhaps I should just remove the trigger...

15 years agoAdded cmp functions to libbe.comment, and fleshed them out in libbe.bug.
W. Trevor King [Mon, 27 Jul 2009 11:18:13 +0000 (07:18 -0400)]
Added cmp functions to libbe.comment, and fleshed them out in libbe.bug.

Previous comment comparison had just been the default Tree.__cmp__.

Fleshed out so A == B ensures no meaningful differences between A and B.

Also added first line of comments to new comment output in libbe.diff,
and added a comment/"settings" node and .comment_mod_string() (to
mirror bugdir and bug).

15 years agoHack Comment.load_settings() to work around From->Author change.
W. Trevor King [Mon, 27 Jul 2009 10:23:20 +0000 (06:23 -0400)]
Hack Comment.load_settings() to work around From->Author change.

"Author" -> comment.author obeys settings_object.setting_name_to_attr_name(),
but all the current on-disk mapfiles talk about "From".  Add a hack to accept
both forms of on-disk comment files.

15 years agoCache data strings in libbe.diff.DiffTree.
W. Trevor King [Mon, 27 Jul 2009 09:57:40 +0000 (05:57 -0400)]
Cache data strings in libbe.diff.DiffTree.

This makes repeated .report() generation from the same tree more
efficient.

15 years agoMajor rewrite of libbe.diff introduces DiffTree and Diff classes.
W. Trevor King [Mon, 27 Jul 2009 09:14:49 +0000 (05:14 -0400)]
Major rewrite of libbe.diff introduces DiffTree and Diff classes.

To make the interface proposed by becommands/subscribers.py easier to
implement, I've moved the libbe.diff functionality into classes.  Now
it should be easy two tweak the output as desired by subclassing these
classes.  The basic idea is that Diff.report_tree() generates a
diff_tree tree of changes between two bugdirs, where diff_tree is some
subclass of DiffTree.  Each type of change has a default .*_string()
method producing a string summary of the change.  DiffTree.report()
moves through and generates a report by joining all those summary
strings to a single root, and DiffTree.report_string() serialized the
report to produce e.g. the output of becommands/diff.py.

15 years ago.sync_with_disk fixes for libbe.bugdir and .comment.
W. Trevor King [Mon, 27 Jul 2009 09:11:33 +0000 (05:11 -0400)]
.sync_with_disk fixes for libbe.bugdir and .comment.

In BugDir, only call bug.remove if bug.sync_with_disk==True.  If it's
just in memory, automatic garbage collection is sufficient cleanup.

Comment.set_sync_with_disk() had been setting .sync_with_disk=True
regardless of the value passed in.  Fixed now.

Also some minor textual adjustments.

15 years agoAdded DiskAccessRequired errors to libbe.bug.Bug and .comment.Comment.
W. Trevor King [Mon, 27 Jul 2009 00:40:08 +0000 (20:40 -0400)]
Added DiskAccessRequired errors to libbe.bug.Bug and .comment.Comment.

15 years agoBugDir._in_memory was a stupid idea. Took it back out.
W. Trevor King [Mon, 27 Jul 2009 00:04:32 +0000 (20:04 -0400)]
BugDir._in_memory was a stupid idea.  Took it back out.

It was too confusing having three memory access levels:
  1) syncronized
  2) explicit
  3) memory-only
with .sync_with_disk selecting between 1 and 2/3 and ._in_memory
selecting between 2/3.

Now there are only two:
  1) syncronized
  2) memory-only excepting explicit BugDir.save() calls.

I avoid the problem of non-syncronized loading of on-disk bugs in
simple_bug_dir by restricting .list_uuids() to in-memory bugs when
.sync_with_disk==True.

Beyond that, I shifted the order of the BugDir methods around a bit so
that they were better grouped according to general idea.

Note that the DiskAccessRequired exceptions on filesystem access when
.sync_with_disk==False should be propogated to the Bug and Comment
methods, but I haven't done that yet.

15 years agoAdded in_memory to BugDir.__init__ to disable saving/loading completely.
W. Trevor King [Sat, 25 Jul 2009 12:59:38 +0000 (08:59 -0400)]
Added in_memory to BugDir.__init__ to disable saving/loading completely.

The previous simple_bug_dir(on_disk==False) supprised me by loading my
BE bugdir when called from the BE directory.  This functionality could
probably move out to Bug and Comment as well, but I have avoided that
for now.

15 years agoAdded on_disk option to libbe.bugdir.simple_bug_dir().
W. Trevor King [Sat, 25 Jul 2009 11:32:12 +0000 (07:32 -0400)]
Added on_disk option to libbe.bugdir.simple_bug_dir().

Now you can easily generate simple_bug_dirs that live only in memory.

15 years agoRenamed Comment.From and .time_string to .author and .date respectively.
W. Trevor King [Sat, 25 Jul 2009 11:26:19 +0000 (07:26 -0400)]
Renamed Comment.From and .time_string to .author and .date respectively.

Now they conform to the
  libbe.settings_object.setting_name_to_attr_name()
standard.

I fixed the references I found in
  becommands/comment.py
  interfaces/xml/be-mbox-to-xml
  interfaces/xml/be-xml-to-mbox
but there may have been some references or files that slipped through.

15 years agoAdded autocommit wishlist request by Martin Krafft
W. Trevor King [Fri, 24 Jul 2009 20:14:57 +0000 (16:14 -0400)]
Added autocommit wishlist request by Martin Krafft

15 years agobe-handle-mail successfully generates bugdir-changed notification emails.
W. Trevor King [Thu, 23 Jul 2009 20:18:34 +0000 (16:18 -0400)]
be-handle-mail successfully generates bugdir-changed notification emails.

This still needs a lot of cleaning up, but it worked for an "all"
subscription to "DIR", so I thought I'd lock in the current status ;).

15 years ago"be diff" now compares agains the last commit (for versioning VCSs).
W. Trevor King [Thu, 23 Jul 2009 18:24:36 +0000 (14:24 -0400)]
"be diff" now compares agains the last commit (for versioning VCSs).

This is the default behaviour of most of the VCSs own diff commands.

15 years agoAdded .revision_id() to all the VCSs.
W. Trevor King [Thu, 23 Jul 2009 18:19:15 +0000 (14:19 -0400)]
Added .revision_id() to all the VCSs.

This makes it easier to compare recent revisions without a human
around to give you revision numbers.

15 years agolibbe.rcs.RCS.commit() now actually calls .pre/postcommit().
W. Trevor King [Thu, 23 Jul 2009 15:43:04 +0000 (11:43 -0400)]
libbe.rcs.RCS.commit() now actually calls .pre/postcommit().

It hadn't before, which defeats the Pu purpose of hook functions.
This hand't caused any problems though, since only libbe.bzr defined a
postcommit() and there were no precommit() definitions.

Bzr's postcommit() had been to auto-merge from the default merge
source.  Yikes!  Removed that ;).

15 years agoBroke encodedMIMEText out of send-pgp-mime.PGPMimeMessageFactory.
W. Trevor King [Thu, 23 Jul 2009 15:37:45 +0000 (11:37 -0400)]
Broke encodedMIMEText out of send-pgp-mime.PGPMimeMessageFactory.

It's useful enough even when you're not intending to encrypt
something.

15 years agoAdded Tree types and get_bugdir_subscribers to becommands/subscribe.py.
W. Trevor King [Thu, 23 Jul 2009 15:27:59 +0000 (11:27 -0400)]
Added Tree types and get_bugdir_subscribers to becommands/subscribe.py.

The Tree subclass SubscriptionType may be a few more lines to setup,
but they should be really easy to extend and will automatically keep
the longhelp and type handling in sync.

An example extension for bugdir types would be
  all -> assigned -> <user>
to subscribe only to bugs being assigned to the specified user.  You'd
have to loosen the currently strict InvalidType checking to make that
work, but the current type-tree handling would be up to the task.

Also a bit of reorganizing to hide the private functions.

15 years agoMerged libbe.diff upgrades and libbe.tree.Tree.has_descendant from be.wtk-rr.
W. Trevor King [Thu, 23 Jul 2009 14:10:36 +0000 (10:10 -0400)]
Merged libbe.diff upgrades and libbe.tree.Tree.has_descendant from be.wtk-rr.

Also pulls "show referenced text" fix to "be comment".

15 years agoAdded bugdir setting comparision to libbe.diff.
W. Trevor King [Thu, 23 Jul 2009 14:08:04 +0000 (10:08 -0400)]
Added bugdir setting comparision to libbe.diff.

Renamed libbe.diff.diff -> bug_diffs, since it doesn't compare bugdirs.

Load comments before bug comparision so cmp_comments will see them.

Use .settings_properties rather than static lists to create attribute
lists for change_lines().

Removed trailing endline from becommands/diff.py output.

15 years agoAdded libbe.bug.cmp_comments(), and added that to default bug comparison.
W. Trevor King [Thu, 23 Jul 2009 13:59:14 +0000 (09:59 -0400)]
Added libbe.bug.cmp_comments(), and added that to default bug comparison.

15 years agoFixed unrecognized "Test" typo in becommands/comment.py.
W. Trevor King [Thu, 23 Jul 2009 13:52:47 +0000 (09:52 -0400)]
Fixed unrecognized "Test" typo in becommands/comment.py.

15 years agoAdded comment on notification granularity (commit-level).
W. Trevor King [Thu, 23 Jul 2009 13:28:48 +0000 (09:28 -0400)]
Added comment on notification granularity (commit-level).

15 years agoAdded libbe.tree.Tree.has_descendant().
W. Trevor King [Thu, 23 Jul 2009 13:25:34 +0000 (09:25 -0400)]
Added libbe.tree.Tree.has_descendant().

Tree equality is now based on instance id.  It had previously used the
default list "equal if all elements are equal", which meant that all
the leaves matched each other.

15 years agolibbe/tree.Tree.traverse(depthFirst)->depth_first & stripped trailing spaces.
W. Trevor King [Thu, 23 Jul 2009 13:20:52 +0000 (09:20 -0400)]
libbe/tree.Tree.traverse(depthFirst)->depth_first & stripped trailing spaces.

15 years agoAdded becommands/subscribe.py to manage subscription list.
W. Trevor King [Wed, 22 Jul 2009 18:54:39 +0000 (14:54 -0400)]
Added becommands/subscribe.py to manage subscription list.

15 years agoShow text of comment's reference in notes when spawning EDITOR.
W. Trevor King [Wed, 22 Jul 2009 12:44:38 +0000 (08:44 -0400)]
Show text of comment's reference in notes when spawning EDITOR.

15 years agoInitial implementation of the comments export
Gianluca Montecchi [Tue, 21 Jul 2009 21:51:33 +0000 (23:51 +0200)]
Initial implementation of the comments export

15 years agoMerged assorted changes from be.wtk-rr for BugDir.extra_strings.
W. Trevor King [Tue, 21 Jul 2009 20:33:28 +0000 (16:33 -0400)]
Merged assorted changes from be.wtk-rr for BugDir.extra_strings.

Other highlights:
  * be show --no-comments
  * Improved *.sync_with_disk.
  * Improved be-mbox-to-xml.

15 years agoAdded: subscribe/unsubscribe (bug #..., "new bugs", "all", etc.)
W. Trevor King [Tue, 21 Jul 2009 20:24:24 +0000 (16:24 -0400)]
Added: subscribe/unsubscribe (bug #..., "new bugs", "all", etc.)

15 years agoAdded .extra_strings to BugDir and Comment
W. Trevor King [Tue, 21 Jul 2009 20:22:34 +0000 (16:22 -0400)]
Added .extra_strings to BugDir and Comment

15 years agoI'll add Comment.extra_strings too, while I'm at it.
W. Trevor King [Tue, 21 Jul 2009 20:21:42 +0000 (16:21 -0400)]
I'll add Comment.extra_strings too, while I'm at it.

15 years agoAdded BugDir.extra_strings.
W. Trevor King [Tue, 21 Jul 2009 20:20:21 +0000 (16:20 -0400)]
Added BugDir.extra_strings.

15 years agoBug._extra_strings_check_fn() guts now utility.iterable_full_of_strings().
W. Trevor King [Tue, 21 Jul 2009 20:19:02 +0000 (16:19 -0400)]
Bug._extra_strings_check_fn() guts now utility.iterable_full_of_strings().

15 years agoMerged libbe.properties unittest fix
W. Trevor King [Tue, 21 Jul 2009 20:18:09 +0000 (16:18 -0400)]
Merged libbe.properties unittest fix

15 years agolibbe.properties unittest changes due to "extra change-hook save" fix.
W. Trevor King [Tue, 21 Jul 2009 20:14:53 +0000 (16:14 -0400)]
libbe.properties unittest changes due to "extra change-hook save" fix.

Missed these earlier.

15 years agoI imported a few threads from the mailing list as wishlist bugs.
W. Trevor King [Tue, 21 Jul 2009 19:22:09 +0000 (15:22 -0400)]
I imported a few threads from the mailing list as wishlist bugs.

12c:uw: Bug aggregation.  Multi-repo meta-BE?
529:ow: How should we version BE?
2f0:aw: Static html report generation
22b:aw: Sorting targets chronologically
d99:aw: CherryPy interface "Cherry-flavored BE"
e08:aw: Interactive email interface

15 years agoAdded "--no-comments" to "be show".
W. Trevor King [Tue, 21 Jul 2009 19:14:59 +0000 (15:14 -0400)]
Added "--no-comments" to "be show".

Also moved the XML-header line to the top of the argument loop, since
there should only be one.  We're still missing global tags wrapping the
whole thing though...

Also set options.XML default to False.  It had been defaulting to
None, which was breaking the non-XML newline-adding check.

15 years agobe-mbox-to-xml is now better at message-id, in-reply-to, and references.
W. Trevor King [Tue, 21 Jul 2009 18:17:03 +0000 (14:17 -0400)]
be-mbox-to-xml is now better at message-id, in-reply-to, and references.

A previous "len(ret) >= 0" had been stripping the alt-id and
in-reply-to from _all_ parts of multipart comments.  Now it only
strips them from parts after the first.  The following parts do not
specify and alt-id, and they all are in-reply-to the first part.

I also added the KNOWN_IDS list for selecting amongst an array of
possible in-reply-to or references ids.  This works well enough for
now, but would be more robust if we could import a list of previously
known ids from BE...

15 years ago"be comment --xml" now saves the comments (again).
W. Trevor King [Tue, 21 Jul 2009 17:32:24 +0000 (13:32 -0400)]
"be comment --xml" now saves the comments (again).

They are generated in memory (from_disk defaults to False)
  133:  new = comment.Comment(bug)
With the leaner saving since I started trusting sync_with_disk, they
were no longer making it to disk.

Easily fixed with an explicit save once you've got them all set up.