W. Trevor King [Wed, 29 Jul 2009 19:46:37 +0000 (15:46 -0400)]
Added clean messages on bug_from_shortname failure.
So user's don't get confused.
W. Trevor King [Thu, 23 Jul 2009 15:43:04 +0000 (11:43 -0400)]
libbe.rcs.RCS.commit() now actually calls .pre/postcommit().
It hadn't before, which defeats the Pu purpose of hook functions.
This hand't caused any problems though, since only libbe.bzr defined a
postcommit() and there were no precommit() definitions.
Bzr's postcommit() had been to auto-merge from the default merge
source. Yikes! Removed that ;).
W. Trevor King [Thu, 23 Jul 2009 14:08:04 +0000 (10:08 -0400)]
Added bugdir setting comparision to libbe.diff.
Renamed libbe.diff.diff -> bug_diffs, since it doesn't compare bugdirs.
Load comments before bug comparision so cmp_comments will see them.
Use .settings_properties rather than static lists to create attribute
lists for change_lines().
Removed trailing endline from becommands/diff.py output.
W. Trevor King [Thu, 23 Jul 2009 13:59:14 +0000 (09:59 -0400)]
Added libbe.bug.cmp_comments(), and added that to default bug comparison.
W. Trevor King [Thu, 23 Jul 2009 13:52:47 +0000 (09:52 -0400)]
Fixed unrecognized "Test" typo in becommands/comment.py.
W. Trevor King [Thu, 23 Jul 2009 13:25:34 +0000 (09:25 -0400)]
Added libbe.tree.Tree.has_descendant().
Tree equality is now based on instance id. It had previously used the
default list "equal if all elements are equal", which meant that all
the leaves matched each other.
W. Trevor King [Thu, 23 Jul 2009 13:20:52 +0000 (09:20 -0400)]
libbe/tree.Tree.traverse(depthFirst)->depth_first & stripped trailing spaces.
W. Trevor King [Wed, 22 Jul 2009 12:44:38 +0000 (08:44 -0400)]
Show text of comment's reference in notes when spawning EDITOR.
W. Trevor King [Tue, 21 Jul 2009 20:22:34 +0000 (16:22 -0400)]
Added .extra_strings to BugDir and Comment
W. Trevor King [Tue, 21 Jul 2009 20:21:42 +0000 (16:21 -0400)]
I'll add Comment.extra_strings too, while I'm at it.
W. Trevor King [Tue, 21 Jul 2009 20:20:21 +0000 (16:20 -0400)]
Added BugDir.extra_strings.
W. Trevor King [Tue, 21 Jul 2009 20:19:02 +0000 (16:19 -0400)]
Bug._extra_strings_check_fn() guts now utility.iterable_full_of_strings().
W. Trevor King [Tue, 21 Jul 2009 20:18:09 +0000 (16:18 -0400)]
Merged libbe.properties unittest fix
W. Trevor King [Tue, 21 Jul 2009 20:14:53 +0000 (16:14 -0400)]
libbe.properties unittest changes due to "extra change-hook save" fix.
Missed these earlier.
W. Trevor King [Tue, 21 Jul 2009 19:22:09 +0000 (15:22 -0400)]
I imported a few threads from the mailing list as wishlist bugs.
12c:uw: Bug aggregation. Multi-repo meta-BE?
529:ow: How should we version BE?
2f0:aw: Static html report generation
22b:aw: Sorting targets chronologically
d99:aw: CherryPy interface "Cherry-flavored BE"
e08:aw: Interactive email interface
W. Trevor King [Tue, 21 Jul 2009 19:14:59 +0000 (15:14 -0400)]
Added "--no-comments" to "be show".
Also moved the XML-header line to the top of the argument loop, since
there should only be one. We're still missing global tags wrapping the
whole thing though...
Also set options.XML default to False. It had been defaulting to
None, which was breaking the non-XML newline-adding check.
W. Trevor King [Tue, 21 Jul 2009 18:17:03 +0000 (14:17 -0400)]
be-mbox-to-xml is now better at message-id, in-reply-to, and references.
A previous "len(ret) >= 0" had been stripping the alt-id and
in-reply-to from _all_ parts of multipart comments. Now it only
strips them from parts after the first. The following parts do not
specify and alt-id, and they all are in-reply-to the first part.
I also added the KNOWN_IDS list for selecting amongst an array of
possible in-reply-to or references ids. This works well enough for
now, but would be more robust if we could import a list of previously
known ids from BE...
W. Trevor King [Tue, 21 Jul 2009 17:32:24 +0000 (13:32 -0400)]
"be comment --xml" now saves the comments (again).
They are generated in memory (from_disk defaults to False)
133: new = comment.Comment(bug)
With the leaner saving since I started trusting sync_with_disk, they
were no longer making it to disk.
Easily fixed with an explicit save once you've got them all set up.
W. Trevor King [Tue, 21 Jul 2009 17:24:55 +0000 (13:24 -0400)]
be-mbox-to-xml handles emails without explicit transfer encodings.
W. Trevor King [Tue, 21 Jul 2009 17:14:24 +0000 (13:14 -0400)]
Added cProfile notes to README.dev.
W. Trevor King [Tue, 21 Jul 2009 16:07:27 +0000 (12:07 -0400)]
Fixed extra change-hook save in testChangeHookMutableProperty.
The actual fix was
@@ -339,7 +355,10 @@
fset = funcs.get("fset")
name = funcs.get("name", "<unknown>")
def _fget(self, new_value=None, from_fset=False): # only used if mutable == True
- value = fget(self)
+ if from_fset == True:
+ value = new_value # compare new value with cached
+ else:
+ value = fget(self) # compare current value with cached
if _cmp_cached_mutable_property(self, "change hook property", name, value) != 0:
# there has been a change, cache new value
old_value = _get_cached_mutable_property(self, "change hook property", name)
The reason for the double-save was:
>>> print t.settings["List-type"]==EMPTY
True
(the cached value here is EMPTY)
>>> t.list_type = []
(old fget compares cached EMPTY to current EMPTY, no change, so no
cache. fset notices change and saves EMPTY->[])
>>> t.list_type.append(5)
(now fget notices the change EMPTY->[], caches [], and calls extra save)
The new way:
>>> print t.settings["List-type"]==EMPTY
True
(the cached value here is EMPTY)
>>> t.list_type = []
(fget compares cached EMPTY to new [] and saves EMPTY->[])
>>> t.list_type.append(5)
(fget sees no change ([]->[]), which is correct)
In addition to the fix and the related corrections to
testChangeHookMutableProperty, I added details about mutables to all
relevant docstrings and stripped trailing whitespace from both files.
W. Trevor King [Tue, 21 Jul 2009 14:32:15 +0000 (10:32 -0400)]
Touched up becommands/diff.py's help message.
W. Trevor King [Tue, 21 Jul 2009 11:28:26 +0000 (07:28 -0400)]
Cleaned up saving/sync_with_disk.
Got rid of a whole bunch of redundant .save() calls when
sync_with_disk==True.
Fixed up the "File-system access" portion of the BugDir docstring so
we can all remember how things are supposed to work ;).
Note that some .save() calls are still required. For example in
becommands/merge.py, the copied comments have their .bug changed, but
that is not a versioned property, so it doesn't trigger an automatic
save, and we have to force the .save() by hand.
libbe.rcs.RCS.mkdir() is now recursive by default, but you can set
check_parents==False if you want it to fail in the case of missing
parents. Because of the recursion, we removed the .update() call
on preexisting directories, since there will be at least one of
these occurrences for every .mkdir(check_parents=True) call, and
I don't know of any VCS that actually needs them...
Also stripped trailing whitespace from some files...
W. Trevor King [Mon, 20 Jul 2009 22:39:31 +0000 (18:39 -0400)]
Cleaned up some outdated libbe.settings_object.EMPTY cruft.
From back before commit
wking@drexel.edu-
20090619184215-nfx205yaj02sqrqx
cleaned up the versioned_property implementation.
Also a few style fixes and typos.
W. Trevor King [Sun, 19 Jul 2009 19:24:51 +0000 (15:24 -0400)]
Added --allow-empty to "be commit"
Previously many backends would silently add an empty commit. Not very
useful. When the new --allow-empty flag and related allow_empty
options are false, every versioning backend is guaranteed to raise the
EmptyCommit exception in the case of an attempted empty commit.
W. Trevor King [Sun, 19 Jul 2009 14:48:12 +0000 (10:48 -0400)]
Added becommands/commit.py and minor fixes.
Now we can commit changes from the command line with a unified
interface. The interface is much less flexible than using your
particular version control system's commit command directly, so this
command is mostly intended for user-interfaces and other tools that
don't want to be bothered with the extra flexibility.
Normalized spacing in rcs.RCS.commit to produce:
summary
<BLANKLINE>
body
<TRAILING-ENDLINE>
messages regardless of the input string format.
Also fixed a "--complete" handline bug in cmdutil, and some minor
docstring typos in libbe.rcs and .editor.
W. Trevor King [Sat, 18 Jul 2009 14:41:11 +0000 (10:41 -0400)]
Import sys in becommands/new.py.
Required for reading the bug summary string from stdin.
W. Trevor King [Sat, 18 Jul 2009 14:29:11 +0000 (10:29 -0400)]
Fixed broken path in libbe.rcs.RCS._rcs_get_file_contents(binary=True).
I'd forgotten to prefix the directory root, so calling
be show --only-raw-body COMMIT-ID
would fail if you weren't executing it in the repository root.
W. Trevor King [Tue, 14 Jul 2009 19:27:32 +0000 (15:27 -0400)]
Merged directory reorganization
W. Trevor King [Tue, 14 Jul 2009 19:25:44 +0000 (15:25 -0400)]
libbe/_version.py made PHONY in Makefile.
It should be updated after bzr commits, but Makefile doesn't
understand bzr, so just update every time.
W. Trevor King [Tue, 14 Jul 2009 19:24:18 +0000 (15:24 -0400)]
Updated Makefile to match new organization
W. Trevor King [Tue, 14 Jul 2009 19:18:07 +0000 (15:18 -0400)]
Reorganized directory structure, mostly to put all the interfaces in
one place and make things clearer to the uninitiated. Here's my
current understanding:
.
|-- libbe (the guts of BE)
|-- becommands (plugins for all "be *" commands)
|-- doc (documentation, currently just the man page)
|-- interfaces (non-commandline interface implementations)
| |-- web
| | |-- Bugs-Everywhere-Web (in Turbogears)
| |-- gui
| | |-- beg (in Tkinter)
| | `-- wxbe (in WX)
| |-- email
| `-- xml (xml <-> whatever conversion)
`-- misc (random odds and ends)
`-- completion (shell completion scripts)
Note that I haven't attempted to use the web or gui interfaces in a
while, so I'm not sure how well they're holding vs the core
development.
W. Trevor King [Tue, 14 Jul 2009 18:34:40 +0000 (14:34 -0400)]
Updated README to match current status.
Mostly updated the list of supported VCSs.
Also corrected spacing inconsistency in README.dev.
W. Trevor King [Tue, 14 Jul 2009 12:13:47 +0000 (08:13 -0400)]
Updated GPLv2 to current GPLv2.
Fixes Ben's bug
00f26f04-9202-4288-8744-
b29abc2342d6.
I also tweaked update_copyright.sh to make possible future
copyright-blurb revision easier. The new algorithm is greedier,
overwriting _all_ consecutive comments after a '^# Copyright' line, so
do
# Copyright
# GPL ... GPL ... GPL
# Your comment here...
not
# Copyright
# GPL ... GPL ... GPL
#
# Your comment here...
Without the blank line, your comment would get overwritten by the next
run of update_copyright.sh.
Note that catmutt is ignored by update_copyright.sh because Moritz
Barsnick has only licensed his grepm code under the GPLv2 (not
GPLv>=2). See the initial catmutt commit for details.
W. Trevor King [Tue, 14 Jul 2009 10:54:42 +0000 (06:54 -0400)]
Updated setup.py url and switched to rolling version names.
Alex Miller [Tue, 14 Jul 2009 10:22:54 +0000 (06:22 -0400)]
Merged Alex Miller's git-config-not-found patch
W. Trevor King [Mon, 13 Jul 2009 11:46:58 +0000 (07:46 -0400)]
Fixed "be --dir --complete"
W. Trevor King [Mon, 13 Jul 2009 11:32:11 +0000 (07:32 -0400)]
Added --dir option to "be"
W. Trevor King [Mon, 13 Jul 2009 11:23:16 +0000 (07:23 -0400)]
Use CmdOptionParser in "be".
All the becommands have been using cmdutil CmdOptionParser for a long
time, but "be" parsed its options by hand. Now it used
CmdOptionParser, which makes adding new options much easier.
W. Trevor King [Sun, 12 Jul 2009 19:27:40 +0000 (15:27 -0400)]
Added (commented out) /usr/local PREFIX to Makefile.
I got a bit confused and installed be into "/usr/local " instead of
"/usr/local" with
PREFIX = /usr/local # ${HOME}
With the alternate PREFIX line right there, there should be less
temptation to do again :p.
W. Trevor King [Sun, 12 Jul 2009 18:32:55 +0000 (14:32 -0400)]
Added "be comment --xml --ignore-missing-references ID COMMENT".
Now you don't have to edit them out by hand.
W. Trevor King [Sun, 12 Jul 2009 17:56:05 +0000 (13:56 -0400)]
be-mbox-to-xml passes attributes on to each part of multipart messages.
Previously "message[<some-attr>]" just returned None if it wasn't set
for that message part, which overwrote anything passed in through
fields.
"from" and "date" added to list of attributes passed along.
For be-xml-to-mbox, "alt-id" was added to Comment._attrs,
and Comment.print_to_mbox was adjusted to handle the case where
we have no information about the parent bug.
With all of this, I can complete the loop
be-mbox-to-xml example.mbox | be-xml-to-mbox > example2.mbox
without errors :p.
Finally, be-xml-to-mbox has been adjusted to also work on files (it
had previously only handled data via stdin). We can't add stdin
handling to be-mbox-to-xml though, because the mailbox package needs
an actual file to work on, and I haven't setup a tmpfile workaround
yet...
W. Trevor King [Sun, 12 Jul 2009 17:12:08 +0000 (13:12 -0400)]
Altered be-xml-to-mbox to work with non-ASCII input.
Now it runs off xml.etree instead of xml.sax.
Removed "No matching bugs found" from "be list --xml" output.
W. Trevor King [Sun, 12 Jul 2009 13:50:24 +0000 (09:50 -0400)]
Added timezone handling to libbe.utility.str_to_time.
W. Trevor King [Sun, 12 Jul 2009 13:05:05 +0000 (09:05 -0400)]
Not escaping whitespace (e.g. endlines) outside the XML document root.
ElementTree.XML was choking on them. I should unescape all whitespace
(e.g. tabs, etc.), but I'm lazy and don't have any XML that's strange
enough to need it ;).
W. Trevor King [Sun, 12 Jul 2009 12:52:50 +0000 (08:52 -0400)]
Minor fixes to get unittests working again.
W. Trevor King [Sun, 12 Jul 2009 12:38:40 +0000 (08:38 -0400)]
Added be-mbox-to-xml.
Reworked to allow "be comment" to handle unicode strings (see bug
e4ed63f6-9000-4d0b-98c3-
487269140141). The solution was to escape all
the unicode to produce and ASCII string before calling
ElementTree.XML, and then converting back to unicode afterwards.
Added a unicode-containing comment to the end of bug
f7ccd916-b5c7-4890-a2e3-
8c8ace17ae3a so that there's a handy unicode
comment for testing.
XML headers (e.g. '<?xml version="1.0" encoding="UTF-8" ?>') are
now added to all xml output from be.
Switched non-text/* encoding library to base64 instead of
email.encoders, which makes that code in libbe/comment.py simpler.
Changed libbe/mapfile.py error encoding from string_escape to
unicode_escape so it can handle unicode.
Everything's still untested, and be-xml-to-mbox doesn't handle unicode
yet, but I felt this commit was getting a bit unwieldy ;).
W. Trevor King [Sat, 11 Jul 2009 14:09:27 +0000 (10:09 -0400)]
Went through "closed" bugs looking for miss-categorized bugs.
Found a few that were actually "fixed" and one that I reopened.
Perhaps we should add a "merged" status to the default, so that the
merged bugs don't clutter up the closed bugs category...
W. Trevor King [Sat, 11 Jul 2009 13:46:38 +0000 (09:46 -0400)]
Updating "be set --help" and "be status --help".
I don't really like the "defaults to None" for the settings that have
funky initialization procedures (most of them :p), but I'm not sure
how to handle that cleanly yet. Perhaps
be set --current
I also need to find a method of adding complicated settings like the
nested lists for severities, etc from the "be set" commandline.
W. Trevor King [Sat, 11 Jul 2009 12:13:34 +0000 (08:13 -0400)]
Removed <abentley@panoramicfeedback.com> from copyright blurbs.
These didn't work with my update_copyright.sh.
I went with
Aaron Bentley and Panometrics, Inc.
instead of
Aaron Bentley <abentley@panoramicfeedback.com> and Panometrics, Inc.
just because of line length, but I'm open to convincing if people
prefer the latter...
W. Trevor King [Sat, 11 Jul 2009 12:01:45 +0000 (08:01 -0400)]
"be comment --xml" now translates comment uuids to alt_ids.
W. Trevor King [Sat, 11 Jul 2009 11:46:22 +0000 (07:46 -0400)]
Adjustments to new versioned_property behavior.
Also adjusted libbe/comment.py to move to user-specified alt_ids,
rather than uuids.
W. Trevor King [Sat, 11 Jul 2009 11:13:17 +0000 (07:13 -0400)]
Fixed versioned_property(default=None, generator=None) defaults.
Now the behavior conforms to the docstring:
If both default and generator are None, then the property will be a
defaulting property which defaults to None.
W. Trevor King [Sat, 11 Jul 2009 10:46:49 +0000 (06:46 -0400)]
Fixed minor doctest failure in cmdutil.py
W. Trevor King [Sat, 11 Jul 2009 10:39:48 +0000 (06:39 -0400)]
Merged "be comment --xml" code from home.
W. Trevor King [Fri, 10 Jul 2009 21:58:49 +0000 (17:58 -0400)]
seems to work ;)
W. Trevor King [Fri, 10 Jul 2009 18:14:24 +0000 (14:14 -0400)]
Save whole bugdir in becommands/tag.py.
It doesn't matter now, but at some point Bugdir might implement some
sort of repo-wide caching which would need to be saved. The
BugDir.save() method should be intelligent enough to not save things
that have not changed, so efficiency should not be effected either.
W. Trevor King [Fri, 10 Jul 2009 18:11:23 +0000 (14:11 -0400)]
Simplified error handling in ./be
Removed superfluous nesting in ./be's error catching. Also replaced
KeyErrors due to unknown commands with the more specific
cmdutil.UnknownCommand, since all sorts of programming errors can
raise KeyErrors.
Untested, since my working tree is a mess at the moment, but what
could go wrong? ;)
W. Trevor King [Wed, 8 Jul 2009 02:18:56 +0000 (22:18 -0400)]
Added new-bug-from-stdin to mirror comments-from-stdin.
W. Trevor King [Mon, 6 Jul 2009 20:15:09 +0000 (16:15 -0400)]
Added "be show --only-raw-body COMMENT-ID".
W. Trevor King [Mon, 6 Jul 2009 19:54:13 +0000 (15:54 -0400)]
Added ability to show individual comments with "be show".
W. Trevor King [Thu, 2 Jul 2009 02:37:57 +0000 (22:37 -0400)]
"be init [ROOTDIR]" -> "be init [--root ROOTDIR]"
Following Ben's Wed, 01 Jul 2009 11:31:51 +1000 suggestion.
W. Trevor King [Thu, 2 Jul 2009 02:21:52 +0000 (22:21 -0400)]
Updated darcs put command for darcs >= 2.2.0, following Chris' report
W. Trevor King [Thu, 2 Jul 2009 02:20:32 +0000 (22:20 -0400)]
Updated copyright blurbs and AUTHORS and included script for future updates
W. Trevor King [Tue, 30 Jun 2009 23:40:01 +0000 (19:40 -0400)]
"be set-root" changed to "be init"
On the advice of
Martin F Krafft <madduck@debian.org>
as posted in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=477125
on
Fri, 12 Jun 2009 17:03:02 +0200
W. Trevor King [Tue, 30 Jun 2009 19:26:56 +0000 (15:26 -0400)]
"be comment" now handles the default options.content_type.
Previously it choked when options.content_type == None.
I'm not sure how that made it past test_usage.sh...
W. Trevor King [Tue, 30 Jun 2009 15:54:56 +0000 (11:54 -0400)]
Add "--show-status" flag to "be depend"
W. Trevor King [Tue, 30 Jun 2009 15:29:06 +0000 (11:29 -0400)]
Added darcs support.
I don't know much darcs, so I make no claims about the beauty of my
implementation. It seems to get the job done though, until a darcs
guru comes along.
I also tweaked the libbe.git.Git._rcs_get_user_id to handle the case
where user.name or user.email are not set.
I also added the option to pass a stdin string into the
libbe.rcs.RCS._u_invoke* functions.
W. Trevor King [Tue, 30 Jun 2009 15:00:46 +0000 (11:00 -0400)]
Remove blank line from bug.xml() output when bug has no comments.
W. Trevor King [Fri, 26 Jun 2009 13:27:50 +0000 (09:27 -0400)]
Added ability to handle non text/* MIME types.
The main problem was the encoding/decoding that was happening to _all_
input/output. Now many I/O activities have a `binary' option to
disable any encoding/decoding. The `binary' flag is set whenever the
comment content-type is not a text/* type.
In order to print valid XML (and make life easy on xml/be-xml-to-mbox),
non text/* types are printed out as base64-encoded MIME messages, so
be list --xml | be-xml-to-mbox | catmutt
works as you'd expect.
With the standard (non-XML) output from `be show', we just print a
message telling the user that we can't reasonably display the MIME
type and that they should use the XML output if they want to see it.
W. Trevor King [Fri, 26 Jun 2009 01:57:02 +0000 (21:57 -0400)]
Updated help strings, man page, and completions
wking [Thu, 25 Jun 2009 21:10:57 +0000 (17:10 -0400)]
Fixed libbe.rcs.RCS.installed to handle missing backend binary.
This makes all the failed tests understandable, since they all crash
with strings like:
AssertionError: Arch RCS not found
Which makes more sense than spitting out the raw CommandError.
It also means that installed_rcs() actually works now ;).
W. Trevor King [Thu, 25 Jun 2009 17:42:19 +0000 (13:42 -0400)]
Updated .bzringore and Makefile.GENERATED_FILES
W. Trevor King [Thu, 25 Jun 2009 17:31:31 +0000 (13:31 -0400)]
Added auto-generated version info. (be --version)
W. Trevor King [Thu, 25 Jun 2009 17:30:23 +0000 (13:30 -0400)]
Remove blank line from tag's output if no tags exist
W. Trevor King [Thu, 25 Jun 2009 14:05:25 +0000 (10:05 -0400)]
Added regexp matching to `be list --extra-strings'
W. Trevor King [Thu, 25 Jun 2009 13:51:41 +0000 (09:51 -0400)]
Added extra_strings functionality to libbe.bug.xml and be-xml-to-mbox.
W. Trevor King [Thu, 25 Jun 2009 13:11:32 +0000 (09:11 -0400)]
Merged extra-strings branch, adding be tag/depend.
W. Trevor King [Thu, 25 Jun 2009 13:10:04 +0000 (09:10 -0400)]
Added `be depend'.
This closes bug
7ec2c071-9630-42b0-b08a-
9854616f9144. BE is now bug
free ;). At least until the next commit :p.
Writing depend.py turned up a few style points in tag.py which I also
fixed.
W. Trevor King [Thu, 25 Jun 2009 12:30:52 +0000 (08:30 -0400)]
Added `be tag --list' to list all tags.
Loading all the bugs for the list search had the side effect of
updating all the bug values files to the new YAML format.
W. Trevor King [Thu, 25 Jun 2009 12:16:47 +0000 (08:16 -0400)]
Added -e/--extra-strings option to `be list`
Now you can limit your list to bugs matching certain extra strings,
e.g. "TAG:working".
W. Trevor King [Thu, 25 Jun 2009 12:05:43 +0000 (08:05 -0400)]
Fixed settings=None bug when bug values file is blank/missing.
Just return an empty dict instead.
Steps to reproduce:
$ mkdir /tmp/BE-test
$ cd /tmp/BE-test
$ be set-root
$ be new 'having too much fun'
W. Trevor King [Thu, 25 Jun 2009 11:45:57 +0000 (07:45 -0400)]
tag --remove now returns bug.settings["extra_strings"] to EMPTY.
extra_strings returns to a defaulting property from a cached/generator
property, with the help of the new, mutable defaults. Lots of
deepcopies avoid mutable default uncertainty too ;). And
copy.deepcopy([]) should be pretty cheap.
tag --remove had previously left settings["extra_strings"] as [],
which polluted the bug's values file. Now the improved
defaulting_property notices a return to the default [], and sets the
internally stored value to EMPTY.
I struggled with creating a more intuitive way to notice changes to
extra_strings than the
tmp = bug.extra_strings
<work on tmp>
bug.extra_strings = tmp
but didn't have any luck. The problem seems to be that if you only
hand out copies of your default, you don't have any pointers to what
you handed out to check for changes. On the other hand, if you hand
out your original default, any external changes will _change_ your
original default. I suppose you could only hand out copies, but keep
a list of all copies handed out, but that sounds like a disaster.
Reassigning is easy enough.
W. Trevor King [Wed, 24 Jun 2009 21:58:41 +0000 (17:58 -0400)]
Merged from main branch. I like my version better ;).
W. Trevor King [Wed, 24 Jun 2009 21:41:56 +0000 (17:41 -0400)]
`be target list` -> `be target --list` to standardize syntax.
And avoid confusion with bugs who's shorname is `list'? ;)
Now the usage info and help string also reflect the new method.
Chris Ball [Wed, 24 Jun 2009 21:40:59 +0000 (17:40 -0400)]
Add documentation and testcase for "be target list".
Gianluca Montecchi [Wed, 24 Jun 2009 21:26:50 +0000 (17:26 -0400)]
Only print a target in "be target list" if it's a string.
Chris Ball [Wed, 24 Jun 2009 21:25:02 +0000 (17:25 -0400)]
Add "be target list", to show a list of existing targets.
Chris Ball [Wed, 24 Jun 2009 21:24:25 +0000 (17:24 -0400)]
Merge with W. Trevor King's tree.
Gianluca Montecchi [Wed, 24 Jun 2009 21:20:12 +0000 (17:20 -0400)]
Add ability to list all current targets.
From his Wed, 24 Jun 2009 23:08:25 +0200 email to the list:
Hello
As I noted some time ago, there is not a way to list all the present targets
in the current repository.
At the time, Chris send me a patch to have this feature, but it still not
merged in the last revision (314).
So this is a patch for this feature to apply against revision 314. It is
basically a port of the old Chris's patch.
bye
Gianluca
W. Trevor King [Tue, 23 Jun 2009 23:59:50 +0000 (19:59 -0400)]
Use generator instead of default for libbe.bug.Bug.extra_strings.
This avoids the problems associated with mutable defaults.
W. Trevor King [Tue, 23 Jun 2009 23:52:20 +0000 (19:52 -0400)]
Added test case for mutables to libbe/settings_object.
This continues the line of changes started in libbe/properties with
the last two commits. Also straightened up stranch double-default in
libbe.settings_object.versioned_property and moved the fn_checked
before checked, which shouldn't matter because I never use both at
once, and can't think of a case where you'd want to.
I've also added some docstrings to the settings_object unit tests,
since apparently docstrings get printed during the test if they exist,
and they look nicer than the name of the unittest itself. More like
./configure output ;).
W. Trevor King [Tue, 23 Jun 2009 18:05:36 +0000 (14:05 -0400)]
Cleaned up libbe.propertied.change_hook_property for mutables.
Now (except for a wimpy hash function) it's as good as it's going to
get for true mutables. Calls to change_hook occur for all changes,
sometime after the change-enducing action and before the next
attribute access. See testChangeHookMutableProperty for an example of
the expected behavior.
If you're doing some mutable-modification (e.g. t.x.append(5)) and you
want to `flush' the changes into a change_hook call, just assign t.x
to a dummy variable. e.g.
t.x.append(5)
dummy = t.x
If you _really_ need post-modification change_hook calls without such
a flush, you're on your own. Would you get the property-owning class
to poll for changes?
W. Trevor King [Tue, 23 Jun 2009 15:44:06 +0000 (11:44 -0400)]
Added becommands/tag.py
Oops, I forgot to add becommands/tag.py with my last commit. Here it
is now, with the added ability to remove tags.
W. Trevor King [Tue, 23 Jun 2009 15:35:23 +0000 (11:35 -0400)]
Added Bug.extra_strings to support add-on functionality, e.g. `be tag`.
Versioned properties whose data is a mutable type are tricky, since
the simple comparisons we'd been using in
libbe.properties.change_hook_property don't work for mutables. For
now, we avoid that problem by assuming a change happened whenever a
mutable property is set. change_hook_property is a bit untidy at the
moment while I work out how to deal with mutables.
As an example of using Bug.extra_strings to patch on some useful
functionality, I've written becommands/tag.py. I'd suggest future
add-ons (e.g. becommands/depend.py?) use the "<LABEL>:<value>" string
format to keep it easy to sort out which strings belong to which
add-ons. tag.py is still missing command line tag-removal and
tag-searching for `be list'. Perhaps something like
be list --extra-strings TAG:<your-tag>,TAG:<another-tag>,DEPEND:<bug-id>
would be good, although it would requre escaping commas from the tags,
or refusing to allow commas in the tags...
libbe.properties.ValueCheckError also got a minor update so the
printed error message makes sense when raised with allowed being an
iterable (i.e. check_property) or a function
(e.g. fn_checked_property).
All of this digging around turned up a really buggy
libbe.bugdir.MultipleBugMatches. Obviously I had never actually
called it before :p. Should be fixed now.
libbe.comment._set_comment_body has also been normalized to match the
suggested change_hook interface: change_hook(self, old, new).
Although, I'm not sure why it hadn't been causing obvious problems
before, so maybe I'm misunderstanding something about that.
W. Trevor King [Mon, 22 Jun 2009 21:31:13 +0000 (17:31 -0400)]
Consolidated outstanding bugs.
Only one live bug left:
7ec2c071-9630-42b0-b08a-
9854616f9144
I've decided (mostly due to the huge Trac post, see bug comments) to
_not_ hardcode dependencies, but to add an attribute-creation
mechanism that a becommand/depend.py could use for dependency
tracking. Time for a new branch to think this out...
W. Trevor King [Mon, 22 Jun 2009 20:27:46 +0000 (16:27 -0400)]
Added `be list --sort *` for user-selectable sorting.
Also added libbe.bug.cmp_last_modified, which handles part of
9ce2f015-8ea0-43a5-a03d-
fc36f6d202fe. To do better we could extend
the RCS framework.
I also transcribed a few emails from the be-devel list onto their
relavent bugs and closed a few bugs.
Finally, I removed some left over InvalidValue cruft.
W. Trevor King [Mon, 22 Jun 2009 18:30:42 +0000 (14:30 -0400)]
Use Comment.content_type in xml output.
W. Trevor King [Mon, 22 Jun 2009 16:20:09 +0000 (12:20 -0400)]
Merged be-xml-to-mbox
W. Trevor King [Mon, 22 Jun 2009 16:16:27 +0000 (12:16 -0400)]
Created be-xml-to-mbox.
Converts the output of `be list --xml` mbox format.
For example:
$ be list --xml | be-xml-to-mbox | catmutt