monkeysphere-validation-agent.git
13 years agoCrypt::Monkeysphere::MSVA requests GnuPG::Interface 0.43.
W. Trevor King [Sun, 29 May 2011 01:54:22 +0000 (21:54 -0400)]
Crypt::Monkeysphere::MSVA requests GnuPG::Interface 0.43.

13 years agoAdd newline after version in `msva-query-agent --version` output.
W. Trevor King [Sun, 29 May 2011 01:45:43 +0000 (21:45 -0400)]
Add newline after version in `msva-query-agent --version` output.

13 years agoMove unit testing over to Build.PL framework (./Build test).
W. Trevor King [Sat, 28 May 2011 22:59:23 +0000 (18:59 -0400)]
Move unit testing over to Build.PL framework (./Build test).

13 years agoAdd doc/ directory and install its contents to /usr/share/doc/msva/.
W. Trevor King [Sat, 28 May 2011 20:49:26 +0000 (16:49 -0400)]
Add doc/ directory and install its contents to /usr/share/doc/msva/.

13 years agoMan pages now built in blib/bindoc, so no need to gitignore *.1.
W. Trevor King [Sat, 28 May 2011 19:20:11 +0000 (15:20 -0400)]
Man pages now built in blib/bindoc, so no need to gitignore *.1.

13 years agoAdd Build.PL side effects to .gitignore.
W. Trevor King [Sat, 28 May 2011 19:18:15 +0000 (15:18 -0400)]
Add Build.PL side effects to .gitignore.

13 years agoAlso install scripts and man pages.
W. Trevor King [Sat, 28 May 2011 19:17:22 +0000 (15:17 -0400)]
Also install scripts and man pages.

13 years agoAdd Build.PL for easy installation.
W. Trevor King [Sat, 28 May 2011 17:18:28 +0000 (13:18 -0400)]
Add Build.PL for easy installation.

13 years agoChange to a CPAN-friendly version string.
W. Trevor King [Sat, 28 May 2011 17:17:38 +0000 (13:17 -0400)]
Change to a CPAN-friendly version string.

13 years agoMove to a Module::Build-friendly layout with code under lib/.
W. Trevor King [Sat, 28 May 2011 17:17:01 +0000 (13:17 -0400)]
Move to a Module::Build-friendly layout with code under lib/.

13 years agoGive default value for $loglevel.
W. Trevor King [Thu, 26 May 2011 11:33:52 +0000 (07:33 -0400)]
Give default value for $loglevel.

This fixes the following warning:

  Use of uninitialized value $loglevel in lc at
  Crypt/Monkeysphere/Logger.pm line 91.

13 years agoSuppress "Subroutine new redefined at Crypt/Monkeysphere/MSVA.pm line 81."
W. Trevor King [Thu, 26 May 2011 11:28:13 +0000 (07:28 -0400)]
Suppress "Subroutine new redefined at Crypt/Monkeysphere/MSVA.pm line 81."

Following the suggestion given by `use diagnostics;`:

  (W redefine) You redefined a subroutine.  To suppress this warning, say

    {
    no warnings 'redefine';
    eval "sub name { ... }";
    }

13 years agomake sure fingerprints and validity get passed through to the marginal UI appropriately
Daniel Kahn Gillmor [Thu, 24 Mar 2011 05:09:27 +0000 (01:09 -0400)]
make sure fingerprints and validity get passed through to the marginal UI appropriately

13 years agoupdate commentary about non-implemented OpenPGPCertificateEmbedded
Daniel Kahn Gillmor [Wed, 23 Mar 2011 19:30:50 +0000 (15:30 -0400)]
update commentary about non-implemented OpenPGPCertificateEmbedded

13 years agoadded first draft of openpgp2x509
Daniel Kahn Gillmor [Wed, 23 Mar 2011 19:13:00 +0000 (15:13 -0400)]
added first draft of openpgp2x509

13 years agofix bug that added subvalid keys to the wrong list
David Bremner [Sat, 19 Mar 2011 19:18:23 +0000 (16:18 -0300)]
fix bug that added subvalid keys to the wrong list

13 years agomake use of PGPExtension in X.509 public key carriers
Daniel Kahn Gillmor [Mon, 14 Mar 2011 05:08:17 +0000 (01:08 -0400)]
make use of PGPExtension in X.509 public key carriers

13 years agoavoid a warning if certificate issuer is not present in cert
Daniel Kahn Gillmor [Mon, 14 Mar 2011 05:06:29 +0000 (01:06 -0400)]
avoid a warning if certificate issuer is not present in cert

13 years agouse the stable version of GnuPG::Interface with our desired changes.
Daniel Kahn Gillmor [Fri, 11 Mar 2011 23:22:38 +0000 (18:22 -0500)]
use the stable version of GnuPG::Interface with our desired changes.

13 years agoupdate gpgkeys_hkpms to use Monkeysphere::Logger instead of Monkeysphere::MSVA::Logger
Daniel Kahn Gillmor [Fri, 11 Mar 2011 16:50:00 +0000 (11:50 -0500)]
update gpgkeys_hkpms to use Monkeysphere::Logger instead of Monkeysphere::MSVA::Logger

13 years agoCrypt::Monkeysphere::OpenPGP : bring in pieces of keytrans for fingerprint computation
Daniel Kahn Gillmor [Fri, 11 Mar 2011 07:34:36 +0000 (02:34 -0500)]
Crypt::Monkeysphere::OpenPGP : bring in pieces of keytrans for fingerprint computation

13 years agouse new upstream features of Crypt::X509 directly -- less code in MSVA
Daniel Kahn Gillmor [Fri, 11 Mar 2011 06:25:38 +0000 (01:25 -0500)]
use new upstream features of Crypt::X509 directly -- less code in MSVA

13 years agoUpdate comments for untaint.
David Bremner [Thu, 10 Mar 2011 21:02:32 +0000 (16:02 -0500)]
Update comments for untaint.

Assume it is generally unwise, and add comments when used explaining
why it is supposed to be OK.

13 years agoupdating changelog to match revisions from David Bremner
Daniel Kahn Gillmor [Thu, 10 Mar 2011 05:59:00 +0000 (00:59 -0500)]
updating changelog to match revisions from David Bremner

13 years agoInterrogate the GnuPG::Interface object to get $GPGHOME, when guessing
David Bremner [Thu, 10 Mar 2011 16:08:07 +0000 (12:08 -0400)]
Interrogate the GnuPG::Interface object to get $GPGHOME, when guessing
a keyserver.

We fall back on the environment, as before. This required splitting
untaint out into its own module.

13 years agorename tests for ordering
David Bremner [Thu, 10 Mar 2011 12:31:02 +0000 (08:31 -0400)]
rename tests for ordering

13 years agoadd missing keyserver policy default
David Bremner [Thu, 10 Mar 2011 12:27:13 +0000 (08:27 -0400)]
add missing keyserver policy default

13 years agorename test directories and sort tests by name
David Bremner [Thu, 10 Mar 2011 12:21:42 +0000 (08:21 -0400)]
rename test directories and sort tests by name

13 years agoadd missing brace
David Bremner [Thu, 10 Mar 2011 12:07:18 +0000 (08:07 -0400)]
add missing brace

13 years agoAllow list of directories on command line for unit tests
David Bremner [Sun, 6 Mar 2011 21:49:26 +0000 (17:49 -0400)]
Allow list of directories on command line for unit tests

13 years agoFactor out userid validation from MSVA.pm into Crypto::Monkeysphere::Validator.
David Bremner [Sun, 6 Mar 2011 21:46:36 +0000 (17:46 -0400)]
Factor out userid validation from MSVA.pm into Crypto::Monkeysphere::Validator.

The use of this new class in Crypto::Monkeysphere::MSVA is untested so far.

13 years agoAdd Keyserver class, and unit tests.
David Bremner [Sun, 6 Mar 2011 18:42:48 +0000 (14:42 -0400)]
Add Keyserver class, and unit tests.

This is really a repackaging of the functions fetch_fpr_from_keyserver
and fetch_uid_from_keyserver from MSVA.pm, along with the part of
get_keyserver from the same file that depends only on GnuPG, not on
MSVA.

13 years agoadd unit test harness.
David Bremner [Sun, 6 Mar 2011 18:40:32 +0000 (14:40 -0400)]
add unit test harness.

The file looks for any files under unit-tests ending in .t, and runs them.
You can use e.g. Test::Simple or Test::More to make such tests.

13 years agouse renamed logger module
David Bremner [Sun, 6 Mar 2011 16:53:39 +0000 (12:53 -0400)]
use renamed logger module

13 years agoRename module Crypt::Monkeysphere::MSVA::Logger to Crypt::Monkeysphere::Logger
David Bremner [Sun, 6 Mar 2011 16:47:38 +0000 (12:47 -0400)]
Rename module Crypt::Monkeysphere::MSVA::Logger to Crypt::Monkeysphere::Logger

13 years agoRename MSVA/Logger.pm to Logger.pm
David Bremner [Sun, 6 Mar 2011 16:46:16 +0000 (12:46 -0400)]
Rename MSVA/Logger.pm to Logger.pm

13 years agoreturn 100 from msva-query-agent if unable to contact msva
Jameson Rollins [Fri, 31 Dec 2010 06:39:17 +0000 (01:39 -0500)]
return 100 from msva-query-agent if unable to contact msva

13 years agotouch z.openpgp4fpr file to prevent unecessary warning in tests/basic
Jameson Rollins [Fri, 31 Dec 2010 06:34:01 +0000 (01:34 -0500)]
touch z.openpgp4fpr file to prevent unecessary warning in tests/basic

13 years agoadd echoes to tests to make up for lack of them in msva-query-agent output
Jameson Rollins [Fri, 31 Dec 2010 06:32:01 +0000 (01:32 -0500)]
add echoes to tests to make up for lack of them in msva-query-agent output

13 years agocheck that key data is not empty, and return error otherwise.
Jameson Rollins [Fri, 31 Dec 2010 06:29:26 +0000 (01:29 -0500)]
check that key data is not empty, and return error otherwise.

13 years agoget rid of confusing $primarymatch label, and fix matching based on fingerprints
Daniel Kahn Gillmor [Thu, 30 Dec 2010 22:50:26 +0000 (17:50 -0500)]
get rid of confusing $primarymatch label, and fix matching based on fingerprints

13 years agorequire openpgp4fpr to be a full fingerprint and standardize internally on upper...
Daniel Kahn Gillmor [Thu, 30 Dec 2010 22:49:39 +0000 (17:49 -0500)]
require openpgp4fpr to be a full fingerprint and standardize internally on upper-case hexdigits

13 years agoswitch from "email" to "e-mail"
Daniel Kahn Gillmor [Thu, 30 Dec 2010 22:13:20 +0000 (17:13 -0500)]
switch from "email" to "e-mail"

13 years agomore cleanup of the usage function to make it easier to edit, and maybe invoke elsewhere.
Daniel Kahn Gillmor [Thu, 30 Dec 2010 22:05:25 +0000 (17:05 -0500)]
more cleanup of the usage function to make it easier to edit, and maybe invoke elsewhere.

13 years agomsva-query-agent report usage when no arguments are given
Daniel Kahn Gillmor [Thu, 30 Dec 2010 21:53:37 +0000 (16:53 -0500)]
msva-query-agent report usage when no arguments are given

13 years agoremove trailing newline entirely from query-agent message output to stdout
Jameson Rollins [Thu, 30 Dec 2010 18:15:02 +0000 (13:15 -0500)]
remove trailing newline entirely from query-agent message output to stdout

This goes a step further than a328802a (which only output newline to
terminals) to just remove the extra newline altogether.  It is not
part of the original message, and query-agent is meant to me mostly
used in pipeline anyway where the stdout is captured by another
calling process.

13 years agoAllow for '0x' prefix to openpgp4fpr
Jameson Rollins [Thu, 30 Dec 2010 17:47:05 +0000 (12:47 -0500)]
Allow for '0x' prefix to openpgp4fpr

Modify the regexp check of the data to return everything after a
'0x' instance as the fingerprint.

13 years agoreturn pkcextractkey before processing key exponent/modulus if an error was encountered
Jameson Rollins [Thu, 30 Dec 2010 17:35:08 +0000 (12:35 -0500)]
return pkcextractkey before processing key exponent/modulus if an error was encountered

This should prevent some unnecessary processing on errors.

13 years agoupdate upstream changelog
Jameson Rollins [Tue, 28 Dec 2010 15:31:25 +0000 (10:31 -0500)]
update upstream changelog

13 years agoadd option to msva-query-agent to just return agent version info
Jameson Rollins [Tue, 28 Dec 2010 15:20:58 +0000 (10:20 -0500)]
add option to msva-query-agent to just return agent version info

This option makes only a simple GET request to the agent and returns
the agent version portion of the response.

13 years agoimprove msva-query-agent man page
Jameson Rollins [Tue, 28 Dec 2010 15:12:18 +0000 (10:12 -0500)]
improve msva-query-agent man page

13 years agomention cabability and validity in verbose output when not capable/valid
Jameson Rollins [Tue, 28 Dec 2010 14:06:12 +0000 (09:06 -0500)]
mention cabability and validity in verbose output when not capable/valid

13 years agoRevert "tweak test-msva to accept full path to msva script"
Jameson Rollins [Tue, 28 Dec 2010 14:03:04 +0000 (09:03 -0500)]
Revert "tweak test-msva to accept full path to msva script"

This reverts commit be8f436bfdcde4d995300078642ac21ab52f2957.

After further consideration, I think the previous handling of argument
parsing is preferable.

14 years agomsva-query-agent only append newline to msg output if tty
Jameson Rollins [Sun, 26 Dec 2010 01:56:17 +0000 (20:56 -0500)]
msva-query-agent only append newline to msg output if tty

msva-query-agent will now only append a newline to the msva return
message on stdout if there is a TTY.  This allows calling processes
that would like to capture the stdout to not have to deal with the
newline, which is not actually a part of the original message anyway.

14 years agoallow passing pkc data to msva-query-agent as argument
Jameson Rollins [Sun, 26 Dec 2010 00:49:59 +0000 (19:49 -0500)]
allow passing pkc data to msva-query-agent as argument

This is likely only useful for 'openpgp4fpr' type, but for that it is
indeed useful.  This will make it considerably easier for calling
programs that want to use this type (like mail clients).

14 years agomsva-query-agent print usage to stderr
Jameson Rollins [Sun, 26 Dec 2010 00:22:05 +0000 (19:22 -0500)]
msva-query-agent print usage to stderr

14 years agoadd test for email context
Jameson Rollins [Sat, 25 Dec 2010 19:50:37 +0000 (14:50 -0500)]
add test for email context

14 years agoadd tests for openpgp4fpr pkc type
Jameson Rollins [Sat, 25 Dec 2010 19:14:17 +0000 (14:14 -0500)]
add tests for openpgp4fpr pkc type

14 years agofix typo
Jameson Rollins [Sat, 25 Dec 2010 19:08:14 +0000 (14:08 -0500)]
fix typo

14 years agoupdate upstream changelog
Jameson Rollins [Sat, 25 Dec 2010 17:05:40 +0000 (12:05 -0500)]
update upstream changelog

14 years agotweaks to break out of unnecessary extra key loops if a valid key is found
Jameson Rollins [Sat, 25 Dec 2010 16:57:07 +0000 (11:57 -0500)]
tweaks to break out of unnecessary extra key loops if a valid key is found

14 years agoadd new "email" context
Jameson Rollins [Sat, 25 Dec 2010 15:58:54 +0000 (10:58 -0500)]
add new "email" context

This can be used for validating user IDs associated with email
signatures.  Since email signatures are generated with signing-capable
keys, the signing capability flag is required for email-context keys
to be valid.

14 years agoAdd support for openpgp4fpr pkc type
Jameson Rollins [Sat, 25 Dec 2010 00:10:25 +0000 (19:10 -0500)]
Add support for openpgp4fpr pkc type

Instead of passing a full key, we here allow instead passing a full
OpenPGP fingerprint.  The key is 'recv'd from the keyserver if not
available, and validation is done on the exact matching key.

14 years agoremove pkc type checking from client, in favor of just passing everything off the...
Jameson Rollins [Sat, 25 Dec 2010 00:08:22 +0000 (19:08 -0500)]
remove pkc type checking from client, in favor of just passing everything off the agent

14 years agotiny bit of cleanup and commenting
Jameson Rollins [Fri, 24 Dec 2010 22:45:13 +0000 (17:45 -0500)]
tiny bit of cleanup and commenting

14 years agomove pkc key extraction functions adjacent to each other
Jameson Rollins [Fri, 24 Dec 2010 22:39:22 +0000 (17:39 -0500)]
move pkc key extraction functions adjacent to each other

NO FUNCITONAL CHANGE.  This is just to make the functions easier to
find in the code.

14 years agosimplify reviewcert by breaking out pkc key extraction code into it's own function
Jameson Rollins [Fri, 24 Dec 2010 22:33:17 +0000 (17:33 -0500)]
simplify reviewcert by breaking out pkc key extraction code into it's own function

As a consequence of this change, a large chunk of reviewcert was able
to be popped out of a conditional, so this change looks bigger than it
is functionally.

14 years agotweak test-msva to accept full path to msva script
Jameson Rollins [Fri, 24 Dec 2010 22:05:10 +0000 (17:05 -0500)]
tweak test-msva to accept full path to msva script

14 years agoadd --help usage to msva-query-agent
Jameson Rollins [Wed, 22 Dec 2010 21:09:56 +0000 (16:09 -0500)]
add --help usage to msva-query-agent

14 years agoavoid some spurious error messages when no agent is found msva-perl/0.8
Daniel Kahn Gillmor [Mon, 20 Dec 2010 21:11:39 +0000 (16:11 -0500)]
avoid some spurious error messages when no agent is found

14 years agoautomatically update the internal versioning of MSVA.pm from the
Daniel Kahn Gillmor [Mon, 20 Dec 2010 17:34:03 +0000 (12:34 -0500)]
automatically update the internal versioning of MSVA.pm from the
Changelog.

This is a little crufty (it might trip up people the first time they
bump versions directly from within a git repo, and cause a spurious
commit or two), but it has a few advantages:

 0) it is a simple, small change to make right now, and

 1) it means we can leave all the files in place, so the test harness
    can work in-place.

 2) our "upstream tarball" can continue to be cleanly built.

Probably the better long-term way to fix this is an "install" target
in the Makefile that does this substitution as it transfers the file
into place.  That target would need to know where to place perl
modules, among other things.  (see MS # 2684)

14 years agobump internal version number.
Daniel Kahn Gillmor [Mon, 20 Dec 2010 17:10:20 +0000 (12:10 -0500)]
bump internal version number.

14 years agoaccept trailing slashes on http-proxy
Daniel Kahn Gillmor [Mon, 20 Dec 2010 09:13:30 +0000 (04:13 -0500)]
accept trailing slashes on http-proxy

14 years agogpgkeys_hkpms: added support for --keyserver-options http-proxy=XXX and https_proxy...
Daniel Kahn Gillmor [Mon, 20 Dec 2010 09:07:27 +0000 (04:07 -0500)]
gpgkeys_hkpms: added support for --keyserver-options http-proxy=XXX and https_proxy environment variables

14 years agotouch up upstream Changelog for proposed release
Daniel Kahn Gillmor [Mon, 20 Dec 2010 07:38:17 +0000 (02:38 -0500)]
touch up upstream Changelog for proposed release

14 years agoList certifiers only once (closes MS # 2573)
Daniel Kahn Gillmor [Mon, 20 Dec 2010 07:36:42 +0000 (02:36 -0500)]
List certifiers only once (closes MS # 2573)

14 years agoDo not report self-sigs as other certifiers (but report valid, non-matching identitie...
Daniel Kahn Gillmor [Mon, 20 Dec 2010 06:56:30 +0000 (01:56 -0500)]
Do not report self-sigs as other certifiers (but report valid, non-matching identities independently) (closes MS # 2569)

14 years agoavoid passing undefined data to decode_base64()
Daniel Kahn Gillmor [Mon, 20 Dec 2010 05:37:26 +0000 (00:37 -0500)]
avoid passing undefined data to decode_base64()

14 years agoallow the use of ports in hostnames
Daniel Kahn Gillmor [Sun, 19 Dec 2010 02:22:00 +0000 (21:22 -0500)]
allow the use of ports in hostnames

14 years agoupdate upstream Changelog
Daniel Kahn Gillmor [Sat, 18 Dec 2010 23:41:55 +0000 (18:41 -0500)]
update upstream Changelog

14 years agoimport hkpms settings from gpg.conf also
Daniel Kahn Gillmor [Sat, 18 Dec 2010 23:40:41 +0000 (18:40 -0500)]
import hkpms settings from gpg.conf also

14 years agodo not use indirect object creation (see p.158 of "Modern Perl")
Daniel Kahn Gillmor [Sat, 18 Dec 2010 23:26:14 +0000 (18:26 -0500)]
do not use indirect object creation (see p.158 of "Modern Perl")

14 years agofixed broken error message
Daniel Kahn Gillmor [Fri, 17 Dec 2010 18:04:44 +0000 (13:04 -0500)]
fixed broken error message

14 years agoprep upstream changelog for 0.7 release msva-perl/0.7
Jameson Rollins [Thu, 16 Dec 2010 20:56:19 +0000 (15:56 -0500)]
prep upstream changelog for 0.7 release

14 years agoadjust gpgkey_hkpms using the standard gpg verbosity/debug settings
Daniel Kahn Gillmor [Thu, 16 Dec 2010 20:51:29 +0000 (15:51 -0500)]
adjust gpgkey_hkpms using the standard gpg verbosity/debug settings

14 years agomake the logger a little bit more functional
Daniel Kahn Gillmor [Thu, 16 Dec 2010 20:36:12 +0000 (15:36 -0500)]
make the logger a little bit more functional

14 years agosupport hkpms queries from the agent
Daniel Kahn Gillmor [Thu, 16 Dec 2010 20:32:25 +0000 (15:32 -0500)]
support hkpms queries from the agent

14 years agoadopt new 1.37 changes to IO::Socket::SSL
Daniel Kahn Gillmor [Thu, 16 Dec 2010 16:09:48 +0000 (11:09 -0500)]
adopt new 1.37 changes to IO::Socket::SSL

14 years agosupply gpgkeys_hkpms (closes MS #2016)
Daniel Kahn Gillmor [Wed, 8 Dec 2010 02:37:24 +0000 (21:37 -0500)]
supply gpgkeys_hkpms (closes MS #2016)

14 years agoexpose version of MSVA.pm publicly
Daniel Kahn Gillmor [Mon, 6 Dec 2010 06:30:06 +0000 (01:30 -0500)]
expose version of MSVA.pm publicly

14 years agoenable requesting keyserverpolicy in Crypt::Monkeysphere::MSVA::Client
Daniel Kahn Gillmor [Mon, 6 Dec 2010 05:36:42 +0000 (00:36 -0500)]
enable requesting keyserverpolicy in Crypt::Monkeysphere::MSVA::Client

14 years agostarted new Changelog entry
Daniel Kahn Gillmor [Sun, 14 Nov 2010 23:51:41 +0000 (18:51 -0500)]
started new Changelog entry

14 years agonormalize word spacing in documentation for msva-query-agent
Daniel Kahn Gillmor [Sun, 14 Nov 2010 23:50:50 +0000 (18:50 -0500)]
normalize word spacing in documentation for msva-query-agent

14 years agodo not bother tracking generated manpages
Daniel Kahn Gillmor [Sun, 14 Nov 2010 23:49:50 +0000 (18:49 -0500)]
do not bother tracking generated manpages

14 years agofix typo in pod documentation for msva-query-agent msva-perl/0.6
Daniel Kahn Gillmor [Sun, 14 Nov 2010 08:26:54 +0000 (03:26 -0500)]
fix typo in pod documentation for msva-query-agent

14 years agoprepare for 0.6 release
Daniel Kahn Gillmor [Sun, 14 Nov 2010 08:17:22 +0000 (03:17 -0500)]
prepare for 0.6 release

14 years agoimplement tests (and looser constraints on) peer names for peers who are clients
Daniel Kahn Gillmor [Sun, 14 Nov 2010 08:07:44 +0000 (03:07 -0500)]
implement tests (and looser constraints on) peer names for peers who are clients

14 years agoadded peertype (addresses #2568) -- still need tests
Daniel Kahn Gillmor [Sat, 13 Nov 2010 21:46:38 +0000 (16:46 -0500)]
added peertype (addresses #2568) -- still need tests

14 years agoadded jrollins to copyright
Daniel Kahn Gillmor [Fri, 5 Nov 2010 18:58:58 +0000 (14:58 -0400)]
added jrollins to copyright

14 years agoMerge remote branch 'jrollins/master'
Daniel Kahn Gillmor [Thu, 4 Nov 2010 06:21:14 +0000 (02:21 -0400)]
Merge remote branch 'jrollins/master'