W. Trevor King [Tue, 17 Nov 2009 13:25:15 +0000 (08:25 -0500)]
Added unicode_output option to VCS._u_invoke()
W. Trevor King [Tue, 17 Nov 2009 13:21:56 +0000 (08:21 -0500)]
rename "output","error" -> "stdout","stderr" in VCS._u_invoke()
W. Trevor King [Sat, 24 Oct 2009 11:21:07 +0000 (07:21 -0400)]
Merged Gianluca's nested directory fix.
Gianluca Montecchi [Thu, 22 Oct 2009 20:20:19 +0000 (22:20 +0200)]
- Merged Trevor branch
- Reapplied the fix for subdirs
Gianluca Montecchi [Wed, 21 Oct 2009 21:34:05 +0000 (23:34 +0200)]
Fixed a typo in the --export-dir-template options
Gianluca Montecchi [Wed, 21 Oct 2009 21:30:35 +0000 (23:30 +0200)]
Fixed a problem with the creation of nested directory
(i.e.: be html -o dir1/dir2 failed to create dir2 if dir1 does not exists)
W. Trevor King [Wed, 21 Oct 2009 15:03:50 +0000 (11:03 -0400)]
Merged Gianluca's recent `be html` work.
* Added --export-template and --export-template-dir
* Fixed index page row colors.
* Fixed --index-header
Also a bit of tightening on my own:
* Inspired by ._write_file, wrote ._read_file and .make_dir.
* Wrapped some lines to stay under 80 characters,
* Stripped trailing whitespace.
gian [Wed, 21 Oct 2009 12:51:06 +0000 (14:51 +0200)]
test for bzr merge
Gianluca Montecchi [Tue, 20 Oct 2009 23:18:40 +0000 (01:18 +0200)]
Finished merge with Trevor branch
Gianluca Montecchi [Tue, 20 Oct 2009 23:14:10 +0000 (01:14 +0200)]
added the --export-template and --export-dir_template
to export the default template
Gianluca Montecchi [Tue, 20 Oct 2009 22:37:18 +0000 (00:37 +0200)]
The (ugly) colors are back
Gianluca Montecchi [Tue, 20 Oct 2009 21:15:27 +0000 (23:15 +0200)]
Fixed the wrong index_header values
Gianluca Montecchi [Tue, 20 Oct 2009 21:08:57 +0000 (23:08 +0200)]
merged with Trevor branch
W. Trevor King [Tue, 20 Oct 2009 13:38:17 +0000 (09:38 -0400)]
Merged my cleanup of Gianluca's HTML branch.
This fixes a bug in binary comments (non-"text/" content-types), where
the content-type wasn't being set until _after_ the save was
attempted. This led to errors for non-ascii bodies (e.g. images with
null characters).
Note that text/html comments are included as is, so make sure they are
formatted appropriately to fit into your tempate without creating
invalid code. This issue could be a real pain in the neck, especially
when including text/html email bodies, which might contain <body>
tags, etc.. Stupid email clients that don't send a text/plain
alternative...
W. Trevor King [Tue, 20 Oct 2009 13:37:22 +0000 (09:37 -0400)]
Save non-text/ comments as separate files. Inline images.
W. Trevor King [Tue, 20 Oct 2009 13:30:42 +0000 (09:30 -0400)]
Pass content_type to Comment.new_reply() to fix error adding non-text/ comments
W. Trevor King [Tue, 20 Oct 2009 12:28:35 +0000 (08:28 -0400)]
Restructured becommands/html to make templating more flexible + general cleanups.
W. Trevor King [Tue, 20 Oct 2009 01:36:25 +0000 (21:36 -0400)]
General cleanup of becommands/html.py
W. Trevor King [Mon, 19 Oct 2009 23:52:14 +0000 (19:52 -0400)]
Merged Gianluca's html becommand with templates.
W. Trevor King [Mon, 19 Oct 2009 19:51:34 +0000 (15:51 -0400)]
Non-event merge with trunk, just to pull in that bit of history
Gianluca Montecchi [Thu, 8 Oct 2009 20:18:50 +0000 (22:18 +0200)]
Reworked the html command template system
Gianluca Montecchi [Wed, 7 Oct 2009 23:17:03 +0000 (01:17 +0200)]
Partially moved to a newer, better and simpler template system
Gianluca Montecchi [Wed, 7 Oct 2009 22:41:31 +0000 (00:41 +0200)]
Template system v1 completed
Gianluca Montecchi [Wed, 7 Oct 2009 18:41:49 +0000 (20:41 +0200)]
Updated to trunk
Chris Ball [Tue, 6 Oct 2009 14:56:47 +0000 (10:56 -0400)]
Fix darcs testsuite failure
W. Trevor King [Tue, 6 Oct 2009 10:47:10 +0000 (06:47 -0400)]
Oops, fixed return typo in libbe.darcs.Darcs._vcs_get_file_contents()
For self.parsed_version[0] >= 2, was returning the entire output of
._u_invoke_client() (status, output, and error). Now it just returns
the output, which is what we want. This fixes Chris' failed test:
======================================================================
FAIL: Should get file contents as committed to specified revision.
----------------------------------------------------------------------
Traceback (most recent call last):
File "libbe/vcs.py", line 852, in test_revision_file_contents_as_committed
self.test_contents['rev_1'], committed_contents)
AssertionError: 'Lorem ipsum' != (0, 'Lorem ipsum', '')
----------------------------------------------------------------------
W. Trevor King [Tue, 6 Oct 2009 10:37:21 +0000 (06:37 -0400)]
Moved VCS detection from _vcs_help() to _vcs_version().
The version string is useful information to have around, while the
help string is probably not. For example, we use it in
darcs.Darcs._vcs_get_file_contents() to construct an incantation
appropriate to the version we're dealing with.
Chris Ball [Tue, 6 Oct 2009 03:16:33 +0000 (23:16 -0400)]
Silence testsuite warnings, from W. Trevor King.
Chris Ball [Tue, 6 Oct 2009 03:15:39 +0000 (23:15 -0400)]
Large merge from W. Trevor King, including Gianluca's HTML export.
W. Trevor King [Tue, 6 Oct 2009 01:00:34 +0000 (21:00 -0400)]
Moved from *.__del__() to exclusive use of *.cleanup().
*.__del__() is run some unspecified time after the refcount for an
object is reduced to zero. Sometimes that means that the rest of the
world has already been deallocated, which makes life difficult,
especially when Python won't attempt to construct stack traces inside
*.__del__(). We were always (hopefully ;) calling del(*) anyway,
so we just replace those calls with *.cleanup()
Gianluca Montecchi [Mon, 5 Oct 2009 22:35:47 +0000 (00:35 +0200)]
Initial implementation of a template system
Gianluca Montecchi [Mon, 5 Oct 2009 22:08:11 +0000 (00:08 +0200)]
Added the verbose option
Gianluca Montecchi [Mon, 5 Oct 2009 21:51:13 +0000 (23:51 +0200)]
help
Gianluca Montecchi [Fri, 2 Oct 2009 22:05:16 +0000 (00:05 +0200)]
Added the initial support for css templates
Gianluca Montecchi [Fri, 2 Oct 2009 21:46:24 +0000 (23:46 +0200)]
Merged with Trevor's -rr branch
Gianluca Montecchi [Thu, 1 Oct 2009 22:08:33 +0000 (00:08 +0200)]
Fixed the merge
Gianluca Montecchi [Thu, 1 Oct 2009 21:39:28 +0000 (23:39 +0200)]
Merged with head branch
W. Trevor King [Sat, 26 Sep 2009 17:49:26 +0000 (13:49 -0400)]
Set self.ret if necessary in be-handle-mail.Command.response_msg().
If an exception is raised during command exection, self.ret may be
left at None.
W. Trevor King [Sat, 26 Sep 2009 17:02:18 +0000 (13:02 -0400)]
Added "Confirm" and "Subscribe" pseudoheaders to be-handle-mail.
Allowed values for both are "yes" or "no", case insensitive.
Setting Confirm:no disables the confirmation email letting you know
your new bug was successfully submitted.
Setting Subscribe:yes automatically subscribes you to the new bug
you're submitting immediately, without reqiring an extra control
email.
In the case where both Confirm:yes and Subscribe:yes, the submitter
will only recieve the subscription email (which shows the "be show"
view of the new bug) and not the submission email (which shows the
output of all the executed submission commands).
Both of these pseudoheaders were in response to a
Would you like a direct response concerning your comments?
checkbox on the web frontend that generates emails for a BE repo.
When the checkbox is set, we set Confirm:yes Subscribe:yes, and the
submitter gets a nice pretty confirmation email and will be
automatically notified of any future action on their bug. When the
checkbox is not set, they get no response or submission emails.
Also fixed up some bugs in in the subscriber_emails() parsing. We now
use ordered_subscriptions to ensure that we parse the "DIR"
subscription first, since we don't want to include the same
information twice, and the user might be subscribed to DIR:all and a
particular bug (which would be wierd, but is easily avoidable). This
also ensures that the more central DIR level changes appear first in
the email.
We also check that there is an entry for a particular bug in bug_index
before attempting to grab it, which could raise KeyErrors otherwise.
Finally, we check to make sure we don't double-include bugs for which
the user is subscribed to both that bug's new and DIR:new.
A final minor correction is the capitalization of the first word of
our log entries. The logs are pretty cluttered, and the
capitalization helps the lines I care about stand out. A better
solution would be to come up with a cleaner idea of what to write to
the logs...
W. Trevor King [Sat, 26 Sep 2009 16:48:42 +0000 (12:48 -0400)]
Load bugs in be-handle-mail.Message.subscriber_emails().
Because subscribe.get_bugdir_subscribers() only looks for subscribers
in bugs that are already in memory.
W. Trevor King [Sat, 26 Sep 2009 16:45:27 +0000 (12:45 -0400)]
Fix agressive be-handle-mail.Message._strip_footer().
It had been eating the last line of the message (which wasn't a
problem when I had a blank line before the footer, but was when I had
neither footer nor trailing blank line).
W. Trevor King [Sat, 26 Sep 2009 16:43:40 +0000 (12:43 -0400)]
Prefix cache attributes in be-handle-mail with underscore (_).
To conform with Python convention for "hiding" class attributes only
intended for internal use.
W. Trevor King [Sat, 26 Sep 2009 16:39:37 +0000 (12:39 -0400)]
Fixed invalid TAG error in becommands.subscribe.get_subscribers()
Check that the string has the right tag before attempting to parse it
:p.
W. Trevor King [Sat, 26 Sep 2009 16:37:49 +0000 (12:37 -0400)]
Added -a and -l options to be subscribe.
It's useful to have some way to see the current subscription status
from the command line ;).
W. Trevor King [Wed, 23 Sep 2009 16:18:31 +0000 (12:18 -0400)]
Added normalize_RFC_2822_date() to be-mbox-to-xml.
The
if new_fields[u'date'] != None:
bit avoids attemting to normalize missing dates (which fails). You
get messages with missing dates when comment_message_to_xml() is
called recursively for multipart messages.
Also fixed some unicode keys (['X'] -> [u'X']) for consistency.
W. Trevor King [Wed, 23 Sep 2009 15:03:59 +0000 (11:03 -0400)]
Added normalize_email_address() to be-mbox-to-xml
W. Trevor King [Wed, 23 Sep 2009 14:47:17 +0000 (10:47 -0400)]
Fixed mutliple in-reply-to splitting in be-mbox-to-xml
W. Trevor King [Wed, 23 Sep 2009 14:07:38 +0000 (10:07 -0400)]
Fixed bugdir name collision in cmdutil.bug_from_shortname()
W. Trevor King [Wed, 23 Sep 2009 13:13:46 +0000 (09:13 -0400)]
Use Bug.active to decide active status in becommands/html.py
W. Trevor King [Wed, 23 Sep 2009 10:30:31 +0000 (06:30 -0400)]
Convert incoming text/* email payloads to unicode in be-handle-mail.
Switched from cStringIO to StringIO in be-handle-mail because:
(from http://docs.python.org/library/stringio.html)
"Unlike the memory files implemented by the StringIO module, those
provided by this [cStringIO] module are not able to accept Unicode
strings that cannot be encoded as plain ASCII strings."
I'm not sure what all the fuss with sys.__stdin__ had been about in
Command.run(), but I took it out and everything still seems to work
;).
Also fix Makefail (again!) to install under $HOME by default.
W. Trevor King [Mon, 21 Sep 2009 13:52:28 +0000 (09:52 -0400)]
os.path.isdir() -> .exists() for check for "comments" file.
"comments" should always be a directory if it exists, but if it is
something else, be should fail rather than return an empty comment
list.
This fix was inspired by some browsing around in response to Thomas
Habets' version of a fix for missing "bugs" directory.
W. Trevor King [Sat, 19 Sep 2009 21:58:09 +0000 (17:58 -0400)]
Include stdout in CommandError.
W. Trevor King [Thu, 17 Sep 2009 19:31:01 +0000 (15:31 -0400)]
Fixed email.Parser typo in send_pgp_mime.py imports for Python 2.4.
W. Trevor King [Tue, 15 Sep 2009 22:59:16 +0000 (18:59 -0400)]
Added `be --verbose-version' option to print full version information.
W. Trevor King [Tue, 15 Sep 2009 13:32:40 +0000 (09:32 -0400)]
Added libbe.version, wrapping the auto-generated libbe._version.
Two major benefits:
1) Programatic access to the BE version. Previously the
version-string logic was internal to the commandline interface ./be,
which left the other interfaces hanging.
2) Simple to override auto-generated revision id version with any
string you like (by setting libbe.version._VERSION, if that's the way
you want to run things or the way your packaging system requires.
Note that other modules should never read libbe.version._VERSION,
since it may not be defined. Instead they should use the output of
libbe.version.version().
W. Trevor King [Sun, 13 Sep 2009 10:42:38 +0000 (06:42 -0400)]
Fixed a few typos in be-handle-mail
W. Trevor King [Sun, 13 Sep 2009 10:32:07 +0000 (06:32 -0400)]
Mention commit message in interactive email README subject explaination.
W. Trevor King [Sun, 13 Sep 2009 09:54:31 +0000 (05:54 -0400)]
Explicitly set encoding to UTF-8.
Because otherwise we run into problems when running be from inside
cron jobs.
W. Trevor King [Fri, 11 Sep 2009 15:52:02 +0000 (11:52 -0400)]
Typo EncryptedMessageFactory -> PGPMimeMessageFactory in send-pgp-mime.py
I changed the class name in commit
wking@drexel.edu-
20090718201613-n242qfl4s3j3kfjf
but missed two references.
W. Trevor King [Mon, 31 Aug 2009 18:19:40 +0000 (14:19 -0400)]
Added docstrings to libbe submodules.
Also a few minor tweaks to the module imports.
W. Trevor King [Mon, 31 Aug 2009 17:54:09 +0000 (13:54 -0400)]
BugDir.duplicate_bugdir() fix for when parent bugdir's sync_with_disk == False.
W. Trevor King [Mon, 31 Aug 2009 17:43:32 +0000 (13:43 -0400)]
RCS -> VCS, BUGDIR_DISK_VERSION -> v1.2
W. Trevor King [Mon, 31 Aug 2009 17:19:45 +0000 (13:19 -0400)]
Merged be.on-disk-upgrade, which added libbe.upgrade
W. Trevor King [Mon, 31 Aug 2009 17:18:36 +0000 (13:18 -0400)]
Use 'v#.#' for major/minor version in upgrade.BUGDIR_DISK_VERSIONS
W. Trevor King [Mon, 31 Aug 2009 17:16:48 +0000 (13:16 -0400)]
Upgrade duplicate bugdirs if necessary (e.g. for `be diff').
Also moved pre-YAML mapfile handling in mapfile.parse() into
upgrade.Upgrade_1_0_to_2._upgrade_mapfile().
W. Trevor King [Mon, 31 Aug 2009 16:32:05 +0000 (12:32 -0400)]
Added libbe/upgrade.py to handle upgrading on-disk bugdirs.
W. Trevor King [Mon, 31 Aug 2009 15:50:28 +0000 (11:50 -0400)]
Made get_path() definitions consistent between bugdirs, bugs, and comments.
W. Trevor King [Mon, 31 Aug 2009 13:54:55 +0000 (09:54 -0400)]
Bug 22b (target-bugs) blocked by 519 (on-disk upgrade) and assigned to Trevor
W. Trevor King [Mon, 31 Aug 2009 06:31:21 +0000 (02:31 -0400)]
VCS vs. RCS terminology blocked by on-disk upgrade path.
W. Trevor King [Mon, 31 Aug 2009 06:26:19 +0000 (02:26 -0400)]
Added comment 22b:7 about representing targets with Bug() instances.
W. Trevor King [Sun, 16 Aug 2009 20:02:18 +0000 (16:02 -0400)]
Broke up be-handle-mail.parse() into parse_new(), _comment(), and _control().
Also fleshed out the be-handle-mail docstring.
W. Trevor King [Sun, 16 Aug 2009 19:09:21 +0000 (15:09 -0400)]
Added on-disk representation upgrade bug
W. Trevor King [Tue, 11 Aug 2009 18:46:26 +0000 (14:46 -0400)]
Handle BugDir.list_uuids() in the case of missing ".be/bugs/".
Previously:
$ be init
$ be list
...
File ".../libbe/bugdir.py", line 537, in list_uuids
for uuid in os.listdir(self.get_path("bugs")):
OSError: [Errno 2] No such file or directory: '.../.be/bugs'
W. Trevor King [Sat, 8 Aug 2009 14:24:33 +0000 (10:24 -0400)]
"be html" fixes bug 2f0
W. Trevor King [Sat, 8 Aug 2009 14:23:23 +0000 (10:23 -0400)]
Oops, update comment.From->author and .time_string->.date in becommands/html.py
W. Trevor King [Fri, 7 Aug 2009 18:29:16 +0000 (14:29 -0400)]
Updated AUTHORS and copyright info for becommands/html.py.
Also adjusted update_copyright.sh to ignore Gianluca's temporary use
of
gianluca <gian@galactica>
since he's now using
Gianluca Montecchi <gian@grys.it>
on becommands/html.py.
W. Trevor King [Fri, 7 Aug 2009 18:19:30 +0000 (14:19 -0400)]
Merged Gianluca's html output branch.
Changes to merge with my branch:
* Added some reference to "be html" or "becommands/html.py" in his
new bugs' summaries. Bug titles should make clear to which aspect
of our growing repository they refer.
* Fixed unittests in becommands/html.py.
* execute() kwarg "test"->!"manipulate_encodings
* bugdir.simple_bug_dir() -> bugdir.SimpleBugDir()
* bd.cleanup() at end of unittests
W. Trevor King [Fri, 7 Aug 2009 17:53:26 +0000 (13:53 -0400)]
Sort bugs in HTML output.
W. Trevor King [Fri, 7 Aug 2009 17:49:47 +0000 (13:49 -0400)]
XHTML attribute values should be strings, and cellspacing not allowed in tr.
W. Trevor King [Fri, 7 Aug 2009 17:45:19 +0000 (13:45 -0400)]
Escape HTML entities (e.g. & and @) in HTML output
W. Trevor King [Fri, 7 Aug 2009 17:23:00 +0000 (13:23 -0400)]
XHTML tags must be closed (e.g. <br />, not <br>)
W. Trevor King [Fri, 7 Aug 2009 17:21:47 +0000 (13:21 -0400)]
XHTML attribute values should be strings.
W. Trevor King [Fri, 7 Aug 2009 17:19:58 +0000 (13:19 -0400)]
Protect bug html from libbe.settings_object.EMPTY
W. Trevor King [Fri, 7 Aug 2009 17:15:19 +0000 (13:15 -0400)]
Added DOCTYPE to detail html as well
W. Trevor King [Fri, 7 Aug 2009 17:12:08 +0000 (13:12 -0400)]
Respect bugdir's encoding in html generation
W. Trevor King [Fri, 7 Aug 2009 17:09:15 +0000 (13:09 -0400)]
Added DOCTYPE and post-</div> endlines
W. Trevor King [Fri, 7 Aug 2009 17:04:46 +0000 (13:04 -0400)]
Improved threaded comment handling.
The previous method only grabbed first line of a comment. The new
approach replaces the messy Comment->string->parse->html with
Comment->html.
Also replaced all open()s with codecs.open to allow for non-ASCII
output. Alphabetized the non libbe imports while I was adding codecs.
W. Trevor King [Fri, 7 Aug 2009 15:52:39 +0000 (11:52 -0400)]
Adjusted help/doc strings in becommands/html.py
Gianluca Montecchi [Tue, 4 Aug 2009 21:31:33 +0000 (23:31 +0200)]
- closed bugs f77, 2b8 d8d
- some changes to the css and to the html layout
W. Trevor King [Tue, 4 Aug 2009 19:43:33 +0000 (15:43 -0400)]
Merged bugfix branch be.missing-git-config
W. Trevor King [Tue, 4 Aug 2009 19:42:49 +0000 (15:42 -0400)]
Now libbe.git.Git handles missing name/email and guesses instead.
W. Trevor King [Tue, 4 Aug 2009 19:34:19 +0000 (15:34 -0400)]
Merged Gianluca's missing-git-config bug report
W. Trevor King [Mon, 3 Aug 2009 23:28:34 +0000 (19:28 -0400)]
Imported Ben's VCS vs. RCS bug report from the mailing list.
W. Trevor King [Mon, 3 Aug 2009 23:27:00 +0000 (19:27 -0400)]
Ssupport for UTF-8 in "be comment" calls to EDITOR/VISUAL.
Gianluca Montecchi [Mon, 3 Aug 2009 19:29:21 +0000 (21:29 +0200)]
Fixed width and index
W. Trevor King [Sat, 1 Aug 2009 18:21:08 +0000 (14:21 -0400)]
Merged dependency tree branch.
Also exposes dependency manipulation functions/classes for use by
other modules.
W. Trevor King [Sat, 1 Aug 2009 18:16:09 +0000 (14:16 -0400)]
Added dependency tree display with "be depend -t DEPTH BUG-ID".
Should probably be a directed graph, since people might not make
tree-like dependency graphs. Cyclic graphs seem unlikely, though,
so a tree only risks redundant bug entries.
W. Trevor King [Sat, 1 Aug 2009 11:52:51 +0000 (07:52 -0400)]
Added one-way-link repair.
W. Trevor King [Sat, 1 Aug 2009 11:12:46 +0000 (07:12 -0400)]
Added two-way dependency links.
Still need to implement and test one-way-link repair.
Gianluca Montecchi [Fri, 31 Jul 2009 21:54:05 +0000 (23:54 +0200)]
Closed bug f77, minox fix to layout
projects / be.git / log