portage.git
13 years agoUpdate timestamps in headers of modified files. v2.2.0_alpha28
Zac Medico [Fri, 18 Mar 2011 21:44:05 +0000 (14:44 -0700)]
Update timestamps in headers of modified files.

13 years agoPackageVirtualDbapi: fix get() for reposyntax
Zac Medico [Fri, 18 Mar 2011 21:38:38 +0000 (14:38 -0700)]
PackageVirtualDbapi: fix get() for reposyntax

13 years agoCompositeTask: fix _wait for TASK_QUEUED
Zac Medico [Fri, 18 Mar 2011 21:05:07 +0000 (14:05 -0700)]
CompositeTask: fix _wait for TASK_QUEUED

Though this case might never have been triggered, the logic was broken
for cases in which self.cancelled was false and a task was queued. In
this case we need to call back into the scheduler until the queued task
is started or we are cancelled, whichever comes first.

13 years agoebuild-ipc: import errno
Zac Medico [Thu, 17 Mar 2011 21:52:41 +0000 (14:52 -0700)]
ebuild-ipc: import errno

13 years agoEbuildIpcDaemon: use non-blocking write
Zac Medico [Thu, 17 Mar 2011 21:39:53 +0000 (14:39 -0700)]
EbuildIpcDaemon: use non-blocking write

This prevents the Scheduler from hanging if the client is killed before
we can send the reply, as reported by David James:

  http://codereview.chromium.org/6713003

This commit depends on ebuild-ipc (the client) opening the other side
of this fifo before it sends its request, which has already been added
in commit eff879ff0ce7dcc1ce68d5f16de1ec73051f8c18.

13 years agoebuild-ipc: use non-blocking read
Zac Medico [Thu, 17 Mar 2011 21:12:13 +0000 (14:12 -0700)]
ebuild-ipc: use non-blocking read

This makes it possible for the daemon to send a reply without blocking,
thereby improving performance and also making it possible for the
daemon to do a non-blocking write without a race condition.

This reverts part of commit 81fc303212b8379219cf5d463c8717359b972dba,
which probably didn't help portability anyway. Now, ebuild-ipc is using
non-blocking read with os.read and EAGAIN handling, just like
EbuildIpcDaemon since commit 7e5b81da12dd7bd59f6620840dc0d824e3f4d69a
(known compatible with FreeBSD).

13 years agoAsynchronousLock: implement _cancel
Zac Medico [Thu, 17 Mar 2011 20:08:35 +0000 (13:08 -0700)]
AsynchronousLock: implement _cancel

13 years agomake.conf.5: fix "direcory" spelling
Zac Medico [Thu, 17 Mar 2011 19:01:57 +0000 (12:01 -0700)]
make.conf.5: fix "direcory" spelling

Thanks to Francesco Turco in bug #359273.

13 years agodep_check: return errors as unicode
Zac Medico [Thu, 17 Mar 2011 18:39:28 +0000 (11:39 -0700)]
dep_check: return errors as unicode

This should prevent the following error due to returning raw bytes,
reported in forum thread #869281:

File "pym/_emerge/BlockerDB.py", line 72, in findInstalledBlockers
portage.writemsg("!!! %s/*DEPEND: %s\n" % \
(pkg_location, atoms), noiselevel=-1)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in
position 23: ordinal not in range(128)

13 years agoAsynchronousTask: add _cancel template method
Zac Medico [Thu, 17 Mar 2011 05:36:33 +0000 (22:36 -0700)]
AsynchronousTask: add _cancel template method

13 years agoUpdate Scheduler to protect against infinite loop
David James [Thu, 17 Mar 2011 04:54:37 +0000 (21:54 -0700)]
Update Scheduler to protect against infinite loop

If we have running tasks, but we're not listening to these tasks,
we're going to loop forever. So throw an exception in this case.

13 years agoScheduler: tweak prefetcher cancellation logic
Zac Medico [Thu, 17 Mar 2011 04:50:36 +0000 (21:50 -0700)]
Scheduler: tweak prefetcher cancellation logic

This should prevent "TypeError: an integer is required" raised from
waitpid when trying to cancel a prefetcher that never started.

13 years agoCompositeTask: handle unstarted terminated tasks
Zac Medico [Thu, 17 Mar 2011 03:44:55 +0000 (20:44 -0700)]
CompositeTask: handle unstarted terminated tasks

13 years agoCompositeTask: fix assertion in _wait
Zac Medico [Thu, 17 Mar 2011 01:42:59 +0000 (18:42 -0700)]
CompositeTask: fix assertion in _wait

13 years agoAsynchronousTask: always call wait() if cancelled
Zac Medico [Thu, 17 Mar 2011 01:19:02 +0000 (18:19 -0700)]
AsynchronousTask: always call wait() if cancelled

This is needed in order to ensure that exit listeners are called.
Subclasses call the base class cancel() method in order to inherit the
wait() call.

13 years agoScheduler: terminate _merge_wait_queue
Zac Medico [Thu, 17 Mar 2011 00:36:36 +0000 (17:36 -0700)]
Scheduler: terminate _merge_wait_queue

13 years agoiter_owners: try the hashed approach in any case
Zac Medico [Wed, 16 Mar 2011 20:58:17 +0000 (13:58 -0700)]
iter_owners: try the hashed approach in any case

Previously, the slow approach was used whenever more than 10 files were
given as input. However, large numbers of files don't necessarily
mean the hashed approach is a bad choice, so try it in any case.

13 years agoslot_conflict: tweak message and fix grammar
Zac Medico [Tue, 15 Mar 2011 22:58:02 +0000 (15:58 -0700)]
slot_conflict: tweak message and fix grammar

13 years agoemerge: support [ y | n ] for --quiet v2.2.0_alpha27
Zac Medico [Mon, 14 Mar 2011 17:52:17 +0000 (10:52 -0700)]
emerge: support [ y | n ] for --quiet

This allows --quiet and --quiet-build to be enabled via
EMERGE_DEFAULT_OPTS, and then temporarily disabled via the command-
line.

13 years agoUpdate timestamps in headers of modified files.
Zac Medico [Mon, 14 Mar 2011 16:40:40 +0000 (09:40 -0700)]
Update timestamps in headers of modified files.

13 years agoScheduler: fix AttributeError in _terminate_tasks
Zac Medico [Sat, 12 Mar 2011 18:35:23 +0000 (10:35 -0800)]
Scheduler: fix AttributeError in _terminate_tasks

Thanks to David James <davidjames@google.com> for reporting this error:
AttributeError: 'EbuildPhase' object has no attribute 'merge'

13 years agoMake all temp dirs under $PORTAGE_TMPDIR/portage.
Zac Medico [Fri, 11 Mar 2011 21:02:31 +0000 (13:02 -0800)]
Make all temp dirs under $PORTAGE_TMPDIR/portage.

Before, some temporary directories would be created directly in
$PORTAGE_TMPDIR. Now, all are subdirectories of $PORTAGE_TMPDIR/portage
since it's common for people to assume that this is the case anyway.
With the default PORTAGE_TMPDIR setting of /var/tmp, this allows
/var/tmp to be mounted with the "noexec" option, as long as the
/var/tmp/portage subdirectory is a separate mount (people have already
tended to assume that they can do this, so we're making it a reality
in order to avoid any more bug reports). This will fix bug #346899.

13 years agoPollScheduler: tweek termination logic
Zac Medico [Fri, 11 Mar 2011 06:02:19 +0000 (22:02 -0800)]
PollScheduler: tweek termination logic

* PollScheduler and all subclasses now use the _terminated_tasks
  variable to check whether or not _terminate_tasks() has been called,
  and behave appropriately in that case.

* The _schedule_tasks() method now has documentation about the
  relationship with _terminate_tasks() and _terminated_tasks.

13 years agoPollScheduler: call _terminate_tasks in _schedule
Zac Medico [Fri, 11 Mar 2011 05:21:19 +0000 (21:21 -0800)]
PollScheduler: call _terminate_tasks in _schedule

This prevents it from being called while the _schedule_tasks()
implementation is running, in order to avoid potential interference.

13 years agoScheduler: avoid infinite loop after CTRL-C
Zac Medico [Fri, 11 Mar 2011 03:29:57 +0000 (19:29 -0800)]
Scheduler: avoid infinite loop after CTRL-C

If CTRL-C was received at certain times, it was possible for discarded
tasks to be erroneously left in Scheduler._running_tasks, which would
cause the main loop to run infinitely. Thanks to David James
<davidjames@google.com> for reporting this issue and helping to devise
a solution.

13 years agoebuild-ipc: use plain file read instead of array
Zac Medico [Thu, 10 Mar 2011 22:49:47 +0000 (14:49 -0800)]
ebuild-ipc: use plain file read instead of array

Array.fromfile() seems to be more error prone. For example, see
bug 337465.

13 years agoAbstractPollTask: log exceptional events
Zac Medico [Thu, 10 Mar 2011 05:46:17 +0000 (21:46 -0800)]
AbstractPollTask: log exceptional events

Previously, when AbstractPollTask receives a POLLERR or POLLNVAL event,
it would silently cancel the task. Now it will generate a message like
this:

   !!! SpawnProcess received strange poll event: 8

The message is displayed via a new _log_poll_exception method, which
is overridden by AbstractEbuildProcess to log the message via elog.

This might help diagnose reported cases of SIGTERM signals killing
ebuild processes for no apparent reason:

   http://code.google.com/p/chromium-os/issues/detail?id=12968

13 years agounmerge: use vardbapi._dblink() to simplify
Zac Medico [Wed, 9 Mar 2011 03:28:21 +0000 (19:28 -0800)]
unmerge: use vardbapi._dblink() to simplify

The dblink constructor is complex and best avoided.

13 years agoBug #357009: Disallow uninstallation of currently used Python interpreter.
Arfrever Frehtes Taifersar Arahesis [Wed, 9 Mar 2011 02:57:23 +0000 (03:57 +0100)]
Bug #357009: Disallow uninstallation of currently used Python interpreter.

13 years agoportdbapi: source ebuilds when eclass dir missing
Zac Medico [Mon, 7 Mar 2011 17:34:02 +0000 (09:34 -0800)]
portdbapi: source ebuilds when eclass dir missing

This will fix bug #357581.

13 years agoeclass_cache: remove deprecated methods
Zac Medico [Sun, 6 Mar 2011 00:41:00 +0000 (16:41 -0800)]
eclass_cache: remove deprecated methods

13 years agoconfig: quote overlays containing spaces
Zac Medico [Fri, 4 Mar 2011 16:39:53 +0000 (08:39 -0800)]
config: quote overlays containing spaces

This will fix bug #357297.

13 years agoRemove redundant CONTENTS parent dir generation.
Zac Medico [Wed, 2 Mar 2011 19:46:57 +0000 (11:46 -0800)]
Remove redundant CONTENTS parent dir generation.

This code is redunant now, since similar code has been added to
dblink.getcontents() in commit
e0b4048274b2cfc1617f2eff379cbe8435e13ed4.

13 years agodblink.getcontents(): generate parent directories
Zac Medico [Wed, 2 Mar 2011 18:51:41 +0000 (10:51 -0800)]
dblink.getcontents(): generate parent directories

We can't necessarily assume that they are explicitly listed in
CONTENTS, and they are crucial for callers such as dblink.isowner().

13 years agograblines: allow inline comments
Zac Medico [Wed, 2 Mar 2011 17:59:11 +0000 (09:59 -0800)]
grablines: allow inline comments

13 years agograbdict: allow inline comments
Theo Chatzimichos [Wed, 2 Mar 2011 17:39:56 +0000 (09:39 -0800)]
grabdict: allow inline comments

13 years agodepgraph: don't output \b to non-tty
Zac Medico [Wed, 2 Mar 2011 16:39:14 +0000 (08:39 -0800)]
depgraph: don't output \b to non-tty

This will fix bug #357093.

13 years agododoc: update copyright date v2.2.0_alpha26
Zac Medico [Wed, 2 Mar 2011 04:52:28 +0000 (20:52 -0800)]
dodoc: update copyright date

13 years agoebuild(1): fix ebuild modification check
Zac Medico [Wed, 2 Mar 2011 00:53:25 +0000 (16:53 -0800)]
ebuild(1): fix ebuild modification check

This has been broken since the setcpv call (triggering metadata
generation) was added before it in commit
0b39d24bb8270e5c89eaddfd1f5a4181cf9e31d3.

13 years agoaction_deselect: expand cat against world atoms
Zac Medico [Tue, 1 Mar 2011 21:52:04 +0000 (13:52 -0800)]
action_deselect: expand cat against world atoms

13 years agounmerge: log pre/postrm FAILED messages
Zac Medico [Tue, 1 Mar 2011 21:20:59 +0000 (13:20 -0800)]
unmerge: log pre/postrm FAILED messages

13 years agoowners_cache: fix EPREFIX miscalculation
Zac Medico [Tue, 1 Mar 2011 21:04:41 +0000 (13:04 -0800)]
owners_cache: fix EPREFIX miscalculation

This reverts commit 43e0b3ea4289aab9b4258d29d06afac40abd6c01 and
renames the root_len variable to eroot_len (for clarity).

13 years agoowners_cache: add parent dirs deeper than EPREFIX
Zac Medico [Tue, 1 Mar 2011 20:42:56 +0000 (12:42 -0800)]
owners_cache: add parent dirs deeper than EPREFIX

13 years agounmerge: implicitly unmerge parent directories
Zac Medico [Tue, 1 Mar 2011 20:07:53 +0000 (12:07 -0800)]
unmerge: implicitly unmerge parent directories

We can't necessarily assume that they are explicitly listed in
CONTENTS.

13 years agoowners_cache: implicitly add parent directories
Zac Medico [Tue, 1 Mar 2011 18:06:01 +0000 (10:06 -0800)]
owners_cache: implicitly add parent directories

We can't necessarily assume that they are explicitly listed in
CONTENTS.

13 years agorepoman: variable.usedwithhelpers ignore quoted
Zac Medico [Mon, 28 Feb 2011 20:37:22 +0000 (12:37 -0800)]
repoman: variable.usedwithhelpers ignore quoted

13 years agoebuild(1): apply package.env earlier
Zac Medico [Mon, 28 Feb 2011 18:57:53 +0000 (10:57 -0800)]
ebuild(1): apply package.env earlier

This makes it possible to override PORTAGE_TMPDIR.

13 years agodepgraph: case insensitive search for unsatisfied
Zac Medico [Mon, 28 Feb 2011 17:58:27 +0000 (09:58 -0800)]
depgraph: case insensitive search for unsatisfied

This will fix bug #356555.

13 years agorepoman: warn about calls to prepall and preplib
Zac Medico [Mon, 28 Feb 2011 05:27:02 +0000 (21:27 -0800)]
repoman: warn about calls to prepall and preplib

13 years agoRun tests with Python 3.3.
Arfrever Frehtes Taifersar Arahesis [Sat, 26 Feb 2011 20:15:50 +0000 (21:15 +0100)]
Run tests with Python 3.3.

13 years agorepoman: add back portage.internal check
Zac Medico [Sat, 26 Feb 2011 00:19:01 +0000 (16:19 -0800)]
repoman: add back portage.internal check

This check got removed for bug #262365, but now that EAPI 4 is released
we can add it back. Now it checks for ecompress/ecompressdir too (for
bug #218347).

13 years agodoins: fix dodoc directory error handling
Zac Medico [Fri, 25 Feb 2011 20:32:21 +0000 (12:32 -0800)]
doins: fix dodoc directory error handling

13 years agodoins: avoid die when called as dodoc with no arg
Zac Medico [Fri, 25 Feb 2011 20:11:34 +0000 (12:11 -0800)]
doins: avoid die when called as dodoc with no arg

13 years agododoc: call doins, to reuse recursion code
Zac Medico [Fri, 25 Feb 2011 19:50:52 +0000 (11:50 -0800)]
dodoc: call doins, to reuse recursion code

This will fix broken recursion logic for bug #356461.

13 years agododoc: quote ${0}
Zac Medico [Fri, 25 Feb 2011 18:18:38 +0000 (10:18 -0800)]
dodoc: quote ${0}

13 years agododoc: Honour exit status of install, bug 356389.
Ulrich Mueller [Fri, 25 Feb 2011 07:43:17 +0000 (08:43 +0100)]
dodoc: Honour exit status of install, bug 356389.

13 years agoaction_sync: handle IPv6 [ip] in SYNC some more
Zac Medico [Fri, 25 Feb 2011 06:29:31 +0000 (22:29 -0800)]
action_sync: handle IPv6 [ip] in SYNC some more

This will fix bug #356375 some more.

13 years agoaction_sync: handle IPv6 [ip] in SYNC
Zac Medico [Fri, 25 Feb 2011 05:58:44 +0000 (21:58 -0800)]
action_sync: handle IPv6 [ip] in SYNC

This will fix bug #356375.

13 years agoemerge.1: escape hyphens v2.2.0_alpha25
Zac Medico [Tue, 22 Feb 2011 17:57:25 +0000 (09:57 -0800)]
emerge.1: escape hyphens

13 years agoemerge: mention revdep-rebuild in depclean help
Zac Medico [Tue, 22 Feb 2011 17:31:50 +0000 (09:31 -0800)]
emerge: mention revdep-rebuild in depclean help

13 years agoemerge.1: mention revdep-rebuild in depclean docs
Zac Medico [Tue, 22 Feb 2011 17:30:09 +0000 (09:30 -0800)]
emerge.1: mention revdep-rebuild in depclean docs

13 years agoshow_depclean_suggestion: use ewarn, not einfo
Zac Medico [Tue, 22 Feb 2011 03:04:10 +0000 (19:04 -0800)]
show_depclean_suggestion: use ewarn, not einfo

13 years agochk_updated_cfg_files: don't display ._cfg0000_
Zac Medico [Tue, 22 Feb 2011 02:59:24 +0000 (18:59 -0800)]
chk_updated_cfg_files: don't display ._cfg0000_

13 years agoUpdate date headers in modified files.
Zac Medico [Tue, 22 Feb 2011 02:50:33 +0000 (18:50 -0800)]
Update date headers in modified files.

13 years agochk_updated_cfg_files: fix plurality of message
Zac Medico [Tue, 22 Feb 2011 02:38:45 +0000 (18:38 -0800)]
chk_updated_cfg_files: fix plurality of message

This will fix bug #355803.

13 years agoemerge.1: fix arg description more for bug 354137
Zac Medico [Tue, 22 Feb 2011 02:19:45 +0000 (18:19 -0800)]
emerge.1: fix arg description more for bug 354137

13 years agopost_emerge: suggest depclean after world update
Zac Medico [Tue, 22 Feb 2011 02:07:07 +0000 (18:07 -0800)]
post_emerge: suggest depclean after world update

This is part of bug #354787.

13 years agopost_emerge: pass in more info
Zac Medico [Tue, 22 Feb 2011 00:35:14 +0000 (16:35 -0800)]
post_emerge: pass in more info

This makes it possible to do things like give special suggestions after
world updates.

13 years agoebuild.sh: remove unused PWORKDIR variable
Zac Medico [Mon, 21 Feb 2011 16:17:09 +0000 (08:17 -0800)]
ebuild.sh: remove unused PWORKDIR variable

13 years agoSubProcess: notify exit listeners in _poll
Zac Medico [Sun, 20 Feb 2011 09:42:14 +0000 (01:42 -0800)]
SubProcess: notify exit listeners in _poll

13 years agoScheduler: ensure _prefetchers is cleared
Zac Medico [Sun, 20 Feb 2011 09:40:37 +0000 (01:40 -0800)]
Scheduler: ensure _prefetchers is cleared

13 years agoUpdate date headers in modified files.
Zac Medico [Sun, 20 Feb 2011 00:00:16 +0000 (16:00 -0800)]
Update date headers in modified files.

13 years agorepoman: variable.usedwithhelpers tighten regex
Zac Medico [Sat, 19 Feb 2011 23:49:13 +0000 (15:49 -0800)]
repoman: variable.usedwithhelpers tighten regex

This will fix bug #355621.

13 years ago_eapi4_src_install: handle empty DOCS like PMS
Zac Medico [Sat, 19 Feb 2011 23:27:32 +0000 (15:27 -0800)]
_eapi4_src_install: handle empty DOCS like PMS

This will fix bug #355635.

13 years agocheck_required_use: improve missing IUSE error
Zac Medico [Sat, 19 Feb 2011 22:53:45 +0000 (14:53 -0800)]
check_required_use: improve missing IUSE error

This will fix bug #355629.

13 years agodocompress, prepcompress: Add missing quotes.
Ulrich Mueller [Fri, 18 Feb 2011 23:42:36 +0000 (00:42 +0100)]
docompress, prepcompress: Add missing quotes.

13 years agoemerge: fix --sync cvs error message
Zac Medico [Fri, 18 Feb 2011 16:44:31 +0000 (08:44 -0800)]
emerge: fix --sync cvs error message

13 years agoemerge: warn to stderr if post_* hooks fail
Zac Medico [Fri, 18 Feb 2011 16:16:31 +0000 (08:16 -0800)]
emerge: warn to stderr if post_* hooks fail

13 years agoemerge: support post_emerge hook like post_sync
Gokdeniz Karadag [Fri, 18 Feb 2011 15:57:25 +0000 (07:57 -0800)]
emerge: support post_emerge hook like post_sync

This will fix bug #355447.

13 years agoegencache: fix cmp_func for python3
Zac Medico [Fri, 18 Feb 2011 15:37:25 +0000 (07:37 -0800)]
egencache: fix cmp_func for python3

13 years agounmerge: don't show null/ cat in unmatched atoms
Zac Medico [Fri, 18 Feb 2011 15:15:15 +0000 (07:15 -0800)]
unmerge: don't show null/ cat in unmatched atoms

This will fix bug #269534.

13 years agoBinpkgVerifier: disable color in background mode
Zac Medico [Fri, 18 Feb 2011 12:05:16 +0000 (04:05 -0800)]
BinpkgVerifier: disable color in background mode

13 years agomail: handle unicode in subject more for python3
Zac Medico [Fri, 18 Feb 2011 08:32:27 +0000 (00:32 -0800)]
mail: handle unicode in subject more for python3

13 years agomail: handle unicode in subject for python3
Zac Medico [Fri, 18 Feb 2011 08:03:10 +0000 (00:03 -0800)]
mail: handle unicode in subject for python3

13 years agoResolverDepthTestCase: test --selective more
Zac Medico [Thu, 17 Feb 2011 10:43:02 +0000 (02:43 -0800)]
ResolverDepthTestCase: test --selective more

13 years agoemerge --sync: display message when cvs fails
Zac Medico [Thu, 17 Feb 2011 10:32:20 +0000 (02:32 -0800)]
emerge --sync: display message when cvs fails

13 years agoUpdate date headers for modified files. v2.2.0_alpha24
Zac Medico [Tue, 15 Feb 2011 17:22:31 +0000 (09:22 -0800)]
Update date headers for modified files.

13 years agodepgraph: fix virtual code to handle unsatisfied
Zac Medico [Mon, 14 Feb 2011 17:00:42 +0000 (09:00 -0800)]
depgraph: fix virtual code to handle unsatisfied

13 years agodepgraph: --deep=0 is equivalent to no deep param
Zac Medico [Mon, 14 Feb 2011 16:43:37 +0000 (08:43 -0800)]
depgraph: --deep=0 is equivalent to no deep param

13 years agodepgraph: --nodeps overrides --complete-graph
Zac Medico [Mon, 14 Feb 2011 16:32:32 +0000 (08:32 -0800)]
depgraph: --nodeps overrides --complete-graph

13 years agoRecognize git-2.eclass when reinstalling self.
Zac Medico [Mon, 14 Feb 2011 15:46:39 +0000 (07:46 -0800)]
Recognize git-2.eclass when reinstalling self.

13 years agoRecognize git-2.eclass as a live eclass.
Zac Medico [Mon, 14 Feb 2011 15:36:12 +0000 (07:36 -0800)]
Recognize git-2.eclass as a live eclass.

13 years agodepgraph: fix KeyError in select_atoms
Zac Medico [Mon, 14 Feb 2011 15:29:33 +0000 (07:29 -0800)]
depgraph: fix KeyError in select_atoms

This happens if depstring evaluates to nothing.

13 years agoget_dep_chain: fix broken parent_arg reference
Zac Medico [Mon, 14 Feb 2011 07:20:48 +0000 (23:20 -0800)]
get_dep_chain: fix broken parent_arg reference

Broken since commit b4f98ec5a1eb2e010a455b19db5bef8d61def241.

13 years agodepgraph: normalize indentation
Zac Medico [Mon, 14 Feb 2011 07:17:04 +0000 (23:17 -0800)]
depgraph: normalize indentation

13 years agodepgraph: ignore fewer deps
Zac Medico [Mon, 14 Feb 2011 06:40:57 +0000 (22:40 -0800)]
depgraph: ignore fewer deps

This restores some desired logic that was left out of commit
5655b4dcfe5e9dae5e9d6352d791c3d04953baf7.

13 years agodepgraph: remove redundant "empty" param checks
Zac Medico [Mon, 14 Feb 2011 06:05:52 +0000 (22:05 -0800)]
depgraph: remove redundant "empty" param checks

Since commit 878f166c5a06b0ab6c5a34dd658c878cc7605fe7, empty implies
deep = True, so these checks are redundant.

13 years agodepgraph: --nodeps overrides --deep
Zac Medico [Mon, 14 Feb 2011 05:50:29 +0000 (21:50 -0800)]
depgraph: --nodeps overrides --deep

13 years agoget_dep_chain: fix unsatisfied_dependency logic
Zac Medico [Mon, 14 Feb 2011 04:57:57 +0000 (20:57 -0800)]
get_dep_chain: fix unsatisfied_dependency logic

Always prefer parents for which the parent atom is unsatisfied by the
child node. This seems to be the intention of the code, though it may
not have behaved correctly due to continuation of the parent loop.

13 years agoFix unhandled FileNotFound from previous commit.
Zac Medico [Mon, 14 Feb 2011 03:59:24 +0000 (19:59 -0800)]
Fix unhandled FileNotFound from previous commit.

There is an existing handler for EnvironmentError, so raise that
instead of FileNotFound.