From: David Bremner <david@tethera.net>
Date: Fri, 12 Aug 2016 23:03:35 +0000 (+0900)
Subject: Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ff7b1b9b61199382aae8a676ff31e9ed07da8649;p=notmuch-archives.git

Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH
---

diff --git a/30/66052f11b6694dd650c2978ad546d5f921105b b/30/66052f11b6694dd650c2978ad546d5f921105b
new file mode 100644
index 000000000..d465ae490
--- /dev/null
+++ b/30/66052f11b6694dd650c2978ad546d5f921105b
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 4EF656DE1D10
+ for <notmuch@notmuchmail.org>; Fri, 12 Aug 2016 16:03:55 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.007
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004,
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id NjSrPYcDjymB for <notmuch@notmuchmail.org>;
+ Fri, 12 Aug 2016 16:03:47 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 336116DE1D0D
+ for <notmuch@notmuchmail.org>; Fri, 12 Aug 2016 16:03:47 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
+ (envelope-from <david@tethera.net>)
+ id 1bYLUZ-0001q3-79; Fri, 12 Aug 2016 19:03:55 -0400
+Received: (nullmailer pid 10055 invoked by uid 1000);
+ Fri, 12 Aug 2016 23:03:35 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>,
+ Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v4 01/16] add util/search-path.{c,
+ h} to test for executables in $PATH
+In-Reply-To: <m2bn0xkb8f.fsf@guru.guru-group.fi>
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>
+ <1467970047-8013-2-git-send-email-dkg@fifthhorseman.net>
+ <878tw2r0vf.fsf@maritornes.cs.unb.ca>
+ <87k2fmse5h.fsf@alice.fifthhorseman.net>
+ <87y442phbm.fsf@maritornes.cs.unb.ca>
+ <87mvkhrfjl.fsf@alice.fifthhorseman.net> <m2bn0xkb8f.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sat, 13 Aug 2016 08:03:35 +0900
+Message-ID: <87popd614o.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 12 Aug 2016 23:03:55 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+>
+> The probability for user error is pretty small there -- if there is
+> typo/thinko there things usually just starts failing. Security is
+> easier to break elsewhere than here (e.g. borken PATH...)
+>
+> I'd keep the current implementation of test_for_executable()...
+>
+> Tomi
+>
+
+OK