From: Mark Walters Date: Sun, 1 Sep 2013 07:50:08 +0000 (+0100) Subject: Re: [PATCH 0/9] emacs: Unify common key bindings and lots more X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=fe5d546528138468a6ffe246072633a945329d6a;p=notmuch-archives.git Re: [PATCH 0/9] emacs: Unify common key bindings and lots more --- diff --git a/bb/f314eedc764560d038bb5c790c4ed78ae8926b b/bb/f314eedc764560d038bb5c790c4ed78ae8926b new file mode 100644 index 000000000..5b0254d2b --- /dev/null +++ b/bb/f314eedc764560d038bb5c790c4ed78ae8926b @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8A536431FB6 + for ; Sun, 1 Sep 2013 01:16:46 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TWz2uxdbI-Yd for ; + Sun, 1 Sep 2013 01:16:41 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 57AE8431FAE + for ; Sun, 1 Sep 2013 00:50:15 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VG2QD-0000RQ-Aj; Sun, 01 Sep 2013 08:50:11 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VG2QD-0004k6-1P; Sun, 01 Sep 2013 08:50:09 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/9] emacs: Unify common key bindings and lots more +In-Reply-To: <1377793557-28878-1-git-send-email-amdragon@mit.edu> +References: <1377793557-28878-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 01 Sep 2013 08:50:08 +0100 +Message-ID: <87k3j12d73.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: ddb1eb28a2d15e0d27a4da287e61c3b4 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 01 Sep 2013 08:16:46 -0000 + + +This patch series LGTM +1 modulo your fix for Jani's problem with point +placement (which as we commented on irc is only a problem with emacs +24). + +Patch 2 doing the point placement is the only one I have any concerns +about: but based on our discussion on irc I agree that point placement +when killing and reloading buffers (as opposed to modifying the existing +buffer) is inherently very fragile and this makes it no worse. + +Finally, two other comments: first, I like the ability to turn off the +auto-refresh (since I often use notmuch over an erratic ssh link). + +Secondly, I was initially unsure about the amount of churn to get a +global keymap but with other things being moved or added to it this does +look worthwhile. In particular, your draft notmuch-go (keyboard +shortcuts for search) looks really nice. + +Best wishes + +Mark + + + +On Thu, 29 Aug 2013, Austin Clements wrote: +> This series moves several common key bindings into a shared +> notmuch-wide keymap. To get there, it first cleans up several things +> so that all notmuch modes have common commands to put into a common +> keymap. +> +> In the process, this fixes inconsistent sort ordering reported in +> id:m2bo5c5h8l.fsf@ramakrmu-mac.i-did-not-set--mail-host-address--so-tickle-me, +> improves the currently fragile hello refresh behavior, combines +> several mostly-duplicated commands, and improves the notmuch-help +> implementation. +> +> This passes all of the tests and basic interactive testing, but it +> would be good for people to exercise it. +> +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch