From: Tom Yu <tlyu@mit.edu>
Date: Tue, 28 Nov 2006 04:57:55 +0000 (+0000)
Subject: krb5int_copy_data_contents shouldn't free memory it didn't allocate
X-Git-Tag: krb5-1.7-alpha1~1431
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=fdfc73ab2aa0a381610f6cd7ae6fbe7246ec53f4;p=krb5.git

krb5int_copy_data_contents shouldn't free memory it didn't allocate

	* src/lib/krb5/krb/copy_data.c (krb5int_copy_data_contents): Don't
	free outdata on malloc failure; we didn't allocate outdata.

ticket: new
target_version: 1.6
tags: pullup
component: krb5-libs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18865 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/krb/copy_data.c b/src/lib/krb5/krb/copy_data.c
index 1be2a2da5..aed2e863b 100644
--- a/src/lib/krb5/krb/copy_data.c
+++ b/src/lib/krb5/krb/copy_data.c
@@ -65,12 +65,10 @@ krb5int_copy_data_contents(krb5_context context, const krb5_data *indata, krb5_d
     if (!indata) {
 	return EINVAL;
     }
-    
 
     outdata->length = indata->length;
     if (outdata->length) {
 	if (!(outdata->data = malloc(outdata->length))) {
-	    krb5_xfree(outdata);
 	    return ENOMEM;
 	}
 	memcpy((char *)outdata->data, (char *)indata->data, outdata->length);