From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 17 Jan 2010 08:57:51 +0000 (-0800)
Subject: commit.c::print_summary: do not release the format string too early
X-Git-Tag: v1.7.0-rc0~72^2~1
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=fc6f19fe2b49928dcb4d2dfac88ca38a47d64cde;p=git.git

commit.c::print_summary: do not release the format string too early

When we are showing a clean merge, log_tree_commit() won't show the header
and we would need the format string to format the commit summary ourselves.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin-commit.c b/builtin-commit.c
index a73a532f2..7f61e87eb 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -1013,7 +1013,6 @@ static void print_summary(const char *prefix, const unsigned char *sha1)
 	rev.verbose_header = 1;
 	rev.show_root_diff = 1;
 	get_commit_format(format.buf, &rev);
-	strbuf_release(&format);
 	rev.always_show_header = 0;
 	rev.diffopt.detect_rename = 1;
 	rev.diffopt.rename_limit = 100;
@@ -1036,6 +1035,7 @@ static void print_summary(const char *prefix, const unsigned char *sha1)
 		printf("%s\n", buf.buf);
 		strbuf_release(&buf);
 	}
+	strbuf_release(&format);
 }
 
 static int git_commit_config(const char *k, const char *v, void *cb)