From: David Edmondson Date: Mon, 8 Feb 2016 17:52:01 +0000 (+0000) Subject: Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=fbf025e0588a903d36fdc95b5dd542d4d3c3fef1;p=notmuch-archives.git Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value sends unencrypted mail --- diff --git a/fe/095b3aa8175d594ac89f70e1bbf1f7cf25acd9 b/fe/095b3aa8175d594ac89f70e1bbf1f7cf25acd9 new file mode 100644 index 000000000..d102b4ae7 --- /dev/null +++ b/fe/095b3aa8175d594ac89f70e1bbf1f7cf25acd9 @@ -0,0 +1,120 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 5B3BB6DE0AC2 + for ; Mon, 8 Feb 2016 09:52:08 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.019 +X-Spam-Level: +X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5 tests=[AWL=0.048, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, + UNPARSEABLE_RELAY=0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OcSriH9B2FFC for ; + Mon, 8 Feb 2016 09:52:06 -0800 (PST) +Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com + [74.125.82.44]) by arlo.cworth.org (Postfix) with ESMTPS id B039E6DE02CE for + ; Mon, 8 Feb 2016 09:52:05 -0800 (PST) +Received: by mail-wm0-f44.google.com with SMTP id p63so126659237wmp.1 + for ; Mon, 08 Feb 2016 09:52:05 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:subject:in-reply-to:references:from:date:message-id:mime-version + :content-type; bh=TuVZef+PxHVtmwQncrQ0raVTVn2gbGkg7CWR23N52b4=; + b=pHceJ9zhD5dGpZ3ti6GJ7EWQcLV1fiOVAPIpWJnJiWPhRHZI52dQ7sbbXsqsgkVzMI + +dyIMeWxgiEmYh84hLbjxVt0TWYXRBv+Ky82yEV6EbdwzEkhr7MXLG3cGkXGPp8FIY9Y + sgGC6IibCG1sZUkGelnIiUZkuZd9yTkhPWHViAD/mWaG4kvYMls/yq31iBk9phuv198D + CMFrVwyiECTPfbNji8F7zQDwgGkHT0wmvMQGT/f8JprmcdLcpUisKhlsNW4XATzHyG48 + kfhtGDHOAE8HjjtmF7Yx5wPH1cP4Uz/Bs0SjzHLA8TFS7jbyn6pX2eWrS8e5N0w704HN + voig== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:from:date + :message-id:mime-version:content-type; + bh=TuVZef+PxHVtmwQncrQ0raVTVn2gbGkg7CWR23N52b4=; + b=bABuPQSfC/wdshK46SQvTuotckMAUV2iWkDHpHVurPtmC1AzRYDf3QNoBuj8plqc2F + 3z41jSj8C6MLejz0p3Mks4oEnXoK5n4Q8CrSzKuaNPOEDWVBXZ1074ARkRPLHab+sTjY + yoaZcZRnkqpG/NqD7c+ITmHZ7Tcp+4LBemT4z7wIB/izuwcVQZhutXvrOkpWaczhGaoU + btRm8Prd4LgRMhCWRe+ELLOl/mOfNa0SwVTpbrCZ4tqS5VmbPxzs+C0EmSsTQGIPOPkM + NHgPHuwvpeJNY0N/GfE0myG8k+MGPCpiURJV0a54oL7pKvbP7eDjEg/turvWqz8GyozU + t/Pw== +X-Gm-Message-State: + AG10YOS67+bp9YsE+aLkk+iSxiBJHCK2MVDgW+0WwATz2KjwAaG7QSV2XZpt6wcxsjQqwg== +X-Received: by 10.28.72.197 with SMTP id v188mr122763wma.34.1454953924344; + Mon, 08 Feb 2016 09:52:04 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id c185sm13708381wma.5.2016.02.08.09.52.02 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 08 Feb 2016 09:52:02 -0800 (PST) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 8a9c7d20; + Mon, 8 Feb 2016 17:52:01 +0000 (UTC) +To: David Bremner , notmuch@notmuchmail.org, + 759646@bugs.debian.org +Subject: Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: + switching mode= to invalid value sends unencrypted mail +In-Reply-To: <87egsldds6.fsf@maritornes.cs.unb.ca> +References: <87lhq7npcw.fsf@maritornes.cs.unb.ca> <87k35q2zso.fsf@nikula.org> + <54055C53.40604@fifthhorseman.net> + + <87egsldds6.fsf@maritornes.cs.unb.ca> +From: David Edmondson +Date: Mon, 08 Feb 2016 17:52:01 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 08 Feb 2016 17:52:08 -0000 + +[Raking over history...] + +On Sat, Nov 29 2014, David Bremner wrote: +> David Edmondson writes: +> +>> On Tue, Sep 02 2014, Tomi Ollila wrote: +>>> On Tue, Sep 02 2014, Daniel Kahn Gillmor wrote: +>>> +>>>> On 08/30/2014 03:37 AM, Jani Nikula wrote: +>>>>> I'm inclined to think this is a bug in message-mode. +>>>> +>>>> I agree it's a bug in message-mode, not in notmuch itself. +>>> +>>> I think it might be here: +>>> +>>> http://bzr.savannah.gnu.org/lh/emacs/emacs-24/annotate/head:/lisp/gnus/mml.el#L258 +>>> +>>> (it takes time to load, please wait...) +>>> +>>> If cond does not match, then don't fail... +>> +>> This looks to have been fixed in emacs at the end of September 2014. +> +> Right, this fix was released in emacs 24.4 +> +> I'm a little torn what to do here. On the one hand the upstream change +> fixes the bug as reported. On the other hand, if something corrupts the +> #secure tag (e.g., by deleting a letter), then the message is still sent +> un-uncrypted. + +That's true, but it's undoubtedly an upstream bug rather than a +notmuch-emacs bug. + +If we apply some heuristic workaround in notmuch, users of gnus (and +mu4e?) will still be vulnerable to the same problem. The right thing to +do is report (and fix) the bug upstream.