From: David Bremner <david@tethera.net>
Date: Sat, 4 Oct 2014 06:37:24 +0000 (+0200)
Subject: Re: [PATCH] test: Port atomicity test to Python
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=fbb549e1fde0fa0b184732ead34877589384bf99;p=notmuch-archives.git

Re: [PATCH] test: Port atomicity test to Python
---

diff --git a/87/f00c839d4b950cd579a3d8dfcb6b71515ef580 b/87/f00c839d4b950cd579a3d8dfcb6b71515ef580
new file mode 100644
index 000000000..7af6ffb3e
--- /dev/null
+++ b/87/f00c839d4b950cd579a3d8dfcb6b71515ef580
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 4B3E6431FBF
+	for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 23:37:40 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Y2KNKzt5ITU0 for <notmuch@notmuchmail.org>;
+	Fri,  3 Oct 2014 23:37:35 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 8F382431FB6
+	for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 23:37:35 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XaIyE-0002EX-O0; Sat, 04 Oct 2014 03:37:34 -0300
+Received: (nullmailer pid 10415 invoked by uid 1000); Sat, 04 Oct 2014
+	06:37:24 -0000
+From: David Bremner <david@tethera.net>
+To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] test: Port atomicity test to Python
+In-Reply-To: <1412355483-7670-1-git-send-email-aclements@csail.mit.edu>
+References: <1412355483-7670-1-git-send-email-aclements@csail.mit.edu>
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 04 Oct 2014 08:37:24 +0200
+Message-ID: <878ukwqr17.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: Austin Clements <aclements@csail.mit.edu>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 04 Oct 2014 06:37:40 -0000
+
+Austin Clements <aclements@csail.mit.edu> writes:
+
+>
+> Hi Amadeusz.  Does this patch fix the problem for you?  I don't have
+> GDB 7.8, so I can't test against it, but the Python interface is less
+> fragile than the GDB scripting language.  (Even if this doesn't fix
+> your problem, I think we should switch to the Python interface.)
+
+I can confirm this new version runs with gdb 7.8 (and python3) on
+debian. I also runs with gdb 7.7.1+dfsg-3 and python2.
+
+> +        shutil.copytree('%s/.notmuch' % maildir, '%s.snap/.notmuch' % maildir)
+
+I hesitate to have an opinion on python style, but for whatever reason I
+have a mild preference for str.format(args)  versus str % args. Not
+enough of a preference to redo the patch.
+
+I also agree that this version is easier to follow than the one it
+replaces.