From: David Bremner <david@tethera.net>
Date: Wed, 9 Sep 2015 17:36:01 +0000 (+2100)
Subject: Re: [PATCH 2/2] cli/count: apply uncrustify changes
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=fb7bb2da6a1be27e03d125a174dfe62e95c722c5;p=notmuch-archives.git

Re: [PATCH 2/2] cli/count: apply uncrustify changes
---

diff --git a/24/83b3c7843a1660c4a2627abc6802e2a0adac46 b/24/83b3c7843a1660c4a2627abc6802e2a0adac46
new file mode 100644
index 000000000..d02e0380a
--- /dev/null
+++ b/24/83b3c7843a1660c4a2627abc6802e2a0adac46
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 7B8286DE0274
+ for <notmuch@notmuchmail.org>; Wed,  9 Sep 2015 10:36:18 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 2.748
+X-Spam-Level: **
+X-Spam-Status: No, score=2.748 tagged_above=-999 required=5 tests=[AWL=-0.942,
+  RCVD_IN_BRBL_LASTEXT=1.644, RCVD_IN_SBL=2.596, RP_MATCHES_RCVD=-0.55]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id J_cCN3h9KjhS for <notmuch@notmuchmail.org>;
+ Wed,  9 Sep 2015 10:36:15 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+ by arlo.cworth.org (Postfix) with ESMTPS id 785406DE0214
+ for <notmuch@notmuchmail.org>; Wed,  9 Sep 2015 10:36:15 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+ (envelope-from <david@tethera.net>)
+ id 1ZZjHx-00010R-JM; Wed, 09 Sep 2015 14:36:05 -0300
+Received: (nullmailer pid 25912 invoked by uid 1000); Wed, 09 Sep 2015
+ 17:36:01 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 2/2] cli/count: apply uncrustify changes
+In-Reply-To: <m2bndegwqf.fsf@guru.guru-group.fi>
+References: <1441632818-22483-1-git-send-email-david@tethera.net>
+ <1441632818-22483-2-git-send-email-david@tethera.net>
+ <m2bndegwqf.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.20.2+71~gf460ad4 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Wed, 09 Sep 2015 14:36:01 -0300
+Message-ID: <87613jpkam.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 09 Sep 2015 17:36:18 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+>>  
+>>      if (exclude == EXCLUDE_TRUE) {
+>>  	search_exclude_tags = notmuch_config_get_search_exclude_tags
+>> -	    (config, &search_exclude_tags_length);
+>> +				  (config, &search_exclude_tags_length);
+>
+> With the first 2 uncrustify does a good job, but this last one it disagrees
+> how emacs(1) indents (and how it is currently indented in other notmuch
+> source files) -- I'd leave the last (3rd) change out.
+
+I actually think the uncrustify version is better, but I agree there is
+not much point having a standard that isn't easily achievable with
+emacs.  After a short struggle trying to understand CC-mode indentation,
+I give up.
+
+d