From: Mark Walters Date: Wed, 7 May 2014 18:06:08 +0000 (+0100) Subject: Re: [Patch v3 0/3] emacs: show: redesign unread/read logic X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=fb70f489afdfce86a905123789b3e6f93e4b7f47;p=notmuch-archives.git Re: [Patch v3 0/3] emacs: show: redesign unread/read logic --- diff --git a/a2/48c7e9c5cbf684ee41586a7706a97ca3bb30fa b/a2/48c7e9c5cbf684ee41586a7706a97ca3bb30fa new file mode 100644 index 000000000..b44ab5797 --- /dev/null +++ b/a2/48c7e9c5cbf684ee41586a7706a97ca3bb30fa @@ -0,0 +1,141 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id DFD2F431FAF + for ; Wed, 7 May 2014 11:06:26 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xGYDvnc5di7Q for ; + Wed, 7 May 2014 11:06:21 -0700 (PDT) +Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id BA000431FAE + for ; Wed, 7 May 2014 11:06:20 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail1.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Wi6ES-0003Y1-En; Wed, 07 May 2014 19:06:16 +0100 +Received: from 188.28.151.112.threembb.co.uk ([188.28.151.112] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Wi6EO-0003QR-Q3; Wed, 07 May 2014 19:06:16 +0100 +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [Patch v3 0/3] emacs: show: redesign unread/read logic +In-Reply-To: +References: <1395777793-13297-1-git-send-email-markwalters1009@gmail.com> + +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 07 May 2014 19:06:08 +0100 +Message-ID: <87a9atmpkf.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 188.28.151.112 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: fd8c1d6eb2a611d2c2787744fd63ce80 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 07 May 2014 18:06:27 -0000 + + +On Wed, 07 May 2014, David Edmondson wrote: +> On Tue, Mar 25 2014, Mark Walters wrote: +>> The third patch adds my attempt at a plausible logic. I find it works +>> very well: it usually does both what I expect and what I want. +> +> Whilst I think that the patch is well done, I don't like the resulting +> behaviour. That is a personal preference, of course. At the moment it +> doesn't seem that there is a way to accept this patch and (optionally) +> retain the existing behaviour. Do you have any thoughts on how we might +> achieve that? + +Thanks for looking and for the feedback. I should emphasise to everyone +that I would like all feedback whether positive or negative! + +> I don't have a strong preference for the default behaviour, though I +> suspect that something closer to the current behaviour (where a message +> is marked seen when it becomes the current message[1]) would better +> match user expectation (but this is an opinion, not something founded in +> fact). + +Just for the record I will detail what happens currently and then I have +a couple questions about your suggestion. + +A message is marked read if: + +1) if you navigate to a message using n/p (next/prev open message) + +2) if you navigate to it using N/P (next/prev message) regardless of +whether the message is open or closed. + +3) if you go to it using n.s.next-matching-message (not bound by +default) whether message is open or closed. + +4) when you enter a buffer and notmuch goes to the first open message. + +but not marked read in cases like: + +1) opening a message + +2) viewing or entering a message using other notmuch navigation such as +notmuch-show-advance and friends (bound to space) + +3) viewing or entering a message using arrow keys, page-up page-down, +ctrl-v mouse clicks etc + +Personally, I think marking a closed message read is a bug, and not +marking it read when opening it is too (at least in many cases). The +other problem with the current approach (in my view) is that if you try +to use the navigation commands non-interactively then messages end up +being marked read, even if they are never displayed to the user. Linking +into the post-command-hook means that this should "just work". + +Questions: What does it mean for a message to be the current message? +Is it just point being in the message? Would you be happy with a message +being marked read when point entered the message? That could be done +from the post-command-hook infrastructure to fix some of the problems +mentioned above. + +I think that is likely that people will disagree on how they want this +to work so I would like to try and make it customisable so I would +definitely be interested to see if I can get the behaviour you would +like from this infrastructure (or something similar). + +Best wishes + +Mark + + + +