From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed, 10 Feb 2016 16:53:46 +0000 (-0500)
Subject: notmuch.Database.remove_message should raise exception on failure
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=fa0bc2ef91cf5c5a86ac24cd76383be3b1819cee;p=notmuch.git

notmuch.Database.remove_message should raise exception on failure

The notmuch python bindings document that database.remove_message
should raise an exception when the message removal fails, but they
don't actually do it.
---

diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py
index 93e7b7a1..f3045334 100644
--- a/bindings/python/notmuch/database.py
+++ b/bindings/python/notmuch/database.py
@@ -483,7 +483,10 @@ class Database(object):
                removed.
         """
         self._assert_db_is_initialized()
-        return self._remove_message(self._db, _str(filename))
+        status = self._remove_message(self._db, _str(filename))
+        if status not in [STATUS.SUCCESS, STATUS.DUPLICATE_MESSAGE_ID]:
+            raise NotmuchError(status)
+        return status
 
     def find_message(self, msgid):
         """Returns a :class:`Message` as identified by its message ID