From: David Bremner Date: Sun, 9 Mar 2014 13:17:55 +0000 (+2100) Subject: Re: [PATCH] test: don't use $(dir) in recipes. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f958b81e5789e9cb61fd95128deca58a67dd854a;p=notmuch-archives.git Re: [PATCH] test: don't use $(dir) in recipes. --- diff --git a/c5/bc0877730ead309240e46a3d1cb38d93c990ca b/c5/bc0877730ead309240e46a3d1cb38d93c990ca new file mode 100644 index 000000000..0a89ea878 --- /dev/null +++ b/c5/bc0877730ead309240e46a3d1cb38d93c990ca @@ -0,0 +1,65 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6FE2E431FBD + for ; Sun, 9 Mar 2014 06:18:06 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id NUesocrAWNiu for ; + Sun, 9 Mar 2014 06:17:59 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7568D431FBC + for ; Sun, 9 Mar 2014 06:17:59 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WMdc6-0003vt-RM; Sun, 09 Mar 2014 10:17:58 -0300 +Received: (nullmailer pid 8516 invoked by uid 1000); Sun, 09 Mar 2014 + 13:17:55 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: Re: [PATCH] test: don't use $(dir) in recipes. +In-Reply-To: <1394287239-17850-1-git-send-email-david@tethera.net> +References: <1394287239-17850-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.17+111~g93cd619 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 09 Mar 2014 10:17:55 -0300 +Message-ID: <87iorna4u4.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 09 Mar 2014 13:18:06 -0000 + +David Bremner writes: + +> According the semantics of make, the expansion of $(dir) in recipes +> uses dynamic scope, i.e. the value at the time the recipe is run. This +> means if test/Makefile.local is not the last sub-makefile included, +> all heck breaks loose. +> --- +> +> This was originally part of some suggested changes to Jani's folder +> series, but no reason to wait for Jani and I to sort that out. + +pushed, possibly just at the point when it did make sense to wait + +d