From: Mark Walters Date: Sat, 26 Apr 2014 10:50:56 +0000 (+0100) Subject: Re: [PATCH 00/11] Improve charset and cid: handling X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f87bbff5aa89ad5b328294acfa5d9004f124bae4;p=notmuch-archives.git Re: [PATCH 00/11] Improve charset and cid: handling --- diff --git a/02/139636d9c7e78e44eb99eeb7ff5518331a19db b/02/139636d9c7e78e44eb99eeb7ff5518331a19db new file mode 100644 index 000000000..0921a7140 --- /dev/null +++ b/02/139636d9c7e78e44eb99eeb7ff5518331a19db @@ -0,0 +1,120 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E6F2A431FB6 + for ; Sat, 26 Apr 2014 03:51:14 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id I1RDV94LB3DQ for ; + Sat, 26 Apr 2014 03:51:07 -0700 (PDT) +Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 760FE431FAF + for ; Sat, 26 Apr 2014 03:51:07 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail1.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1We0CC-0006JS-OO; Sat, 26 Apr 2014 11:51:03 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1We0CC-0006Lg-H6; Sat, 26 Apr 2014 11:51:00 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] Improve charset and cid: handling +In-Reply-To: <1398105468-14317-1-git-send-email-amdragon@mit.edu> +References: <1398105468-14317-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 26 Apr 2014 11:50:56 +0100 +Message-ID: <87tx9gl5yn.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: a0adc557c4a0351168ac667c3bd0f1dd (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 26 Apr 2014 10:51:15 -0000 + + +Aside from the minor comments I mentioned in previous emails and one +more comment below this looks good. + +The extra comment is that on emacs23 I get the following when compiling: + +In end of data: +notmuch-show.el:2188:1:Warning: the following functions are not known to be + defined: libxml-parse-html-region, shr-insert-document + +Finally, I have not really tested it as I mainly use emacs23 + +Best wishes + +Mark + + + + +On Mon, 21 Apr 2014, Austin Clements wrote: +> I set out to quickly add support for cid: links in the shr renderer +> and wound up making our charset handling more robust and rewriting our +> content-ID handling. The test introduced in patch 2 passes in all but +> one really obscure case, but only because of many unwritten and +> potentially fragile assumptions that Emacs and the CLI make about each +> other. +> +> The first three patches could reasonably go in to 0.18. The rest of +> this series is certainly post-0.18, but I didn't want to lose track of +> it. +> +> This series comes in three stages. Each depends on the earlier ones, +> but each prefix makes sense on its own and could be pushed without the +> later stages. +> +> Patch 1 is a simple clean up patch. +> +> Patches 2 through 7 robust-ify our charset handling in Emacs, mostly +> by splitting the broken `notmuch-get-bodypart-content' API into +> `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text' so a +> caller can explicitly convey their requirements. +> +> The remaining patches improve our content-ID handling and add support +> for cid: links for shr. +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch