From: Austin Clements Date: Mon, 9 Dec 2013 00:28:13 +0000 (+1900) Subject: Re: [PATCH 4/4] test: give unique timestamps to messages X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f874d883f6c0f079d8cc8c6411581ae0b343cd32;p=notmuch-archives.git Re: [PATCH 4/4] test: give unique timestamps to messages --- diff --git a/8c/7b1042c51083dac6e45bbe80834a116261c0cf b/8c/7b1042c51083dac6e45bbe80834a116261c0cf new file mode 100644 index 000000000..03bc756c8 --- /dev/null +++ b/8c/7b1042c51083dac6e45bbe80834a116261c0cf @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A91D2431FD0 + for ; Sun, 8 Dec 2013 16:28:23 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SrB2CpK6S1VC for ; + Sun, 8 Dec 2013 16:28:17 -0800 (PST) +Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu + [18.7.68.37]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id AFF8B431FCB + for ; Sun, 8 Dec 2013 16:28:17 -0800 (PST) +X-AuditID: 12074425-b7fd96d000000c39-78-52a50e9f4dfd +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id F4.45.03129.F9E05A25; Sun, 8 Dec 2013 19:28:15 -0500 (EST) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id rB90SFgk009609; + Sun, 8 Dec 2013 19:28:15 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id rB90SDhv006592 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sun, 8 Dec 2013 19:28:14 -0500 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1Vpohp-0006OQ-Kn; Sun, 08 Dec 2013 19:28:13 -0500 +Date: Sun, 8 Dec 2013 19:28:13 -0500 +From: Austin Clements +To: David Bremner +Subject: Re: [PATCH 4/4] test: give unique timestamps to messages +Message-ID: <20131209002753.GI8854@mit.edu> +References: <1386517946-22054-1-git-send-email-david@tethera.net> + <1386517946-22054-5-git-send-email-david@tethera.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1386517946-22054-5-git-send-email-david@tethera.net> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT0Z3PtzTI4OIPc4sbrd2MFtdvzmR2 + YPJ4tuoWs8eWQ++ZA5iiuGxSUnMyy1KL9O0SuDI+LPnHXPBHtKL/VT97A2OHUBcjJ4eEgInE + /TPTmSFsMYkL99azdTFycQgJzGaSaL1xGCwhJLCBUeJJUzRE4hSTRNu+gywQzhJGifen7rKC + VLEIqEjc/TIVrINNQENi2/7ljCC2iICqxNVtk9lAbGYBaYlvv5uZQGxhAUeJZwvOg9XzCmhL + TLt7nB1iW6XE/X1nWSDighInZz5hgejVkrjx7yVQLwfYnOX/OEDCnAJOEgd3zwFbJQp0wpST + 29gmMArNQtI9C0n3LITuBYzMqxhlU3KrdHMTM3OKU5N1i5MT8/JSi3Qt9HIzS/RSU0o3MYLD + 2kV1B+OEQ0qHGAU4GJV4eFewLg0SYk0sK67MPcQoycGkJMo7mRsoxJeUn1KZkVicEV9UmpNa + fIhRgoNZSYRX6cSSICHelMTKqtSifJiUNAeLkjjvLQ77ICGB9MSS1OzU1ILUIpisDAeHkgTv + bl6goYJFqempFWmZOSUIaSYOTpDhPEDDl4HU8BYXJOYWZ6ZD5E8xKkqJ864BSQiAJDJK8+B6 + YWnnFaM40CvCvMtBqniAKQuu+xXQYCagwZOuLgIZXJKIkJJqYFQ7Nldkj1DOrJ3hU5tnsDo9 + fLOR3d1osucL3cm/meOeqK13esLU6iXmpcmm3uL48UzO6Wezbpks/lEkdW9iaCCrUevqrv+T + Cv2CW39OTdKfWXz67qR/avuvNmpyCIf9XMmgt1Ao5danaeuCopSu7FsmxPb93XxtY8UZbQp2 + GQ5zFvXy8DNqBCmxFGckGmoxFxUnAgCs+ZHtFgMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 09 Dec 2013 00:28:23 -0000 + +Quoth David Bremner on Dec 08 at 11:52 pm: +> The choice of decreasing timestamps is a hack which reduces the number +> of existing tests which fail. This can be changed to increasing +> if/when somebody wants update another 47 tests. +> --- +> test/excludes | 4 ++-- +> test/test-lib.sh | 2 +- +> 2 files changed, 3 insertions(+), 3 deletions(-) +> +> diff --git a/test/excludes b/test/excludes +> index f1ae9ea..8bbbc2d 100755 +> --- a/test/excludes +> +++ b/test/excludes +> @@ -67,7 +67,7 @@ thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inb +> test_begin_subtest "Search, don't exclude \"deleted\" messages when --exclude=flag specified" +> output=$(notmuch search --exclude=flag subject:deleted | notmuch_search_sanitize) +> test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread) +> -thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inbox unread)" +> +thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Deleted (deleted inbox unread)" +> +> test_begin_subtest "Search, don't exclude \"deleted\" messages from search if not configured" +> notmuch config set search.exclude_tags +> @@ -152,7 +152,7 @@ ${matching_message_ids[5]}" +> test_begin_subtest "Search, exclude=flag (thread summary)" +> output=$(notmuch search --exclude=flag tag:test | notmuch_search_sanitize) +> test_expect_equal "$output" "thread:XXX 2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: single match: reply 2 (deleted inbox test unread) +> -thread:XXX 2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: double match: reply 4 (deleted inbox test unread) +> +thread:XXX 2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: double match: reply 2 (deleted inbox test unread) +> thread:XXX 2001-01-05 [0/6] Notmuch Test Suite; Some messages excluded: single excluded match: reply 3 (deleted inbox test unread) +> thread:XXX 2001-01-05 [1/6] Notmuch Test Suite; Some messages excluded: single non-excluded match: reply 4 (deleted inbox test unread) +> thread:XXX 2001-01-05 [1/6] Notmuch Test Suite; No messages excluded: single match: reply 3 (inbox test unread)" +> diff --git a/test/test-lib.sh b/test/test-lib.sh +> index d238c66..792e477 100644 +> --- a/test/test-lib.sh +> +++ b/test/test-lib.sh +> @@ -356,7 +356,7 @@ generate_message () +> fi +> +> if [ -z "${template[date]}" ]; then +> - template[date]="Fri, 05 Jan 2001 15:43:57 +0000" +> + template[date]=$(date -Ru -d@$((978709437 - gen_msg_cnt))) + +It would be worth adding a comment here to explain that the decreasing +timestamp is a historical artifact, to save people the trouble of +digging back in the log to figure out why it goes down. + +> fi +> +> additional_headers=""