From: Jani Nikula Date: Sat, 13 Aug 2016 11:58:30 +0000 (+0300) Subject: Re: [PATCH 0/4] Allow specifying alternate names for addresses in other_email X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f7993f830baf75e329ae2e3d40b8f9932152bd1a;p=notmuch-archives.git Re: [PATCH 0/4] Allow specifying alternate names for addresses in other_email --- diff --git a/1e/6ec75ea610e092e32b8eb45c49b5ce96fa0e44 b/1e/6ec75ea610e092e32b8eb45c49b5ce96fa0e44 new file mode 100644 index 000000000..7dd1c0ccf --- /dev/null +++ b/1e/6ec75ea610e092e32b8eb45c49b5ce96fa0e44 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 36BFB6DE3BFB + for ; Sat, 13 Aug 2016 05:00:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.182 +X-Spam-Level: +X-Spam-Status: No, score=0.182 tagged_above=-999 required=5 tests=[AWL=0.902, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id zOIi3HuVYSn0 for ; + Sat, 13 Aug 2016 04:59:56 -0700 (PDT) +Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com + [74.125.82.67]) by arlo.cworth.org (Postfix) with ESMTPS id BB1896DE3BF2 for + ; Sat, 13 Aug 2016 04:59:55 -0700 (PDT) +Received: by mail-wm0-f67.google.com with SMTP id i5so2077214wmg.2 + for ; Sat, 13 Aug 2016 04:59:55 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=nikula-org.20150623.gappssmtp.com; s=20150623; + h=from:to:subject:in-reply-to:references:date:message-id:mime-version; + bh=aJpzBpoqyt11QRhy6EmDvUP6sK9xF9GjYupIvFQczEk=; + b=MJ9TtxVJBywJG0v2vrEVN5rrglrz2yjPSb4szkMJanO7n+XJ99ZF41z14SjWKy3kUF + 2yTlrZlfm22ZjTif/tnjLci4oGu3r9MlrRcpKHUFC5ILGSpGpYihnnrGlioSCJcevEVG + 1cfBF0XtAofKgwteP/q/yNZkE0h5EAewh6rnUMwiO/jyg2kIk0AslpUAHLJRejoL6xxl + U+L5H/wPwPKXUeVT59TCz5IMdCdneixB8hmY9r3aYU0TjpG4P8//fEXuxE4IMnndpiz3 + /FPM7GToVO5iqrBggcEl6rTKFgxVj/8q3PMkBdNQoyp7uoo3272lbO6/wsOGq4zYLoW8 + k0IQ== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references:date + :message-id:mime-version; + bh=aJpzBpoqyt11QRhy6EmDvUP6sK9xF9GjYupIvFQczEk=; + b=Bstu0V6O++EjLvOQqKOli+MibP30bGLdZo2voZeZK9TQbcBlU5IPK4xv+IPuxqa3XE + zzoqsCoTIFSHuDJ6UqW97dk0sFwdYr+5rrDjxvePX7rxdmh9oQsyQxSzTDcl3Mv4w214 + ezUXNZCDS39U4gm2HZ0VM8O05yB+6p53zILg8wC6RWj+ZPTc690xGSo14K5QY0BG1XSL + 0hjgz3iEI84cAQs8grv8OGB53yjcJRpRBv1MsWyoUgjoPMjoR5ZCBcnNUBWRTEmMnGjx + pXZHKW0Tozu5PVQCdUiUTTCgOnZBFRvnm7QRGHqORecI1Vn9hX0WjpFpvTItWajvGeoj + sG5g== +X-Gm-Message-State: + AEkooutx55SRqYXmgTCEumX+N+0MewGvP4HhyMuA1VViCgITWEivS3B7KYBEoQkLlOVVIw== +X-Received: by 10.28.194.195 with SMTP id s186mr3825443wmf.48.1471089594364; + Sat, 13 Aug 2016 04:59:54 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c368-70.dhcp.inet.fi. + [88.195.104.70]) + by smtp.gmail.com with ESMTPSA id q137sm6869922wmd.19.2016.08.13.04.59.53 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 13 Aug 2016 04:59:53 -0700 (PDT) +From: Jani Nikula +To: Shea Levy , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/4] Allow specifying alternate names for addresses in + other_email +In-Reply-To: <1470776118-5070-1-git-send-email-shea@shealevy.com> +References: <1470776118-5070-1-git-send-email-shea@shealevy.com> +Date: Sat, 13 Aug 2016 14:58:30 +0300 +Message-ID: <87k2fk98yh.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 13 Aug 2016 12:00:04 -0000 + +On Tue, 09 Aug 2016, Shea Levy wrote: +> Currently, while notmuch-reply will recognize email addresses other than +> the main address with user.other_email, it always sets the name part of +> the address in the envelope-from and From headers to user.name. This +> patchset enables specifying names on a per-address basis with a new +> user.other_name property. Presumably other users of user.other_email +> may want to use this as well, but those are not updated currently. + +I am not convinved by adding another configuration option, especially +when it has to be in sync with another configuration option (ordering in +user.other_name having to match user.other_email). I would much prefer +allowing (but not requiring) "Name " style addresses +both in user.primary_email and user.other_email. + +With a cursory glance at the implementation, I wonder if you could just +pick the name based on the address you've picked earlier, and leave the +address matching mostly as it is. Would save some passing of parameters +around. Maybe. + +Additionally, I'd very much like to have my series [1] merged +first. It'll be *much* easier to rebase your series on top than the +other way around... + +BR, +Jani. + + +[1] id:cover.1471088022.git.jani@nikula.org