From: Tomi Ollila Date: Sun, 27 Oct 2013 09:42:14 +0000 (+0200) Subject: Re: [PATCH 0/4] rename pick to tree X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f745e76df404b040c82da4dec7e9b908ebb6e6f0;p=notmuch-archives.git Re: [PATCH 0/4] rename pick to tree --- diff --git a/f5/df8ba9845ed91bf6ce67e0c4039941dea610d6 b/f5/df8ba9845ed91bf6ce67e0c4039941dea610d6 new file mode 100644 index 000000000..ddbd13aa0 --- /dev/null +++ b/f5/df8ba9845ed91bf6ce67e0c4039941dea610d6 @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 26173431FD9 + for ; Sun, 27 Oct 2013 02:42:29 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id G4NILZOLszRm for ; + Sun, 27 Oct 2013 02:42:23 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id A16C4431FD8 + for ; Sun, 27 Oct 2013 02:42:22 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 23A191000B2; + Sun, 27 Oct 2013 11:42:15 +0200 (EET) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/4] rename pick to tree +In-Reply-To: <1382824928-3771-1-git-send-email-markwalters1009@gmail.com> +References: <1382824928-3771-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.16+115~g11c2ff5 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 27 Oct 2013 09:42:29 -0000 + +On Sun, Oct 27 2013, Mark Walters wrote: + +> This is a non-screwed up (I hope) version of +> id:1382822481-26659-1-git-send-email-markwalters1009@gmail.com +> +> It renames pick to tree (usually called tree view in +> documentation). See the previous cover letter for comments and how I +> have split it. +> +> This time all tests pass at each stage on a fresh clone, and the +> actual move of the notmuch-pick.el file itself to notmuch-tree.el is +> also included. + +LGTM. I will test (again) when the series posted to move this mainline +is submitted. + +Tomi + +> Best wishes +> +> Mark +> +> Mark Walters (4): +> contrib: pick: move lisp names from pick to tree +> pick: Change the test names and print out for pick tests +> pick: rename test outputs from pick to tree +> pick: rename test emacs-pick to emacs-tree +> +> contrib/notmuch-pick/notmuch-pick.el | 951 -------------------- +> contrib/notmuch-pick/notmuch-tree.el | 951 ++++++++++++++++++++ +> contrib/notmuch-pick/run-tests.sh | 4 +- +> contrib/notmuch-pick/test/emacs-pick | 210 ----- +> contrib/notmuch-pick/test/emacs-tree | 210 +++++ +> .../pick.expected-output/notmuch-pick-show-window | 40 - +> .../notmuch-pick-single-thread | 6 - +> .../pick.expected-output/notmuch-pick-tag-inbox | 53 -- +> .../notmuch-pick-tag-inbox-tagged | 53 -- +> .../notmuch-pick-tag-inbox-thread-tagged | 53 -- +> .../tree.expected-output/notmuch-tree-show-window | 40 + +> .../notmuch-tree-single-thread | 6 + +> .../tree.expected-output/notmuch-tree-tag-inbox | 53 ++ +> .../notmuch-tree-tag-inbox-tagged | 53 ++ +> .../notmuch-tree-tag-inbox-thread-tagged | 53 ++ +> 15 files changed, 1368 insertions(+), 1368 deletions(-) +> delete mode 100644 contrib/notmuch-pick/notmuch-pick.el +> create mode 100644 contrib/notmuch-pick/notmuch-tree.el +> delete mode 100755 contrib/notmuch-pick/test/emacs-pick +> create mode 100755 contrib/notmuch-pick/test/emacs-tree +> delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-show-window +> delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-single-thread +> delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox +> delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox-tagged +> delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox-thread-tagged +> create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-show-window +> create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-single-thread +> create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-tag-inbox +> create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-tag-inbox-tagged +> create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-tag-inbox-thread-tagged +> +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch