From: Mark Walters Date: Sat, 22 Jun 2013 07:55:56 +0000 (+0100) Subject: Re: [PATCH v6 00/12] insert command X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f729a2fb359b0d2e3dbc7d8a1eece10ab41c671b;p=notmuch-archives.git Re: [PATCH v6 00/12] insert command --- diff --git a/f4/fecc043504305e10f3e8995c42b59b2b0ed681 b/f4/fecc043504305e10f3e8995c42b59b2b0ed681 new file mode 100644 index 000000000..4ddeb718f --- /dev/null +++ b/f4/fecc043504305e10f3e8995c42b59b2b0ed681 @@ -0,0 +1,138 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0A682431FB6 + for ; Sat, 22 Jun 2013 00:56:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id y8ia40ZQZshJ for ; + Sat, 22 Jun 2013 00:56:01 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 661C7431FAE + for ; Sat, 22 Jun 2013 00:56:01 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1UqIfv-00014Z-IA; Sat, 22 Jun 2013 08:55:59 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1UqIfv-0002vo-9d; Sat, 22 Jun 2013 08:55:59 +0100 +From: Mark Walters +To: Peter Wang , notmuch@notmuchmail.org +Subject: Re: [PATCH v6 00/12] insert command +In-Reply-To: <1371880008-18312-1-git-send-email-novalazy@gmail.com> +References: <1371880008-18312-1-git-send-email-novalazy@gmail.com> +User-Agent: Notmuch/0.15.2+171~ge2f30a2 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 22 Jun 2013 08:55:56 +0100 +Message-ID: <87ehbuvasz.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 9f7e9d81fb209cbfe00a345652646ea9 (of first 20000 bytes) +X-SpamAssassin-Score: -0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.0 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 22 Jun 2013 07:56:09 -0000 + + +Overall this series looks very good and my only comments are the ones I +have just sent. There is one trivial bug and we need to decide whether +we need something like --fail-on-index-fail. + +Once those are fixed or decided then this series has a +1 from me. + +Best wishes + +Mark + +On Sat, 22 Jun 2013, Peter Wang wrote: +> Since v5: +> +> - return success if the message was successfully added to the maildir +> even if we weren't able to add it to the notmuch database +> - document exit status +> - add a couple of tests +> - don't print anything after parse_arguments returns failure +> +> Peter Wang (12): +> tag-util: move out 'tag' command-line checks +> tag-util: do not reset list in parse_tag_command_line +> cli: add insert command +> man: document 'insert' command +> man: reference notmuch-insert.1 +> test: add tests for insert +> insert: add --folder option +> man: document insert --folder option +> test: test insert --folder option +> insert: add --create-folder option +> man: document insert --create-folder +> test: test insert --create-folder option +> +> Makefile.local | 1 + +> man/Makefile.local | 1 + +> man/man1/notmuch-config.1 | 4 +- +> man/man1/notmuch-count.1 | 4 +- +> man/man1/notmuch-dump.1 | 4 +- +> man/man1/notmuch-insert.1 | 75 +++++++ +> man/man1/notmuch-new.1 | 4 +- +> man/man1/notmuch-reply.1 | 3 +- +> man/man1/notmuch-restore.1 | 3 +- +> man/man1/notmuch-search.1 | 3 +- +> man/man1/notmuch-show.1 | 3 +- +> man/man1/notmuch-tag.1 | 3 +- +> man/man1/notmuch.1 | 3 +- +> man/man5/notmuch-hooks.5 | 4 +- +> man/man7/notmuch-search-terms.7 | 3 +- +> notmuch-client.h | 3 + +> notmuch-insert.c | 477 ++++++++++++++++++++++++++++++++++++++++ +> notmuch-tag.c | 5 + +> notmuch.c | 3 + +> tag-util.c | 8 +- +> tag-util.h | 2 + +> test/insert | 121 ++++++++++ +> test/notmuch-test | 1 + +> 23 files changed, 716 insertions(+), 22 deletions(-) +> create mode 100644 man/man1/notmuch-insert.1 +> create mode 100644 notmuch-insert.c +> create mode 100755 test/insert +> +> -- +> 1.7.12.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch