From: David Bremner <david@tethera.net>
Date: Sat, 2 Nov 2013 12:23:29 +0000 (+2100)
Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted database
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f6e64631bc2da4ac8ca68d3904316115e6c1e3c6;p=notmuch-archives.git

Re: [PATCH 4/4] database: Handle error while deleting uncompacted database
---

diff --git a/72/fa3a324b0eaf73119624feca5826468a9672e0 b/72/fa3a324b0eaf73119624feca5826468a9672e0
new file mode 100644
index 000000000..b243f4d5a
--- /dev/null
+++ b/72/fa3a324b0eaf73119624feca5826468a9672e0
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 835FE431FC0
+	for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 05:23:46 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id FdjrSSuEfU2s for <notmuch@notmuchmail.org>;
+	Sat,  2 Nov 2013 05:23:41 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id D1151431FAF
+	for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 05:23:41 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1VcaEm-0005mW-Ro; Sat, 02 Nov 2013 09:23:32 -0300
+Received: (nullmailer pid 17055 invoked by uid 1000); Sat, 02 Nov 2013
+	12:23:29 -0000
+From: David Bremner <david@tethera.net>
+To: Ben Gamari <bgamari.foss@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted
+	database
+In-Reply-To: <1382998997-9938-4-git-send-email-bgamari.foss@gmail.com>
+References: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com>
+	<1382998997-9938-4-git-send-email-bgamari.foss@gmail.com>
+User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 02 Nov 2013 09:23:29 -0300
+Message-ID: <87fvrfrnzy.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 02 Nov 2013 12:23:46 -0000
+
+Ben Gamari <bgamari.foss@gmail.com> writes:
+
+> We never checked to ensure that the rmtree() of the old database
+> succeeded.
+>
+
+Is there some reason these patches (and the existing compact code in the
+lib) is using fprintf and not the status callback function? Most places
+we don't (yet) have logging callbacks, but here we do.
+
+d
+