From: Shawn O. Pearce Date: Wed, 19 Sep 2007 04:49:42 +0000 (-0400) Subject: Fix memory leaks when disconnecting transport instances X-Git-Tag: v1.5.4-rc0~292^2~33 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f4e95765b042f3e31a8902e78a5101768b33e445;p=git.git Fix memory leaks when disconnecting transport instances Most transport implementations tend to allocate a data buffer in the struct transport instance during transport_get() so we need to free that data buffer when we disconnect it. Signed-off-by: Shawn O. Pearce Signed-off-by: Junio C Hamano --- diff --git a/transport.c b/transport.c index a1d0a3c89..4f9cddc30 100644 --- a/transport.c +++ b/transport.c @@ -236,6 +236,7 @@ static int close_bundle(struct transport *transport) struct bundle_transport_data *data = transport->data; if (data->fd > 0) close(data->fd); + free(data); return 0; } @@ -372,6 +373,12 @@ static int git_transport_push(struct transport *transport, int refspec_nr, const return !!err; } +static int disconnect_git(struct transport *transport) +{ + free(transport->data); + return 0; +} + static int is_local(const char *url) { const char *colon = strchr(url, ':'); @@ -419,6 +426,7 @@ struct transport *transport_get(struct remote *remote, const char *url) ret->get_refs_list = get_refs_via_connect; ret->fetch = fetch_refs_via_pack; ret->push = git_transport_push; + ret->disconnect = disconnect_git; data->thin = 1; data->uploadpack = "git-upload-pack";