From: David Bremner Date: Sun, 14 Aug 2016 00:08:22 +0000 (+0900) Subject: Re: [PATCH v4 10/16] Add n_d_add_message_with_indexopts (extension of n_d_add_message) X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f49c721daf9de38959be9a2f12a3a4d7feff4456;p=notmuch-archives.git Re: [PATCH v4 10/16] Add n_d_add_message_with_indexopts (extension of n_d_add_message) --- diff --git a/1b/2eefd335626631d23ec69d44bcabc04b37168b b/1b/2eefd335626631d23ec69d44bcabc04b37168b new file mode 100644 index 000000000..3159ca638 --- /dev/null +++ b/1b/2eefd335626631d23ec69d44bcabc04b37168b @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 334A06DE4DD0 + for ; Sat, 13 Aug 2016 17:08:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.007 +X-Spam-Level: +X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, + SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id tREUeJ1SvpgL for ; + Sat, 13 Aug 2016 17:08:33 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 95DB46DE4DCF + for ; Sat, 13 Aug 2016 17:08:32 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) + (envelope-from ) + id 1bYiyr-0004sl-7T; Sat, 13 Aug 2016 20:08:45 -0400 +Received: (nullmailer pid 30418 invoked by uid 1000); + Sun, 14 Aug 2016 00:08:22 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , + Notmuch Mail +Subject: Re: [PATCH v4 10/16] Add n_d_add_message_with_indexopts (extension of + n_d_add_message) +In-Reply-To: <1467970047-8013-11-git-send-email-dkg@fifthhorseman.net> +References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net> + <1467970047-8013-11-git-send-email-dkg@fifthhorseman.net> +User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sun, 14 Aug 2016 09:08:22 +0900 +Message-ID: <8760r45i15.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 14 Aug 2016 00:08:42 -0000 + +Daniel Kahn Gillmor writes: + +> diff --git a/lib/notmuch.h b/lib/notmuch.h +> index b92d969..66b3503 100644 +> --- a/lib/notmuch.h +> +++ b/lib/notmuch.h +> @@ -605,6 +605,20 @@ notmuch_status_t +> notmuch_database_add_message (notmuch_database_t *database, +> const char *filename, +> notmuch_message_t **message); +> +/** +> + * Add a new message to the given notmuch database or associate an +> + * additional filename with an existing message using specified +> + * options. +> + * +> + * This does the same thing as notmuch_database_add_message except +> + * that it passes a pre-configured set of indexing options to indicate +> + * how the specific message should be indexed. +> + */ +> +notmuch_status_t +> +notmuch_database_add_message_with_indexopts (notmuch_database_t *database, +> + const char *filename, +> + notmuch_indexopts_t *indexopts, +> + notmuch_message_t **message); +> + +I'm a bit surprised that no new return values are possible / documented +here. + +d