From: Tomi Ollila Date: Fri, 25 Jul 2014 08:51:52 +0000 (+0300) Subject: Re: [PATCH] emacs: Clarify that notmuch-poll-script is deprecated X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f39ca3f59618f286208472c95ea0a3631d939d33;p=notmuch-archives.git Re: [PATCH] emacs: Clarify that notmuch-poll-script is deprecated --- diff --git a/9e/b3918bf8cf64912de183e10619356ced3a43d9 b/9e/b3918bf8cf64912de183e10619356ced3a43d9 new file mode 100644 index 000000000..60bc0bb3f --- /dev/null +++ b/9e/b3918bf8cf64912de183e10619356ced3a43d9 @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2B071431FC2 + for ; Fri, 25 Jul 2014 01:52:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4vRNpeGkAT-K for ; + Fri, 25 Jul 2014 01:51:59 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id A2644431FAF + for ; Fri, 25 Jul 2014 01:51:59 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id A8414100199; + Fri, 25 Jul 2014 11:51:52 +0300 (EEST) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Clarify that notmuch-poll-script is deprecated +In-Reply-To: <1406236771-5792-1-git-send-email-amdragon@mit.edu> +References: <1406236771-5792-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 25 Jul 2014 08:52:10 -0000 + +On Fri, Jul 25 2014, Austin Clements wrote: + +> notmuch-poll-script has long since been deprecated in favor of +> post-new hooks, but this wasn't obvious from the documentation. +> Update the documentation to make this clear. Since +> notmuch-poll-script could, to some extend, be used to control the path +> of the notmuch binary and that use is now clearly discouraged, promote +> notmuch-command to a real defcustom instead of just a variable. +> --- + +Fine by me -- although the post/pre-new hooks are not sufficient for me ;D + +Tomi + +> emacs/notmuch-lib.el | 24 ++++++++++++++++-------- +> 1 file changed, 16 insertions(+), 8 deletions(-) +> +> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el +> index 2941da3..c06baac 100644 +> --- a/emacs/notmuch-lib.el +> +++ b/emacs/notmuch-lib.el +> @@ -25,9 +25,6 @@ +> (require 'mm-decode) +> (require 'cl) +> +> -(defvar notmuch-command "notmuch" +> - "Command to run the notmuch binary.") +> - +> (defgroup notmuch nil +> "Notmuch mail reader for Emacs." +> :group 'mail) +> @@ -66,6 +63,16 @@ (defgroup notmuch-faces nil +> "Graphical attributes for displaying text" +> :group 'notmuch) +> +> +(defcustom notmuch-command "notmuch" +> + "Name of the notmuch binary. +> + +> +This can be a relative or absolute path to the notmuch binary. +> +If this is a relative path, it will be searched for in all of the +> +directories given in `exec-path' (which is, by default, based on +> +$PATH)." +> + :type 'string +> + :group 'notmuch-external) +> + +> (defcustom notmuch-search-oldest-first t +> "Show the oldest mail first when searching. +> +> @@ -77,7 +84,11 @@ (defcustom notmuch-search-oldest-first t +> :group 'notmuch-search) +> +> (defcustom notmuch-poll-script nil +> - "An external script to incorporate new mail into the notmuch database. +> + "[Deprecated] Command to run to incorporate new mail into the notmuch database. +> + +> +This option has been deprecated in favor of \"notmuch new\" +> +hooks (see man notmuch-hooks). To change the path to the notmuch +> +binary, customize `notmuch-command'. +> +> This variable controls the action invoked by +> `notmuch-poll-and-refresh-this-buffer' (bound by default to 'G') +> @@ -93,10 +104,7 @@ (defcustom notmuch-poll-script nil +> +> 1. Invoke a program to transfer mail to the local mail store +> 2. Invoke \"notmuch new\" to incorporate the new mail +> -3. Invoke one or more \"notmuch tag\" commands to classify the mail +> - +> -Note that the recommended way of achieving the same is using +> -\"notmuch new\" hooks." +> +3. Invoke one or more \"notmuch tag\" commands to classify the mail" +> :type '(choice (const :tag "notmuch new" nil) +> (const :tag "Disabled" "") +> (string :tag "Custom script")) +> -- +> 2.0.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch