From: W. Trevor King <wking@tremily.us>
Date: Sat, 23 Mar 2013 12:08:40 +0000 (-0400)
Subject: ui.cli: Remove explicit return from QuestionCommandLine._extra_ps1_lines()
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f3221829f455c1b6d46e3ea4c43f01d0ce0f168b;p=quizzer.git

ui.cli: Remove explicit return from QuestionCommandLine._extra_ps1_lines()

Mixing return statements and `yield`-based generators is bad practice.
---

diff --git a/quizzer/ui/cli.py b/quizzer/ui/cli.py
index ba26b32..763e3a7 100644
--- a/quizzer/ui/cli.py
+++ b/quizzer/ui/cli.py
@@ -100,7 +100,6 @@ class QuestionCommandLine (_cmd.Cmd):
                 self._separator = ','
                 yield ("Separate multiple answers with the '{}' character"
                        ).format(self._separator)
-        return []
 
     def _process_answer(self, answer):
         "Back out any mappings suggested by _extra_ps1_lines()"