From: Joey Hess <joey@kodama.kitenet.net>
Date: Wed, 19 Mar 2008 19:12:59 +0000 (-0400)
Subject: getargv needs to return a list reference
X-Git-Tag: 2.41~73
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=f003e97d10e42ea97b4a03fd62a296fe993a9677;p=ikiwiki.git

getargv needs to return a list reference

xml rpc only allows functions to return a single value, no lists. So getargv
needs to return a list reference, which means that the caller will see an xml
rpc array.
---

diff --git a/IkiWiki/Plugin/external.pm b/IkiWiki/Plugin/external.pm
index 300dee7ed..a90c5d8e2 100644
--- a/IkiWiki/Plugin/external.pm
+++ b/IkiWiki/Plugin/external.pm
@@ -156,7 +156,7 @@ sub setstate ($$$$;@) { #{{{
 sub getargv ($) { #{{{
 	my $plugin=shift;
 
-	return @ARGV;
+	return \@ARGV;
 } #}}}
 
 sub setargv ($@) { #{{{
diff --git a/doc/plugins/write/external.mdwn b/doc/plugins/write/external.mdwn
index 2ee841e61..058b9e58a 100644
--- a/doc/plugins/write/external.mdwn
+++ b/doc/plugins/write/external.mdwn
@@ -53,7 +53,7 @@ it, external plugins can use the `getstate` and `setstate` RPCs. To access
 stored state, call `getstate("page", "id", "key")`, and to store state,
 call `setstate("page", "id", "key", "value")`.
 
-To access ikiwiki's ARGV, call `getargv()`. To change its ARGV, call
+To access ikiwiki's ARGV array, call `getargv()`. To change its ARGV, call
 `setargv(value)`.
 
 ## Notes on function parameters