From: Fraser Tweedale Date: Wed, 21 May 2014 22:13:08 +0000 (+1000) Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ef9c8ec467b8ef20b97f3fd6ff98c9640e18a6e2;p=notmuch-archives.git Re: [PATCH 1/2] configure: add a fallback check for zlib --- diff --git a/16/94b4ae1987e8df177b45d5608f110e53c4998c b/16/94b4ae1987e8df177b45d5608f110e53c4998c new file mode 100644 index 000000000..8e7cc388f --- /dev/null +++ b/16/94b4ae1987e8df177b45d5608f110e53c4998c @@ -0,0 +1,164 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1BA71431FC4 + for ; Wed, 21 May 2014 15:13:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0KBdpgxL03Bu for ; + Wed, 21 May 2014 15:13:23 -0700 (PDT) +Received: from captainmorgan.hollandpark.frase.id.au + (110-174-235-130.static.tpgi.com.au [110.174.235.130]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D18AE431FBC + for ; Wed, 21 May 2014 15:13:22 -0700 (PDT) +Received: from bacardi.hollandpark.frase.id.au + (bacardi.hollandpark.frase.id.au [192.168.0.100]) + by captainmorgan.hollandpark.frase.id.au (8.14.5/8.14.5) with ESMTP id + s4LMDBa8028318; Thu, 22 May 2014 08:13:11 +1000 (EST) + (envelope-from frase@frase.id.au) +Received: from bacardi.hollandpark.frase.id.au (localhost [127.0.0.1]) + by bacardi.hollandpark.frase.id.au (8.14.7/8.14.7) with ESMTP id + s4LMDBPc085980 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 + verify=NO); Thu, 22 May 2014 08:13:11 +1000 (EST) + (envelope-from frase@frase.id.au) +Received: (from fraser@localhost) + by bacardi.hollandpark.frase.id.au (8.14.7/8.14.7/Submit) id + s4LMD8gm085979; Thu, 22 May 2014 08:13:08 +1000 (EST) + (envelope-from frase@frase.id.au) +X-Authentication-Warning: bacardi.hollandpark.frase.id.au: fraser set sender + to frase@frase.id.au using -f +Date: Thu, 22 May 2014 08:13:08 +1000 +From: Fraser Tweedale +To: Tomi Ollila +Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib +Message-ID: <20140521221307.GU62147@bacardi.hollandpark.frase.id.au> +References: <1399753646-3026-1-git-send-email-xico@atelo.org> + <536e965c9415e_300d7772fc9@nysa.notmuch> + + <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch> + <20140521091304.GT62147@bacardi.hollandpark.frase.id.au> + +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="2xeD/fx0+7k8I/QN" +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.23 (2014-03-12) +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 21 May 2014 22:13:31 -0000 + + +--2xeD/fx0+7k8I/QN +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Wed, May 21, 2014 at 10:34:25PM +0300, Tomi Ollila wrote: +> On Wed, May 21 2014, Fraser Tweedale wrote: +>=20 +> > On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: +> >> Tomi Ollila wrote: +> >> > On Sun, May 11 2014, Felipe Contreras w= +rote: +> >> >=20 +> >> > > X=C4=ABc=C3=B2 wrote: +> >> > >> Since zlib is part of the base system, FreeBSD chose not to regis= +ter it +> >> > >> in pkg-config through zlib.pc. As a fallback test, configure will= + build +> >> > >> and run a zlib version check and make sure the header and library +> >> > >> versions are compatible. +> >> > > +> >> > > We could try to generate our on zlib.pc, this way the configure sc= +ript +> >> > > would be cleaner. +> >> >=20 +> >> > But for that we'd need to figure out the version, and is there simpl= +er +> >> > robust way to do that some other way ? +> >>=20 +> >> I don't meant to change the code that is checking for the version in t= +he +> >> patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c, +> >> or something. +> >>=20 +> > +> > [please cc me in replies; I am not subscribed to the list] +> > +> > I think that the additional complexity outweighs the benefit of a +> > somewhat cleaner build script. +> > +> > If the $vz1, $vz2, et al. are what's bothering you, perhaps we could +> > push the complexity of version comparison into have_zlib.c and +> > supply the (string) version number as an argument to the program. +> > The have_zlib program could do the comparison and exit accordingly, +> > and plain old "1.2.5.2" can take its place in the configure script +> > once more. +> > +> > However, I don't see any problems with the patch as it is; I have +> > tested it on FreeBSD 10.0 and it works. +>=20 +> Did you notice=20 +>=20 +> http://mid.gmane.org/1399864172-28227-1-git-send-email-felipe.contreras@g= +mail.com +>=20 +> :D +>=20 + +Whups, I missed that one :) Cheers. + +> > +> > Regards, +> > +> > Fraser +> > +> >> --=20 +> >> Felipe Contreras +>=20 +> Tomi + +--2xeD/fx0+7k8I/QN +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.22 (FreeBSD) + +iQIcBAEBAgAGBQJTfSTzAAoJEEtTkFJBEeHi9PMQAL4khwt/qMwGAJDp8CFw/COU +ov0MA9mCRnPkbJLBYnJEB2WQD7QLpCY5Gle1rZIxYOVB1VUjR0VKoBFV+osCxB/b ++duxeZled2ftrNt9Xq1yn4mBIqbfbcuG3+dUQ0ZFBpjut3d8wv1Xm/Ey+esw8YWC +MCHD9zHiqIDrX2kZfY/hLsdmtCJUphkJHmir/QL4/bbUSaIFu8eaId5p9U5Zl62H +93bbt/IQal+FDLclApJLvUf82OS4IIaaZtvxZNEAOEPwRsam3UOzsNrQvjEO6+dK +W+pSvCoapidE8mZxWFLqAJtBDiYKehlDyy7b0LfkQNgEv5DE5vbtfLhWzMDbaPuW +lQ+6XreRK7KZudtChqc3choWPPFVjaFWqm1YGOZZJVgi75KMWAfI6efChGFPXLSc +a5pqdotTGYzUu5EF0ltv8KcJHrN8mGkVu7r3SWrxqHvUkAohAfXFcMHGfLOpAgne +GqfZw4w/eDsr7CHdtBLfwSeJYH8BygPVUKIxdFZ94KLe7u4VhrpQdvD7U+zkJwJq +zt1BZUnVehKMZW6A9LN0nxhgDziGXOnuGZLgVPpVDCkckW/EmbVFLjxN6uePxwKS +XpFNisgpnCXWjSmKjZWOM/i5p6dYES3G6qxuFzX8KmcD6jpowJwn9YvQp/e04/dd +ikJo1T9NYpA1ikBOyiYb +=X0t6 +-----END PGP SIGNATURE----- + +--2xeD/fx0+7k8I/QN--