From: David Bremner <david@tethera.net>
Date: Sat, 2 Nov 2013 14:56:58 +0000 (+2100)
Subject: Re: [PATCH] test: fix compact backup / restore test
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=eedb735bada81fece9307857222b1848205fd52c;p=notmuch-archives.git

Re: [PATCH] test: fix compact backup / restore test
---

diff --git a/c8/598f07e295ddc46ec3585443da7a6ac88016b6 b/c8/598f07e295ddc46ec3585443da7a6ac88016b6
new file mode 100644
index 000000000..67c2c8903
--- /dev/null
+++ b/c8/598f07e295ddc46ec3585443da7a6ac88016b6
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 60B12431FC3
+	for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 07:57:12 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id tNwyVCKu3Hx7 for <notmuch@notmuchmail.org>;
+	Sat,  2 Nov 2013 07:57:06 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 4F72B431FAF
+	for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 07:57:06 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1VccdL-0006RQ-I7; Sat, 02 Nov 2013 11:57:03 -0300
+Received: (nullmailer pid 6639 invoked by uid 1000); Sat, 02 Nov 2013
+	14:56:58 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] test: fix compact backup / restore test
+In-Reply-To: <m2li172avu.fsf@guru.guru-group.fi>
+References: <1383350515-24320-1-git-send-email-david@tethera.net>
+	<m2li172avu.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 02 Nov 2013 11:56:58 -0300
+Message-ID: <87a9hmsvgl.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 02 Nov 2013 14:57:12 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+> On Sat, Nov 02 2013, David Bremner <david@tethera.net> wrote:
+>
+>> It was looking in completely the wrong place for the backup and the
+>> (test) xapian database. Unfortunately test_begin_subtest hides the
+>> relevant errors.
+>> ---
+>
+> LGTM. It took me a while noticing that also ${TEST_TMPDIR}
+> was changed to ${MAIL_DIR}
+
+Globally it makes me a bit nervous to be doing destructive operations on
+${MAIL_DIR}, but that isn't specific to this patch. I wonder if it would
+be worth globally replacing the variable with something like
+TEST_MAIL_DIR just to make collision with user environment less
+likely. Or maybe it's enough just to be careful to override MAIL_DIR.
+
+d
+