From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Sun, 24 Jan 2016 16:03:22 +0000 (+1900)
Subject: Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ee673946e80584728aa317355f92098acb9ab7da;p=notmuch-archives.git

Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available
---

diff --git a/b0/a07f4b107870d7d680a2646fbb434b3f0d8e59 b/b0/a07f4b107870d7d680a2646fbb434b3f0d8e59
new file mode 100644
index 000000000..767b8bdc0
--- /dev/null
+++ b/b0/a07f4b107870d7d680a2646fbb434b3f0d8e59
@@ -0,0 +1,70 @@
+Return-Path: <dkg@fifthhorseman.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 769E96DE0AC2
+ for <notmuch@notmuchmail.org>; Sun, 24 Jan 2016 08:03:25 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.094
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.094 tagged_above=-999 required=5
+ tests=[AWL=-0.094] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id trri_zIQ6VzL for <notmuch@notmuchmail.org>;
+ Sun, 24 Jan 2016 08:03:23 -0800 (PST)
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])
+ by arlo.cworth.org (Postfix) with ESMTP id A687C6DE02DA
+ for <notmuch@notmuchmail.org>; Sun, 24 Jan 2016 08:03:23 -0800 (PST)
+Received: from fifthhorseman.net (h-67-101-29-155.nycm.ny.dynamic.megapath.net
+ [67.101.29.155])
+ by che.mayfirst.org (Postfix) with ESMTPSA id 47713F991;
+ Sun, 24 Jan 2016 11:03:21 -0500 (EST)
+Received: by fifthhorseman.net (Postfix, from userid 1000)
+ id 3EED320152; Sun, 24 Jan 2016 11:03:22 -0500 (EST)
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available
+In-Reply-To: <m2r3h757a1.fsf@guru.guru-group.fi>
+References: <1453258369-7366-1-git-send-email-dkg@fifthhorseman.net>
+ <1453258369-7366-7-git-send-email-dkg@fifthhorseman.net>
+ <m2r3h757a1.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.21+67~g41ad7ff (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sun, 24 Jan 2016 11:03:22 -0500
+Message-ID: <877fiz7ynp.fsf@alice.fifthhorseman.net>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 24 Jan 2016 16:03:25 -0000
+
+On Sun 2016-01-24 10:25:26 -0500, Tomi Ollila wrote:
+> On Wed, Jan 20 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
+>> --- a/test/test-lib.sh
+>> +++ b/test/test-lib.sh
+>> @@ -85,6 +85,13 @@ unset GREP_OPTIONS
+>>  # For emacsclient
+>>  unset ALTERNATE_EDITOR
+>>  
+>> +# choose the preferred GnuPG binary:
+>> +if hash gpg2 2> /dev/null; then
+>
+> For consistency, instead of hash ... 2>/dev/null, use command -v >/dev/null
+
+gotcha, i found several other instances of "command -v $whatever >
+/dev/null" in the codebase already, so i'll stick with that.  updated in
+my local copy now.
+
+   --dkg