From: Tomi Ollila Date: Sun, 13 Jul 2014 06:05:41 +0000 (+0300) Subject: Re: [PATCH v3 0/5] rst2man.py support and doc-build cleanups X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ed4a919213fee627ea822f584ad14d329fddeee0;p=notmuch-archives.git Re: [PATCH v3 0/5] rst2man.py support and doc-build cleanups --- diff --git a/9a/0720de70f3dd37595fd5a7aa960d524330fb68 b/9a/0720de70f3dd37595fd5a7aa960d524330fb68 new file mode 100644 index 000000000..79dcdccec --- /dev/null +++ b/9a/0720de70f3dd37595fd5a7aa960d524330fb68 @@ -0,0 +1,118 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id AE31E431FCB + for ; Sat, 12 Jul 2014 23:05:53 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lA8bfTjAyQAT for ; + Sat, 12 Jul 2014 23:05:46 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 5200A431FBD + for ; Sat, 12 Jul 2014 23:05:46 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id F05E71000B3; + Sun, 13 Jul 2014 09:05:41 +0300 (EEST) +From: Tomi Ollila +To: "W. Trevor King" , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 0/5] rst2man.py support and doc-build cleanups +In-Reply-To: +References: +User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 13 Jul 2014 06:05:53 -0000 + +On Sun, Jul 13 2014, "W. Trevor King" wrote: + +> Changes since v2 [1]: +> +> * In patches 1/5 and 5/5, use for loops to check for rst2man[.py] and +> rst2html[.py]. +> * In patches 1/5 and 5/5, store the command names, not the full paths +> (command -v =E2=80=A6) [2]. +> * In patch 3/5, I've added argparse handling to the newly-renamed +> rst-man2any.py. Tomi suggested modeling the name and UI on texi2any +> [3], but texi2any is for converting a single file, while +> rst-man2any.py is for converting a whole tree (and it takes an +> arbitrary ReST-to-$x converter to do the real work). I've basically +> just cleaned things up, but if folks aren't satisfied I'm going to +> need more concrete suggestions ;). + +The series now looks good to me, I don't have time to test it now but will +do it after Jul 20th. + +I am satisfied with rst-man2any.py, but as being normal picky me I wonder +whether the command prefix 'rst-' is being too generic i.e. is invading +that "namespace". If no one else has the same feeling (or the feeling is +just wrong (or insignificant)) then this can be forgotten :D + +> +> Cheers, +> Trevor + +Thanks, good work! + + +Tomi + +> +> [1]: id:cover.1399740604.git.wking@tremily.us +> http://thread.gmane.org/gmane.mail.notmuch.general/18291 +> [2]: id:m2ion3dn0r.fsf@guru.guru-group.fi +> http://article.gmane.org/gmane.mail.notmuch.general/18652 +> [3]: id:m2lhrzj8kb.fsf@guru.guru-group.fi +> http://article.gmane.org/gmane.mail.notmuch.general/18653 +> +> W. Trevor King (5): +> doc: Allow rst2man.py as an alternative to rst2man +> doc/prerst2man.py: Convert execfile to import +> doc/rst-man2any.py: Adjust to handle any output format, not just man +> pages +> doc: Consolidate Makefile targets around {build|install}-{format} +> doc: Add rst2html support for building HTML docs +> +> Makefile.local | 14 ++++++- +> configure | 45 ++++++++++++++++++++--- +> doc/INSTALL | 47 +++++++++++++++++------- +> doc/Makefile.local | 48 ++++++++++++++---------- +> doc/prerst2man.py | 63 -------------------------------- +> doc/rst-man2any.py | 105 +++++++++++++++++++++++++++++++++++++++++++++++= +++++++ +> 6 files changed, 217 insertions(+), 105 deletions(-) +> delete mode 100644 doc/prerst2man.py +> create mode 100755 doc/rst-man2any.py +> +> --=20 +> 1.9.1.353.gc66d89d +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch